From unknown Mon Aug 18 04:43:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Resent-From: Matt Armstrong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Apr 2021 18:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 47552@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161730232932353 (code B ref -1); Thu, 01 Apr 2021 18:39:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Apr 2021 18:38:49 +0000 Received: from localhost ([127.0.0.1]:58662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS2DQ-0008Pk-TE for submit@debbugs.gnu.org; Thu, 01 Apr 2021 14:38:49 -0400 Received: from lists.gnu.org ([209.51.188.17]:44936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS2DO-0008Pc-Gm for submit@debbugs.gnu.org; Thu, 01 Apr 2021 14:38:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lS2DO-000362-9l for bug-gnu-emacs@gnu.org; Thu, 01 Apr 2021 14:38:46 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:65481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lS2DL-0000Ar-N9 for bug-gnu-emacs@gnu.org; Thu, 01 Apr 2021 14:38:45 -0400 X-Originating-IP: 24.113.169.116 Received: from mdeb (24-113-169-116.wavecable.com [24.113.169.116]) (Authenticated sender: matt@rfc20.org) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id DD53640004 for ; Thu, 1 Apr 2021 18:38:38 +0000 (UTC) Received: from matt by mdeb with local (Exim 4.94) (envelope-from ) id 1lS2DC-000B6r-Q2 for bug-gnu-emacs@gnu.org; Thu, 01 Apr 2021 11:38:34 -0700 From: Matt Armstrong Date: Thu, 01 Apr 2021 11:38:34 -0700 Message-ID: <87wntlyhn9.fsf@rfc20.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.194; envelope-from=matt@rfc20.org; helo=relay2-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) I confirmed this in 27 and 28. Evaluate these forms in *scratch* or M-x ielm: (require 'cl-macs) (cl-defstruct a gcs-done) (make-a) *** Eval error *** Wrong type argument: numberp, nil Success is expected, as occurs for structs that don't happen to have "gcs-done" fields. The issue is related to the generated code for `make-a', which boils down to let binding gcs-done to nil: (let ((gcs-done))) Eval the above to get the same error. Perhaps the code generated for the make- functions should use make-symbol or gensym instead? Or a fixed series of field0...fieldN symbols? Why risk potentially binding dynamic vars? For reference, here is how `make-a' is generated. (defun make-a (&rest --cl-rest--) (let* ((gcs-done (car (cdr (plist-member --cl-rest-- ':gcs-done))))) (progn (let ((--cl-keys-- --cl-rest--)) (while --cl-keys-- (cond ((memq (car --cl-keys--) '(:gcs-done :allow-other-keys)) (setq --cl-keys-- (cdr (cdr --cl-keys--)))) ((car (cdr (memq ':allow-other-keys --cl-rest--))) (setq --cl-keys-- nil)) (t (error "Keyword argument %s not one of (:gcs-done)" (car --cl-keys--)))))) (record 'a gcs-done)))) In GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.23, cairo version 1.16.0) of 2020-11-07, modified by Debian built on x86-ubc-01 Windowing system distributor 'The X.Org Foundation', version 11.0.12010000 System Description: Debian GNU/Linux bullseye/sid Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --enable-libsystemd --with-pop=yes --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/27.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/27.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --without-gconf --with-mailutils --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --enable-libsystemd --with-pop=yes --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/27.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/27.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --without-gconf --with-mailutils --with-cairo --with-x=yes --with-x-toolkit=gtk3 --with-toolkit-scroll-bars 'CFLAGS=-g -O2 -fdebug-prefix-map=/build/emacs-6jKC2B/emacs-27.1+1=. -fstack-protector-strong -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 44948 7866) (symbols 48 6003 1) (strings 32 15436 2234) (string-bytes 1 500128) (vectors 16 10073) (vector-slots 8 129761 10564) (floats 8 19 39) (intervals 56 243 0) (buffers 1000 11)) From unknown Mon Aug 18 04:43:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Apr 2021 20:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Matt Armstrong Cc: monnier@iro.umontreal.ca, 47552@debbugs.gnu.org Received: via spool by 47552-submit@debbugs.gnu.org id=B47552.161756749922805 (code B ref 47552); Sun, 04 Apr 2021 20:19:02 +0000 Received: (at 47552) by debbugs.gnu.org; 4 Apr 2021 20:18:19 +0000 Received: from localhost ([127.0.0.1]:36530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9CN-0005vl-0s for submit@debbugs.gnu.org; Sun, 04 Apr 2021 16:18:19 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9CK-0005vT-AL for 47552@debbugs.gnu.org; Sun, 04 Apr 2021 16:18:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7H/EDtN7+PSufdEur52501VoSFgvnX90Y4yQxgBnkCA=; b=BD/kVpQDgma9mT2eFUXH0RGI1E oWOrHXUPI3FBnrrG/cI/VC9grE7s9jhTk0/UWDU9Mz9q1fR/XGu/u0KRmAay4j8+Ys9ptZlDy02zx LRfuFjXl5lqz8ntLeoHSBo2aaNo/TlJXQhJ5rlgRp/aygKUt9x4Knbnw26zOB7OQxTzc=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lT9C0-0002P1-Dr; Sun, 04 Apr 2021 22:18:09 +0200 From: Lars Ingebrigtsen References: <87wntlyhn9.fsf@rfc20.org> X-Now-Playing: JPEGMAFIA's _EP2!_: "THIS ONES FOR US!" Date: Sun, 04 Apr 2021 22:17:55 +0200 In-Reply-To: <87wntlyhn9.fsf@rfc20.org> (Matt Armstrong's message of "Thu, 01 Apr 2021 11:38:34 -0700") Message-ID: <87y2dxerd8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Matt Armstrong writes: > I confirmed this in 27 and 28. > > Evaluate these forms in *scratch* or M-x ielm: > > (require 'cl-macs) > (cl-defstruct a gcs-done) > (make-a) > *** Eval error *** Wrong type argument: numberp, nil [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Matt Armstrong writes: > I confirmed this in 27 and 28. > > Evaluate these forms in *scratch* or M-x ielm: > > (require 'cl-macs) > (cl-defstruct a gcs-done) > (make-a) > *** Eval error *** Wrong type argument: numberp, nil > > Success is expected, as occurs for structs that don't happen to have > "gcs-done" fields. > > The issue is related to the generated code for `make-a', which boils > down to let binding gcs-done to nil: > > (let ((gcs-done))) > > Eval the above to get the same error. > > Perhaps the code generated for the make- functions should use > make-symbol or gensym instead? Or a fixed series of field0...fieldN > symbols? Why risk potentially binding dynamic vars? Using a gensym seems like an obvious solution to me, but perhaps Stefan has an opinion here (added to the CCs). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 04 16:18:22 2021 Received: (at control) by debbugs.gnu.org; 4 Apr 2021 20:18:22 +0000 Received: from localhost ([127.0.0.1]:36533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9CQ-0005w2-8s for submit@debbugs.gnu.org; Sun, 04 Apr 2021 16:18:22 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT9CP-0005vc-3l for control@debbugs.gnu.org; Sun, 04 Apr 2021 16:18:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8MRoiYSogP9q2nTzR2MrNiDfMCN+R/ifd20ZL4O2qI4=; b=E8xi7aa9zf+2lMLiykA137FShT nAywU5+JRzjxWK9b+8qcJExdn5swWUDbM4yd4XKWcO2OYB9wuo+hUlugd1MbfZU0u5tmwdlom9wwv 66WpQPotcEFYSzOVNlLT5w6PUWqLlTDxEmNKYJ4MpZlCElKi2O/c4UVfd6Gy5OLi1IpQ=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lT9CH-0002PE-NM for control@debbugs.gnu.org; Sun, 04 Apr 2021 22:18:15 +0200 Date: Sun, 04 Apr 2021 22:18:13 +0200 Message-Id: <87wnthercq.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #47552 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 47552 fixed close 47552 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 47552 fixed close 47552 28.1 quit From unknown Mon Aug 18 04:43:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Apr 2021 23:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: Matt Armstrong , 47552@debbugs.gnu.org Received: via spool by 47552-submit@debbugs.gnu.org id=B47552.161757718612933 (code B ref 47552); Sun, 04 Apr 2021 23:00:02 +0000 Received: (at 47552) by debbugs.gnu.org; 4 Apr 2021 22:59:46 +0000 Received: from localhost ([127.0.0.1]:36606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTBib-0003MW-PY for submit@debbugs.gnu.org; Sun, 04 Apr 2021 18:59:45 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTBia-0003MI-1t for 47552@debbugs.gnu.org; Sun, 04 Apr 2021 18:59:44 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0BE5D4415E5; Sun, 4 Apr 2021 18:59:39 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A576144096A; Sun, 4 Apr 2021 18:59:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1617577177; bh=5YpO06UNpFBXwRJ2upGHVhoPZYeLmJ6wa03DOSks7r4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IGKsdJjK9DfrslgbQwNnYMbVauR4Hty+mQF3EQ4dJ4z0TO7cq1z3gb5uxM+qdQdyh 18xFViFkkI2uG5lg0vyw3Qsldg81/8bPbDbUvqQdw4TnjAVv/MMj8baRUTUYpoHrbI 6lPzpMy7Y0Rv1w1ixwjylDz06zc7J+XYSs+3FvyzdlkZVzxGd3mu+VYJ+9tog1Ctpk HbI8NI8+G6kR/EAsx2vS25/TzeAGfH10E5P1H+Inud6SKxBGVvY8SbteuwQvhuMJme okwXhinfPROjrYznIw2ebD/Tc3xrz1a7Zf0poAvHsJd6cHWwVX9nexGzMkS1QnmDa/ Lkj4Fwi9R1RlQ== Received: from alfajor (104-222-126-84.cpe.teksavvy.com [104.222.126.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BE2761203B2; Sun, 4 Apr 2021 18:59:36 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87wntlyhn9.fsf@rfc20.org> <87y2dxerd8.fsf@gnus.org> Date: Sun, 04 Apr 2021 18:59:36 -0400 In-Reply-To: <87y2dxerd8.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 04 Apr 2021 22:17:55 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> The issue is related to the generated code for `make-a', which boils >> down to let binding gcs-done to nil: >> >> (let ((gcs-done))) >> >> Eval the above to get the same error. >> >> Perhaps the code generated for the make- functions should use >> make-symbol or gensym instead? Or a fixed series of field0...fieldN >> symbols? Why risk potentially binding dynamic vars? > > Using a gensym seems like an obvious solution to me, but perhaps Stefan > has an opinion here (added to the CCs). I'm pretty sure that's the right solution, *but* I don't think it's obvious how to get there: `cl-defstruct` defines the constructor using `cl-defsubst` and its `&key` arguments, so the `:gcs-gone` keyword argument inevitably maps to a `gcs-done` variable by definition of how `&key` is supposed to work. So I suspect that in order to fix it, we'd need to stop using `&key`, or to use a more sophisticated version (which I think we'd have to implement first) which lets you specify separately the keyword and the matching variable name (and then make sure that the inlining optimizations still work for it). Stefan From unknown Mon Aug 18 04:43:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Apr 2021 16:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Stefan Monnier Cc: Matt Armstrong , 47552@debbugs.gnu.org Received: via spool by 47552-submit@debbugs.gnu.org id=B47552.16181587003255 (code B ref 47552); Sun, 11 Apr 2021 16:32:02 +0000 Received: (at 47552) by debbugs.gnu.org; 11 Apr 2021 16:31:40 +0000 Received: from localhost ([127.0.0.1]:55786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVczs-0000qR-CA for submit@debbugs.gnu.org; Sun, 11 Apr 2021 12:31:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVczq-0000qE-TO for 47552@debbugs.gnu.org; Sun, 11 Apr 2021 12:31:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6XRHyCQiqskSxq6dxaEQHDYJorEE1R62aKlCbvGoD9c=; b=mEETHgpuEqIGNjTyRwGQBA2BAU b1L56DCzmOMNnqlr4BHmJrEOkvZnjeIn+MG4wxjeWsAprbFyRhwAjjv4W1IA9bHcQkCTMl0nAVusA MsSm6i6FsH0YcKOC7R2mJvTjZvxwTRHUsczM8hSlHgQsWf8d6W26I4cZGmchx8fiaXZk=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVczZ-0001vj-RA; Sun, 11 Apr 2021 18:31:31 +0200 From: Lars Ingebrigtsen References: <87wntlyhn9.fsf@rfc20.org> <87y2dxerd8.fsf@gnus.org> X-Now-Playing: Anthony Shake Shakir's _Frictionalism 1994-2009_: "The Fake Left. Go Right Plan" Date: Sun, 11 Apr 2021 18:31:20 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 04 Apr 2021 18:59:36 -0400") Message-ID: <87pmz0236v.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > I'm pretty sure that's the right solution, *but* I don't think it's > obvious how to get there: `cl-defstruct` defines the constructor > using `cl-defsubst` and its `&key` arguments, so the `:gcs-go [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > I'm pretty sure that's the right solution, *but* I don't think it's > obvious how to get there: `cl-defstruct` defines the constructor > using `cl-defsubst` and its `&key` arguments, so the `:gcs-gone` keyword > argument inevitably maps to a `gcs-done` variable by definition of how > `&key` is supposed to work. I'm having a hard time following the code in cl-defstruct -- even where things are actually defined. But... Indeed doing this "doesn't work": (cl-defsubst foo4 (&key gcs-done) gcs-done) (foo4 :foo 1) -> Debugger entered--Lisp error: (wrong-type-argument numberp nil) But: (foo4 :gcs-done 1) => 1 Hm... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 15 23:22:58 2023 Received: (at control) by debbugs.gnu.org; 16 Jun 2023 03:22:58 +0000 Received: from localhost ([127.0.0.1]:48310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qA038-0003Fs-3Q for submit@debbugs.gnu.org; Thu, 15 Jun 2023 23:22:58 -0400 Received: from mout.web.de ([217.72.192.78]:52283) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qA035-0003Fa-9l for control@debbugs.gnu.org; Thu, 15 Jun 2023 23:22:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1686885769; x=1687490569; i=michael_heerdegen@web.de; bh=oNvE5MqS66Tgik/UXaS7PzfEo1MSegYIkUIvtMR9mCQ=; h=X-UI-Sender-Class:Date:To:From:Subject; b=XuGjdg4Zp84I8p8b3hX469KlnpVh4wf2lXUs3jWZD0FyyihsGbc3XTqtajQVv9V6m7PIWlN Tzn/+BhOjrsEFSk7/40gjQQ5h3le/X7+yqwucGKDvvTYVi2Af1ZcfzbFzXGzHdzM8CY8M4tdV jt+Q9fyymig0rJ2dCVu7pO5OpxPkT51B70d36zz53W5MILmW65JCNnR6Z1s9lKuL+06Jpd+bs Z7HzJjOKp4W5ghkTOv3jVAtvkYrZs0MHLru9V9ueR6pqIkHvoFnlujwNjCjxIgxHv1DYBGJ4C mJUipWiC4Hfi6d5ezInFPyYfayghBTh8UmCj0YiBiZBSgQg8R4Fg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.139]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N8Vop-1q58QK1FVx-014XcA for ; Fri, 16 Jun 2023 05:22:49 +0200 Date: Fri, 16 Jun 2023 05:22:48 +0200 Message-Id: <87wn04ay5z.fsf@web.de> To: control@debbugs.gnu.org From: Michael Heerdegen Subject: control message for bug #47552 X-Provags-ID: V03:K1:nXXcTTHi9ZCcluk2qz2dL4IyYSwd0KszAs3nKpQ2dkubhNIvlrA GGOh12/3+PGW1KHZrBGIyCPT7sGARzkErvCpK2XA2yBTL/CYVsUXueTBjqme22vx8AxzogP /FL2SAeA89sp9jO9TIxEoEAx/HLtxKtfjtj4wb/vP4LoNbpC1ieLpk1q94OJGXmfR21fymI gVY168PjqfFC92WDTYlRg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:RQAg8v6NPrY=;yCf6togEuVdw2yfXj4/FKZmNt5l xW1dIprhU4SwvE5QukV+7fLEvujpmP41ayX9O5PB2suf2Ycdt/dCzjffmJfBUi1kSU0OA0DAw Uohh8irs3RyNb3Dn80p55a4ue5c6Tnyf5rBL2/Tx5CgOyr18qBBYafJBk9fcLgdr5PQMV6HGm OtAO/WvsKmpzB9UY61Rbp4K9zvYzUEh8BgxEqPWFr0VTkv6Zmm6TPdpO1PRujYE12eMthp+Dc L4AThUZpC+4GD0iDQKZh/+dR0r2AlWUhVS/lyesuFfbWutv/oJPxnEO81m9pq0qHiIC5ycl2Y 773LOhBRf3EBWXhruUne8wEUhzsCz+D2BC7VTOiqE4sYpajtbBzDmLLJpQDWPE5Pn4Fh4YgSl lL4gTQDXwvvHck9hGBz3QFjFrxOAsBVSvgTfVPPmJvmHgzj0ecRh898Lz4H+of6kc6wit4VuP Zv+RNYlQmte8KoIe3zL4vsvpGQxe5QXdOFu3xxq4oHGz2HTbrsD38vc8f+HLfiHbwN8uqC5qH cwaNyFF+/emtYibjxKe54lhXGYdjxes3UuhcpLCljMR50T45Z7RK+ETKEpul9M/gTSS5b0DCV rMLQCEqkil5FeQXpRBlsyniUpztJlbLEasE11GMGAcTwUYwLtnwFs1xOLkO5p8/xuLFl8+VFS HSTmZHhfV1nn0e964a3T3/mHIcvLLA4GrJ1JebMC2ljXnKAq467nCBdJUWAnyMVvHrSMeIY9M uRXXfwmOUfoq1dd4tTmc6iYexXzNUyqwS/9dgXJA1W3pWi9e6yiRJge4PXhU/9/uPT2n/gZUH YrtWAaC8CWwDms+TuXkBL4IXG4gbfzKKo2zQg/S/ZC/yyVRcqG9/ozc1poIwsY83opnw9ehPf HHJooYTD4RygS4haRX9c+8QiK4C0I3J3UdIQaJwMTuoPIrF86hKkF1jmflHidV1TIp2yjTmyh UxiwFA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) unarchive 47552 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 15 23:23:27 2023 Received: (at control) by debbugs.gnu.org; 16 Jun 2023 03:23:27 +0000 Received: from localhost ([127.0.0.1]:48316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qA03b-0003HV-CW for submit@debbugs.gnu.org; Thu, 15 Jun 2023 23:23:27 -0400 Received: from mout.web.de ([217.72.192.78]:44059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qA03Z-0003HG-Kn for control@debbugs.gnu.org; Thu, 15 Jun 2023 23:23:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1686885800; x=1687490600; i=michael_heerdegen@web.de; bh=HrqSL4sASYoAF6nTFJkdxGe/m4kq/LrVrXaJPk8lIaM=; h=X-UI-Sender-Class:Date:To:From:Subject; b=JGA16360BG1RJ2PLM04f1lmpFD+w0g5X53JZoABnIV9uNBLKfHRove0iW6G1unWnE1MlFI5 2yybSfa8TME/M+PbtFBOwjaHSuazhtg9wRYnL/URBvnlWegXgqgZrG04z++EpPzkBgEaAS2Em +UpgrAC0ID6ciR0ukjqI/XRzJwHjqs0bUDzE0YT7bZgdzU4NMY53KbHtHfYICChygf49x/TiJ /Dau8RMjVii8UyFDFMZEJt3t8kBBhwd+5fm6ZN1Fidg1MHXQM1tq7mCHS45FxcnGX+85Ask1h RDIepg7D6bCHHgZj+B+K6XsRcB9BDyFevKes4aUqgTIQ/s8IGb9g== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.139]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MD5jv-1qIYcw3wUD-0097hk for ; Fri, 16 Jun 2023 05:23:20 +0200 Date: Fri, 16 Jun 2023 05:23:19 +0200 Message-Id: <87v8foay54.fsf@web.de> To: control@debbugs.gnu.org From: Michael Heerdegen Subject: control message for bug #47552 X-Provags-ID: V03:K1:B4W16waGwTESqY6I4D/Dvs+DdhF5YV7u9TKPouT4jl+RuQbsZPK dXPkOIFvkdI4+BRjjdMGrIMAu9FYayvrVPACmL3urlWi4DudyIAQxSFzGqDFdfx/EOu+v1m y/0rnLqCYynFq5BIoCxYBD591AStdEpdsByiICE6q7AbOEJhIhAeMVDJJiuj2+vH3qm4pnb GNu0T8A8u1X4TdyWUS5oA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:lRuBMgLOiN8=;REATr1N66ihI17SBevZnqpdRIWP QbIVYiW44QAvCigrR9jG0Y2JVdDGUtD22NhoI9Mq3GJdOmNEnRDvv/BM7YlPhIb3WBUseKtzJ gWOpiqNErIAVW+mYAn/HoWSzE0Y/HDPKCMj1Ub9fGpkSHzrvQ+PWXRjIR5x9DhqIBEfhBGdVS dexuM67VyG1RrVO86mpGUU5G0ba0u1Zbnv06huDCdRlNs7ItUR3imYMmsUWXhOSZ1eq+YApt2 ArYkO82fssaHCZT8ef9NrvTHPtwfA0cu3MiqKbHaqImAssRIvCDRHxWlBby5n75FgcxZ8vlMo hrlpUbdPibmFCjfMbsZMy3colmBQj34qyMXGiPzw4m19uRjdQ4pBArNQ5iQdkCMibSSLCxCiJ oFmpqt9MMBnc0ZMVkTo6BP06u1FFq5rXdDXhSk1TP3dvj6IoKqedeyt6h/2YVRfSMaQlS/CHC b0YDiC+soqe70kH/vg9oruXcOzcKrdCz6VUG40oqgtimI1rnyJRQwIhSbGlTAj6+k7BIaq+lR J1rAd63tEqIOqvVsWFHjy3E3+YbEDbSdtYQQUssXRdu6WTv3CZ3GLqNd/MOdPcvl2csKWKjsP bunxW6KQ3WEZoqPCsTJ6D/AQ6Z61R4C+1xvzMIITrGE+k1QgblkMDZyLmyQj/kDdRGgivz+zx xsiqJfl0mTPbpv3X7oUcXoEe+Lg7OjasuPhjZ02MgPAMHBlTh5LSY1etxGBKxSP0yW80KkNak wLV6Kg38cn/guFSN9Vg7pE9AZGSImkBFWiSfb4eCDDwDK8vY1OSSMehUsTe2HtnVZyIctNQYq UHVPGa3e9IXth0Ht4Y3Ou7tcR7GgWicOrlu3cXH+3HV2Ob6byg8j4sugRP4A+KqcTFxmU/ywT 3bB+jVMkFvDXTIt4DvoDNepgSvTCCO2kK8tTMOTYfTu2xROva3w/zPsahfkNaRC9x50A7VzaB /gEmE231DgzQNBwEsv3wYH22ulE= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) reopen 47552 tags 47552 - fixed patch quit From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 15 23:33:04 2023 Received: (at control) by debbugs.gnu.org; 16 Jun 2023 03:33:04 +0000 Received: from localhost ([127.0.0.1]:48337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qA0Ct-000648-Vc for submit@debbugs.gnu.org; Thu, 15 Jun 2023 23:33:04 -0400 Received: from mout.web.de ([212.227.15.4]:52223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qA0Cs-00063e-4o for control@debbugs.gnu.org; Thu, 15 Jun 2023 23:33:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1686886376; x=1687491176; i=michael_heerdegen@web.de; bh=tDQKR7PrIwi1dh8yn7onFbFBD4ZZ6a7OZBI1PsoqZ6I=; h=X-UI-Sender-Class:Date:To:From:Subject; b=WAk1eA6w+GMDJuhkMTCdgKBbqGvQ5cFJhmzYaF6y2JUfGrUjNReXZiSBKNQ+nsES+XRg/OQ 3rqr6AAyIPoYtGAmPX8qEeb1rR4mdtLTGQPhC7Vvu6XzVIlqdQey/SPaFL1poWiz9+lqNNfJm t/Wgghnn0gyA46F+OkevVBqxJiYxAH2NxF1EtFuoxM2r6lCPGGCViq5VY8VeGCNSt+8wphEhl EjCMxi7itHT1zUUYoAV+pM/WJL+EIVPdcvGqYJiH1kVTkbU67TggaPFUb21GvA202hHkqHQJA reYnMKImMOiRAeFoPuPpIBnnkmQH9/L7MUwhLWZsng9lBLp8d9Eg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.139]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Mo6Jz-1pkram3gsN-00pF27 for ; Fri, 16 Jun 2023 05:32:55 +0200 Date: Fri, 16 Jun 2023 05:32:55 +0200 Message-Id: <87ttv8axp4.fsf@web.de> To: control@debbugs.gnu.org From: Michael Heerdegen Subject: control message for bug #47552 X-Provags-ID: V03:K1:dukGi880Rq5gIbeumkp8zmrl+m4w4mSNry02ZNzj4ZI0Ot+Pey1 saWjJsHlgVWUtPpneoDJ1iey6ye9COhs/VEpsT7rlZHR6ht7ESi8P1KwPMGr0eQCYewekTT zYBhoaV79rdJwilwzd+NuzUB+T3L9nEJpEQf1sM08vSAlHdFJzNo7nH5NcsnaHvqleQ3dD5 UyovZ/UL3vwY/TvxzJjJQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:u8dActIGt9s=;49nfXia8C9blX++7M6uK587Nj09 alvc++Ystcokv+HcCRv4KghNfJPbZDOlI3e3iEJxsFYGGV6ChjKSYqFJybmggXXkeYL4xeQJE iQlrDuY7eNmmab7fH94lEeVpnkwq3B/5p3taz+9PBjhOQ44GTtGcVLjJzLBsBYQ4F7jv6ZFkv Yc6GAdTaI61Fki5cAQ/n3h+etw1YoyyaliM++XMXtGJmfWUQhqTnbsxGEQJ3wnhqyqkx8JirE B8b8JDPxC+hp+BOnqdQbJme47rCloChFdsz4kGWpE2Mk0ynVwh/dumtXewWSV8zjdbsVpeFTP xRGh6XbNE5lpTjO3DfeJ8JdYoeZqkGEmtAEmOdGN7hZi+YqH6txRvFC3O6OGY3+A3rhjCdOfQ XNnUVCBbYUHvSQZPatNdQa/Z5bpZo6559NCDbFrv+K8FO4IdqkhrxJiZVfAlAY7m9llZDp/V9 c+wo6kuV+Rj7MXBSZV2cHLGXkoRfch0G5LRPd+YuIllU32kcsCR+E9Tc7MvzBWuIFCX+6euUo mxvMelJYQQxDe46IttsMv0vkHgwEKy0YEztOYv1s8mIsiqGJhyHuzWs8XucDAytPz1zVqG7kf BTVTufDeiQjLWPGPUdqw27ZrEALbETrnZe1t4gLXUKbiJNDUG9N+Rqcdqf1V/kNy9vWbka8UM iDpVzr/wX2mRywJ2bm+TI+lJJ2VB2n9WyxkW3i5OWoTb5kzQvUtE87sLw5PKGTHai7B2xDGAh 6wd8A3+cJdV9Fg+IwjLakrbYG3zFlMLGU4TxhCp6QXZ6CFhWnpqxQVNMuFnFn4F+j3JtkuyEI HFIix8JUT1fwuY+xOxBSidzGlBerWAkzTGXfADvs1uCY4lCJmRJ4csnz0F7FRWYcMqISiHFYc 0gW2/lg9Eo+fWhYKfbmgFKcSBCWoUqfyeYEj2d3kKKkQSM+NbUrXoqjajKRFggtqSUdycNItv DYr/Y4QtRqTHGhVNAXYZlm823/Y= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) found 47552 28.2 quit From unknown Mon Aug 18 04:43:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Jun 2023 03:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: Matt Armstrong , Stefan Monnier , 47552@debbugs.gnu.org Received: via spool by 47552-submit@debbugs.gnu.org id=B47552.16868873402522 (code B ref 47552); Fri, 16 Jun 2023 03:49:02 +0000 Received: (at 47552) by debbugs.gnu.org; 16 Jun 2023 03:49:00 +0000 Received: from localhost ([127.0.0.1]:48387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qA0SK-0000ec-01 for submit@debbugs.gnu.org; Thu, 15 Jun 2023 23:49:00 -0400 Received: from mout.web.de ([212.227.17.12]:52211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qA0SH-0000eM-Qf for 47552@debbugs.gnu.org; Thu, 15 Jun 2023 23:48:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1686887328; x=1687492128; i=michael_heerdegen@web.de; bh=AVWhyQkV/5W+gVwgfnXuJGy7wZgP09L7PzXey8qNvB0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=gSadRwAu8EJNWnscf6kDfjdB50FOmp2VZN6CJqZZniy0YXpwhTZ6xkSChjrNkuMQPtQkC9k VZHqOGl3wx0Pac2uIJJG2xxobvCdLMxsuNJEqXmN9dyi6i5FFXtERpBFZmxdUpYqtKoCjcuIR RwkT2SMnxCcHceAhV1dfHYCF8hX6ts7QLjRD3BL55rCA7u7OXu8zmcGOBB9KYhOtrKbj8r9oR FptlIPlJRvgyTBdVNX4H+bIgbxUi58YhsRBOS7WSKXMn6B9uE6FrYybBOHy+hTsmkvAPRkWOo JjUDNraceyrVxE/HZ/USbXUNxjlMyiu2RaeedQSyW+jjT5lQkymw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.139]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MWQyX-1qbiTj1FkZ-00Xtuc; Fri, 16 Jun 2023 05:48:48 +0200 From: Michael Heerdegen In-Reply-To: <87pmz0236v.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 11 Apr 2021 18:31:20 +0200") References: <87wntlyhn9.fsf@rfc20.org> <87y2dxerd8.fsf@gnus.org> <87pmz0236v.fsf@gnus.org> Date: Fri, 16 Jun 2023 05:48:47 +0200 Message-ID: <87mt10awyo.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:OxI0juSpjBCjfg2nI0qYhEJwdpNkam2f07ldPe1DvOLo3CplXa7 P00wW7P7jauLxccyE0U1j+hQMeh/rchfdQBAmP4hzU6hi24TpPV7jsApDWkP+cYD6PR/VBt bMxEmkSZ68r7a8V2mL7vkyR0+i5qD/ZKMSkEYgQzHrWvZEu1XQQWKAFaV3JmkvXjn4MZKuh mzyZybfTztAcp+3fIvUqA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:wNnbLvSbbek=;JFfKGe03KxRujShoQcBGxYN1CnG iUu4V9gVvsQwo1AJVsG+YCt4GjYgcuhlcL6SR72Q6n4alUtoPFwjxjbQ7/kLJoJYwi1CZIgW/ 26gFuDuKYaJ8xb8xDv51TsEQWvsCR1lbf7AYPdCxJaGGYvC97inSrzI323wn/MNvH4tz2IGU5 nkggJkI5WCc9CyUBeN5y2zzJ4jmQhE+e4V5egi4rf+WyQRWNCk3gBwwu4pLto2vPCxcdeZRG/ +Jsrv8QV72a74ondUAqhG4bPIDXwbR4I5cDt+r5VNDkz758S6cBWmhLr8gViTexKQFnO7gdS6 Cebf+b6todiXTr1M3USqbE60NjZ18qF8i7Vz185t/fn0NDe9Elj+WPbulxDubpKgGyjkSUwaw 93pTGgegefC3L0o2xz/D6qX+XHRXlCSlfclTh+w1XDyADWnUMnWFfettisOKY3ZdZrQLkFO6E aw4xe+37Q4JNKqFJEeJlfF+PwH/ws0jGF9q+Kaw4o8HzVfBcedyD55FAA2tsOgY6PNiVeLTnI OIISTgEZjxAoTIbFObJCystsA92xl7Mspglelq/U+7INWiDF4EE6Bak3DNP2nj8KJdiqyK4Ek 59dkaIC7+6/5I7XGeHmtfgaAuGxcFIiZiCNsyqCWeBk+gyGpQsZEe6fs4VDQOsL2pLaqu61uQ 4RMUMxj48ynb1X9QgTx8de+bVq7aMfm0AjxDKEwwPUMKArz1QnVTXhJJvW/BMfLtptIwymrJR 4m5fa3FrL0+i0OUznb4FkRS/F8nAYWWzx862tGx+p+NXIla3TZHB3ylEKsA3Q+5paRMscc2Gi i+n4cogWR8sV9fK7w70sBCzrZFcf3LpveZjJg0bnzCEkAVPLLXXJkO+PpYSlc30YrNU8C6zMg FYBTpuC9FG4t1FPuKAe7rusOEDCk5EsdVEE4rhHdr9Bg2pX770px8uGSobfwLbj8gM6D5s5kc AOBkwNJLT7IQOMUoIm8wMdjkoio= Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Stefan Monnier writes: > > > I'm pretty sure that's the right solution, *but* I don't think it's > > obvious how to get there: `cl-defstruct` defines the constructor > > using `cl-defsubst` and its `&key` arguments, so the `:gcs-gone` keywo= rd > > argument inevitably maps to a `gcs-done` variable by definition of how > > `&key` is supposed to work. > > I'm having a hard time following the code in cl-defstruct -- even where > things are actually defined. > > But... Indeed doing this "doesn't work": It still doesn't work - I think this bug had been closed by accident? The original recipe still fails. Here is another incarnation of this bug: #+begin_src emacs-lisp (require 'cl-lib) (defun xyz ()) (cl-defstruct barf "Doc" (buffer-file-name (xyz))) (defun barf-foo () (let ((barf (make-barf))) barf)) #+end_src ~~> | Debugger entered--Lisp error: (wrong-type-argument stringp (xyz)) | (let* ((buffer-file-name (car (cdr (or (plist-member --cl-rest-- ':buf= fer-file-name) ... | make-barf--cmacro((make-barf)) | apply(make-barf--cmacro (make-barf) nil) | macroexp--compiler-macro(make-barf--cmacro (make-barf)) | #f(compiled-function (form func) #)(((ma= ke-barf)) make-barf) | macroexp--expand-all((make-barf)) Here the problem is that the variable `buffer-file-name' is not allowed to be bound to something that is not a string. Michael. From unknown Mon Aug 18 04:43:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2023 19:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: Matt Armstrong , 47552@debbugs.gnu.org Received: via spool by 47552-submit@debbugs.gnu.org id=B47552.168711501517473 (code B ref 47552); Sun, 18 Jun 2023 19:04:01 +0000 Received: (at 47552) by debbugs.gnu.org; 18 Jun 2023 19:03:35 +0000 Received: from localhost ([127.0.0.1]:54951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAxgV-0004Xl-AQ for submit@debbugs.gnu.org; Sun, 18 Jun 2023 15:03:35 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAxgT-0004XX-81 for 47552@debbugs.gnu.org; Sun, 18 Jun 2023 15:03:34 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A4EC7806F0; Sun, 18 Jun 2023 15:03:27 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 529F3803BD; Sun, 18 Jun 2023 15:03:26 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687115006; bh=Fzp9xarFd+JZflZauSuNp1kEBuUpxUVAhv8PA5Yc7y4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VZ8ZzxvVLpLqlUGPy5cFCX73yKAeluJme4c3jtOS+70r0zw9NsR5DrJFIt0uFlHmJ 1QPlh37vjB2ulEo4geU/aBtKbWU8h2+mcioGxgwiV/PSBNPjoWuoF2fPEWLpqjI6uv n5gQMCCxKOjX3rSNmgxPo3yS3EQiCL3IsYH29huRkZyzCqrl9bNj1FbgQE8Pkt4NFP zMU+DLtAjqt0pm23cLh+ljh5OerQA/v8mqBjENPd2DXXAoCmhc4QyswT/o5hkRY6pe KU011tdaCzQSok6uo+zjudvuGOLQ2C0gCEQTXsPFHkUaGMwyCKQiXsZAqVAuWDdw37 MLiW12oXub4Vw== Received: from pastel (unknown [45.72.207.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2D42D12019B; Sun, 18 Jun 2023 15:03:26 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87pmz0236v.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 11 Apr 2021 18:31:20 +0200") Message-ID: References: <87wntlyhn9.fsf@rfc20.org> <87y2dxerd8.fsf@gnus.org> <87pmz0236v.fsf@gnus.org> Date: Sun, 18 Jun 2023 15:03:25 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > But... Indeed doing this "doesn't work": > > (cl-defsubst foo4 (&key gcs-done) > gcs-done) > > (foo4 :foo 1) > -> Debugger entered--Lisp error: (wrong-type-argument numberp nil) I think the problem is that ELisp function arguments are defined as being always-statically-scoped, but the macroexpansion of (cl-defun foo4 (&key gcs-done) gcs-done) uses `let` rather than `lambda` to bind `gcs-done`, so it ends up being dynamically-scoped. Maybe we should introduce something like (defmacro slet* (bindings &rest body) (named-let expand ((bindings bindings)) (pcase-exhaustive bindings ('() (macroexp-progn body)) (`((,var ,exp) . ,bindings) (let ((rest (expand bindings))) (if (macroexp--dynamic-variable-p var) `(funcall (lambda (,var) ,rest) ,exp) (macroexp-let* `((,var ,exp)) rest))))))) Except I see that `macroexpand-all` will incorrectly turn the funcall+lambda into a `let`. Some wise ass knew about it but did it anyway. They even wrote a comment about it: ;; In lexical-binding mode, let and functions don't bind vars in the same way ;; (let obey special-variable-p, but functions don't). But luckily, this ;; doesn't matter here, because function's behavior is underspecified so it ;; can safely be turned into a `let', even though the reverse is not true. so we need to either fix that `macroexp--unfold-lambda` or circumvent it by obfuscating the code, e.g.: (defmacro slet* (bindings &rest body) (named-let expand ((bindings bindings)) (pcase-exhaustive bindings ('() (macroexp-progn body)) (`((,var ,exp) . ,bindings) (let ((rest (expand bindings))) (if (macroexp--dynamic-variable-p var) `(funcall (identity (lambda (,var) ,rest)) ,exp) (macroexp-let* `((,var ,exp)) rest))))))) Another way to look at it is that maybe we should introduce an `un-defvar`, such that we can use (un-defvar gcs-done) (cl-defun foo4 (&key gcs-done) gcs-done) and have `gcs-done` bound statically. Stefan From unknown Mon Aug 18 04:43:32 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Matt Armstrong Subject: bug#47552: closed (Re: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code) Message-ID: References: <87wntlyhn9.fsf@rfc20.org> X-Gnu-PR-Message: they-closed 47552 X-Gnu-PR-Package: emacs Reply-To: 47552@debbugs.gnu.org Date: Fri, 23 Jun 2023 15:39:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1687534741-7803-1" This is a multi-part message in MIME format... ------------=_1687534741-7803-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #47552: 27.1; cl-defstruct field names matching read-only variables -> bad = code which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 47552@debbugs.gnu.org. --=20 47552: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D47552 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1687534741-7803-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 47552-done) by debbugs.gnu.org; 23 Jun 2023 15:38:16 +0000 Received: from localhost ([127.0.0.1]:39398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCirY-00020r-Cf for submit@debbugs.gnu.org; Fri, 23 Jun 2023 11:38:16 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCirT-00020b-ON for 47552-done@debbugs.gnu.org; Fri, 23 Jun 2023 11:38:15 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 082E6443383; Fri, 23 Jun 2023 11:38:06 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 65A0B443380; Fri, 23 Jun 2023 11:38:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687534680; bh=IcWF2k9oXKW/IgsQKuszw+hFbKJZptWokekZPsiBmO8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=fWFRtvIKT0XXBuuVgNjdFNcliiJJdjOUfKRmRKvi46TVkCgtFVe83fBHyEW1Iv0Q0 dOwNfozuZnjNDJt04cPyB0eglTjn3ZS7jJ1LpHMDVe5CWdhlkgPoYWywDYq2JtS01i A7V4Yvrrycc+YWWAQZVHYhMt23OcymGqvgswApV/mMPLLSviH4Z8DrnIgYoNW53Msi HAMz8IVHf8SfvO6boiHcKbKtGOuFs0HfdDWYQgpHeZm5y+ZFjyd8BGeN1P84JN8p1B THn/qNeW0W0O+tUD7IYJByVm1A4iQFNZriNEW9IYZ1r2nWmwNsWPe4S/AQ81jqzeoX bX5CYcEXVa1xQ== Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 46163120193; Fri, 23 Jun 2023 11:38:00 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code In-Reply-To: (Stefan Monnier's message of "Sun, 18 Jun 2023 15:03:25 -0400") Message-ID: References: <87wntlyhn9.fsf@rfc20.org> <87y2dxerd8.fsf@gnus.org> <87pmz0236v.fsf@gnus.org> Date: Fri, 23 Jun 2023 11:37:53 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.010 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47552-done Cc: Matt Armstrong , 47552-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > (defmacro slet* (bindings &rest body) > (named-let expand ((bindings bindings)) > (pcase-exhaustive bindings > ('() (macroexp-progn body)) > (`((,var ,exp) . ,bindings) > (let ((rest (expand bindings))) > (if (macroexp--dynamic-variable-p var) > `(funcall (identity (lambda (,var) ,rest)) ,exp) > (macroexp-let* `((,var ,exp)) rest))))))) Not sure we want to expose that to the language, so I turned it into a function in `cl-macs.el` for use by `cl-defun/defmacro/defsubst/...` and pushed it to `master`. I believe this fixes the bug. Stefan ------------=_1687534741-7803-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Apr 2021 18:38:49 +0000 Received: from localhost ([127.0.0.1]:58662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS2DQ-0008Pk-TE for submit@debbugs.gnu.org; Thu, 01 Apr 2021 14:38:49 -0400 Received: from lists.gnu.org ([209.51.188.17]:44936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS2DO-0008Pc-Gm for submit@debbugs.gnu.org; Thu, 01 Apr 2021 14:38:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lS2DO-000362-9l for bug-gnu-emacs@gnu.org; Thu, 01 Apr 2021 14:38:46 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:65481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lS2DL-0000Ar-N9 for bug-gnu-emacs@gnu.org; Thu, 01 Apr 2021 14:38:45 -0400 X-Originating-IP: 24.113.169.116 Received: from mdeb (24-113-169-116.wavecable.com [24.113.169.116]) (Authenticated sender: matt@rfc20.org) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id DD53640004 for ; Thu, 1 Apr 2021 18:38:38 +0000 (UTC) Received: from matt by mdeb with local (Exim 4.94) (envelope-from ) id 1lS2DC-000B6r-Q2 for bug-gnu-emacs@gnu.org; Thu, 01 Apr 2021 11:38:34 -0700 From: Matt Armstrong To: bug-gnu-emacs@gnu.org Subject: 27.1; cl-defstruct field names matching read-only variables -> bad code Date: Thu, 01 Apr 2021 11:38:34 -0700 Message-ID: <87wntlyhn9.fsf@rfc20.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.194; envelope-from=matt@rfc20.org; helo=relay2-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) I confirmed this in 27 and 28. Evaluate these forms in *scratch* or M-x ielm: (require 'cl-macs) (cl-defstruct a gcs-done) (make-a) *** Eval error *** Wrong type argument: numberp, nil Success is expected, as occurs for structs that don't happen to have "gcs-done" fields. The issue is related to the generated code for `make-a', which boils down to let binding gcs-done to nil: (let ((gcs-done))) Eval the above to get the same error. Perhaps the code generated for the make- functions should use make-symbol or gensym instead? Or a fixed series of field0...fieldN symbols? Why risk potentially binding dynamic vars? For reference, here is how `make-a' is generated. (defun make-a (&rest --cl-rest--) (let* ((gcs-done (car (cdr (plist-member --cl-rest-- ':gcs-done))))) (progn (let ((--cl-keys-- --cl-rest--)) (while --cl-keys-- (cond ((memq (car --cl-keys--) '(:gcs-done :allow-other-keys)) (setq --cl-keys-- (cdr (cdr --cl-keys--)))) ((car (cdr (memq ':allow-other-keys --cl-rest--))) (setq --cl-keys-- nil)) (t (error "Keyword argument %s not one of (:gcs-done)" (car --cl-keys--)))))) (record 'a gcs-done)))) In GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.23, cairo version 1.16.0) of 2020-11-07, modified by Debian built on x86-ubc-01 Windowing system distributor 'The X.Org Foundation', version 11.0.12010000 System Description: Debian GNU/Linux bullseye/sid Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --enable-libsystemd --with-pop=yes --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/27.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/27.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --without-gconf --with-mailutils --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --enable-libsystemd --with-pop=yes --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/27.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/27.1/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --without-gconf --with-mailutils --with-cairo --with-x=yes --with-x-toolkit=gtk3 --with-toolkit-scroll-bars 'CFLAGS=-g -O2 -fdebug-prefix-map=/build/emacs-6jKC2B/emacs-27.1+1=. -fstack-protector-strong -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 44948 7866) (symbols 48 6003 1) (strings 32 15436 2234) (string-bytes 1 500128) (vectors 16 10073) (vector-slots 8 129761 10564) (floats 8 19 39) (intervals 56 243 0) (buffers 1000 11)) ------------=_1687534741-7803-1-- From unknown Mon Aug 18 04:43:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Jun 2023 00:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 47552@debbugs.gnu.org Cc: matt@rfc20.org, monnier@iro.umontreal.ca Received: via spool by 47552-submit@debbugs.gnu.org id=B47552.168756599132571 (code B ref 47552); Sat, 24 Jun 2023 00:20:02 +0000 Received: (at 47552) by debbugs.gnu.org; 24 Jun 2023 00:19:51 +0000 Received: from localhost ([127.0.0.1]:39700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCr0J-0008TH-H8 for submit@debbugs.gnu.org; Fri, 23 Jun 2023 20:19:51 -0400 Received: from mout.web.de ([212.227.17.12]:59683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCr0D-0008Sy-K7 for 47552@debbugs.gnu.org; Fri, 23 Jun 2023 20:19:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1687565976; x=1688170776; i=michael_heerdegen@web.de; bh=4hraNG3S7Aj6bifh0bn5CvD6+tHeodmRMrtXJ73yyOw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=N7qj/7wFQbUIiSEvsu0/cGSU/vwjkcrCx559MiNVoyQLsfJFRH0Rb6NJTPtZwu/pe56L4O7 vXy+MzWZFBkj7XNy6PeAKJupw7Btcnu89GOYczSdc3YgzsQP0ctdyYR51hBNRNHOTMDwsdxLh 1W4gjmUyEW4aqjdlTcOCDCGTCbNM/N0d64+CoCrFCbgvhZF+jcFx/5VEnFYvGSiFivZP3c+Jg FS29Jc389OrIufcCYbH2y99UJVApwRM7DEamBlZtwv1TnWfnrPgrtVMliC3Wr1RVHgovmkvn3 TpGPtSa9l03DhdUr05w7m7R6JC/OxunrykvMXwL6xtuSvOoZ4WXA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([87.163.112.144]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MlbHE-1pm0RR3a8w-00it0G; Sat, 24 Jun 2023 02:19:35 +0200 From: Michael Heerdegen In-Reply-To: (Stefan Monnier via's message of "Fri, 23 Jun 2023 11:37:53 -0400") References: <87wntlyhn9.fsf@rfc20.org> <87y2dxerd8.fsf@gnus.org> <87pmz0236v.fsf@gnus.org> Date: Sat, 24 Jun 2023 02:19:34 +0200 Message-ID: <87pm5lr9t5.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:SZIxoOdQtA+UOMZWSDMCAgAghPCk2a9CDNyN3TiG2Lr5w/80ygX 0nyouS85cP/PLcUn5tLh8PZYLJQxMW2JpHu0kG4FGhWNu4KfmBc/FL9H6idx1JePrxKQdaH LF0+hfb6pFJO0yB6a435II8hfEtfOP5oACozJ1PfGONc16oR2ZJVlMAZBQ1dOk9EMVvzHIA GmGL9ueTVnQN2MNS6ubQg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:hnOuONBNLsM=;MEbv/fCI0ST6Y1eJSsN6XBV0aaM 9lYDZ3A5FDuH8ihDIYGZTK2DSs0+swR991pwvVOXLndnVbSZuZHFU0qF657IofDK+/lxD4iz8 irDTa3S4+QyXc0IW5HPzrAN/P/NkV9SNwFGt3mmJ1c0OCO0HM0KL4P3S7MW3bo3E4r/hNPFF0 ltyuc+oW77XirXazyylsZER0q+fo4RJw7RXLE6QTDXnRYob77iCPtkcuYBZqxaCBnh9JFvHwE MMM02lsAOTDDr7T/mNXkDrIe+kuEnviLpWIy1LLsILi7mNFGXwch3zMssfU09MRpjk5iFoZxt MVKtI3wutYk2nU1XXEsTTs93eTD1/H0C0b4cLZm3xKCz2g410GKQzehj2fhTL/zqz4mXP4HiP uK25oH/a2X8cX95WeT7y59eBYV0vOlLmfD4iLkSfxWCISP5G5jDRlCjOKwvDONjLie+RB7GNj 0n4J0odCo589K4tl4SAdJKNFyfCwOR9crNRI+eere/esMT/T+fee9AlRfHl0mzEFO1NycbxVz 4c0o9Sx4obe0lwuI9lnKzMf2X/XWiWXbmjTxrMNX8vWXERrDD3SwBCSvgEIRFlMo1N11TJhYD ofW90X4UrsOVeNKge/2o4y/kHjMlRCNPvy8W0mg+tlYLZFZV/krriz07thjsf3SpaxMjZNDb2 f96yiMixhBSqoU0xa5W8IxR8Jv91IQHNS7hPzPgyx/kKyItZktnSjVAFWuVwAWi/7Kuoedihj wUzwO5IojOnabYn/i7wuy95FIC2SGUwlQLI/e7QxgkCHgfzYKOzQHzKZdEZmNjMcuVrGMzW8V Q+jk1kalBSBRVFAVewdEu7Pn9aXjyhkUueA3PeaZyb6fqvlnl234EPoRc2AEmG9UMfiWYlc+i prNAAPSSaGOpsay9GwCPQdgrC1JzfPihvI42fiIRoHLTo/bjSKu8wXWNOZoGTMD2pfs+bO+DC nMmzar/ipRrUjzub+EiOxH4Tc7I= X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > I believe this fixes the bug. Thanks. Didn't read the fix yet, but | load-with-code-conversion("/home/micha/software/emacs/lisp/emacs-lisp/cl-preloaded.el" "/home/micha/software/emacs/lisp/emacs-lisp/cl-preloaded.el" nil nil) | load("emacs-lisp/cl-preloaded") | load("loadup.el") | Eager macro-expansion failure: (void-function seq-some) | make[2]: *** [Makefile:916: bootstrap-emacs.pdmp] Error 255 | make[2]: Leaving directory '/home/micha/software/emacs/src' | make[1]: *** [Makefile:544: src] Error 2 | make[1]: Leaving directory '/home/micha/software/emacs' | make[1]: Entering directory '/home/micha/software/emacs' is printed when building from scratch. TIA, Michael. From unknown Mon Aug 18 04:43:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Jun 2023 15:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: matt@rfc20.org, 47552@debbugs.gnu.org Received: via spool by 47552-submit@debbugs.gnu.org id=B47552.16876215721836 (code B ref 47552); Sat, 24 Jun 2023 15:47:02 +0000 Received: (at 47552) by debbugs.gnu.org; 24 Jun 2023 15:46:12 +0000 Received: from localhost ([127.0.0.1]:41356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD5Sm-0000TX-0y for submit@debbugs.gnu.org; Sat, 24 Jun 2023 11:46:12 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:35370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD5Sg-0000Sl-Ml for 47552@debbugs.gnu.org; Sat, 24 Jun 2023 11:46:10 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AA01F806F0; Sat, 24 Jun 2023 11:46:00 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 985B98035A; Sat, 24 Jun 2023 11:45:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687621559; bh=BnTNGA2MTZPXcIuSH2XTKOD8zYKA7K2BWXx4/nLcGLY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=M2zvp9P4LBwFU/tydcK9Wlh3UavFpZPTD+tmxjFXTiz8BrB798lAVy/Dxis+yJCnr yIl5d+dfS+xj8617Y3r2XwXQ9GHdZKB+CtYPSzzqVOsu2wi1ye7TWqx1ZFnUjRi0xT lqgtbv77J1OvmDQCaFn+a2BCWvXbPZzu6z4p/l+whMun9ayAEFjm48ceaVDG7kO+Nc 6DhArXhKyvpVwZQf63x5VCpTDFLjL04SdaSqaVVyshZcyAUqLzoWIiQwdkXaMXbHQd rxyt1Q02+v+oSaLnCZMJy2cWprk5EMNawtlE1C+UMNx+MfxA5VVGU25N5KRi7LpVRQ EbIEbxJzd2k3g== Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6E36B1204FE; Sat, 24 Jun 2023 11:45:59 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87pm5lr9t5.fsf@web.de> (Michael Heerdegen's message of "Sat, 24 Jun 2023 02:19:34 +0200") Message-ID: References: <87wntlyhn9.fsf@rfc20.org> <87y2dxerd8.fsf@gnus.org> <87pmz0236v.fsf@gnus.org> <87pm5lr9t5.fsf@web.de> Date: Sat, 24 Jun 2023 11:45:58 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.457 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > | load-with-code-conversion("/home/micha/software/emacs/lisp/emacs-lisp/cl-preloaded.el" "/home/micha/software/emacs/lisp/emacs-lisp/cl-preloaded.el" nil nil) > | load("emacs-lisp/cl-preloaded") > | load("loadup.el") > | Eager macro-expansion failure: (void-function seq-some) > | make[2]: *** [Makefile:916: bootstrap-emacs.pdmp] Error 255 > | make[2]: Leaving directory '/home/micha/software/emacs/src' > | make[1]: *** [Makefile:544: src] Error 2 > | make[1]: Leaving directory '/home/micha/software/emacs' > | make[1]: Entering directory '/home/micha/software/emacs' > > is printed when building from scratch. Damn! OK, should work again now. Sorry 'bout that. Stefan From unknown Mon Aug 18 04:43:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jun 2023 03:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: matt@rfc20.org, 47552@debbugs.gnu.org Received: via spool by 47552-submit@debbugs.gnu.org id=B47552.16876646049984 (code B ref 47552); Sun, 25 Jun 2023 03:44:02 +0000 Received: (at 47552) by debbugs.gnu.org; 25 Jun 2023 03:43:24 +0000 Received: from localhost ([127.0.0.1]:41792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDGeq-0002ax-B8 for submit@debbugs.gnu.org; Sat, 24 Jun 2023 23:43:24 -0400 Received: from mout.web.de ([212.227.15.14]:44677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDGel-0002ag-T0 for 47552@debbugs.gnu.org; Sat, 24 Jun 2023 23:43:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1687664589; x=1688269389; i=michael_heerdegen@web.de; bh=L1rVMTV0nofz+V9/EFZrNPkeWQikNsndyw0ccEg1d4Y=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=XXPyCH+7j0CQfV6qmv0voPWt37HMuP3HlxfRFhOQRfJtw1ZTwrKm6hD1RDI471QH90mhwAl xjReekmrRkM971aKPKmfBaS0jWB9HndYhguPwxdQAdP2YE4dyWrEv7diAhSfv2SCrigUiVqlJ QUjPRlYM5ASLRha254rVhDcLEqSy1RHi0RLgQA8wiJHY63nBdKj42MvXBnfkcPGJINuTX/fma 9gsO+1+t4Ysp7OqYKGzlYuyrn4GAG05fZZMnS16ev9WFg5T2G0xC5g6AxpaVn/7QT+QulEFVm Z9IPvctnZwYlUG44SMS9DPEqopdHLWkU6ghbOYhCIHfMxc8hKcsg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([87.163.112.144]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Melaj-1pcYG00Sfd-00adTD; Sun, 25 Jun 2023 05:43:09 +0200 From: Michael Heerdegen In-Reply-To: (Stefan Monnier's message of "Sat, 24 Jun 2023 11:45:58 -0400") References: <87wntlyhn9.fsf@rfc20.org> <87y2dxerd8.fsf@gnus.org> <87pmz0236v.fsf@gnus.org> <87pm5lr9t5.fsf@web.de> Date: Sun, 25 Jun 2023 05:43:07 +0200 Message-ID: <87y1k8jjg4.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:K1miZP+7R+oh99LFZ9lbR2uiC7ppwE9fuvtvMVTMAvS7QV4MZAP yuYE0bMjOstDz5vZNpAYdBzyIVmyF2/XUgc/RvKZ1oUfr6n7hecgSFwYAQUqwfyVzn/6LxC my83GYJA6ZEpN9PFglWV7bbk9EX3UNX7J0TBTuiOnA1pLtnZMYkG8KIeN88tGDFudJSqNhP qpshua1bwtg7Kh6ymanDg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:WBp0zS0Q5Q8=;G0YDMDbOp4EX4PaAv1dczGQWpmR GK5krO+7ECPJWPUujWixgzu5mYTCG0a6qqtMUZdPH3wkK+qwmqrz+D5fFbT203tkDJPgTmWJg sQCuwxkTZPvBNqPmr6IZ8sKHHDSTPI4RNlka6Wa/kraYaXUYoiS78ZydynT3qtJ1P80zDdtLI fnt0Vo4UMafpKmDZsWih4TZkaEIN9HNq0oqB6eCxt/mcwVjG0WNCla8X6WQaouBWNyuHYiTe9 9e66hCpKlWAJlOos7K4LGYo9GCJ4fm+U715+/Mg2VAATfUtawMvweNNCAyVw3rrtwmUY1RVC7 XOFiGEIahzgOFIX6jIu0eYUe5EBxghtyfLIUxOMXnuyPOlJvzU9uyPp0jB2YhHEmiMdYK9Uz9 Hk84b7+7LBlCssgfgN5OwDr0l27QcgAcetaCex/JFwvUaegAqOVyl6b8iQCtOdBPviOueYlVk ZsdgM3kDksuUhrNdtiA7woTIeFTaLS/PpbqeB+mwEl4HAjs7mdNpduUOTp523jeB5ocMBwJeL GWDL6QUgj9Au41ZTsRQwNO41YIL3foyK4U9BRJBHPRgvmU0WGdoe2d8s1wVf4qysLhaVW1/C5 b337Ee8Gnh1malJqiKdN7yYE3BxYsiUFTb5ulaV0m22R3JiJP2D1CZimRryR16ETqt+ndA+cv nzpPicG1xC5ucvE0sXN+dJBkf2MlvRuE/FRuOjhTQXuv5oX76dJucIBTdf6XZ+Lp6yaCCFYQ5 ovTqX7UiDVVolHMvHAcAwwXRLIPeHxaRyv1BFt9Y6XVw17COUL5reKIQOPe8irsuMBoFPneit UZmG6tTjqq75H7zGodcGEw+NmRXY+BbLxX6JHeXAX4AwBrU64Wn1btiqX1b5biNsj4vyGkSXx yuuhthkyUcgukq6h3zu/4lTZ04X4g/L/cttEianzI3p0RxUHUk85ePCkMa/pQNYRESSIBNgtM ggmM/24f15PdBwZuVFbOXnAVZPA= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: > Damn! OK, should work again now. Sorry 'bout that. Works, thanks. One (very small) downside of the code generated now is that it may trigger "Lexical argument shadows the dynamic variable" warnings. 'date' for example is bad as a slot name when "diary" is loaded. I think these warnings can safely be ignored but I don't know if there is a way to get rid of them (and there may be a lot since the `defstruct' call is not the only place where a warning is emitted: also some defined functions lead to those warnings). Michael. From unknown Mon Aug 18 04:43:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jun 2023 04:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: matt@rfc20.org, 47552@debbugs.gnu.org Received: via spool by 47552-submit@debbugs.gnu.org id=B47552.168766584312624 (code B ref 47552); Sun, 25 Jun 2023 04:05:02 +0000 Received: (at 47552) by debbugs.gnu.org; 25 Jun 2023 04:04:03 +0000 Received: from localhost ([127.0.0.1]:41886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDGyo-0003HY-Tg for submit@debbugs.gnu.org; Sun, 25 Jun 2023 00:04:03 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDGym-0003H4-Pz for 47552@debbugs.gnu.org; Sun, 25 Jun 2023 00:04:02 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2C6918035A; Sun, 25 Jun 2023 00:03:55 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 177B580262; Sun, 25 Jun 2023 00:03:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687665834; bh=hpsgBX0zN2yGKHF8ql5+7x8OFZ/+fFm0RIqZFdB1pF8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=oZGyS9vGYTPNKfpV9L6A3rX40dLly55eedDFlza4+jkHvSk9SMz6VBnNH5eIeT2C1 NCjmt814k3wBNBdqAGxNJPJT/3PXdlfshQBSGAS9IzDUg/JFGXlYpTDlH3NB/9ASzx 0P/uZWToR04w7CxKUVfVuOPVGKw/NVHM7rCKEkrAiL8fHOfezl6BCspwsAkCEZoBxt 7MW7Ho2smqOQM5c7jGNa+6XiN44oKZfruU6A9fCKAoMEM9QfRuJIgHgCVWN4jU3r9i jW5xToiKIpkz5/4pK3QpwgotpAK3Ifdj0ilSxZDGSNW9a45fjH+2ZEJMdKoRQPg0lP hJoIBR74oBh3w== Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DF49A12062F; Sun, 25 Jun 2023 00:03:53 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87y1k8jjg4.fsf@web.de> (Michael Heerdegen's message of "Sun, 25 Jun 2023 05:43:07 +0200") Message-ID: References: <87wntlyhn9.fsf@rfc20.org> <87y2dxerd8.fsf@gnus.org> <87pmz0236v.fsf@gnus.org> <87pm5lr9t5.fsf@web.de> <87y1k8jjg4.fsf@web.de> Date: Sun, 25 Jun 2023 00:03:52 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.203 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > One (very small) downside of the code generated now is that it may > trigger "Lexical argument shadows the dynamic variable" warnings. Yup. The current code doesn't offer a way to silence them with `with-suppressed-warnings`, AFAICT :-( > 'date' for example is bad as a slot name when "diary" is loaded. AFAIK, `date` is not globally defined as dynbound by diary, so it should not be a problem. More specifically, the `date` variable is treated as dynbound only inside calendar's own files, but not in code found in other files. If you found it to be otherwise, please report it as a bug. Stefan From unknown Mon Aug 18 04:43:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47552: 27.1; cl-defstruct field names matching read-only variables -> bad code Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jun 2023 04:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: matt@rfc20.org, 47552@debbugs.gnu.org Received: via spool by 47552-submit@debbugs.gnu.org id=B47552.168766834117026 (code B ref 47552); Sun, 25 Jun 2023 04:46:02 +0000 Received: (at 47552) by debbugs.gnu.org; 25 Jun 2023 04:45:41 +0000 Received: from localhost ([127.0.0.1]:41903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDHd7-0004QY-7g for submit@debbugs.gnu.org; Sun, 25 Jun 2023 00:45:41 -0400 Received: from mout.web.de ([212.227.15.3]:54895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDHd2-0004QB-GI for 47552@debbugs.gnu.org; Sun, 25 Jun 2023 00:45:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1687668326; x=1688273126; i=michael_heerdegen@web.de; bh=5a6/Asz2Ns0UKTVYSRodqXjVx5axQ8V7Bzy2BoJTJoM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=fSABKCkFsGJN9D8Z1y2L+gYWTM37v5SvEQL1l3h+vJ5bMxG6zrsKNiq1EQQv9J7e9lmYOZB SLyipKHENh4VH1AFGnKViHi4RB6NsPSS54xmTJWHfG7E4dyx1eQjnw39zDGXkExHjGFHNIwNq RMWqe+iUK7GHlOYHU8dx4fa5ySw1hxMyiB49BUmApsSWO4mwlLg8GA7rXc8uhTWVpAi5nLRG4 feky1ipd95oZmNq/sSvhpa5PdY2qK+VM3onnDe9EcMCT/Oexfq5aRS0qvsOCC81Pmtz99WPoY VZML/HkqbdLGzuROiubwchmZb1kzRKyM/M0+GpwJ/FoY2EzyDHNw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([87.163.112.144]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MIc3F-1qGM9j18PF-00EieX; Sun, 25 Jun 2023 06:45:26 +0200 From: Michael Heerdegen In-Reply-To: (Stefan Monnier's message of "Sun, 25 Jun 2023 00:03:52 -0400") References: <87wntlyhn9.fsf@rfc20.org> <87y2dxerd8.fsf@gnus.org> <87pmz0236v.fsf@gnus.org> <87pm5lr9t5.fsf@web.de> <87y1k8jjg4.fsf@web.de> Date: Sun, 25 Jun 2023 06:45:25 +0200 Message-ID: <87ttuwjgka.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:wxFoGOd92nCpdcTHuakgHWGnYOL7L9lz21Z0JlU0c5UzGDRnYrA 2VmWkP3BixHiHHfY01XshkOhj08atCbeBidF2i/LE2hkpCVB3fv8lDlyv5J0II6a8euK0pj GZA6FBi2iboRoXwH1MBpUqlv2tFkYHhplxlR+x7Si+KMZcxFHt3rk40hrqxEVNRgxd3kzB0 zGHgfeIBcncqDLVNh2HlA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:j03fd3wu0Mg=;BHZC5sDMP2HK54pqy6rrUYDbw+2 2NODfUdVDKOIHVGSS9TQsLIOX2a4jjk0kBJxkylmShEYt6vbG+hOr+97UWEA9N+SkiyrXKTjw tXRSKN3tCzm/K/nilaULZIp5ShcGefReAitHpElZ4hPqA3wvMNuX/h+yBD/d/OdHQjRedXitf nxmNYk89AvbSUq3gIGUaYdcM81kkQ0O7ufm6j0Gzn6T/ScP+ZbkcjgJfoIGS6tK8kRCtBpPgB E8ZfLuP7tbPMrMHzcb6xMWVf1aNAfS7BKosIl2RpSjF2nWLwxdgv0TVdai9xI5zuXPEDAEDXY jIQ1eb060S1agnI9HmS++iZnc3rN84PYpCNefxO/HIBA557mCddvcZH9tNrfR4qp4kCMc/n77 FjbgDF4msgN0Xf9NQjPq/0bRd6LeLpj4OiTWZYBAzOlwtgHijWNsA4aSQsMdyBgn7gDYVXfNp 8x6jnbVWQueU68YnLEFVSHE+w8G8RytuvSIIvFQ+rOwznV++kNPzolQqUCFPZi/CCaVWapDMN 8aMRB246IjdtcOELhEnjKgRWWRDnvhbdQZbzIWE+9GbOL5oM2IE2Lbc9xJaMK0v2ZsZWV+GB7 X/+ShcCuet14bQxSSvUtdYSYFJiB9or3svCed5FXPHQEhMh6heaVsgrKWnhck67B7ZWVzGCaq jFdrpbBlQOrGxq/HcOlfYXBwGB1AH9x8Lo5udzLtPkclDVPpR0wvAGQDyJYHsSDvnFvJm53ak TNwTYc2nQmlylo1bmoJ6gf3Vy10UpS0qcnSxFw5DcoX9KkvqYNRdGoMoKgp+1f7+BQcWqnOSe 3jtzF4YngKyqmLCQkBKfRA8ppsNQXAjfnmgKxGU/JXJA5M6WYPRCCYqbHKqElyyu+X+VEnQf0 USmIGxbQUjJN9cSwl5j0SyN28fPlIY0RcIDDVCYiFdf/Jh0D1i/ZXeBRHUfgEENOdu9+uCrGS 7vn2wdhaZEgMu5BFGhxZ4nL3UP0= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: > AFAIK, `date` is not globally defined as dynbound by diary, so it should > not be a problem. More specifically, the `date` variable is treated as > dynbound only inside calendar's own files, but not in code found in > other files. Hmm, indeed. > If you found it to be otherwise, please report it as a bug. It turned out I had created an alias for the variable (using `defvaralias') long ago, more or less only to get rid of warnings at that moment, AFAIR. Seems that this makes the variable special globally. Michael.