From unknown Fri Jun 20 07:28:46 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#47540 <47540@debbugs.gnu.org> To: bug#47540 <47540@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add prips. Reply-To: bug#47540 <47540@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:28:46 +0000 retitle 47540 [PATCH] gnu: Add prips. reassign 47540 guix-patches submitter 47540 david larsson severity 47540 normal tag 47540 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 01 09:12:21 2021 Received: (at submit) by debbugs.gnu.org; 1 Apr 2021 13:12:21 +0000 Received: from localhost ([127.0.0.1]:56597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRx7R-0001NK-HL for submit@debbugs.gnu.org; Thu, 01 Apr 2021 09:12:21 -0400 Received: from lists.gnu.org ([209.51.188.17]:38498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRx7P-0001NC-LC for submit@debbugs.gnu.org; Thu, 01 Apr 2021 09:12:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRx7P-0001ak-GW for guix-patches@gnu.org; Thu, 01 Apr 2021 09:12:15 -0400 Received: from server0.selfhosted.xyz ([217.64.149.7]:50828) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRx7M-00045Y-B6 for guix-patches@gnu.org; Thu, 01 Apr 2021 09:12:15 -0400 Received: from server0.selfhosted.xyz (localhost [127.0.0.1]) by server0.selfhosted.xyz (Postfix) with ESMTP id 203821CCFA57 for ; Thu, 1 Apr 2021 15:11:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=selfhosted.xyz; s=dkim; t=1617282722; bh=0KYnXFLOn9TP7CDJ3hVvWPBJMR8LeYF/7VRW1qzM1Iw=; h=Date:From:To:Subject; b=08mQpirlRWqmy5Uk+SrnalSaYjqMtUcJzymylXzo7VM1MoGzmeeDOTTe0lCOMTapC WDK3gaXK4ij+6yhYrqBMsMNL9jEzs8qfc359lfEPxZWbXkKqKy9f3cjpxJiBbHUtwX /YUdUjX88DRIw99DnU8CRmFSRwgNsxgp0QnvHzxHSdNlZeR/xsoEvGbmDQyQEAc3Pj sYpI0qaSC4v4MeLtthtbkQQiSRetuF+ozO4Evr6Hb70YtKIgrFBpM18hWx9xESrksy fkiJPmVGsHNgsv8G0xZQEMWPQTHhoEhbrtBlpYJ5FTNa5NpJCBendfgJUTjsE8cjOW NNz7i9n1xypmA== X-Fuglu-Suspect: 0d9931dcd0394f47991aacfe23a58f3a X-Fuglu-Spamstatus: NO Received: from webmail.selfhosted.xyz (office.selfhosted.xyz [192.168.1.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mail@selfhosted.xyz) by server0.selfhosted.xyz (Postfix) with ESMTPSA for ; Thu, 1 Apr 2021 15:11:57 +0200 (CEST) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_8f78689425fda87146ef3aeeba779bd0" Date: Thu, 01 Apr 2021 15:11:56 +0200 From: david larsson To: guix-patches@gnu.org Subject: [PATCH] gnu: Add prips. Message-ID: X-Sender: david.larsson@selfhosted.xyz Received-SPF: pass client-ip=217.64.149.7; envelope-from=david.larsson@selfhosted.xyz; helo=server0.selfhosted.xyz X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499, FROM_SUSPICIOUS_NTLD_FP=0.001, PDS_OTHER_BAD_TLD=1.999, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From 22cc953d3e663bb842d5a0b970577a3d54f6fef1 Mon Sep 17 00:00:00 2001 From: methuselah-0 Date: Thu, 1 Apr 2021 15:10:45 +0200 Subject: [PATCH] gnu: Add prips. * gnu/packages/admin.scm (prips): New variable. --- gnu/packages/admin.scm | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: selfhosted.xyz (xyz)] 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=david.larsson%40selfhosted.xyz; ip=209.51.188.17; r=debbugs.gnu.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) --=_8f78689425fda87146ef3aeeba779bd0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8; format=flowed From 22cc953d3e663bb842d5a0b970577a3d54f6fef1 Mon Sep 17 00:00:00 2001 From: methuselah-0 Date: Thu, 1 Apr 2021 15:10:45 +0200 Subject: [PATCH] gnu: Add prips. * gnu/packages/admin.scm (prips): New variable. --- gnu/packages/admin.scm | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index df7973395d..f6cb62a568 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -39,6 +39,7 @@ ;;; Copyright © 2021 Stefan Reichör ;;; Copyright © 2021 qblade ;;; Copyright © 2021 Hyunseok Kim +;;; Copyright © 2021 David Larsson ;;; ;;; This file is part of GNU Guix. ;;; @@ -1019,6 +1020,39 @@ recursive runs on the generated subnets. (also IPv6) @end itemize\n") (license license:bsd-3))) +(define-public prips + (package + (name "prips") + (version "1.1.1") + (source + (origin + (method url-fetch) + (uri (string-append "https://devel.ringlet.net/files/sys/" + name "/" name "-" version ".tar.xz")) + (sha256 + (base32 "1a33vbl4w603mk6mm5r3vhk87fy3dfk5wdpch0yd3ncbkg3fmvqn")))) + (build-system gnu-build-system) + (arguments + '(#:make-flags (list "CC=gcc") + #:phases (modify-phases + %standard-phases + (delete 'configure) + (delete 'check) + (replace 'install + (lambda _ + (let* + ((bin-dir (string-append %output "/bin")) + (bin-file (string-append bin-dir "/prips"))) + (mkdir-p bin-dir) + (copy-file "prips" bin-file) + (chmod bin-file #o700))))))) + (synopsis "Tool that prints the IP addresses in a given range") + (description "Prips can be used to print all of the IP addresses in + a given range. This allows the enhancement of tools only work + on one host at a time (e.g. whois).") + (home-page "https://devel.ringlet.net/sysutils/prips/") + (license license:gpl2))) + (define-public alive (package (name "alive") -- 2.30.2 --=_8f78689425fda87146ef3aeeba779bd0 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-Add-prips.patch Content-Disposition: attachment; filename=0001-gnu-Add-prips.patch; size=2327 RnJvbSAyMmNjOTUzZDNlNjYzYmI4NDJkNWEwYjk3MDU3N2EzZDU0ZjZmZWYxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtZXRodXNlbGFoLTAgPGRhdmlkLmxhcnNzb25Ac2VsZmhvc3Rl ZC54eXo+CkRhdGU6IFRodSwgMSBBcHIgMjAyMSAxNToxMDo0NSArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIGdudTogQWRkIHByaXBzLgoKKiBnbnUvcGFja2FnZXMvYWRtaW4uc2NtIChwcmlwcyk6IE5l dyB2YXJpYWJsZS4KLS0tCiBnbnUvcGFja2FnZXMvYWRtaW4uc2NtIHwgMzQgKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKykK CmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvYWRtaW4uc2NtIGIvZ251L3BhY2thZ2VzL2FkbWlu LnNjbQppbmRleCBkZjc5NzMzOTVkLi5mNmNiNjJhNTY4IDEwMDY0NAotLS0gYS9nbnUvcGFja2Fn ZXMvYWRtaW4uc2NtCisrKyBiL2dudS9wYWNrYWdlcy9hZG1pbi5zY20KQEAgLTM5LDYgKzM5LDcg QEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAyMSBTdGVmYW4gUmVpY2jDtnIgPHN0ZWZhbkB4c3RldmUu YXQ+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMjEgcWJsYWRlIDxxYmxhZGVAcHJvdG9ubWFpbC5jb20+ CiA7OzsgQ29weXJpZ2h0IMKpIDIwMjEgSHl1bnNlb2sgS2ltIDxsYXNuZXNuZUBsYWd1bnBvc3By YXNpaG9wcmUub3JnPgorOzs7IENvcHlyaWdodCDCqSAyMDIxIERhdmlkIExhcnNzb24gPGRhdmlk LmxhcnNzb25Ac2VsZmhvc3RlZC54eXo+CiA7OzsKIDs7OyBUaGlzIGZpbGUgaXMgcGFydCBvZiBH TlUgR3VpeC4KIDs7OwpAQCAtMTAxOSw2ICsxMDIwLDM5IEBAIHJlY3Vyc2l2ZSBydW5zIG9uIHRo ZSBnZW5lcmF0ZWQgc3VibmV0cy4gIChhbHNvIElQdjYpCiBAZW5kIGl0ZW1pemVcbiIpCiAgICAg KGxpY2Vuc2UgbGljZW5zZTpic2QtMykpKQogCisoZGVmaW5lLXB1YmxpYyBwcmlwcworICAocGFj a2FnZQorICAgIChuYW1lICJwcmlwcyIpCisgICAgKHZlcnNpb24gIjEuMS4xIikKKyAgICAoc291 cmNlCisgICAgIChvcmlnaW4KKyAgICAgICAobWV0aG9kIHVybC1mZXRjaCkKKyAgICAgICAodXJp IChzdHJpbmctYXBwZW5kICJodHRwczovL2RldmVsLnJpbmdsZXQubmV0L2ZpbGVzL3N5cy8iCisg ICAgICAgICAgICAgICAgICAgICAgICAgICBuYW1lICIvIiBuYW1lICItIiB2ZXJzaW9uICIudGFy Lnh6IikpCisgICAgICAgKHNoYTI1NgorICAgICAgICAoYmFzZTMyICIxYTMzdmJsNHc2MDNtazZt bTVyM3Zoazg3ZnkzZGZrNXdkcGNoMHlkM25jYmtnM2ZtdnFuIikpKSkKKyAgICAoYnVpbGQtc3lz dGVtIGdudS1idWlsZC1zeXN0ZW0pCisgICAgKGFyZ3VtZW50cworICAgICAnKCM6bWFrZS1mbGFn cyAobGlzdCAiQ0M9Z2NjIikKKyAgICAgICAjOnBoYXNlcyAobW9kaWZ5LXBoYXNlcworICAgICAg ICAgICAgICAgICAgICAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAgICAgICAgICAoZGVsZXRl ICdjb25maWd1cmUpCisgICAgICAgICAgICAgICAgICAoZGVsZXRlICdjaGVjaykKKyAgICAgICAg ICAgICAgICAgIChyZXBsYWNlICdpbnN0YWxsCisgICAgICAgICAgICAgICAgICAgIChsYW1iZGEg XworICAgICAgICAgICAgICAgICAgICAgIChsZXQqCisgICAgICAgICAgICAgICAgICAgICAgICAg ICgoYmluLWRpciAgKHN0cmluZy1hcHBlbmQgJW91dHB1dCAiL2JpbiIpKQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgKGJpbi1maWxlIChzdHJpbmctYXBwZW5kIGJpbi1kaXIgIi9wcmlwcyIp KSkKKyAgICAgICAgICAgICAgICAgICAgICAgIChta2Rpci1wIGJpbi1kaXIpCisgICAgICAgICAg ICAgICAgICAgICAgICAoY29weS1maWxlICJwcmlwcyIgYmluLWZpbGUpCisgICAgICAgICAgICAg ICAgICAgICAgICAoY2htb2QgYmluLWZpbGUgI283MDApKSkpKSkpCisgICAgKHN5bm9wc2lzICJU b29sIHRoYXQgcHJpbnRzIHRoZSBJUCBhZGRyZXNzZXMgaW4gYSBnaXZlbiByYW5nZSIpCisgICAg KGRlc2NyaXB0aW9uICJQcmlwcyBjYW4gYmUgdXNlZCB0byBwcmludCBhbGwgb2YgdGhlIElQIGFk ZHJlc3NlcyBpbgorIGEgZ2l2ZW4gcmFuZ2UuICBUaGlzIGFsbG93cyB0aGUgZW5oYW5jZW1lbnQg b2YgdG9vbHMgb25seSB3b3JrCisgb24gb25lIGhvc3QgYXQgYSB0aW1lIChlLmcuIHdob2lzKS4i KQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vZGV2ZWwucmluZ2xldC5uZXQvc3lzdXRpbHMvcHJp cHMvIikKKyAgICAobGljZW5zZSBsaWNlbnNlOmdwbDIpKSkKKwogKGRlZmluZS1wdWJsaWMgYWxp dmUKICAgKHBhY2thZ2UKICAgICAobmFtZSAiYWxpdmUiKQotLSAKMi4zMC4yCgo= --=_8f78689425fda87146ef3aeeba779bd0-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 01 15:44:59 2021 Received: (at 47540) by debbugs.gnu.org; 1 Apr 2021 19:45:00 +0000 Received: from localhost ([127.0.0.1]:58722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS3FT-0001i8-Li for submit@debbugs.gnu.org; Thu, 01 Apr 2021 15:44:59 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:51010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS3FR-0001hy-Dh for 47540@debbugs.gnu.org; Thu, 01 Apr 2021 15:44:58 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id nXkv240070mfAB406XkvWj; Thu, 01 Apr 2021 21:44:55 +0200 Message-ID: <94325c646a58888160ed6548dc5f646629e8374d.camel@telenet.be> Subject: Re: [bug#47540] [PATCH] gnu: Add prips. From: Maxime Devos To: david larsson , 47540@debbugs.gnu.org Date: Thu, 01 Apr 2021 21:44:46 +0200 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-dJ9+wJe64WdixGqcSMfY" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1617306295; bh=df1yBLh9tbrdapd9rt6PN2gDCrKM/EJ1uvsXwurKi9Q=; h=Subject:From:To:Date:In-Reply-To:References; b=JhOIb44cV+WdoI8MYBcf8ZR+yUkuHKzqIIL2kxxhyLOfmry6GhmR+DepHwKFUsrKg p8oQLkydytBkolen4dhjfPavuS/ghRWmiPgIlzEhU31MZuvACLew6aX4gq4QsOVvqf NohsFbGutaN+FWcG5YRyb6OTviixvK1MGO/hy7K9mGP3xphctu6J79SQKNunzlXz6b A45NisU5rf+nIvWYeUcYUBw3XEQ+5Yp6foCOTQLJ93qkKwYExcQIk4oB9PDW6jXAg/ ybPLhHDZD/yi50vw2oMgFW6R16lsb8i6ESi4MqyK0B0eD52ABFuanomaGjOHlDe356 OYgKLSDoHOfBA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47540 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-dJ9+wJe64WdixGqcSMfY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Some comments on the patch. On Thu, 2021-04-01 at 15:11 +0200, david larsson wrote: > [...] > +(define-public prips > + (package > + (name "prips") > + (version "1.1.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://devel.ringlet.net/files/sys/" > + name "/" name "-" version ".tar.xz")) > + (sha256 > + (base32=20 > "1a33vbl4w603mk6mm5r3vhk87fy3dfk5wdpch0yd3ncbkg3fmvqn")))) > + (build-system gnu-build-system) > + (arguments > + '(#:make-flags (list "CC=3Dgcc") As "CC=3Dgcc" is a constant, I would write '("CC=3Dgcc") here, though admittedly this is largely a matter of taste. Another problem: when cross-compiling, "gcc" will be a compiler for the build system, not the host system (assuming I got the terminology right). Instead, write `(#:make-flags (list (string-append "CC" ,(cc-for-target))) ...) (The quasiquote ` is important.) (TODO to self: fix other packages that incorrectly set "CC=3Dgcc" ...) > + #:phases (modify-phases > + %standard-phases %standard-phases shouldn't be on a separate line here. > + (delete 'configure) > + (delete 'check) Prips has some tests, so don't delete this phase. > + (replace 'install > + (lambda _ > + (let* > + ((bin-dir (string-append %output "/bin")) > + (bin-file (string-append bin-dir "/prips"))) The ((bin-dir ...)) should be on the same line as 'let*'. > + (mkdir-p bin-dir) > + (copy-file "prips" bin-file) > + (chmod bin-file #o700))))))) Why are you making bin/prips writable? Shouldn't this be (chmod bin-file #o600) instead? > + (synopsis "Tool that prints the IP addresses in a given range") > + (description "Prips can be used to print all of the IP addresses in > + a given range. This allows the enhancement of tools only work =E2=80=98Enhancement=E2=80=99 is rather vague and leaning towards marketing= -speak. I do not have an alternative suggestion however. > + on one host at a time (e.g. whois).") > + (home-page "https://devel.ringlet.net/sysutils/prips/") > + (license license:gpl2))) I looked at the source code and it seems prips is actually gpl2+. Greetings, Maxime. --=-dJ9+wJe64WdixGqcSMfY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYGYirhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7uybAQCxoal1eunp70qhVEm7IQnbnP+P tpvkpTfUHSVTquYNxwD+Mqj0hgYwCTQkhxLAKt2ni8I8NojCq1ilGXK7YZL5rwc= =eMbV -----END PGP SIGNATURE----- --=-dJ9+wJe64WdixGqcSMfY-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 05 09:09:42 2021 Received: (at 47540) by debbugs.gnu.org; 5 Apr 2021 13:09:42 +0000 Received: from localhost ([127.0.0.1]:37283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTOz7-0003lc-O5 for submit@debbugs.gnu.org; Mon, 05 Apr 2021 09:09:42 -0400 Received: from server0.selfhosted.xyz ([217.64.149.7]:51162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTOz4-0003lH-OS for 47540@debbugs.gnu.org; Mon, 05 Apr 2021 09:09:40 -0400 Received: from server0.selfhosted.xyz (localhost [127.0.0.1]) by server0.selfhosted.xyz (Postfix) with ESMTP id F11521CE6DAD; Mon, 5 Apr 2021 15:09:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=selfhosted.xyz; s=dkim; t=1617628170; bh=l1/a2yrJbZTExZYihAa00sYfy+nleHmrKsTq57sc97k=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=LsB2HHTes364PqftWOOwZxQ0BPQiAtAL0dWeKT+r0WFCkQ/xBi8a1IiSvQH/v878v SGVkYjfkF1wmtGpZPPGHAOh+5bmVOOgCVoUtd+tsE/vO7InvWOfQ9xq+fIg0Cm0E+N doXh2vah0qJE2gYT/XHq950oEj5A6i15LCh/547+qf84qVXZxB9hvmAxMtyxgmtRTM KRD8EJs7N0R5S5R2EbVHIY6IjHhASUoxF0+baEwjG33/vkjH1lrQE2+JLx+Vj4/qfV 2BRWtsGwmmqFbMpzeV0BJQOxCr7HibMXriwPDZIIoeU/0yP0bqmgF9XTgUz3XC4a1y qYpYnG3GUKWrw== X-Fuglu-Suspect: 91ff8ee08b3746949a4f8a92afa0503b X-Fuglu-Spamstatus: NO Received: from webmail.selfhosted.xyz (office.selfhosted.xyz [192.168.1.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mail@selfhosted.xyz) by server0.selfhosted.xyz (Postfix) with ESMTPSA; Mon, 5 Apr 2021 15:09:23 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 05 Apr 2021 15:09:23 +0200 From: david larsson To: Maxime Devos Subject: Re: [bug#47540] [PATCH] gnu: Add prips. In-Reply-To: <94325c646a58888160ed6548dc5f646629e8374d.camel@telenet.be> References: <94325c646a58888160ed6548dc5f646629e8374d.camel@telenet.be> Message-ID: <04a8eb1efe98cd5ada24e870b39a3671@selfhosted.xyz> X-Sender: david.larsson@selfhosted.xyz X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 47540 Cc: 47540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On 2021-04-01 21:44, Maxime Devos wrote: >> + (arguments >> + '(#:make-flags (list "CC=gcc") > > As "CC=gcc" is a constant, I would write '("CC=gcc") here, > though admittedly this is largely a matter of taste. > Another problem: when cross-compiling, "gcc" will be a > compiler for the build system, not the host system (assuming > I got the terminology right). Instead, write > > `(#:make-flags (list (string-append "CC" ,(cc-for-target))) > ...) > > (The quasiquote ` is important.) Fixed. >> + #:phases (modify-phases >> + %standard-phases > > %standard-phases shouldn't be on a separate line here. Fixed. > >> + (delete 'configure) >> + (delete 'check) > > Prips has some tests, so don't delete this phase. I tried to fix but this fails. > >> + (replace 'install >> + (lambda _ >> + (let* >> + ((bin-dir (string-append %output "/bin")) >> + (bin-file (string-append bin-dir >> "/prips"))) > > The ((bin-dir ...)) should be on the same line as 'let*'. > >> + (mkdir-p bin-dir) >> + (copy-file "prips" bin-file) >> + (chmod bin-file #o700))))))) > > Why are you making bin/prips writable? Shouldn't this be > (chmod bin-file #o600) instead? I don't know for sure why that happened, but it's fixed to #o600 now. >> + (synopsis "Tool that prints the IP addresses in a given range") >> + (description "Prips can be used to print all of the IP addresses >> in >> + a given range. This allows the enhancement of tools only work > > ‘Enhancement’ is rather vague and leaning towards marketing-speak. > I do not have an alternative suggestion however. This was an exact quote from website or something. >> + (license license:gpl2))) > > I looked at the source code and it seems prips is actually gpl2+. Fixed. > Greetings, > Maxime. Thanks for your review! This is what it looks like now, and failing the check phase: (define-public prips (package (name "prips") (version "1.1.1") (source (origin (method url-fetch) (uri (string-append "https://devel.ringlet.net/files/sys/" name "/" name "-" version ".tar.xz")) (sha256 (base32 "1a33vbl4w603mk6mm5r3vhk87fy3dfk5wdpch0yd3ncbkg3fmvqn")))) (build-system gnu-build-system) (arguments `(#:make-flags (list (string-append "CC=" ,(cc-for-target))) #:phases (modify-phases %standard-phases (delete 'configure) ;(delete 'check) (replace 'install (lambda _ (let* ((bin-dir (string-append %output "/bin")) (bin-file (string-append bin-dir "/prips"))) (mkdir-p bin-dir) (copy-file "prips" bin-file) (chmod bin-file #o600))))))) (synopsis "Tool that prints the IP addresses in a given range") (description "Prips can be used to print all of the IP addresses in a given range. This allows the enhancement of tools only work on one host at a time (e.g. whois).") (home-page "https://devel.ringlet.net/sysutils/prips/") (license license:gpl2+))) The logs: --------------- starting phase `check' make: *** No rule to make target 'check'. Stop. Test suite failed, dumping logs. command "make" "check" "-j" "2" "CC=gcc" failed with status 2 Best regards, David --------------- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 05 13:39:02 2021 Received: (at 47540) by debbugs.gnu.org; 5 Apr 2021 17:39:02 +0000 Received: from localhost ([127.0.0.1]:38522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTTBl-0000GS-U7 for submit@debbugs.gnu.org; Mon, 05 Apr 2021 13:39:02 -0400 Received: from server0.selfhosted.xyz ([217.64.149.7]:50194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTTBh-0000Fv-UG for 47540@debbugs.gnu.org; Mon, 05 Apr 2021 13:39:00 -0400 Received: from server0.selfhosted.xyz (localhost [127.0.0.1]) by server0.selfhosted.xyz (Postfix) with ESMTP id 7F3041CE7503; Mon, 5 Apr 2021 19:38:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=selfhosted.xyz; s=dkim; t=1617644331; bh=3ZPjySxcQh2oe14i7nWlkT+Bh00SL0a8EJgnEBlsk/Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=chSQoIEXkpu4386fXIAav1yctB//DUUbLjhIAyFyg0wmWUnoTwCLbvot9KrzfbgID exCpzBNi42SeFq3bC9ahSp5l2WowG176hYc5sZxeLm9k3ghSPqdzKS3xuGq0juVJtS 6iHqjtDypqF1AH3r2jkqb9Hdtrn/SIxXrJxlcYGvcMQk2FYEp8fAP0oopmWFQT7BJM bEMEZ5qWjj8iRPVzxNym5QSZvKrPVpxRdaGTnrzYD7QU+Ms4QQJWaxFZAR7fbOJwoZ gT3REw3Uii83mlXEtT0+paMmFTaU2UpkrkQMH+1Bt23CBVN06nypp0+M75uwKMktFg vJU2qXxgxnotQ== X-Fuglu-Suspect: ed240d31d02c4d47883cff73df8dfa0b X-Fuglu-Spamstatus: NO Received: from webmail.selfhosted.xyz (office.selfhosted.xyz [192.168.1.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mail@selfhosted.xyz) by server0.selfhosted.xyz (Postfix) with ESMTPSA; Mon, 5 Apr 2021 19:38:44 +0200 (CEST) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_fe7a3f89ec9d526943eb00f11fd144e3" Date: Mon, 05 Apr 2021 19:38:44 +0200 From: david larsson To: Maxime Devos Subject: Re: [bug#47540] [PATCH] gnu: Add prips. In-Reply-To: <04a8eb1efe98cd5ada24e870b39a3671@selfhosted.xyz> References: <94325c646a58888160ed6548dc5f646629e8374d.camel@telenet.be> <04a8eb1efe98cd5ada24e870b39a3671@selfhosted.xyz> Message-ID: X-Sender: david.larsson@selfhosted.xyz X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 47540 Cc: Guix-patches , 47540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --=_fe7a3f89ec9d526943eb00f11fd144e3 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Here's a new patch which has the fixes you mentioned, except I still haven't readded the configure and test phases as I don't know how to make them work. Best regards, David --=_fe7a3f89ec9d526943eb00f11fd144e3 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; charset=us-ascii; name=0001-gnu-Add-prips.patch Content-Disposition: attachment; filename=0001-gnu-Add-prips.patch; size=2334 RnJvbSA4NzM3N2E0OTE4YWI4YzVmZGE5MzlkMDY5NmU3MjU0MjVlMzJmZWUzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtZXRodXNlbGFoLTAgPGRhdmlkLmxhcnNzb25Ac2VsZmhvc3Rl ZC54eXo+CkRhdGU6IE1vbiwgNSBBcHIgMjAyMSAxOTozNjoyNyArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIGdudTogQWRkIHByaXBzLgoKZ251L3BhY2thZ2VzL2FkbWluLnNjbSAocHJpcHMpOiBOZXcg dmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2FkbWluLnNjbSB8IDMzICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKykKCmRp ZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvYWRtaW4uc2NtIGIvZ251L3BhY2thZ2VzL2FkbWluLnNj bQppbmRleCBkZjc5NzMzOTVkLi5mZDVhNjYxNzM4IDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMv YWRtaW4uc2NtCisrKyBiL2dudS9wYWNrYWdlcy9hZG1pbi5zY20KQEAgLTM5LDYgKzM5LDcgQEAK IDs7OyBDb3B5cmlnaHQgwqkgMjAyMSBTdGVmYW4gUmVpY2jDtnIgPHN0ZWZhbkB4c3RldmUuYXQ+ CiA7OzsgQ29weXJpZ2h0IMKpIDIwMjEgcWJsYWRlIDxxYmxhZGVAcHJvdG9ubWFpbC5jb20+CiA7 OzsgQ29weXJpZ2h0IMKpIDIwMjEgSHl1bnNlb2sgS2ltIDxsYXNuZXNuZUBsYWd1bnBvc3ByYXNp aG9wcmUub3JnPgorOzs7IENvcHlyaWdodCDCqSAyMDIxIERhdmlkIExhcnNzb24gPGRhdmlkLmxh cnNzb25Ac2VsZmhvc3RlZC54eXo+CiA7OzsKIDs7OyBUaGlzIGZpbGUgaXMgcGFydCBvZiBHTlUg R3VpeC4KIDs7OwpAQCAtMTAxOSw2ICsxMDIwLDM4IEBAIHJlY3Vyc2l2ZSBydW5zIG9uIHRoZSBn ZW5lcmF0ZWQgc3VibmV0cy4gIChhbHNvIElQdjYpCiBAZW5kIGl0ZW1pemVcbiIpCiAgICAgKGxp Y2Vuc2UgbGljZW5zZTpic2QtMykpKQogCisoZGVmaW5lLXB1YmxpYyBwcmlwcworICAocGFja2Fn ZQorICAgIChuYW1lICJwcmlwcyIpCisgICAgKHZlcnNpb24gIjEuMS4xIikKKyAgICAoc291cmNl CisgICAgIChvcmlnaW4KKyAgICAgICAobWV0aG9kIHVybC1mZXRjaCkKKyAgICAgICAodXJpIChz dHJpbmctYXBwZW5kICJodHRwczovL2RldmVsLnJpbmdsZXQubmV0L2ZpbGVzL3N5cy8iCisgICAg ICAgICAgICAgICAgICAgICAgICAgICBuYW1lICIvIiBuYW1lICItIiB2ZXJzaW9uICIudGFyLnh6 IikpCisgICAgICAgKHNoYTI1NgorICAgICAgICAoYmFzZTMyICIxYTMzdmJsNHc2MDNtazZtbTVy M3Zoazg3ZnkzZGZrNXdkcGNoMHlkM25jYmtnM2ZtdnFuIikpKSkKKyAgICAoYnVpbGQtc3lzdGVt IGdudS1idWlsZC1zeXN0ZW0pCisgICAgKGFyZ3VtZW50cworICAgICBgKCM6bWFrZS1mbGFncyAo bGlzdCAoc3RyaW5nLWFwcGVuZCAiQ0M9IiAsKGNjLWZvci10YXJnZXQpKSkKKyAgICAgICAjOnBo YXNlcyAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAgICAgICAgICAo ZGVsZXRlICdjb25maWd1cmUpCisgICAgICAgICAgICAgICAgICAoZGVsZXRlICdjaGVjaykKKyAg ICAgICAgICAgICAgICAgIChyZXBsYWNlICdpbnN0YWxsCisgICAgICAgICAgICAgICAgICAgIChs YW1iZGEgXworICAgICAgICAgICAgICAgICAgICAgIChsZXQqCisgICAgICAgICAgICAgICAgICAg ICAgICAgICgoYmluLWRpciAgKHN0cmluZy1hcHBlbmQgJW91dHB1dCAiL2JpbiIpKQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgKGJpbi1maWxlIChzdHJpbmctYXBwZW5kIGJpbi1kaXIgIi9w cmlwcyIpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIChta2Rpci1wIGJpbi1kaXIpCisgICAg ICAgICAgICAgICAgICAgICAgICAoY29weS1maWxlICJwcmlwcyIgYmluLWZpbGUpCisgICAgICAg ICAgICAgICAgICAgICAgICAoY2htb2QgYmluLWZpbGUgI282MDApKSkpKSkpCisgICAgKHN5bm9w c2lzICJUb29sIHRoYXQgcHJpbnRzIHRoZSBJUCBhZGRyZXNzZXMgaW4gYSBnaXZlbiByYW5nZSIp CisgICAgKGRlc2NyaXB0aW9uICJQcmlwcyBjYW4gYmUgdXNlZCB0byBwcmludCBhbGwgb2YgdGhl IElQIGFkZHJlc3NlcyBpbgorIGEgZ2l2ZW4gcmFuZ2UuICBUaGlzIGFsbG93cyB0aGUgZW5oYW5j ZW1lbnQgb2YgdG9vbHMgb25seSB3b3JrCisgb24gb25lIGhvc3QgYXQgYSB0aW1lIChlLmcuIHdo b2lzKS4iKQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vZGV2ZWwucmluZ2xldC5uZXQvc3lzdXRp bHMvcHJpcHMvIikKKyAgICAobGljZW5zZSBsaWNlbnNlOmdwbDIrKSkpCisKIChkZWZpbmUtcHVi bGljIGFsaXZlCiAgIChwYWNrYWdlCiAgICAgKG5hbWUgImFsaXZlIikKLS0gCjIuMzAuMgoK --=_fe7a3f89ec9d526943eb00f11fd144e3-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 06 10:04:40 2021 Received: (at 47540) by debbugs.gnu.org; 6 Apr 2021 14:04:40 +0000 Received: from localhost ([127.0.0.1]:41316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTmJs-0000El-F2 for submit@debbugs.gnu.org; Tue, 06 Apr 2021 10:04:40 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:43208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTmJp-0000Eb-1i for 47540@debbugs.gnu.org; Tue, 06 Apr 2021 10:04:38 -0400 Received: from butterfly.local ([213.119.235.56]) by michel.telenet-ops.be with bizsmtp id pS4Y2400P1Dh5Ut06S4Zme; Tue, 06 Apr 2021 16:04:35 +0200 Message-ID: <96ad7a4cc63b104b2cc5eac5997b6ac2854fe101.camel@telenet.be> Subject: Re: [bug#47540] [PATCH] gnu: Add prips. From: Maxime Devos To: david larsson Date: Tue, 06 Apr 2021 16:04:27 +0200 In-Reply-To: References: <94325c646a58888160ed6548dc5f646629e8374d.camel@telenet.be> <04a8eb1efe98cd5ada24e870b39a3671@selfhosted.xyz> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-M/rOOU3+gHwdTiHbC8Zd" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1617717875; bh=oZSaWq3v+BSwlux0yUySPBPOXUEFX233mVFvt6ICBZ4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=NSBIx+W1Hxj4dTYdhheFDq12Zo/1Kuu45nEuBY+SX7xLrsTTS1XhTBhL/gx96i1Z3 uSLFGFRtXeNBBiXLH89CGFd5611ncVkORks5ybm+tYwmGyturO2r0sdrvT0VDff+hj 2UnRs0dgh36aL1ae0YYrFcN7TPlT4DBwFGHeFPP6ONmzhxNzPL0sXDsSVkw9Z1cLwv MYoSDPqVeBKWPbXIIv1x+IV4NPkhxFRXWrNL4MHVuKGsHcrTZ7dcO/U8SaskrQ1ndo SufZZU0ZjFCf+6YbFufofGe/KiKSxplb5/ySwbVZveE/Wl6CrLzFLWluZ+R+LLvekG 2zvC38U2j5/bg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47540 Cc: Guix-patches , 47540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-M/rOOU3+gHwdTiHbC8Zd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable [...] > +(define-public prips > + (package > + (name "prips") > + (version "1.1.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://devel.ringlet.net/files/sys/" > + name "/" name "-" version ".tar.xz")) > + (sha256 > + (base32 "1a33vbl4w603mk6mm5r3vhk87fy3dfk5wdpch0yd3ncbkg3fmvqn"))= )) > + (build-system gnu-build-system) Add =E2=80=98(native-inputs `(("perl-test-harness" ,perl-test-harness)))=E2= =80=99 such that the makefile can find the 'prove' binary. > + (arguments > + `(#:make-flags (list (string-append "CC=3D" ,(cc-for-target))) Add =E2=80=98#:test-target "test"=E2=80=99 here, as the makefile has a 'tes= t' target instead of a 'check' target. > + #:phases (modify-phases %standard-phases > + (delete 'configure) > + (delete 'check) and remove the (delete 'check). The package now builds successfully for me. Greetings, Maxime. --=-M/rOOU3+gHwdTiHbC8Zd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYGxqaxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7gz+AP9up3IG1370MAdxFkbp5eJpn6FL o4e5VGaAagu1k4LcQwEA65WQ82qp2WON7l43zxSFLev+SYXBp+AtqUb56OWHEgc= =OqGY -----END PGP SIGNATURE----- --=-M/rOOU3+gHwdTiHbC8Zd-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 08 15:29:16 2021 Received: (at 47540) by debbugs.gnu.org; 8 Apr 2021 19:29:16 +0000 Received: from localhost ([127.0.0.1]:48369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUaL6-0008OS-Gv for submit@debbugs.gnu.org; Thu, 08 Apr 2021 15:29:16 -0400 Received: from server0.selfhosted.xyz ([217.64.149.7]:39208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUaL2-0008OB-KA for 47540@debbugs.gnu.org; Thu, 08 Apr 2021 15:29:14 -0400 Received: from server0.selfhosted.xyz (localhost [127.0.0.1]) by server0.selfhosted.xyz (Postfix) with ESMTP id D01E11CF8D7D; Thu, 8 Apr 2021 21:28:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=selfhosted.xyz; s=dkim; t=1617910146; bh=TicfklrOF341bl1grGarRZWOxWVeCVV+WOxnLypt2p8=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=q2L3e28IvZG0EH6tUVhnOmdPM3SHptUu0l7AenvkEyxgTPPkcLp9vOtUwa64/2TIV dw95vnbhrghSO2OhRmga1dQsjD0ySanA+QhjNZdvgGUuvy+ETn0BF7xROuu08nzQQv Sk28gQPzWvLFAsp9oWOXRpe8BMynXvNeb73ckkgzwI/ACOD+WJfIFiB2DoCSvT/TCt aBDyxZw2voI6Ki6HTsPAl3p1QuZNKlmbwQtdeONlySfn/gbt3z16k1wdAaufBMA0j2 sOwOLy3qiymVA9GbqFYHd6WPffQsrmXdERjfOmqLdn0CsOSbIaSKVLpS2TfozoOqRQ rM1LUFqihS+Pg== X-Fuglu-Suspect: b0be46da7af64d0698c5c4b50c7f356e X-Fuglu-Spamstatus: NO Received: from webmail.selfhosted.xyz (office.selfhosted.xyz [192.168.1.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mail@selfhosted.xyz) by server0.selfhosted.xyz (Postfix) with ESMTPSA; Thu, 8 Apr 2021 21:28:59 +0200 (CEST) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_67ccf9bf7785ac9cd4b097758fa5df17" Date: Thu, 08 Apr 2021 21:28:59 +0200 From: david larsson To: Maxime Devos Subject: Re: [bug#47540] [PATCH] gnu: Add prips. In-Reply-To: <96ad7a4cc63b104b2cc5eac5997b6ac2854fe101.camel@telenet.be> References: <94325c646a58888160ed6548dc5f646629e8374d.camel@telenet.be> <04a8eb1efe98cd5ada24e870b39a3671@selfhosted.xyz> <96ad7a4cc63b104b2cc5eac5997b6ac2854fe101.camel@telenet.be> Message-ID: <444cc65de656858b59e577dce74009bb@selfhosted.xyz> X-Sender: david.larsson@selfhosted.xyz X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 47540 Cc: Guix-patches , 47540@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --=_67ccf9bf7785ac9cd4b097758fa5df17 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8; format=flowed On 2021-04-06 16:04, Maxime Devos wrote: > Add ‘(native-inputs `(("perl-test-harness" ,perl-test-harness)))’ such > that > the makefile can find the 'prove' binary. Fixed. > > Add ‘#:test-target "test"’ here, as the makefile has a 'test' target > instead of a 'check' target. > >> + #:phases (modify-phases %standard-phases >> + (delete 'configure) >> + (delete 'check) > > and remove the (delete 'check). Fixed. > The package now builds successfully for me. For me as well. > Greetings, > Maxime. Thanks for your review and help with improving this package! Best regards, David --=_67ccf9bf7785ac9cd4b097758fa5df17 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-Add-prips.patch Content-Disposition: attachment; filename=0001-gnu-Add-prips.patch; size=2394 RnJvbSA4NWNmN2I5ZDIyODAxZDliM2JhYzg5NTZiMzU4ZmNlNGMzMmRjYjRjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtZXRodXNlbGFoLTAgPGRhdmlkLmxhcnNzb25Ac2VsZmhvc3Rl ZC54eXo+CkRhdGU6IFRodSwgOCBBcHIgMjAyMSAyMToyNjoyMyArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIGdudTogQWRkIHByaXBzLgoKZ251L3BhY2thZ2VzL2FkbWluLnNjbSAocHJpcHMpOiBOZXcg dmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2FkbWluLnNjbSB8IDM0ICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspCgpk aWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2FkbWluLnNjbSBiL2dudS9wYWNrYWdlcy9hZG1pbi5z Y20KaW5kZXggZGY3OTczMzk1ZC4uMTVhYzg4NDFjNiAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2Vz L2FkbWluLnNjbQorKysgYi9nbnUvcGFja2FnZXMvYWRtaW4uc2NtCkBAIC0zOSw2ICszOSw3IEBA CiA7OzsgQ29weXJpZ2h0IMKpIDIwMjEgU3RlZmFuIFJlaWNow7ZyIDxzdGVmYW5AeHN0ZXZlLmF0 PgogOzs7IENvcHlyaWdodCDCqSAyMDIxIHFibGFkZSA8cWJsYWRlQHByb3Rvbm1haWwuY29tPgog Ozs7IENvcHlyaWdodCDCqSAyMDIxIEh5dW5zZW9rIEtpbSA8bGFzbmVzbmVAbGFndW5wb3NwcmFz aWhvcHJlLm9yZz4KKzs7OyBDb3B5cmlnaHQgwqkgMjAyMSBEYXZpZCBMYXJzc29uIDxkYXZpZC5s YXJzc29uQHNlbGZob3N0ZWQueHl6PgogOzs7CiA7OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05V IEd1aXguCiA7OzsKQEAgLTEwMTksNiArMTAyMCwzOSBAQCByZWN1cnNpdmUgcnVucyBvbiB0aGUg Z2VuZXJhdGVkIHN1Ym5ldHMuICAoYWxzbyBJUHY2KQogQGVuZCBpdGVtaXplXG4iKQogICAgIChs aWNlbnNlIGxpY2Vuc2U6YnNkLTMpKSkKIAorKGRlZmluZS1wdWJsaWMgcHJpcHMKKyAgKHBhY2th Z2UKKyAgICAobmFtZSAicHJpcHMiKQorICAgICh2ZXJzaW9uICIxLjEuMSIpCisgICAgKHNvdXJj ZQorICAgICAob3JpZ2luCisgICAgICAgKG1ldGhvZCB1cmwtZmV0Y2gpCisgICAgICAgKHVyaSAo c3RyaW5nLWFwcGVuZCAiaHR0cHM6Ly9kZXZlbC5yaW5nbGV0Lm5ldC9maWxlcy9zeXMvIgorICAg ICAgICAgICAgICAgICAgICAgICAgICAgbmFtZSAiLyIgbmFtZSAiLSIgdmVyc2lvbiAiLnRhci54 eiIpKQorICAgICAgIChzaGEyNTYKKyAgICAgICAgKGJhc2UzMiAiMWEzM3ZibDR3NjAzbWs2bW01 cjN2aGs4N2Z5M2RmazV3ZHBjaDB5ZDNuY2JrZzNmbXZxbiIpKSkpCisgICAgKGJ1aWxkLXN5c3Rl bSBnbnUtYnVpbGQtc3lzdGVtKQorICAgIChhcmd1bWVudHMKKyAgICAgYCgjOm1ha2UtZmxhZ3Mg KGxpc3QgKHN0cmluZy1hcHBlbmQgIkNDPSIgLChjYy1mb3ItdGFyZ2V0KSkpCisgICAgICAgIzp0 ZXN0LXRhcmdldCAidGVzdCIKKyAgICAgICAjOnBoYXNlcyAobW9kaWZ5LXBoYXNlcyAlc3RhbmRh cmQtcGhhc2VzCisgICAgICAgICAgICAgICAgICAoZGVsZXRlICdjb25maWd1cmUpCisgICAgICAg ICAgICAgICAgICAocmVwbGFjZSAnaW5zdGFsbAorICAgICAgICAgICAgICAgICAgICAobGFtYmRh IF8KKyAgICAgICAgICAgICAgICAgICAgICAobGV0KgorICAgICAgICAgICAgICAgICAgICAgICAg ICAoKGJpbi1kaXIgIChzdHJpbmctYXBwZW5kICVvdXRwdXQgIi9iaW4iKSkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgIChiaW4tZmlsZSAoc3RyaW5nLWFwcGVuZCBiaW4tZGlyICIvcHJpcHMi KSkpCisgICAgICAgICAgICAgICAgICAgICAgICAobWtkaXItcCBiaW4tZGlyKQorICAgICAgICAg ICAgICAgICAgICAgICAgKGNvcHktZmlsZSAicHJpcHMiIGJpbi1maWxlKQorICAgICAgICAgICAg ICAgICAgICAgICAgKGNobW9kIGJpbi1maWxlICNvNjAwKSkpKSkpKQorICAgIChuYXRpdmUtaW5w dXRzIGAoKCJwZXJsLXRlc3QtaGFybmVzcyIgLHBlcmwtdGVzdC1oYXJuZXNzKSkpCisgICAgKHN5 bm9wc2lzICJUb29sIHRoYXQgcHJpbnRzIHRoZSBJUCBhZGRyZXNzZXMgaW4gYSBnaXZlbiByYW5n ZSIpCisgICAgKGRlc2NyaXB0aW9uICJQcmlwcyBjYW4gYmUgdXNlZCB0byBwcmludCBhbGwgb2Yg dGhlIElQIGFkZHJlc3NlcyBpbgorIGEgZ2l2ZW4gcmFuZ2UuICBUaGlzIGFsbG93cyB0aGUgZW5o YW5jZW1lbnQgb2YgdG9vbHMgb25seSB3b3JrCisgb24gb25lIGhvc3QgYXQgYSB0aW1lIChlLmcu IHdob2lzKS4iKQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vZGV2ZWwucmluZ2xldC5uZXQvc3lz dXRpbHMvcHJpcHMvIikKKyAgICAobGljZW5zZSBsaWNlbnNlOmdwbDIrKSkpCisKIChkZWZpbmUt cHVibGljIGFsaXZlCiAgIChwYWNrYWdlCiAgICAgKG5hbWUgImFsaXZlIikKLS0gCjIuMzAuMgoK --=_67ccf9bf7785ac9cd4b097758fa5df17-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 12 06:47:52 2021 Received: (at 47540-done) by debbugs.gnu.org; 12 Apr 2021 10:47:52 +0000 Received: from localhost ([127.0.0.1]:56610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVu6i-00011B-Dx for submit@debbugs.gnu.org; Mon, 12 Apr 2021 06:47:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVu6g-00010x-Ga for 47540-done@debbugs.gnu.org; Mon, 12 Apr 2021 06:47:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51559) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVu6Z-0001Jh-DC; Mon, 12 Apr 2021 06:47:43 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47860 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lVu6Y-0005zE-Tb; Mon, 12 Apr 2021 06:47:43 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: david larsson Subject: Re: bug#47540: [PATCH] gnu: Add prips. References: <94325c646a58888160ed6548dc5f646629e8374d.camel@telenet.be> <04a8eb1efe98cd5ada24e870b39a3671@selfhosted.xyz> <96ad7a4cc63b104b2cc5eac5997b6ac2854fe101.camel@telenet.be> <444cc65de656858b59e577dce74009bb@selfhosted.xyz> Date: Mon, 12 Apr 2021 12:47:41 +0200 In-Reply-To: <444cc65de656858b59e577dce74009bb@selfhosted.xyz> (david larsson's message of "Thu, 08 Apr 2021 21:28:59 +0200") Message-ID: <87h7kbrd82.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, david larsson skribis: > From 85cf7b9d22801d9b3bac8956b358fce4c32dcb4c Mon Sep 17 00:00:00 2001 > From: methuselah-0 > Date: Thu, 8 Apr 2021 21:26:23 +0200 > Subject: [PATCH] gnu: Add prips. > [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: selfhosted.xyz (xyz)] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [209.51.188.92 listed in list.dnswl.org] X-Debbugs-Envelope-To: 47540-done Cc: 47540-done@debbugs.gnu.org, Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, david larsson skribis: > From 85cf7b9d22801d9b3bac8956b358fce4c32dcb4c Mon Sep 17 00:00:00 2001 > From: methuselah-0 > Date: Thu, 8 Apr 2021 21:26:23 +0200 > Subject: [PATCH] gnu: Add prips. > > gnu/packages/admin.scm (prips): New variable. [...] > + (replace 'install > + (lambda _ > + (let* > + ((bin-dir (string-append %output "/bin")) > + (bin-file (string-append bin-dir "/prips"))) > + (mkdir-p bin-dir) > + (copy-file "prips" bin-file) > + (chmod bin-file #o600))))))) That installed a non-executable file. I fixed this with the patch below, which also make the style more consistent. Thanks David, and thanks Maxime for the review! Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index f3e8774b75..512ac320e6 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -1070,13 +1070,10 @@ recursive runs on the generated subnets. (also IPv6) #:phases (modify-phases %standard-phases (delete 'configure) (replace 'install - (lambda _ - (let* - ((bin-dir (string-append %output "/bin")) - (bin-file (string-append bin-dir "/prips"))) - (mkdir-p bin-dir) - (copy-file "prips" bin-file) - (chmod bin-file #o600))))))) + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (install-file "prips" + (string-append out "/bin")))))))) (native-inputs `(("perl-test-harness" ,perl-test-harness))) (synopsis "Tool that prints the IP addresses in a given range") (description "Prips can be used to print all of the IP addresses in --=-=-=-- From unknown Fri Jun 20 07:28:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 10 May 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator