GNU bug report logs - #47501
[PATCH] Do not search the global keymap in project--keymap-prompt

Previous Next

Package: emacs;

Reported by: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>

Date: Tue, 30 Mar 2021 17:03:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Do not search the global keymap in project--keymap-prompt
Date: Tue, 30 Mar 2021 19:02:34 +0200
[Message part 1 (text/plain, inline)]
Hi,

project--keymap-prompt searches project-prefix-map *plus* the global
keymap when constructing the prompt for project-switch-command.  This
can result in weird behavior; for example,

    (global-set-key (kbd "M-s r") 'rgrep)
    (require 'project)
    (define-key project-prefix-map (kbd "<f5>") 'rgrep)
    (push '(rgrep "rgrep") project-switch-commands)

might (or will?) cause project-switch-project to display "[M-s r] rgrep"
instead of the expected "[<f5>] rgrep".

The attached patch fixes the issue as per the documentation of
`where-is-internal'.

Best regards,
Dario

[0001-Do-not-search-the-global-keymap-in-project-keymap-pr.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
-- 
$ keyserver=hkps://hkps.pool.sks-keyservers.net
$ keyid=744A4F0B4F1C9371
$ gpg --keyserver $keyserver --search-keys $keyid

This bug report was last modified 4 years and 44 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.