From unknown Fri Jun 20 07:12:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#47488 <47488@debbugs.gnu.org> To: bug#47488 <47488@debbugs.gnu.org> Subject: Status: Treatment of # in js.el Reply-To: bug#47488 <47488@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:12:56 +0000 retitle 47488 Treatment of # in js.el reassign 47488 emacs submitter 47488 Reuben Thomas severity 47488 minor tag 47488 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 29 17:28:51 2021 Received: (at submit) by debbugs.gnu.org; 29 Mar 2021 21:28:51 +0000 Received: from localhost ([127.0.0.1]:49763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQzRK-0006Yq-QE for submit@debbugs.gnu.org; Mon, 29 Mar 2021 17:28:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:46636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQzRI-0006Yi-87 for submit@debbugs.gnu.org; Mon, 29 Mar 2021 17:28:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQzRI-0003kg-15 for bug-gnu-emacs@gnu.org; Mon, 29 Mar 2021 17:28:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52405) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQzRH-00040H-Qt for bug-gnu-emacs@gnu.org; Mon, 29 Mar 2021 17:28:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59438) by fencepost.gnu.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lQzRG-0005Um-NR for bug-emacs@gnu.org; Mon, 29 Mar 2021 17:28:47 -0400 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]:39915) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQzRC-0003x7-Of for bug-emacs@gnu.org; Mon, 29 Mar 2021 17:28:46 -0400 Received: by mail-oi1-x233.google.com with SMTP id i81so14443103oif.6 for ; Mon, 29 Mar 2021 14:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=ktGZElXPQJ4e3ZiyH6x6y6felPsSmax9pW/E1yibK1U=; b=Z5EpqUXsrGGc+7b/ux/Yd7L1fNjtLrqssHeDc4U4yg0jWLq+sblSArvNqPpmw2k4q+ PsREnbwSKWaa0y67T6BdQkapZv3U1I4YxDv7DnInYk85qX09a7R4CLGk74NPYKTp+FNn QICOK21WhgO1FYW8g4JXj0dbjjejvV4N0jr+A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ktGZElXPQJ4e3ZiyH6x6y6felPsSmax9pW/E1yibK1U=; b=Ml04qZ7KYdcKjEw6/iqDU+aAWLLN+DQ5nHtMr3RkNSmFpx05z5IyQlv8GBuJxPdbWN 21KgouCYQAl71Za/FZUxHhdqszbuLYQB9tkFprj0jwQuUlJWMYh1tCKauWLBVU0O0jRY 91brK8PBBymvljluXjK46kP4G0FojA/48IFotFwVu4SWZgco8hZebNbPuCoFjXpR52S/ rhT61hey4aQxLEeoiJRVtqs1s/YTi7+f4bxIoBTkjI+bLxhVqGOrAa2pfc16M0yK+WkO daLDcNzrUZQghUtYmcMmlytfdMDlk56God+TEeCCMlqyD8Dvv+hKDEARE2BqS00Jmwzr aFEQ== X-Gm-Message-State: AOAM532nGqz+yoQ0fqa1fcmZ7DguOlDU3S50bhqd/DMewdRq9KQMGOOL p212ahGTSBuHxgfSO5DA55duyHMsUShV6HQiIMMa5qZZ8p0Iqw== X-Google-Smtp-Source: ABdhPJz2wKEI6Z1F4+wdL0FGkiAU8qdtj6gjN2I8xldObYt+MrGpxGw4Ib9LlmD0mOYAlSUJGkB++PDbwRNKgKq6o2E= X-Received: by 2002:aca:f245:: with SMTP id q66mr784980oih.179.1617053320827; Mon, 29 Mar 2021 14:28:40 -0700 (PDT) MIME-Version: 1.0 From: Reuben Thomas Date: Mon, 29 Mar 2021 21:28:29 +0000 Message-ID: Subject: Treatment of # in js.el To: bug-emacs Content-Type: multipart/alternative; boundary="000000000000c56d6d05beb39025" Received-SPF: pass client-ip=2607:f8b0:4864:20::233; envelope-from=rrt@sc3d.org; helo=mail-oi1-x233.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --000000000000c56d6d05beb39025 Content-Type: text/plain; charset="UTF-8" I started using private class fields, as described here (a stage 3 proposal that is widely implemented, though not actually standardized yet AFAICT). These are normal fields that start with a hash. I find in js--proper-indentation the line (annotated by git blame): 17b5d0f7077 (Chong Yidong 2009-08-14 2864) ((eq (char-after) ?#) 0) It sets the indentation for a line starting with # unconditionally to 0. I cannot find any other use of # in JavaScript that would justify treating lines starting with # apparently like C preprocessor macros. There is other related code, and it all seems to go back to when js.el was first installed in Emacs. Is this just because the code was originally based on cc-mode or something, and the references to hash were never removed? Or was cpp used with early JavaScript?? I see references such as js--opt-cpp-start which says "Regexp matching the prefix of a cpp directive", and a match for "#define" in js--update-quick-match-re. I cannot see any code in js-tests.el that tests this cpp-related functionality. Is there some reason to keep the cpp-related code in js.el? I presume removing it would simplify then adding support for private class fields; indeed, maybe no particular support is needed if cpp support is first removed. -- https://rrt.sc3d.org --000000000000c56d6d05beb39025 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I started using private class fields, a= s described here (a stage 3 proposal th= at is widely implemented, though not actually standardized yet AFAICT).

These are normal fields t= hat start with a hash.

I find in js--proper-indentation the line (annotated by git blame):
<= div class=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-serif= ;font-size:small">
17b5d0f7077 (Chong Yidong = =C2=A0 =C2=A0 =C2=A0 =C2=A0 2009-08-14 2864) =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 ((eq (char-after) ?#) 0)

It sets the indentation for a line starting with # unconditionall= y to 0. I cannot find any other use of # in JavaScript that would justify t= reating lines starting with # apparently like C preprocessor macros. There = is other related code, and it all seems to go back to when js.el was first = installed in Emacs.

Is= this just because the code was originally based on cc-mode or something, a= nd the references to hash were never removed? Or was cpp used with early Ja= vaScript?? I see references such as js--opt-cpp-start which says "Rege= xp matching the prefix of a cpp directive", and a match for "#def= ine" in js--update-quick-match-re.

I cannot see any code in js-tests.el that tests this cpp-relat= ed functionality.

Is t= here some reason to keep the cpp-related code in js.el? I presume removing = it would simplify then adding support for private class fields; indeed, may= be no particular support is needed if cpp support is first removed.

--
--000000000000c56d6d05beb39025-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 29 20:50:21 2021 Received: (at 47488) by debbugs.gnu.org; 30 Mar 2021 00:50:21 +0000 Received: from localhost ([127.0.0.1]:49881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lR2aL-0007FS-FM for submit@debbugs.gnu.org; Mon, 29 Mar 2021 20:50:21 -0400 Received: from mail-ej1-f51.google.com ([209.85.218.51]:46623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lR2aH-0007FA-OW for 47488@debbugs.gnu.org; Mon, 29 Mar 2021 20:50:20 -0400 Received: by mail-ej1-f51.google.com with SMTP id u21so22128970ejo.13 for <47488@debbugs.gnu.org>; Mon, 29 Mar 2021 17:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1TFRFGCDaMtHKm6MKbg8BNLNFpuJukMB/lkidx1x2H4=; b=OT4luyBiQXwHbg1mXBt2nyQT14IxaRxstYn2jbEjBy0EnM2lcho4JY6p+Ha6OzGxDm +pTiWncIrsX8QCj/ijjDdzmcPq3lV7GTBLRw+xo9WijrzUvLB5xDHP16MjMTlVa+83IV 5pSJGfwsm4/qFZquxY6L0aB4OKWzmGJeABRAklcTPAINSw9OQB1FCskKrFAevrkdFB/L Oo0j7fwgsz99544ltbAtHPj3dVDMZrE++/BDDI1Ma4JfOputRtouOp6xiN3SQmIiUFbp 2007+kGo7UXSlR/NwU37OrtiBcs2Y0XlN7tnANgMs8/X81OuCaV8NMUHQqyrr3hokaBg oSMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1TFRFGCDaMtHKm6MKbg8BNLNFpuJukMB/lkidx1x2H4=; b=klcjkmGghwfxwH1hiG9e+uDj6mvpdJQfPljzIRSXuPljAO1AFpW0v7AUvUeGi1uP/D v2Hi/5WEHeAjSQvvTumTPo64E+qqhfbiV2wBURoXWL8xECyaYJPYAkFWJ0DPEB1Kz+Cl iP/ypsjL6PisP1AUuO8lAdoGMsnWHuC/4mD1S+Ukg9hfRrK6CcAjgGEHYNURcemF8sEO DoQ4Mwgr71VdbTE4JrqgvzykAiTHbGY1yKEsvrQIQ5YYPavIUeBlt4EMS9TgaPUIYwKk /aNQZo9RYd/jOpOgOmJYsdc0ZAO4Jwggr1SdkVL7eIt0/tXIKpDZR1wiFJdud+uH1gCu 2jwA== X-Gm-Message-State: AOAM5309fd07FUxDJdZgCRKyvJSL0PxNLQIeFxB8rv9ZeBiF20/et2fb bAGMtib/addeJMtefoSNCUDG0NnFNSM= X-Google-Smtp-Source: ABdhPJyle49V0pxK38PYA1ZvOOcDzxgbJZHtQTQxPL9tKgrbTlVEN3TLsrai54YHmMRyWRzGl2YMEg== X-Received: by 2002:a17:906:a51:: with SMTP id x17mr31125559ejf.25.1617065411805; Mon, 29 Mar 2021 17:50:11 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id q26sm9117922eja.45.2021.03.29.17.50.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Mar 2021 17:50:11 -0700 (PDT) Subject: Re: bug#47488: Treatment of # in js.el To: Reuben Thomas , 47488@debbugs.gnu.org References: From: Dmitry Gutov Message-ID: Date: Tue, 30 Mar 2021 03:50:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 47488 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 30.03.2021 00:28, Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Is this just because the code was originally based on cc-mode or > something, and the references to hash were never removed? Or was cpp > used with early JavaScript?? I see references such as js--opt-cpp-start > which says "Regexp matching the prefix of a cpp directive", and a match > for "#define" in js--update-quick-match-re. IIRC this was related to the use of the C preprocessor in some JS codebases (Mozilla?). Not sure if that practice stopped. From debbugs-submit-bounces@debbugs.gnu.org Sat May 08 08:43:41 2021 Received: (at 47488) by debbugs.gnu.org; 8 May 2021 12:43:41 +0000 Received: from localhost ([127.0.0.1]:50077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfMJ3-00079M-9L for submit@debbugs.gnu.org; Sat, 08 May 2021 08:43:41 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfMJ1-00079E-5k for 47488@debbugs.gnu.org; Sat, 08 May 2021 08:43:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UD73tCf+nrxhqci6gM+1EgweWEVCCVJT4IqAwYKH4rM=; b=gQd/2U+Q655arIfM60l0jxCZaP +sYGp1WveUvBG2tu/DcOheY2ZEBbusw3pGl7Pynu94bdRvzOxCMLUaqcuIzWvhYL07HTdI2eo5mo8 5mRDtgxGVBwxZjDmxnYLpM4kKvTRUwWOBlrMU8DXgOu5vZkdKw2mESiVG3BSZnjVdET4=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfMIs-0004WO-MC; Sat, 08 May 2021 14:43:33 +0200 From: Lars Ingebrigtsen To: Reuben Thomas Subject: Re: bug#47488: Treatment of # in js.el References: X-Now-Playing: King Crimson's _In the Court of the Crimson King (1)_: "I Talk To The Wind (studio run through, 2019 mix)" Date: Sat, 08 May 2021 14:43:29 +0200 In-Reply-To: (Reuben Thomas's message of "Mon, 29 Mar 2021 21:28:29 +0000") Message-ID: <871rahqtu6.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Reuben Thomas writes: > I started using private class fields, as described here (a stage 3 proposal that is > widely implemented, though not actually standardized yet AFAICT). > > These are normal fields that start with a [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47488 Cc: 47488@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Reuben Thomas writes: > I started using private class fields, as described here (a stage 3 proposal that is > widely implemented, though not actually standardized yet AFAICT). > > These are normal fields that start with a hash. > > I find in js--proper-indentation the line (annotated by git blame): > > 17b5d0f7077 (Chong Yidong 2009-08-14 2864) ((eq (char-after) ?#) 0) Yeah, that doesn't seem correct for Javascript. I've just removed that line in Emacs 28, and that seems to fix the issue for me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat May 08 08:43:53 2021 Received: (at control) by debbugs.gnu.org; 8 May 2021 12:43:54 +0000 Received: from localhost ([127.0.0.1]:50081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfMJF-00079Y-HS for submit@debbugs.gnu.org; Sat, 08 May 2021 08:43:53 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfMJ5-00079G-LJ for control@debbugs.gnu.org; Sat, 08 May 2021 08:43:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=16TU1Q3JRI75AcD1VzVDG3Cfcv0LRMUuLuYNNIiyHb0=; b=pztonurQpvLtB8ZE0K6HB6uTSe iTitp+MG42/c5KSx9iK4U4MqK+GE81mFYDPgpER4wNZ9dfsB71e17sUCZoOsH7yF++SvF/c1V32yz 7RkqY96eQ1H+MymYMihhi7o+PSKgViRnqAnaMcc/QnZFyDsp5ouaj9qibFxQv89EhbMM=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfMIy-0004WW-3g for control@debbugs.gnu.org; Sat, 08 May 2021 14:43:38 +0200 Date: Sat, 08 May 2021 14:43:34 +0200 Message-Id: <87zgx5pf9l.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #47488 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 47488 fixed close 47488 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 47488 fixed close 47488 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun May 09 07:18:14 2021 Received: (at 47488) by debbugs.gnu.org; 9 May 2021 11:18:14 +0000 Received: from localhost ([127.0.0.1]:55360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfhRu-0002Gt-Ak for submit@debbugs.gnu.org; Sun, 09 May 2021 07:18:14 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:43856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfhRr-0002Gm-RM for 47488@debbugs.gnu.org; Sun, 09 May 2021 07:18:13 -0400 Received: by mail-wr1-f41.google.com with SMTP id s8so13671563wrw.10 for <47488@debbugs.gnu.org>; Sun, 09 May 2021 04:18:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bjaJD04UMVd3TJEoQA2/bxbYodRUOaklM98pzSsOyVw=; b=dXY7Xf6Ez+6DInzeeLA179SayICL5+Ifhut8PYw5RVSACxFnHxeOnN4CipkbAt26/0 3+ngxSdXHB3aOhr7/cHzY/8Ft9jDGtz2h0c8g0crsW/YstxLeDcasTnsHTwjvdXnEofO j2cLmmcMbW6j6W6ue+O1Xqr4RnHbFc8Eho/w8b7y6n8RwXe21wRw/vzdjAA7ol2141Kz 4p9cwMpAGz5FJ2trY25hGhD0Zc4E+xftA9a+5jZo3L/b4rUY0FFVFM9BwiaPS/QOzf5T KkTriLWrysqZwd+TVVADCkDLFkTOhNDHXEboJRETUkkWTLDepgc2gOqvYFrxjCC6Ft7i /Zog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bjaJD04UMVd3TJEoQA2/bxbYodRUOaklM98pzSsOyVw=; b=B6Y/nb1g6vZAx28vzosPUp2F+tyR2Z/m+yLAhwmka7kRrYWYpQQqjKRSSJI9mIIJ86 Ji0dozq2h0suOh09WfY/5l+MMCSbKO6wMA0u4ZoZWrOhTnvPWN3isTuGDGMo83CYr1uf SBxhvixAaAxLfETC5v9yHtEELx8dvCwPC1oc0yB4WQpWbBmajxCX1xk+WqfK2omaWbIg /ZSpBztlVTNhbBp/laCCP7Mz+/lBqoN7jIVtvLUHYZvZUWmrersrOwtzH1/5Nm9x9WGh aTKJDtwAhxY3jZOyfgWAZk0LpnfvnZIxknEL2UCYM8RMclRrIyHlNWpvIF/eKF5mZlFO u+dg== X-Gm-Message-State: AOAM530k3PD2s2Qapgh/Ui7hltugneIA2v2WjD+f4diNsWgZCnOWSP5m ZuSLkTxPNxYkMvriIFV1nmTmS4zosec= X-Google-Smtp-Source: ABdhPJxdX7FHDP6TmTO1tbzUDG9+Y0HlMtfTJOQXKYF08gUPTuwNcxo48tqtF409cm0bVcjlE9BkBw== X-Received: by 2002:adf:d215:: with SMTP id j21mr25098415wrh.251.1620559086009; Sun, 09 May 2021 04:18:06 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id c5sm17657301wrs.73.2021.05.09.04.18.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 May 2021 04:18:05 -0700 (PDT) Subject: Re: bug#47488: Treatment of # in js.el To: Lars Ingebrigtsen , Reuben Thomas References: <871rahqtu6.fsf@gnus.org> From: Dmitry Gutov Message-ID: <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> Date: Sun, 9 May 2021 14:18:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <871rahqtu6.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 47488 Cc: 47488@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 08.05.2021 15:43, Lars Ingebrigtsen wrote: > Yeah, that doesn't seem correct for Javascript. I've just removed that > line in Emacs 28, and that seems to fix the issue for me. I have just done a search, and there are still a fair number of lines like #ifdef XP_UNIX #ifndef XP_MACOSX #define UNIX_BUT_NOT_MAC #endif #endif ... #ifdef UNIX_BUT_NOT_MAC pref("general.autoScroll", false); #else pref("general.autoScroll", true); #endif in JS files in gecko-dev. (The above is from browser/app/profile/firefox.js). And they also have pieces like this.#m?.x; (mostly in test examples). So ideally we would support both. From debbugs-submit-bounces@debbugs.gnu.org Sun May 09 07:32:06 2021 Received: (at 47488) by debbugs.gnu.org; 9 May 2021 11:32:06 +0000 Received: from localhost ([127.0.0.1]:55370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfhfK-00048J-B0 for submit@debbugs.gnu.org; Sun, 09 May 2021 07:32:06 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:40770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfhfJ-00042n-2v for 47488@debbugs.gnu.org; Sun, 09 May 2021 07:32:05 -0400 Received: by mail-wm1-f50.google.com with SMTP id y124-20020a1c32820000b029010c93864955so9564329wmy.5 for <47488@debbugs.gnu.org>; Sun, 09 May 2021 04:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BADDi0IOgSxNVLQDXeH59s1R/czY0LywLZnMtcw0e0Y=; b=CavVral9rLO4fUosllp8sMOKtARZa75pO+ctS9A6HRSGN3vDhj5Wu9xn7Ko788BplS F4/dmgIhUsyOlsw0oR8PGxVA4GuLjmsMl4Xzx6u1pK0dpBBPA7+cuKvUdwSco+QaZPQH 4Gc2ueHCdLtLlOD6GK/LUiLO1aBfpOwPFpKHTUk6BPRsQS/iKkJi1wpQNDnqqF/snZ9P d3NAkbtc47GLKhUH5jxQfl15c2u1pU4DCWWHBs6w6Ccna85uY/zm/sFaJq9LSJFbe2VD DRZBizJOSq5ukLWvNTPgQcRxEcAy1DyA670V5yVtLTTVGVYGfs6c6ATnlhuErMorlTyc D/7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BADDi0IOgSxNVLQDXeH59s1R/czY0LywLZnMtcw0e0Y=; b=BV8anM7tP8v1sBRbTBFHyGKXiYy9HHljA9inXAobwhVDTBhweLkC8pgtjcRLZCrzkZ ncFDZHWty25Lco7jdPhj2TbxcdQL/rAMTA91nE+eQJqU8HfqEnsR3Jgn+l9c+OU1aNMY ynbfPHeYjqTnII/3oKx9R5foGttpwmpA5oYF0yDPA9pOLTuhIt8zKyt4Bhgs95jrQ4pF g8eGsMz6soW1mPU8kzuDA65rdkVOL087A0K4IjVn077h6xabcLLBvaxTM0EypVRYzs6e /Jf6kemsaE0LSuUeOzI1PfyCjxHDrf6STbHxt2vLIkfpZSDuzm2MCDCfljSHU2VoSrtr rfHg== X-Gm-Message-State: AOAM533LmS95Ru6i6a+peyMC6Mm78bK39Cn7/7ffmDZ+1pEdxT80Ikt2 GiWgtHKKnXS3LUXQB5KHjI28FmjeM/k= X-Google-Smtp-Source: ABdhPJyoaWTUl0uueyn5thmBIq7OTIgBHAFLfvI0sUlvP17hNyFNJ58HAra625vwGcPKALG5tlqCDg== X-Received: by 2002:a1c:7c03:: with SMTP id x3mr32154425wmc.168.1620559919264; Sun, 09 May 2021 04:31:59 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id c15sm17412891wrr.3.2021.05.09.04.31.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 May 2021 04:31:58 -0700 (PDT) Subject: Re: bug#47488: Treatment of # in js.el From: Dmitry Gutov To: Lars Ingebrigtsen , Reuben Thomas References: <871rahqtu6.fsf@gnus.org> <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> Message-ID: <13e28dc3-8fb0-dd81-df37-e4dadc852cfb@yandex.ru> Date: Sun, 9 May 2021 14:31:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 47488 Cc: 47488@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 09.05.2021 14:18, Dmitry Gutov wrote: > So ideally we would support both. Also see js--beginning-of-macro which is still called in js--proper-indentation. It is a part of the same feature. From debbugs-submit-bounces@debbugs.gnu.org Mon May 10 04:29:26 2021 Received: (at 47488) by debbugs.gnu.org; 10 May 2021 08:29:26 +0000 Received: from localhost ([127.0.0.1]:57339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lg1I6-0005Yl-2Y for submit@debbugs.gnu.org; Mon, 10 May 2021 04:29:26 -0400 Received: from quimby.gnus.org ([95.216.78.240]:60962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lg1I4-0005YY-5K for 47488@debbugs.gnu.org; Mon, 10 May 2021 04:29:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1wDKp7s0HPhJ4tkQ/DfbApxGwaP8yJVMKQP4T5Va838=; b=cEqddF3tZsXowG5NvOJwTpuPeN MbrZ8u4ltdTT9LSqGspU/Q8Z5TlIrwOq4BiYNY/dsxTviuja6NMSSw/gcXpDJZ8FHOrO2vGeAX1Pc aDVGwvC3Jo+NKvJ9Pn3x3r/SPCuMdqSuPgQFy7mlY5g3eDo1KX1kK9eKtdNgrN0nYFrM=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lg1Hu-0004u0-Vt; Mon, 10 May 2021 10:29:17 +0200 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#47488: Treatment of # in js.el References: <871rahqtu6.fsf@gnus.org> <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEVXbq5uktalelSq qLpSMCRALi////+1HfPUAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+UFCggcLhmyTq8AAAGXSURBVDjL dZJbjoMwDEXNTPtPxA6cdAGQLmAUOf8Vsve/lbHjQAttrUZQH1+/AgwBzvaTcyIYcph/5+mAYwMh BDswqCcYHyHnhQ45xj3V3RSjxo9hzCHMwV+XqIphznmaQp4nLTY7WrrCSni024he3MGLja3dAOFs qiBVXN9BU8C7YvLJv4HwESyfQcz5myKnb4oEV1GDw4zQFOL2MCHYUyPjEndgst1yijqgnG/2esmk 4HFy34R5MVCPxHKyKhKQHHKR1l4b4EovmovGPbqi8t+1ix7A1FKtBqhWrlsBMiDLqsVJ3/Vnfmam +go2q+wCAy2Vu5MwsYN7aaBbYuoCSSUuNod2rGUKcRfIHWMGsXItvdexa7hhxL5dk7TyBtZbMYUb u4ZVT5iwPMHWrh4kLBHqDsTGs4NiYL9ARVXslCNoQ7gfVwfs66quKchYGmBfSZtGGFHWDbjEGm1+ KaQAoWfgVqjgzQBrw+CdeF+YnKIpLE3tfmzPtYPq69BN4B6g/0Bs272ffVT7YLt/ffr7l9wvW0o6 gn9wV9K5EXjSaQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0wNS0xMFQwODoyODo0NiswMDowMFS6 VVMAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDUtMTBUMDg6Mjg6NDYrMDA6MDAl5+3vAAAAAElF TkSuQmCC X-Now-Playing: Laura Veirs's _Troubled by the Fire_: "Ohio Clouds" Date: Mon, 10 May 2021 10:29:14 +0200 In-Reply-To: <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> (Dmitry Gutov's message of "Sun, 9 May 2021 14:18:03 +0300") Message-ID: <87v97rc7qd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > So ideally we would support both. Hm, yes I guess so. But how? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47488 Cc: 47488@debbugs.gnu.org, Reuben Thomas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > So ideally we would support both. Hm, yes I guess so. But how? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon May 10 04:34:26 2021 Received: (at 47488) by debbugs.gnu.org; 10 May 2021 08:34:26 +0000 Received: from localhost ([127.0.0.1]:57352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lg1Mw-0005i3-Ez for submit@debbugs.gnu.org; Mon, 10 May 2021 04:34:26 -0400 Received: from mail-oi1-f173.google.com ([209.85.167.173]:46860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lg1Mr-0005hn-DJ for 47488@debbugs.gnu.org; Mon, 10 May 2021 04:34:25 -0400 Received: by mail-oi1-f173.google.com with SMTP id x15so1360420oic.13 for <47488@debbugs.gnu.org>; Mon, 10 May 2021 01:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CIfcoW7TTuel63xl2WosFK+T+134BrjgbAhHupOO2Ng=; b=uQnDAJ3iBDqjlzwQukZ6HiW49jlChLVUPR0fRBL3kcQLt+Q9ZMhbBDg71LwV5SJZwf KScp8uz3SoHMyLDci023xiuinDzCgE3ahA5CKa1jJ51w+aeHGQEpPvgzDZ2UW0cwrMaj uCx5wPwJstCbx5Q5b/DqKOow+kwHs7LisJcPI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CIfcoW7TTuel63xl2WosFK+T+134BrjgbAhHupOO2Ng=; b=OnB5zWQtK3TIyY+aylTPDACya9722/0I+zpmhWJFo2C2DAVEJrzevQ63BW+rdh+NHN CgDUlcuAcsZJUabu+fAEFY6gdoW8p9ESKTJaEpAHQDFBk9VsoRF/ds88nWzFhMP2S23n yBb3l89CssvxG/Zm1Uptb669c9XD4DghUmMBxaos+97hwBi3MO08b7ubTh+esS4aRc72 /pyHCERtJGIGj49sLvhmQdMUWsFp23idak/s0bJbECKjkst8PC49cRcMxILQBaFM+yb1 oO0qnl4mJzO946HUNjyNSZG89qceTcP0F2TdxF3n/z/SEr6nNx7E+kNw490lXuzBIooh yO8w== X-Gm-Message-State: AOAM533tG7FB7F3WFt8GDnGT9dZulWdA4L+bmdKgrDvj3OYrdidHesKd LuIVNPEbXCVf9t8/mQrnDv7OXgynY6yN/l4kqy5eJA== X-Google-Smtp-Source: ABdhPJymKR0zTAt3Cj/sl19JoPR1YL8luJCEeUZNujr5WJ0f7ws8xZRKD7UGKjLVAuedqplsGFBmdgfyu7mm7VF/9AU= X-Received: by 2002:aca:3389:: with SMTP id z131mr24808573oiz.11.1620635655742; Mon, 10 May 2021 01:34:15 -0700 (PDT) MIME-Version: 1.0 References: <871rahqtu6.fsf@gnus.org> <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> In-Reply-To: <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> From: Reuben Thomas Date: Mon, 10 May 2021 09:34:04 +0100 Message-ID: Subject: Re: bug#47488: Treatment of # in js.el To: Dmitry Gutov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 47488 Cc: Lars Ingebrigtsen , 47488@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, 9 May 2021 at 12:18, Dmitry Gutov wrote: > > So ideally we would support both. Thanks for doing the research, Dmitry! Sorry not to be more useful here, but one suggestion: I doubt there are many code bases that use the hash character in both senses, so if there were a solution that allowed both to be supported but not at the same time, that would already be a big improvement on the current situation. (My impression is that using cpp with JavaScript is very much a legacy technique.) -- https://rrt.sc3d.org From debbugs-submit-bounces@debbugs.gnu.org Mon May 10 08:12:39 2021 Received: (at 47488) by debbugs.gnu.org; 10 May 2021 12:12:39 +0000 Received: from localhost ([127.0.0.1]:57608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lg4m7-0005lj-KF for submit@debbugs.gnu.org; Mon, 10 May 2021 08:12:39 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:34770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lg4m6-0005lX-1F for 47488@debbugs.gnu.org; Mon, 10 May 2021 08:12:38 -0400 Received: by mail-wm1-f42.google.com with SMTP id u5-20020a7bc0450000b02901480e40338bso9566449wmc.1 for <47488@debbugs.gnu.org>; Mon, 10 May 2021 05:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=n45bM9frKZx4v/gYyqx994NGUl1lML0+50DeivwKmPY=; b=RBXfT+f2fSTehX3fYvgl8xUX41Dzwh4w4OaMUYweMlfgRybD9QMy6yxecoAPbxPtbq Zh5paogF2Wc8Uhb8S05ErcFtuI4I6j++00QbDAXmYq1tAhxe68h65Hl/a8A0LxeLXkvd jyt81E32ucjXnWUwq1md9AN36X06hL+nc4htsFOc0D6SWsYgHE0kP2pyYAYaUtUwSVDw hBP0nCvenG1MJAkior9xsRGk5VBy5CmCS2wRBRmpYbs5pWIy5Cr9EekYSli6PjC65auS 8egPeAXp5YK3paQF8JGQ7vEMYS+sBC9xJpiWhtkF/lTikCnLPBuVj7oBpMf4AfwVazP+ xkUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=n45bM9frKZx4v/gYyqx994NGUl1lML0+50DeivwKmPY=; b=hbmXvrSrdHzdM2cT/eqymbUhXowreDefzZ8VuR1MHAoT1pBAb09aeVR+A0/pKyD9HX 4UmjYUvC/BAGBVHCBKqideSa/1LCSSFxmxDpuWoFJB4Vl9nM/7IePXc8zGxDe9mfLd2M s/N3bG9mBqab+oruQhB4cJDf85CbArYRAeiymjt98U/0fx15+lC+uL/MX2mUNd5CSUxy z8ZhkwF1ZOF0Uo62sJUD9AssTEN0nlt7ERW9WTvzOT3BdnEN4ocHh0JIyShoIdiMbyfu 0LojGdL01dOqOGxURl9pcoBxtn/qQSgIYuPwxyV9AQoOkhpe29iM0mXKqHVmqE634dhy iLQw== X-Gm-Message-State: AOAM532Clqrev/lPSG7QWINQU2ED3N0BNgzdRP6AAijcyxZzyCz2dgbT rSgvLuIm6bsHcggiNywICTo= X-Google-Smtp-Source: ABdhPJwb+fGH0O20/zhc7AIN42E9b4+wglD4/4mwmGXliS35nP3xiZiu5yBUQN9rNqKCU1vHV3z1VA== X-Received: by 2002:a7b:c145:: with SMTP id z5mr25665941wmi.77.1620648752254; Mon, 10 May 2021 05:12:32 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id n123sm22075166wme.24.2021.05.10.05.12.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 05:12:31 -0700 (PDT) Subject: Re: bug#47488: Treatment of # in js.el To: Lars Ingebrigtsen References: <871rahqtu6.fsf@gnus.org> <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> <87v97rc7qd.fsf@gnus.org> From: Dmitry Gutov Message-ID: <01d660ba-9700-396c-2932-96547740d4d9@yandex.ru> Date: Mon, 10 May 2021 15:12:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87v97rc7qd.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 47488 Cc: 47488@debbugs.gnu.org, Reuben Thomas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 10.05.2021 11:29, Lars Ingebrigtsen wrote: > Hm, yes I guess so. But how? Maybe check against a specific list of preprocessor instructions, such as #define, #ifdef, etc. From debbugs-submit-bounces@debbugs.gnu.org Mon May 10 08:14:21 2021 Received: (at 47488) by debbugs.gnu.org; 10 May 2021 12:14:21 +0000 Received: from localhost ([127.0.0.1]:57612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lg4nk-0005od-Tv for submit@debbugs.gnu.org; Mon, 10 May 2021 08:14:21 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:38897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lg4nj-0005oP-Cf for 47488@debbugs.gnu.org; Mon, 10 May 2021 08:14:20 -0400 Received: by mail-wr1-f54.google.com with SMTP id l14so16386350wrx.5 for <47488@debbugs.gnu.org>; Mon, 10 May 2021 05:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rZIbUnl0/bhbEWrkmSSvflIO7mmmuvCKIlBKVxec1RQ=; b=pz3RJ4Ax1iKiTZGBJ2FxaQHIl2EWrDdl51uTtTgP6kYG5AxwU4uO5Mwh5HcAKnxGpg kKu3jlA5AW80IRj6BcQXmwVvM6GhKNzErP3XoKtYUAyoXdm0Xm0/r/VZknXiUEc2YHhu EW5wsTVLu8bOik8BqJYLaA4usMAAXTd6bA8qECdJI2R3AX2b3qnf9VJKKYk/dPuY81TF MNoBlcda5t7Xqfrh9ECiuN9bqD0qZVdPklpqKnKone+W71pNia7lUPYZuBYB5ZYjacgM OEqurGk7Cz8B97pgFNQg4NXBKDvBFjMODW9lPrml+fh9asYCNI/3Wy7CdrUTFRrlLQcd YC2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rZIbUnl0/bhbEWrkmSSvflIO7mmmuvCKIlBKVxec1RQ=; b=OXsgLZyIZrm8pOXU6RGGEFJr2D3ALy4io3JVP/vz9zOFdVl2UcqFrMFKBukCLipcjC 2/Q919c+1V2A3xQGeRhmkOIUWvtjcY92BLimQPTUaGd6w5+5OW2kxJx7j2dw4jK9DFRQ D3tosU+rFBAeteOHT7Z5C65q41f6EJfbC11f/nKwa3w/eiKZ1NGBuHoFYbOgvo63s57J S8DK73+KXEKyvlm5kdvdI/uEv9qiBMWdirXQz7RoWisthKPiPkG1q1wQfEmxOZYPabBo r5WRqX/oaRNS5ABa6PbwcNbSNw6HDgAaIqcqZ+gzxs7qcwuBsqCxoccchCOnSZYi2ypf G9oA== X-Gm-Message-State: AOAM530er6xxmCMFXavEdWGHaBT1Caxz/T8TgPLevwHF7VOB+VSCH1Un NTqa1vEsgyGRQdmJ/+NwQbXNQ4AE5qA= X-Google-Smtp-Source: ABdhPJxBMUu15HHO/0+GPB3NjLiaFk5pYudFTKi4k0BaB6Ru25heEmmf9CN4v5fgFN/4EP/1RRmN4A== X-Received: by 2002:a5d:4e0b:: with SMTP id p11mr29885463wrt.220.1620648853648; Mon, 10 May 2021 05:14:13 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id r2sm23634857wrv.39.2021.05.10.05.14.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 05:14:13 -0700 (PDT) Subject: Re: bug#47488: Treatment of # in js.el To: Reuben Thomas References: <871rahqtu6.fsf@gnus.org> <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> From: Dmitry Gutov Message-ID: Date: Mon, 10 May 2021 15:14:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 47488 Cc: Lars Ingebrigtsen , 47488@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 10.05.2021 11:34, Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Sorry not to be more useful here, but one suggestion: I doubt there > are many code bases that use the hash character in both senses, so if > there were a solution that allowed both to be supported but not at the > same time, that would already be a big improvement on the current > situation. (My impression is that using cpp with JavaScript is very > much a legacy technique.) Well, Mozilla codebase is the one that does both (and I doubt there are many other examples of using C preprocessor in JS). We could add a custom var that disables this behavior, of course. js2-mode has one, but it only affects the parser, not the indentation behavior. From debbugs-submit-bounces@debbugs.gnu.org Tue May 11 08:21:57 2021 Received: (at 47488) by debbugs.gnu.org; 11 May 2021 12:21:57 +0000 Received: from localhost ([127.0.0.1]:35249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgROf-0004eY-6k for submit@debbugs.gnu.org; Tue, 11 May 2021 08:21:57 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgROd-0004e5-BJ for 47488@debbugs.gnu.org; Tue, 11 May 2021 08:21:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RqIUtsrA5t824OQ8pR1J9b1a2dDZ0LLCnlXtolvQyS4=; b=W3gIj6Z+anQpZScpYCVnBecF5N HbJKay5W1xDxjjGdjECtWj1IADhsKjCrTUm3auwp4Dq1imn7aNhq1UHFMYc1MDA2jZLO1omLndW3a 0a6i/dL4UF+/lOF/VIZLu532z4v6dxB60XBZxY/80F4EczcA8DAmAcB32NjtPsqHA6/A=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgROU-0004Zb-65; Tue, 11 May 2021 14:21:48 +0200 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#47488: Treatment of # in js.el References: <871rahqtu6.fsf@gnus.org> <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEUxKihGNCpVRS9k NSVhVURsUC2KYSowOkd7ZTwwQVOMdU6niU7///8670f3AAAAAWJLR0QMgbNRYwAAAAd0SU1FB+UF CwwCOfGVOw4AAAGrSURBVDjLdVOxTsMwED27ChHbnUOYY4uUiomqYgfEBySh6cDGEMSYDbFWdGFC CKniT/g8zkna2C6c2lrJe3f37p0LMIRAIMEnH0bh8DLjZ34pRPdkFIxBzEHOEJbrAbsfm0kOwEwE ednVOrkhHJGuRNGTCBzARl32ALfygdUAQK9hjDSDIHoOyT2vdQGifQGn0uSeiHqKFxg1RNgR3b6C SDW7iYU7Nzcu9764Srkt9cfgwb5WVKSICHnNm/AslFYrospXmZfBUjV3zaiq/VpMJqtNNpkPsM8C WadqEP3maIcjTE0RmMh0+0k3IWALS1PKMlid1YXRU8klQyDSGG3m886P1gWUwaPHZHEIsNapZoD9 iF0g5ouRJ4sr4ksYe4ti1jRbJDbjxWvO+aeaBI8Zb31l3y1vly9uvG19T+ItD5NwIb+SEPk5QJIA fpjljQfJqgWaAHzVd9eBX7H9bxx/hp5IiDUq/dqGV07O8rVOK6N1mPJgjJbV7PYAEN1XnXVTBO6n euzoplRv7wX+AcDz8uKnGBbqAYpoPSRnwa6cPXhGHqgZaQT/hOPHLysFLiUgmIu1AAAAJXRFWHRk YXRlOmNyZWF0ZQAyMDIxLTA1LTExVDEyOjAyOjU3KzAwOjAweBFhsAAAACV0RVh0ZGF0ZTptb2Rp ZnkAMjAyMS0wNS0xMVQxMjowMjo1NyswMDowMAlM2QwAAAAASUVORK5CYII= X-Now-Playing: Coil's _Love's Secret Domain (1)_: "Dark River" Date: Tue, 11 May 2021 14:21:45 +0200 In-Reply-To: (Dmitry Gutov's message of "Mon, 10 May 2021 15:14:11 +0300") Message-ID: <87lf8lpijq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: > We could add a custom var that disables this behavior, of > course. js2-mode has one, but it only affects the parser, not the > indentation behavior. If we could avoid having a user option, that's be nice... Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47488 Cc: 47488@debbugs.gnu.org, Reuben Thomas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > We could add a custom var that disables this behavior, of > course. js2-mode has one, but it only affects the parser, not the > indentation behavior. If we could avoid having a user option, that's be nice... > Maybe check against a specific list of preprocessor instructions, such > as #define, #ifdef, etc. I think that sounds like a good solution. Grepping around a bit, perhaps `cpp-font-lock-keywords-source-directives' in font-lock.el would be a good source to use here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Jun 20 07:12:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug No longer marked as fixed in versions 28.1 and reopened. Date: Tue, 11 May 2021 12:23:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug No longer marked as fixed in versions 28.1 and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Tue May 11 08:22:05 2021 Received: (at control) by debbugs.gnu.org; 11 May 2021 12:22:05 +0000 Received: from localhost ([127.0.0.1]:35254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgROn-0004fP-F7 for submit@debbugs.gnu.org; Tue, 11 May 2021 08:22:05 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgROl-0004eh-Tu for control@debbugs.gnu.org; Tue, 11 May 2021 08:22:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jI7Nh6lEDbJYGjcwQsKhgU3UvWEJhKhwD7tc5POPdXA=; b=sgvfnAQMQZuUUzhB2S/UwoeGW1 pJE7i8MUkjylKrIQk0Ig9CkuGBr9avHF8dmBIfwz81Kn5oU5LBTie2lyvJdN0+s0+XzB8Oht9YU0+ wsDp7RiDmofdEjy+Ns1l7rOClUCI/uBOmB3g0AxObKljehTDd3L7AwoCMFF2fojpaAEY=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgROe-0004Zt-Gq for control@debbugs.gnu.org; Tue, 11 May 2021 14:21:58 +0200 Date: Tue, 11 May 2021 14:21:56 +0200 Message-Id: <87k0o5pijf.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #47488 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: reopen 47488 tags 47488 - fixed patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) reopen 47488 tags 47488 - fixed patch quit From debbugs-submit-bounces@debbugs.gnu.org Tue May 11 08:45:24 2021 Received: (at 47488) by debbugs.gnu.org; 11 May 2021 12:45:24 +0000 Received: from localhost ([127.0.0.1]:35290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgRlM-0007ns-B6 for submit@debbugs.gnu.org; Tue, 11 May 2021 08:45:24 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:35493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgRlK-0007gl-Hc for 47488@debbugs.gnu.org; Tue, 11 May 2021 08:45:23 -0400 Received: by mail-wm1-f54.google.com with SMTP id j3-20020a05600c4843b02901484662c4ebso1158540wmo.0 for <47488@debbugs.gnu.org>; Tue, 11 May 2021 05:45:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zyJuCYPb/dGowyKsoZNcQbR8GvE5HFJD4yEwbF4jtgI=; b=qgXUuRd5bO7p/ZaxMOMcoteigmR8IiTv/6DI72AE+wpWvc3QM+pXrq9hrd6BFN5EZy +g9aSUxbD7iLmc8GRaBG7skyHKVkrTrIzOJY49pdC+ZaJOFeqX3o8rdtXQpxa7tKGlFQ lljF8c6UiUWJrghjh/wLPf0Zuc1qXNJ9tKkVSlTg9MSRziqhPKeBL0HNWtO10od5dESS 9YzYp0tDcN5jCl2k8yUtSJ4nGqEy1danzXip4LFMjYAHvsnAAvLfDN/+N5fksyG8LFzG W8x+L55sO88EIGh1lTWdA/6GhA8ymMqBAjNebu08xG9D8i4jfGipWUfm1KNel+cKCOMS Rz6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zyJuCYPb/dGowyKsoZNcQbR8GvE5HFJD4yEwbF4jtgI=; b=dgfRsGnL2TM6/Ge7oOsmI56hflB+de45tYBmS9m0Hpa5ZwceKGknyAZGob5dA11Y6K qQ9Ztn3KZVL/PEOu0DfqvqL/4YYqDLMyVpG7OTKe8MMu3B76VDhX+wF2NdSwVYLIh0jT E73EWI/d97GCz05iDrZrQ17rM2phfD/Eu9tpEKDUM89H4GIf8HaJZhEGDWwX3AN3uA/I RjyMzNr+W4Tzts0J/kJZWJfZNebBq/SOOV5z4rZkRxvkLc4l/fJl83IQWv9zqahYSrKG C9kKDRD8CNEajRsPYRdkfISp85HzqKB67OluktLljnsoVacAQLdz9qCkws7k21WOn2S8 ZbTw== X-Gm-Message-State: AOAM531SY7RbPA62zMl9RiYK5vgknaJxFF/tGfRMPEOz9P9xPEH+vB2f iFuRmSJtf3/+5k/w6JXZr7KF7xWRAw4= X-Google-Smtp-Source: ABdhPJz5/sPS1e0G33AcdOnLueRnuYdP3xTJEYUX99oWBfUF2d5m0HhRUoKVgpXYhyXNBbtBUiU0lg== X-Received: by 2002:a7b:c4cf:: with SMTP id g15mr32510710wmk.163.1620737116601; Tue, 11 May 2021 05:45:16 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id q10sm23621962wmc.31.2021.05.11.05.45.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 May 2021 05:45:15 -0700 (PDT) Subject: Re: bug#47488: Treatment of # in js.el To: Lars Ingebrigtsen References: <871rahqtu6.fsf@gnus.org> <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> <87lf8lpijq.fsf@gnus.org> From: Dmitry Gutov Message-ID: Date: Tue, 11 May 2021 15:45:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87lf8lpijq.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 47488 Cc: 47488@debbugs.gnu.org, Reuben Thomas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 11.05.2021 15:21, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> We could add a custom var that disables this behavior, of >> course. js2-mode has one, but it only affects the parser, not the >> indentation behavior. > > If we could avoid having a user option, that's be nice... Probably not without seeing an occasional false positive, e.g. ... >> Maybe check against a specific list of preprocessor instructions, such >> as #define, #ifdef, etc. > > I think that sounds like a good solution. Grepping around a bit, > perhaps `cpp-font-lock-keywords-source-directives' in font-lock.el would > be a good source to use here? ... looking at the regexp it also matches #file, #line or #warning. Each of these could also be a name of a private attribute, I think. Still, if those are indeed standard preprocessor directives, this var looks like a good choice. From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 09:32:12 2021 Received: (at 47488) by debbugs.gnu.org; 12 May 2021 13:32:12 +0000 Received: from localhost ([127.0.0.1]:38456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgoyC-0005vi-Ik for submit@debbugs.gnu.org; Wed, 12 May 2021 09:32:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgoyA-0005vQ-GK for 47488@debbugs.gnu.org; Wed, 12 May 2021 09:32:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vL/CKJk1BdQb9KCwFi8XD/SHjVutbuybkqtt23D6cZA=; b=gSeYYqcJgSRzYnCvLBvTq0qjD0 GaJBgVQED3e3NRFtpbjWcSXK/7lIkzb6hg4pWAQN8XyLe98H+f5+UcboTuPyBdocQW2BaT1vCoTpK h4iIzNn4dIosLWwdrNIRl9+MNholyN4owCY/PyeaZMvfeiP56UWbY7Wxk0mIT7jo0398=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgoy1-0004s9-Tj; Wed, 12 May 2021 15:32:04 +0200 From: Lars Ingebrigtsen To: Dmitry Gutov Subject: Re: bug#47488: Treatment of # in js.el References: <871rahqtu6.fsf@gnus.org> <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> <87lf8lpijq.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEUpIyRXQkK2jXT/ //8moIRuAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UFDA0PHwojkjAAAAFjSURBVCjPTZK9bsIwEMfv IjsSmRgCKp7pkDxFItXMobIReGJIJeqnoEN3OlAVJiolFfgpe3bChxffz3f3vw8ZgE5cwf2gh6Kz OTyCv7EH/4iohx3QxfXqRFYaYKSUJph6wBXAgGCtfcrOiwLUuuqE/EM9ZGRRpcSDl8A9sI0XmKRU SBwWay+dKQritvV56Uj5QK0CxBW79Z/y4g6UIR7But01DKB17g7auO1tGCNX22AAA1y4w6lbAqcp rWuuO+DSmDP2EgwH8c+tB2nK9rZQNPoOIPimz3+TcsLyUw/maJe26YKUMPbs6s5TRbPjMn+/wsde ib7vSbTLVPJd+F2jwF3+lMw+3Z6IQDSxa7Ulz1he4gAUF5UzF53HF+tIEBlqPCEBCUasKpkCGwDZ fF9MILM6ePBLjeCZFOivMJi/8EIHSGT7exBFG0DIv9Zl0DjfQa5eG5fi2ToaPa9xOuMl1Wn/AQ24 Y7feUWh8AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA1LTEyVDEzOjE1OjMwKzAwOjAwrNX/dwAA ACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNS0xMlQxMzoxNTozMCswMDowMN2IR8sAAAAASUVORK5C YII= X-Now-Playing: Neil Young & Stray Gators's _Archives Vol. II (1): Everybody's Alone (1972 - 1976)_: "Yonder Stands the Sinner" Date: Wed, 12 May 2021 15:32:01 +0200 In-Reply-To: (Dmitry Gutov's message of "Tue, 11 May 2021 15:45:13 +0300") Message-ID: <87sg2sjcxa.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dmitry Gutov writes: >> I think that sounds like a good solution. Grepping around a bit, >> perhaps `cpp-font-lock-keywords-source-directives' in font-lock.el would >> be a good source to use here? > > ... looking at the [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47488 Cc: 47488@debbugs.gnu.org, Reuben Thomas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: >> I think that sounds like a good solution. Grepping around a bit, >> perhaps `cpp-font-lock-keywords-source-directives' in font-lock.el would >> be a good source to use here? > > ... looking at the regexp it also matches #file, #line or #warning. > > Each of these could also be a name of a private attribute, I > think. Still, if those are indeed standard preprocessor directives, > this var looks like a good choice. I've never heard of the #file directive, but: ;; `cpp-font-lock-keywords-source-directives' is calculated from: ;; ;; (regexp-opt ;; '("define" "elif" "else" "endif" "error" "file" "if" "ifdef" ;; "ifndef" "import" "include" "line" "pragma" "undef" "warning")) I spent 30 seconds googling, and I could find no list of directive that includes #file, so... Bug #warning is used, and so is #line, so perhaps it's an old thing? Anyway, I'll amend the change to js.el to check whether it matches this regexp. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 09:41:49 2021 Received: (at control) by debbugs.gnu.org; 12 May 2021 13:41:49 +0000 Received: from localhost ([127.0.0.1]:38470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgp7V-0006EK-E5 for submit@debbugs.gnu.org; Wed, 12 May 2021 09:41:49 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgp7T-0006E2-Oq for control@debbugs.gnu.org; Wed, 12 May 2021 09:41:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=16TU1Q3JRI75AcD1VzVDG3Cfcv0LRMUuLuYNNIiyHb0=; b=u31d//MWcB7eCE8vl5utqGlR6s rr+AXaI+9K6M4FEOb3wbJ4mYOwHeRdAsfvDp0pMP5YBJKAPJCsgF3+xOlOK2whLMk12V0+bijhkew HHdV1K/JH4SS6UTnh9bNAs85v2lm/YR7cGkeT+v2Wxu0H4OS2Q0O7syTlBsMMySra5wo=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgp7L-00051S-Jn for control@debbugs.gnu.org; Wed, 12 May 2021 15:41:41 +0200 Date: Wed, 12 May 2021 15:41:39 +0200 Message-Id: <87r1icjch8.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #47488 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 47488 fixed close 47488 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 47488 fixed close 47488 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 09:53:19 2021 Received: (at 47488) by debbugs.gnu.org; 12 May 2021 13:53:19 +0000 Received: from localhost ([127.0.0.1]:38503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgpId-0000I3-GA for submit@debbugs.gnu.org; Wed, 12 May 2021 09:53:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgpIc-0000Ho-09 for 47488@debbugs.gnu.org; Wed, 12 May 2021 09:53:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58592) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgpIW-0006nr-50; Wed, 12 May 2021 09:53:12 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2076 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgpIV-0006Yk-Kz; Wed, 12 May 2021 09:53:11 -0400 Date: Wed, 12 May 2021 16:53:21 +0300 Message-Id: <83sg2s2h4e.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87sg2sjcxa.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 12 May 2021 15:32:01 +0200) Subject: Re: bug#47488: Treatment of # in js.el References: <871rahqtu6.fsf@gnus.org> <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> <87lf8lpijq.fsf@gnus.org> <87sg2sjcxa.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47488 Cc: 47488@debbugs.gnu.org, rrt@sc3d.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Wed, 12 May 2021 15:32:01 +0200 > Cc: 47488@debbugs.gnu.org, Reuben Thomas > > I've never heard of the #file directive, but: > > ;; `cpp-font-lock-keywords-source-directives' is calculated from: > ;; > ;; (regexp-opt > ;; '("define" "elif" "else" "endif" "error" "file" "if" "ifdef" > ;; "ifndef" "import" "include" "line" "pragma" "undef" "warning")) > > I spent 30 seconds googling, and I could find no list of directive that > includes #file, so... Bug #warning is used, and so is #line, so perhaps > it's an old thing? The #file directive is emitted by the preprocessor, so that later compiling the preprocessed source would yield the correct source line numbers. Try preprocessing some .c file with "gcc -E" and you will see these directives in the output. From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 09:56:18 2021 Received: (at 47488) by debbugs.gnu.org; 12 May 2021 13:56:18 +0000 Received: from localhost ([127.0.0.1]:39957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgpLV-0000js-JE for submit@debbugs.gnu.org; Wed, 12 May 2021 09:56:17 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgpLS-0000jl-Jj for 47488@debbugs.gnu.org; Wed, 12 May 2021 09:56:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AoXj13hiAhaLxpkKo19ovUmeib12adlDop7gzO70ufU=; b=P3FkbVRicuGKGAgGe6DuLv5aYz JBZqFi05ZZfTvHgPi2tkA8/XypabYgcemAzANNFIbKAwq5DKbaGwlHVV5bXu6v5uZm+M1PkIEjj/4 d3jajVKyHZPjja5QWwfavzLp5c1i3AAQw6WQUAb8/92wdjcwvA51GbVaObCeQge+LUV4=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgpLK-0005DD-1v; Wed, 12 May 2021 15:56:08 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#47488: Treatment of # in js.el References: <871rahqtu6.fsf@gnus.org> <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> <87lf8lpijq.fsf@gnus.org> <87sg2sjcxa.fsf@gnus.org> <83sg2s2h4e.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEUMDR4pNFhoZ4P/ ///NGFFJAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UFDA00AlWXEdEAAAGUSURBVCjPNVKxjtswDKUM y0A9eYgCJFvH5ivkAMnQSSlM46ApyxW1v+LQL3AB+9C7KQXsIOZX9lHXcqDwRL5nPdJEGs2FrvQ/ OKOgZ2WQdoVPl+YNyVmuFWYrkmX2G5yFoI85BqslcUrqQwUJMx6ooi9xSAKkYNe/5EldmXshS+7f V3cLyh/hoQldTzYQRIvVK3BM+4lbWRgt7QK2RLkLxNuVrEwdQNhoxSzMjDYDjueLfBdZAVpc16+f X+WhJhHJmVX7xVB4Y07JNrfeDNadEwhbb2Z7j2/pXdt6HguRyacKzVPxLuMCCd4e78OeZOnBCu1P GZ7IPkcYsuc/wj9gXyinp+K2n2bMT6oNddmNDiPA4+qow3zLm4JwosbEFxThw+p0vg4ZONZYNV4+ DgCUGwWZCNrKnBRQL3jXIfgESl3R2lRpvEd0uSvnutA0eef5pBsmk0YRj2CGOv0Jrr9gpLX7aIxj IGM7UsdN2Sh1NZ68a9+HHNT5mz2xLuUTmfNwd5zAmWz76/e2U7BeyMW6iQlI+Augmnr0p6VtjgAA ACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0wNS0xMlQxMzo1MjowMiswMDowMOfAgUYAAAAldEVYdGRh dGU6bW9kaWZ5ADIwMjEtMDUtMTJUMTM6NTI6MDIrMDA6MDCWnTn6AAAAAElFTkSuQmCC X-Now-Playing: Bertine Zetlitz's _Morbid Latenight Show_: "Getting Out" Date: Wed, 12 May 2021 15:56:05 +0200 In-Reply-To: <83sg2s2h4e.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 May 2021 16:53:21 +0300") Message-ID: <87eeecjbt6.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > The #file directive is emitted by the preprocessor, so that later > compiling the preprocessed source would yield the correct source line > numbers. Try preprocessing some .c file with "gcc -E" and [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47488 Cc: 47488@debbugs.gnu.org, rrt@sc3d.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > The #file directive is emitted by the preprocessor, so that later > compiling the preprocessed source would yield the correct source line > numbers. Try preprocessing some .c file with "gcc -E" and you will > see these directives in the output. Ah; thanks. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 10:39:19 2021 Received: (at 47488) by debbugs.gnu.org; 12 May 2021 14:39:20 +0000 Received: from localhost ([127.0.0.1]:40010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgq19-0001vL-OU for submit@debbugs.gnu.org; Wed, 12 May 2021 10:39:19 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:37505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgq17-0001vB-0P for 47488@debbugs.gnu.org; Wed, 12 May 2021 10:39:18 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4FgHVW3mnDz1sCV9; Wed, 12 May 2021 16:39:15 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4FgHVW17rwz1qvy1; Wed, 12 May 2021 16:39:15 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 4cIrNV6kuRGy; Wed, 12 May 2021 16:39:14 +0200 (CEST) X-Auth-Info: 8AVZ1WX0BBy83yH1dpoxsughI47aO4ei8/SXMrp0jBHm0ZUuriYIUHskGOMR+v2p Received: from igel.home (ppp-46-244-187-18.dynamic.mnet-online.de [46.244.187.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 12 May 2021 16:39:14 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id EA5B72C36BE; Wed, 12 May 2021 16:39:13 +0200 (CEST) From: Andreas Schwab To: Eli Zaretskii Subject: Re: bug#47488: Treatment of # in js.el References: <871rahqtu6.fsf@gnus.org> <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> <87lf8lpijq.fsf@gnus.org> <87sg2sjcxa.fsf@gnus.org> <83sg2s2h4e.fsf@gnu.org> X-Yow: My LESLIE GORE record is BROKEN.. Date: Wed, 12 May 2021 16:39:13 +0200 In-Reply-To: <83sg2s2h4e.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 May 2021 16:53:21 +0300") Message-ID: <87h7j8nhim.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 47488 Cc: Lars Ingebrigtsen , rrt@sc3d.org, 47488@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Mai 12 2021, Eli Zaretskii wrote: > The #file directive is emitted by the preprocessor, so that later > compiling the preprocessed source would yield the correct source line > numbers. Try preprocessing some .c file with "gcc -E" and you will > see these directives in the output. Not by gcc. It uses # LINE FILE FLAGS for that purpose. The gcc preprocessor doesn't know anything about #file. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 10:49:20 2021 Received: (at 47488) by debbugs.gnu.org; 12 May 2021 14:49:20 +0000 Received: from localhost ([127.0.0.1]:40030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgqAm-0002Bc-AF for submit@debbugs.gnu.org; Wed, 12 May 2021 10:49:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgqAk-0002BQ-Lu for 47488@debbugs.gnu.org; Wed, 12 May 2021 10:49:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60378) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgqAe-0007Tb-RH; Wed, 12 May 2021 10:49:08 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1642 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgqAd-0003ba-9i; Wed, 12 May 2021 10:49:07 -0400 Date: Wed, 12 May 2021 17:49:13 +0300 Message-Id: <83pmxw2eja.fsf@gnu.org> From: Eli Zaretskii To: Andreas Schwab In-Reply-To: <87h7j8nhim.fsf@igel.home> (message from Andreas Schwab on Wed, 12 May 2021 16:39:13 +0200) Subject: Re: bug#47488: Treatment of # in js.el References: <871rahqtu6.fsf@gnus.org> <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> <87lf8lpijq.fsf@gnus.org> <87sg2sjcxa.fsf@gnus.org> <83sg2s2h4e.fsf@gnu.org> <87h7j8nhim.fsf@igel.home> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47488 Cc: larsi@gnus.org, rrt@sc3d.org, 47488@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andreas Schwab > Cc: Lars Ingebrigtsen , 47488@debbugs.gnu.org, > dgutov@yandex.ru, rrt@sc3d.org > Date: Wed, 12 May 2021 16:39:13 +0200 > > On Mai 12 2021, Eli Zaretskii wrote: > > > The #file directive is emitted by the preprocessor, so that later > > compiling the preprocessed source would yield the correct source line > > numbers. Try preprocessing some .c file with "gcc -E" and you will > > see these directives in the output. > > Not by gcc. It uses # LINE FILE FLAGS for that purpose. The gcc > preprocessor doesn't know anything about #file. You are right, sorry. I confused this with #line, which can optionally state the file. From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 10:56:55 2021 Received: (at 47488) by debbugs.gnu.org; 12 May 2021 14:56:55 +0000 Received: from localhost ([127.0.0.1]:40050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgqIB-0002OP-H9 for submit@debbugs.gnu.org; Wed, 12 May 2021 10:56:55 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:37538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgqI9-0002OC-Lt for 47488@debbugs.gnu.org; Wed, 12 May 2021 10:56:54 -0400 Received: by mail-wr1-f47.google.com with SMTP id q5so4475851wrs.4 for <47488@debbugs.gnu.org>; Wed, 12 May 2021 07:56:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RmEZFxuScAFajhDM9KN0nS//43bRhCKbP+F+Fem9aOk=; b=BC1r7EnAj+TQxJ+YVlDo6ka6OIPSae3Ow+pnmeVJj4boIlQv3xAAHNnrh+twjCScso 8rInSwtV0/tB/Uz+H/npnOM8+FsQWSbD+jdL7tf4MCApqW5iyQ1AjRs0ppxxHrFwhhng dZzyw0f6C1sQTa5zMqmoZD+Y0jIxbz99/OPCPAWUbeGV0+xhTW03qFh5KfhGgKOeAi2y 41shV1QHkVpE44E840zg1/dNf1wZtsuWat2aR0vVbXI8gYWsmcW9PAZ05CBeNIXnTOvD uXQJp0WNqZlGPgkv80h+9kgBYKcWFVUlJfgwVAUF1Bmf/9HUEU/Spn2QrVniac1tqgH9 D0Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RmEZFxuScAFajhDM9KN0nS//43bRhCKbP+F+Fem9aOk=; b=YIAW0TYWvByfq7B4PRW87T3i1RPALxgSLIXfqRjBBoWtyS3KOF5Cyfjobwi9a1GMci mDX+9lnM95NHrScgxdXa7EIGpGeF3d5ruoHE6mLCCvVFFcMX0jMpHgaoAoSu5yAChKM2 GMxc04RvrxOpZJXrOT+3iR1Ii9vUL5tEYu9vHVgexGPWAumKoFAnjb+kYH9Qlm+lINrH WmlCioWCpEC5aSu1z3WBuaeEixocNNBWI7Ph44NnIayUjbQj0K9jmhpNuUAqpBs4QQ8k Z9AMNUzprFMqHUIkzmLOdEk5U4jbOa/ASyu1d/7zhq7PukZEFtjccWovxVyWRHPOPGw2 wbRg== X-Gm-Message-State: AOAM530XlSEgKn1w5CBJA1P7/0DdEovz6ivmkGttYV2071cNmmitb4Gv 9j0JmG1403Lq3xq+ubffafI= X-Google-Smtp-Source: ABdhPJyFAUZiMIORz9y13Nw572fRMThMPFzqsGUmwmAM6Oy8ixcZ4ktYCyMmrmOQA4jSY+qHP0XvyQ== X-Received: by 2002:adf:f607:: with SMTP id t7mr45185922wrp.172.1620831407785; Wed, 12 May 2021 07:56:47 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id s1sm6661671wmj.8.2021.05.12.07.56.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 May 2021 07:56:46 -0700 (PDT) Subject: Re: bug#47488: Treatment of # in js.el To: Lars Ingebrigtsen References: <871rahqtu6.fsf@gnus.org> <030f4208-3688-1e23-990e-1becd852c27b@yandex.ru> <87lf8lpijq.fsf@gnus.org> <87sg2sjcxa.fsf@gnus.org> From: Dmitry Gutov Message-ID: Date: Wed, 12 May 2021 17:56:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87sg2sjcxa.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 47488 Cc: 47488@debbugs.gnu.org, Reuben Thomas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 12.05.2021 16:32, Lars Ingebrigtsen wrote: > Anyway, I'll amend the change to js.el to check whether it matches this > regexp. Thanks! We'll probably need to add a user option anyway, but that can wait until the corresponding bug report. From unknown Fri Jun 20 07:12:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 10 Jun 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator