GNU bug report logs - #47466
[PATCH] scripts: import: cran: Add missing help for 'style' option.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: zimoun <zimon.toutoune <at> gmail.com>
Subject: bug#47466: closed (Re: [bug#47466] [PATCH] scripts: import: cran:
 Add missing help for 'style' option.)
Date: Mon, 29 Mar 2021 18:58:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#47466: [PATCH] scripts: import: cran: Add missing help for 'style' option.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 47466 <at> debbugs.gnu.org.

-- 
47466: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47466
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 47466-done <at> debbugs.gnu.org
Subject: Re: [bug#47466] [PATCH] scripts: import: cran: Add missing help for
 'style' option.
Date: Mon, 29 Mar 2021 19:57:49 +0100

[Message part 3 (text/plain, inline)]

zimoun <zimon.toutoune <at> gmail.com> writes:

> * guix/scripts/import/cran.scm (show-help): Add help message for 'style'
> option.
> ---
>  guix/scripts/import/cran.scm | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/guix/scripts/import/cran.scm b/guix/scripts/import/cran.scm
> index 4767bc082d..466d0cb8e2 100644
> --- a/guix/scripts/import/cran.scm
> +++ b/guix/scripts/import/cran.scm
> @@ -50,6 +50,9 @@ Import and convert the CRAN package for PACKAGE-NAME.\n"))
>    (display (G_ "
>    -r, --recursive        import packages recursively"))
>    (display (G_ "
> +  -s SPECIFICATIONS, --style=SPECIFICATIONS
> +                         specify package specifications instead of references"))
> +  (display (G_ "
>    -V, --version          display version information and exit"))
>    (newline)
>    (show-bug-report-information))

I changed the message, and pushed this as
55c25ee4c5cee0707c94f773eb7d1686f79cff75.

+  -s, --style=STYLE      choose output style, either specification or variable"))

In my view, the thing in caps is a placeholder, so I put STYLE rather
than SPECIFICATIONS, I also altered the message to hint at what this
controls (the output), and the supported values.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: zimoun <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH] scripts: import: cran: Add missing help for 'style' option.
Date: Mon, 29 Mar 2021 15:11:17 +0200

* guix/scripts/import/cran.scm (show-help): Add help message for 'style'
option.
---
 guix/scripts/import/cran.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/guix/scripts/import/cran.scm b/guix/scripts/import/cran.scm
index 4767bc082d..466d0cb8e2 100644
--- a/guix/scripts/import/cran.scm
+++ b/guix/scripts/import/cran.scm
@@ -50,6 +50,9 @@ Import and convert the CRAN package for PACKAGE-NAME.\n"))
   (display (G_ "
   -r, --recursive        import packages recursively"))
   (display (G_ "
+  -s SPECIFICATIONS, --style=SPECIFICATIONS
+                         specify package specifications instead of references"))
+  (display (G_ "
   -V, --version          display version information and exit"))
   (newline)
   (show-bug-report-information))
-- 
2.28.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.