From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 27 12:49:44 2021 Received: (at submit) by debbugs.gnu.org; 27 Mar 2021 16:49:44 +0000 Received: from localhost ([127.0.0.1]:44785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQC88-0000wB-5R for submit@debbugs.gnu.org; Sat, 27 Mar 2021 12:49:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:53192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQBp6-0000RL-0V for submit@debbugs.gnu.org; Sat, 27 Mar 2021 12:30:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQBp5-0005wy-Nf for guix-patches@gnu.org; Sat, 27 Mar 2021 12:30:03 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:55151) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQBp3-0006ZN-RL for guix-patches@gnu.org; Sat, 27 Mar 2021 12:30:03 -0400 Received: by mail-wm1-x32d.google.com with SMTP id k128so4470385wmk.4 for ; Sat, 27 Mar 2021 09:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NJgRaxIEBBUU77Lj1ojHAAz9wkuH8WP7IQEcShqi3MM=; b=lGEJ8LCcgXiyUe3pK/9akcWudRZEve6r7ETq75O16QhN+7CbqB/X3c7RnHWrN6dJFb 2XjcmTO4jssU7gEUufhhm/U1XoKZpQUYAe+DPRlZWSFqjoT9sTiDKwn7o+DoaldYICF0 IM5uZPs4j9cghQyZhX12aHl2rnQtDqR4bC3qwMUOCesDeF8fsvIarZDF9kqP+M9gtjFo cARHKaq2lC2G1il7+SONTZ79fHVFirDOK/Pk29szhym8YtatPip2wg8D8b1UgnA63VIk raIxukUdJTk/nUEQ3WWH3nSm+Zid4YHPGf+SIFKFbU809qK91pdABqQQ5AssNJk3SNRK hVfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NJgRaxIEBBUU77Lj1ojHAAz9wkuH8WP7IQEcShqi3MM=; b=Py+aF9QxZRa1DhyMwMyJrSzrZruKuxP25ZfwXIMDn/huAyZeO6hE1gYTT3dtTTopue OgV37pqg6X23uJUVChc4EZKYbFZdRfc2un3XnUdv5+YvWs+69zR1nH665ETZt+oVOIYM gZnfkEAITmPDgJsIpcGf6Pl8bm0KYQdDxQd5sGfrS08aPSVMtgGkQ8s34miGntl7P+lM H808+5ibHUTXkXECh+ZNe68/DOycpaj1k4j1YUBVH7hSly8XBKATsuGWPp2VdLRYsSIY 1feI/y8iV+LbC/T+++4Bk5Y03YQSqM3Xbv2aSa+8Jdg9eTqsbTsqGNrWH5r0ZzgFgVZz cFWg== X-Gm-Message-State: AOAM530go3EoWr5mo9AQ9pSh++kL/vDQqNhF6Gw/82iNNTc8ad7Nl9Fg /GZ8UqP0xSMeejrxqZEjQw/SjBeJWEo= X-Google-Smtp-Source: ABdhPJzW1JfC81a2rtMJD80xjzaClmtmDkSxSuKVn23VjHrQKZ6MGDwUG/O51H4PYwII2KyT65zl9w== X-Received: by 2002:a05:600c:614:: with SMTP id o20mr17351226wmm.66.1616862599924; Sat, 27 Mar 2021 09:29:59 -0700 (PDT) Received: from localhost.localdomain ([213.195.111.200]) by smtp.googlemail.com with ESMTPSA id q207sm17819245wme.36.2021.03.27.09.29.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Mar 2021 09:29:59 -0700 (PDT) From: =?UTF-8?q?N=C3=A9fix=20Estrada?= To: guix-patches@gnu.org Subject: [PATCH] Added Go 1.16.2 Date: Sat, 27 Mar 2021 17:29:53 +0100 Message-Id: <20210327162953.32278-1-nefixestrada@gmail.com> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=nefixestrada@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 27 Mar 2021 12:49:42 -0400 Cc: =?UTF-8?q?N=C3=A9fix=20Estrada?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Signed-off-by: Néfix Estrada --- gnu/packages/golang.scm | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index d9988cd7ad..df17955c93 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -25,6 +25,7 @@ ;;; Copyright © 2020 Martin Becze ;;; Copyright © 2021 Ricardo Wurmus ;;; Copyright © 2021 Guillaume Le Vaillant +;;; Copyright © 2021 Néfix Estrada ;;; ;;; This file is part of GNU Guix. ;;; @@ -440,6 +441,32 @@ in the style of communicating sequential processes (@dfn{CSP}).") ,@(package-native-inputs go-1.4))) (supported-systems %supported-systems))) +(define-public go-1.16 + (package + (inherit go-1.14) + (name "go") + (version "1.16.2") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/golang/go") + (commit (string-append "go" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1cvw81hgb7akqp53lqbgpk303km8a7xs7lcr8c8z30hr5ql2kz90")))) + (arguments + (substitute-keyword-arguments (package-arguments go-1.14) + ((#:phases phases) + `(modify-phases ,phases + (add-after 'prebuild 'prebuild-1-16 + (lambda* (#:key inputs #:allow-other-keys) + (let* ((gcclib (string-append (assoc-ref inputs "gcc:lib") "/lib"))) + (substitute* "cmd/go/testdata/script/link_syso_issue33139.txt" + (("\\[\\!cgo\\] skip") + "[!exec:cc] skip"))))))))))) + (define-public go go-1.14) (define-public go-github-com-alsm-ioprogress -- 2.31.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 27 15:56:49 2021 Received: (at 47434) by debbugs.gnu.org; 27 Mar 2021 19:56:49 +0000 Received: from localhost ([127.0.0.1]:44993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQF3A-0005Xk-ON for submit@debbugs.gnu.org; Sat, 27 Mar 2021 15:56:49 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:43674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQF38-0005Xb-Jd for 47434@debbugs.gnu.org; Sat, 27 Mar 2021 15:56:47 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id lXwk240070mfAB406XwkRZ; Sat, 27 Mar 2021 20:56:44 +0100 Message-ID: Subject: Re: [bug#47434] [PATCH] Added Go 1.16.2 From: Maxime Devos To: =?ISO-8859-1?Q?N=E9fix?= Estrada , 47434@debbugs.gnu.org Date: Sat, 27 Mar 2021 20:56:06 +0100 In-Reply-To: <20210327162953.32278-1-nefixestrada@gmail.com> References: <20210327162953.32278-1-nefixestrada@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-OgCPHJ+Y7OCky1/8riFL" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1616875004; bh=sRiNfx78x4vfvhZQOduaxOvXio4XcY2irIuveXVwNew=; h=Subject:From:To:Date:In-Reply-To:References; b=qEBuCWlK0/a+/f/GhuVJ8RLPyg7xmLST50Lg75iryx0no9v7rA0cguaLqd1M+/Dxx 0vjGgFKfAxi5w0YmZv0ni8Uvr/3pEdkMGPJrahQbE65+vBEHJgzsZiOA+enfYxmmY2 xc+7c9EEOH+W9EyAhLVDCZrLpIEmXCoFjRIaXuSlY22t0WMg1Rs/YYDWC9iCjQ9oWL lHx96jLbICVVu15kpYO4ps6MddGForV5OUW8JEtsqdrrlIzW+bLE3S9GFYvo96z50x ZupSVGmNmEIkL5lqojYLDFV7X/JBvEJ2Giv6pZkqEtcPGxJU0crhokOqzy/+DkAPEf gQs8cz4LrD9UA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47434 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-OgCPHJ+Y7OCky1/8riFL Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2021-03-27 at 17:29 +0100, N=C3=A9fix Estrada wrote: > Signed-off-by: N=C3=A9fix Estrada > --- > gnu/packages/golang.scm | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) A commit message is missing, see =E2=80=9816.6 Submitting Patches=E2=80=99 = in the manual (and there are plenty of examples in "git log"). There have been a few patches lately by new contributers without commit messages; is this section of the manual hard to find? Is there some location where we could prominently feature a link to the section? Also, =E2=80=98we=E2=80=99 don't use =E2=80=98Signed-off-by=E2=80=99 like t= hat. From =E2=80=9816.8 Commit Access=E2=80=99: When pushing a commit on behalf of somebody else, please add a =E2=80=98Signed-off-by=E2=80=99 line at the end of the commit log message= =E2=80=94e.g., with =E2=80=98git am --signoff=E2=80=99. This improves tracking of who did what= . Thus, it is up to committers to add a line like that. Perhaps a system like the Linux kernel project uses could be useful in the future, but I don't think =E2=80=98we=E2=80=99 are at that point yet > diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm > index d9988cd7ad..df17955c93 100644 > --- a/gnu/packages/golang.scm > +++ b/gnu/packages/golang.scm > @@ -25,6 +25,7 @@ > ;;; Copyright =C2=A9 2020 Martin Becze > ;;; Copyright =C2=A9 2021 Ricardo Wurmus > ;;; Copyright =C2=A9 2021 Guillaume Le Vaillant > +;;; Copyright =C2=A9 2021 N=C3=A9fix Estrada > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -440,6 +441,32 @@ in the style of communicating sequential processes (= @dfn{CSP}).") > ,@(package-native-inputs go-1.4))) > (supported-systems %supported-systems))) > =20 > +(define-public go-1.16 > + (package > + (inherit go-1.14) > + [...] > + (arguments > + (substitute-keyword-arguments (package-arguments go-1.14) > + ((#:phases phases) > + `(modify-phases ,phases This part looks good to me. > + (add-after 'prebuild 'prebuild-1-16 > + (lambda* (#:key inputs #:allow-other-keys) > + (let* ((gcclib (string-append (assoc-ref inputs "gcc:lib") "/lib= "))) > + (substitute* "cmd/go/testdata/script/link_syso_issue33139.txt" > + (("\\[\\!cgo\\] skip") > + "[!exec:cc] skip"))))))))))) > + What's this 'prebuild-1-16' phase for? Please add a comment explaining! And what's (let* ((gcclib ...) ...) doing there if gcclib isn't used afterw= ards? > (define-public go go-1.14) Something to consider for people who know the go situation in guix: could this be replaced with (define-public go go-1.16) after this patch? (And go-1.14 deleted as there are no uses of it anymore.) The output of "guix refresh --list-dependent go" is: Building the following 125 packages would ensure 440 dependent packages are= rebuilt: [...] so this shouldn't cause a world-rebuild (note go packages are (reportedly) cheap to build). But perhaps there are API incompatibilities between 1.16 = and 1.14? idk. Note: this patch should be reviewed by someone more knowledged about go in guix than me. Thanks for looking into this, Greetings, Maxime --=-OgCPHJ+Y7OCky1/8riFL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYF+N1xccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7g+wAQDIuumSyfD/ULQ6MOVcveXlQVhm dfdAg9AWgUPK6DMA7QD/dAWawD4s1WIrRlbWUv7OI0SMaSR4qdI7KJoMcTQbIww= =k3hI -----END PGP SIGNATURE----- --=-OgCPHJ+Y7OCky1/8riFL-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 28 20:47:04 2021 Received: (at 47434) by debbugs.gnu.org; 29 Mar 2021 00:47:04 +0000 Received: from localhost ([127.0.0.1]:47312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQg3b-0002LK-PF for submit@debbugs.gnu.org; Sun, 28 Mar 2021 20:47:04 -0400 Received: from mail-qt1-f169.google.com ([209.85.160.169]:43749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQg3Z-0002Kq-PG for 47434@debbugs.gnu.org; Sun, 28 Mar 2021 20:47:02 -0400 Received: by mail-qt1-f169.google.com with SMTP id s2so8256367qtx.10 for <47434@debbugs.gnu.org>; Sun, 28 Mar 2021 17:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=uXVqh2PmQRMpKOYTkcJGsoU9LEqct4mPkn0mtlSF89Q=; b=RWmLP6SbCIoOCljuHwn112K0pSNo3/RC6h2IObHkPD/Ergc+ekwuR0Q+nWtoY/Amr+ P9dyctwexQ4SOYgBaU4u+owCMKrkz2xFMA999vFInY7esSgHb7WcT1hrloeuI3iJ0G3O 7qWi8VkIAeCASMOb1vHShb+B/H71mmHUHkJty4oRaWYgNJm+uLT2FxvkDpmFrZgCL3yw Zuvky2MRgmyQO49DsfLi7QsDJ8Hf1yvLRLVFMLECM38sfYq5/VwZuqgTfkhftVPo9SGH cmEpkCK1nMcFbUvLJzLslmqW4lmkkew/9KkKMwMhblZT2ZB2Vs2nm71Inkc55rosHpYB cyOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=uXVqh2PmQRMpKOYTkcJGsoU9LEqct4mPkn0mtlSF89Q=; b=qT4nmVygk3FaIVXO4DAX02zkc6+0KWtMO85mySB8rWiU5ubiAdedtRgENCBmEv7mK+ oUO11qtt7cJN0rE2LcaODqhA1fKtC0r/5Ilw9ohJ3+Pw2cMc6ic4ogrC6dxK/cgEVwzC fsECxsNSiiqVtAzUixS0EPXfz/xLuy4YUfF+ouVHwnkRkuknwTvQbWACLbopgae6xGLa K07oVKW5OLrXiCI9UeTUrjhRUy64bsv9iSNu1MVc2oTCAlt56sUu/KXM/mwuwu4mrvJR RyDOzJiY6byX04DdS/6Vj+MwuETHq0UpcA6BWv1nrK4849gRQ30GQYP/z7gTDJS1c4XG JicA== X-Gm-Message-State: AOAM533+3y3fz4tfLc9Fk6reiCyLRLID4JAgrwhtBeZLyOPgCfTb4eXG dSaaLh6pYGobXqslf6KGhrvcLrvg4mY= X-Google-Smtp-Source: ABdhPJwJHYkxKlaiOvXRCOWRBrx7CuKtERc1mOW4Wd3xzcQT+dMehox5kws4c8UI4IufjvHTnaGm3w== X-Received: by 2002:a05:622a:188:: with SMTP id s8mr20742852qtw.42.1616978815805; Sun, 28 Mar 2021 17:46:55 -0700 (PDT) Received: from hurd (dsl-155-113.b2b2c.ca. [66.158.155.113]) by smtp.gmail.com with ESMTPSA id a138sm12139150qkg.29.2021.03.28.17.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Mar 2021 17:46:55 -0700 (PDT) From: Maxim Cournoyer To: Maxime Devos Subject: Re: bug#47434: [PATCH] Added Go 1.16.2 References: <20210327162953.32278-1-nefixestrada@gmail.com> Date: Sun, 28 Mar 2021 20:46:49 -0400 In-Reply-To: (Maxime Devos's message of "Sat, 27 Mar 2021 20:56:06 +0100") Message-ID: <874kgudbwm.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 47434 Cc: 47434@debbugs.gnu.org, =?utf-8?Q?N=C3=A9fix?= Estrada X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Maxime Devos writes: > On Sat, 2021-03-27 at 17:29 +0100, N=C3=A9fix Estrada wrote: >> Signed-off-by: N=C3=A9fix Estrada >> --- >> gnu/packages/golang.scm | 27 +++++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) > > A commit message is missing, see =E2=80=9816.6 Submitting Patches=E2=80= =99 in > the manual (and there are plenty of examples in "git log"). > > There have been a few patches lately by new > contributers without commit messages; is this section of the > manual hard to find? Is there some location where we could > prominently feature a link to the section? > > Also, =E2=80=98we=E2=80=99 don't use =E2=80=98Signed-off-by=E2=80=99 like= that. From =E2=80=9816.8 Commit Access=E2=80=99: > > When pushing a commit on behalf of somebody else, please add a > =E2=80=98Signed-off-by=E2=80=99 line at the end of the commit log message= =E2=80=94e.g., with > =E2=80=98git am --signoff=E2=80=99. This improves tracking of who did wh= at. > > Thus, it is up to committers to add a line like that. Perhaps a system > like the Linux kernel project uses could be useful in the future, > but I don't think =E2=80=98we=E2=80=99 are at that point yet > >> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm >> index d9988cd7ad..df17955c93 100644 >> --- a/gnu/packages/golang.scm >> +++ b/gnu/packages/golang.scm >> @@ -25,6 +25,7 @@ >> ;;; Copyright =C2=A9 2020 Martin Becze >> ;;; Copyright =C2=A9 2021 Ricardo Wurmus >> ;;; Copyright =C2=A9 2021 Guillaume Le Vaillant >> +;;; Copyright =C2=A9 2021 N=C3=A9fix Estrada >> ;;; >> ;;; This file is part of GNU Guix. >> ;;; >> @@ -440,6 +441,32 @@ in the style of communicating sequential processes = (@dfn{CSP}).") >> ,@(package-native-inputs go-1.4))) >> (supported-systems %supported-systems))) >>=20=20 >> +(define-public go-1.16 >> + (package >> + (inherit go-1.14) >> + [...] > >> + (arguments >> + (substitute-keyword-arguments (package-arguments go-1.14) >> + ((#:phases phases) >> + `(modify-phases ,phases > > This part looks good to me. > >> + (add-after 'prebuild 'prebuild-1-16 >> + (lambda* (#:key inputs #:allow-other-keys) >> + (let* ((gcclib (string-append (assoc-ref inputs "gcc:lib") "/li= b"))) >> + (substitute* "cmd/go/testdata/script/link_syso_issue33139.txt" >> + (("\\[\\!cgo\\] skip") >> + "[!exec:cc] skip"))))))))))) >> + > > What's this 'prebuild-1-16' phase for? Please add a comment explaining! > And what's (let* ((gcclib ...) ...) doing there if gcclib isn't used afte= rwards? > >> (define-public go go-1.14) > > Something to consider for people who know the go situation in guix: > could this be replaced with (define-public go go-1.16) after this patch? > (And go-1.14 deleted as there are no uses of it anymore.) > The output of "guix refresh --list-dependent go" is: > > Building the following 125 packages would ensure 440 dependent packages a= re rebuilt: > [...] > > so this shouldn't cause a world-rebuild (note go packages are (reportedly) > cheap to build). But perhaps there are API incompatibilities between 1.1= 6 and > 1.14? idk. Go 1.16 does break some go packages. I have a similar patch locally but I haven't pushed it yet because I was pursuing the different failures it causes. Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 29 02:18:54 2021 Received: (at 47434) by debbugs.gnu.org; 29 Mar 2021 06:18:54 +0000 Received: from localhost ([127.0.0.1]:47633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQlEk-00026m-BC for submit@debbugs.gnu.org; Mon, 29 Mar 2021 02:18:54 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:48266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQlEi-00026d-A4 for 47434@debbugs.gnu.org; Mon, 29 Mar 2021 02:18:53 -0400 Received: from butterfly.local ([178.119.10.153]) by andre.telenet-ops.be with bizsmtp id m6Jq240063J72EA016Jq0d; Mon, 29 Mar 2021 08:18:50 +0200 Message-ID: <29af474b4cc48fd552cd123e71fb389ed1a0f0e9.camel@telenet.be> Subject: Re: bug#47434: [PATCH] Added Go 1.16.2 From: Maxime Devos To: Maxim Cournoyer Date: Mon, 29 Mar 2021 08:18:34 +0200 In-Reply-To: <874kgudbwm.fsf_-_@gmail.com> References: <20210327162953.32278-1-nefixestrada@gmail.com> <874kgudbwm.fsf_-_@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-a5SrbNn4zHfaNHig4yp7" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1616998730; bh=gdAs0/5nAap68L22WijrzKjYU69Xqr5IkUXznO3n13U=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=UErN7Y78mKwWAqypVfpQRHjWo/dzn6TSJZfidRj+AXGV6XSHqIVm+AofL/ipQTUZG yRAyojPuUpbRDK4PWucUKmFNEGrTzPRbN5MZDUFGXrcP4oJ9WyFCQ3BwfkiqcMAtWL 4Qh6vQFJP//HLInkbygr3ajd4zQxjyN/v6coDzq6O5xb+o4iMksfv6pMlTnoD6N9s0 a7MhvJMTD/cByM4XsOpgYt/MPL0cKkujWuw6ViBh3Kn0FNlTNOgImAa7W06VG92Tvh iZDhrogSEIB6rCv6cdznYhdXlBD77LKxLvIsz78xwDDWeJChL1+GfmPEGXIhIs2L27 4soEIx+amdb6w== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47434 Cc: 47434@debbugs.gnu.org, =?ISO-8859-1?Q?N=E9fix?= Estrada X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-a5SrbNn4zHfaNHig4yp7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2021-03-28 at 20:46 -0400, Maxim Cournoyer wrote: > Hi, >=20 > Maxime Devos writes: >=20 > > [...] >=20 > Go 1.16 does break some go packages. I have a similar patch locally but > I haven't pushed it yet because I was pursuing the different failures it > causes. Ok. If the 1.14 -> 1.16 upgrade would break packages, then it makes sense t= o (at first) define the updated go as a package variant and only later use it in the go packages once the update issues have been fixed or worked-around. Greetings, Maxime. --=-a5SrbNn4zHfaNHig4yp7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYGFxOhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7sDfAQDq32nLgg4kI7y3PMogF4jksxGQ m9gNwxkBICDgKrL/mAD8D3GwNEz1trCWgB/MUu63kzkAX1ym9fAghPTB9VZVUwE= =O/z1 -----END PGP SIGNATURE----- --=-a5SrbNn4zHfaNHig4yp7-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 05 18:50:58 2021 Received: (at 47434-done) by debbugs.gnu.org; 5 Aug 2021 22:50:58 +0000 Received: from localhost ([127.0.0.1]:48588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBmCY-00082m-B9 for submit@debbugs.gnu.org; Thu, 05 Aug 2021 18:50:58 -0400 Received: from out0.migadu.com ([94.23.1.103]:60371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBmCV-00082b-7k for 47434-done@debbugs.gnu.org; Thu, 05 Aug 2021 18:50:57 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1628203853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UOTdPDm7AJWXuNQV69cziPpLaluLXwKnAloZztkvqX0=; b=JYek+/V8f3c9b7MgnjyksQMB4bvP8b0JnRt2UQY+dqdKgAm1hL7P8SgxVCsJzsGpmnYV1C 6xNTCzV/UqMIf9ilwCWKyv0ZUqCVMVLUDftt80ghRprPJEi2gGnu7lZcdAC76fLcgU6KOx ueiJDxOVgYaHO1Gqu+6N1qfMhLxoYCw= From: Sarah Morgensen To: 47434-done@debbugs.gnu.org Subject: Re: bug#47434: [PATCH] Added Go 1.16.2 References: <20210327162953.32278-1-nefixestrada@gmail.com> Date: Thu, 05 Aug 2021 15:50:49 -0700 In-Reply-To: <20210327162953.32278-1-nefixestrada@gmail.com> (=?utf-8?Q?=22N=C3=A9fix?= Estrada"'s message of "Sat, 27 Mar 2021 17:29:53 +0100") Message-ID: <861r7733qu.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47434-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Superseded by #49221; closing. From unknown Sat Jun 14 03:55:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 03 Sep 2021 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator