GNU bug report logs - #47414
26.1; [PATCH] compilation-goto-locus does not handle right display-buffer

Previous Next

Package: emacs;

Reported by: pillule <pillule <at> riseup.net>

Date: Fri, 26 Mar 2021 17:28:01 UTC

Severity: normal

Tags: fixed, patch

Found in version 26.1

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 47414 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: pillule <pillule <at> riseup.net>
Cc: 47414 <at> debbugs.gnu.org
Subject: Re: bug#47414: 26.1; [PATCH] compilation-goto-locus does not handle
 right display-buffer
Date: Sun, 28 Mar 2021 15:19:34 +0200

pillule <pillule <at> riseup.net> writes:

> This patch is a trivial check aknowledge if we are in the compilation
> window before choosing what display function to use, so users can
> customize the behavior of compilation windows via display-buffer-alist
> without breaking the error navigation functionnalities.

Thanks; applied to Emacs 28.

I'm not 100% confident here, though, since the logic here is slightly
convoluted, but if I read the code correctly, then this shouldn't
introduce any regressions, at least.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 4 years and 84 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.