GNU bug report logs - #47392
[PATCH 0/2] Add Laminar.

Previous Next

Full log

Message #17 received at 47392 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 47392 <at> debbugs.gnu.org
Subject: Re: bug#47392: [PATCH 0/2] Add Laminar.
Date: Mon, 05 Apr 2021 11:58:18 +0200

Christopher Baines <mail <at> cbaines.net> skribis:

> * gnu/services/ci.scm: New file.
> * gnu/tests/ci.scm: New file.
> * doc/guix.texi (Laminar): Document the Laminar service.

[...]

> +@defvr {Scheme Procedure} laminar-service-type
> +The type of the Laminar service.  Its value must be a
> +@code{laminar-configuration} object, as described below.
> +@end defvr

It would be nice to add a config example with one or two sentences
explaining what it does.

> +  #:export (<laminar-configuration>

Please don’t export the record type descriptor.

Otherwise LGTM, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.