GNU bug report logs - #47389
27.1.91; completion issue on eshell

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Eli Zaretskii <eliz <at> gnu.org>, andrés ramírez <rrandresf <at> gmail.com>, 47389 <at> debbugs.gnu.org, 41423 <at> debbugs.gnu.org
Subject: bug#47389: 27.1.91; completion issue on eshell
Date: Mon, 27 Jun 2022 10:29:34 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> If You code the 'minimalist version of the patch'. I could try it on this
>> version.
>
> See patch below.  You don't need to rebuild Emacs either: just recompile
> that one file and you're done.

[...]

> diff --git a/lisp/eshell/em-cmpl.el b/lisp/eshell/em-cmpl.el
> index faf749d836..744be525ec 100644
> --- a/lisp/eshell/em-cmpl.el
> +++ b/lisp/eshell/em-cmpl.el
> @@ -399,16 +399,21 @@
>
>  (defun eshell-complete-commands-list ()
>    "Generate list of applicable, visible commands."
> -  (let ((filename (pcomplete-arg)) glob-name)
> +  ;; Building the commands list can take quite a while, especially over Tramp
> +  ;; (bug#41423), so do it lazily.

Re-skimming this bug report quickly, it seems like this patch was
applied at the time, but Andrés had some additional issues, and a
proposed addition patch?

Andrés, did this patch fix the issue, and if not, do you have an
additional patch here?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.