From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 25 10:05:48 2021 Received: (at submit) by debbugs.gnu.org; 25 Mar 2021 14:05:48 +0000 Received: from localhost ([127.0.0.1]:39118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPQcO-0000Kl-00 for submit@debbugs.gnu.org; Thu, 25 Mar 2021 10:05:48 -0400 Received: from lists.gnu.org ([209.51.188.17]:38632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPQcM-0000Ke-7h for submit@debbugs.gnu.org; Thu, 25 Mar 2021 10:05:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPQcL-0000jU-VO for bug-gnu-emacs@gnu.org; Thu, 25 Mar 2021 10:05:46 -0400 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]:42736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPQcJ-0004XF-JR for bug-gnu-emacs@gnu.org; Thu, 25 Mar 2021 10:05:45 -0400 Received: by mail-qk1-x734.google.com with SMTP id y5so1808604qkl.9 for ; Thu, 25 Mar 2021 07:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=zwG1RdSMV8OQPIKmtJeKOKRjJ+ip8NlOlLAQ1/jipUo=; b=a5bOlbdLqaXyyVFQ3e1KWeNMA129VmaSPNC/WXGkfBIX88d81HALKWfK3jD4uOgwXh J17e17IJ0HGEhvAGF8G0RVMs/pz//ZZ2Gr5c77Hn9UuWoK6SKCAFl2IzIL9UxOoqTEtd tZ86wfnAHJngNeFvViL/JxKp3429QIrwQNRq5BV8k6F4zyGEG7dBd+cVvGDRgoXW7hnu fTAEEYdaW0mw+cZ5f1FhO/fwaZ7YZTtG0CXNtMAbhZPLYoJMtGcIF2/mEsz/ZB6lO2Wo jep2o7g77EXZNlo9gufhuLQ9wM0c7GU8BUGDO6n3Up0bXWMpFE7oJLq0n63cs1gis8Zq USag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=zwG1RdSMV8OQPIKmtJeKOKRjJ+ip8NlOlLAQ1/jipUo=; b=XWP3F6yXI4fCwAmUovak+fwzXx+If4MMmzMzb3RohjXvWDf6B4muhXmYWaQ8fv1XMF 5dNXRhaEk4n3HuO6hFebQP1iL2k3jzRQTSOr13RV6FCYsE4X3kNDkjDij+c+DNHR9YpT KjaZdu341PN5XQfZqfemqrYeO/CKy1xl1+/XxWSMT/EgPQGwzWC7dvKnVMYjGpssp8Cc pwlbHFG5XdIBWeRd7b2Yscu4AVnvYsNiUVkkD6vforjWH4izvxcTGU5BUm9q+pd/jtsz CSE+VSaAbv4Hor/sgfecRtJ5x9VWlltdfk7NFCLGN/RCKkSmKAM3gaQODHZFam5N6aVl ckzg== X-Gm-Message-State: AOAM5332ULJuBrznKd+83TqNjOiBsPHS+y6PBujRy/Bv7q8UxidEaKIV c2t922FZ5bphz0UQ6DUAJ5FvRjTGvNI= X-Google-Smtp-Source: ABdhPJwWGb3gKIJ2nDFAFX4AAbtT5whpGMehXiDzMrmX6b4F5+/0gVjE14ENRf8HSMDCtA7is9Tt0g== X-Received: by 2002:a37:a912:: with SMTP id s18mr8494511qke.80.1616681141401; Thu, 25 Mar 2021 07:05:41 -0700 (PDT) Received: from earth (c-73-163-194-78.hsd1.dc.comcast.net. [73.163.194.78]) by smtp.gmail.com with ESMTPSA id z14sm3511674qti.87.2021.03.25.07.05.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 07:05:41 -0700 (PDT) From: Alex Branham To: bug-gnu-emacs@gnu.org Subject: 27.1; eldoc-documentation-function is ignore in updated eldoc Date: Thu, 25 Mar 2021 10:05:40 -0400 Message-ID: <871rc35nwr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::734; envelope-from=alex.branham@gmail.com; helo=mail-qk1-x734.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello - Emacs 27.1 ships with eldoc that defines eldoc-documentation-function as #'ignore. If users install eglot from ELPA, this pulls in an updated eldoc that attempts to redefine eldoc-documentation-function. However, the value does not change (since eldoc-documentation-function is already bound, defcustom does not update it when called in eldoc--documentation-strategy-defcustom) so the value is still ignore, meaning users get: There is no ElDoc support in this buffer since eldoc-documentation-function is #'ignore, regardless of the value of eldoc-documentation-functions. Here's the bug report we received with the original issue: https://github.com/emacs-ess/ESS/issues/1130 Thanks! From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 26 14:28:03 2021 Received: (at 47388) by debbugs.gnu.org; 26 Mar 2021 18:28:03 +0000 Received: from localhost ([127.0.0.1]:42447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPrBj-0005KG-36 for submit@debbugs.gnu.org; Fri, 26 Mar 2021 14:28:03 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:37408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPrBh-0005Jl-2a for 47388@debbugs.gnu.org; Fri, 26 Mar 2021 14:28:01 -0400 Received: by mail-wr1-f49.google.com with SMTP id x16so6545322wrn.4 for <47388@debbugs.gnu.org>; Fri, 26 Mar 2021 11:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=oQzks/BnKKvMXy9d1s0b4nyVb70sD+NbTtbRtR8dMps=; b=cvFAfNBXmLykY/QcZyJGdsvMnO6pXK6gjHaZshEP4lX7v8C63VH2kxEArfKmThhG1B q63txk3nm9ZhmPTiLCUcJYWGR1kx2HjieYc2fBu2hjXfMHe5FhRnLfkYzfZFD07K2uFe +QGu3ydrpeYDCgL7gUSbudIx+0Cjjz8oT84GuiDyU3O3UqeixfBaiu1YBoOgOuNZR5Fg ZoJynLlVqQjwxo9Unyfalz6GUHs/jRtr2GKz4a5XGHTkJeFCMSC0jfuZGzvonaHUX+AV su9wTrcgKtqBbnPQJHxwWWFgmtm1cCwlFgDVwgZ+fNihnfdUk+sSYz97RMAFlCNG5uKl nMiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=oQzks/BnKKvMXy9d1s0b4nyVb70sD+NbTtbRtR8dMps=; b=GH4clAon5BQeLeWCsgs8liQ21vYYG2W03Y5gEN62MjeinM4FtYjpE3eqasNLt1EHJw YZqEhzTwUAgp7oSUhkRlogNRfZ/vjjGPphTJDX1Wap2tbNIfRzw2AHNRDNjuakC4UOas bbO1VfzbEHjnldHMxrlsusA9d/VYPwhO+ANK5JFSKhKeMJWi1d61pFIdtVFEtiuN+MnR SkNHrBllqTCzFLvNgwnXiwVlTalBdmXACroUuEu9tWJ9IHCqngR2rsy58onmrX+YocR7 JWroGrOq6c/Ben/Mazq11b+K4Gtdyb3Jlwr76Rhx54KQF/nMh0LgzM8SnPDfZFFZtigI cI7w== X-Gm-Message-State: AOAM532EFZhdWMmD51cMGYOOMINGyJv/4ezRRZN2KUWY3jGYHLcAc9x0 LLtYalcsnMBKDsqZ2brhKGVXQQ== X-Google-Smtp-Source: ABdhPJymzJ5yKy7qGGwq3jTL08yGfEL3B/yh+OJ//VRohhHhVhGlYPxuca2PgL32EZbTA3AG8zAevA== X-Received: by 2002:a05:6000:1ce:: with SMTP id t14mr15715535wrx.85.1616783275269; Fri, 26 Mar 2021 11:27:55 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id f4sm14084464wrz.4.2021.03.26.11.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 11:27:54 -0700 (PDT) From: "Basil L. Contovounesios" To: Alex Branham Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc References: <871rc35nwr.fsf@gmail.com> Date: Fri, 26 Mar 2021 18:27:53 +0000 In-Reply-To: <871rc35nwr.fsf@gmail.com> (Alex Branham's message of "Thu, 25 Mar 2021 10:05:40 -0400") Message-ID: <87o8f53h3q.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 47388 Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Branham writes: > Emacs 27.1 ships with eldoc that defines eldoc-documentation-function as > #'ignore. If users install eglot from ELPA, this pulls in an updated > eldoc that attempts to redefine eldoc-documentation-function. However, > the value does not change (since eldoc-documentation-function is already > bound, defcustom does not update it when called in > eldoc--documentation-strategy-defcustom) so the value is still ignore, > meaning users get: > > There is no ElDoc support in this buffer > > since eldoc-documentation-function is #'ignore, regardless of the value > of eldoc-documentation-functions. > > Here's the bug report we received with the original issue: > https://github.com/emacs-ess/ESS/issues/1130 Thanks, CCing Jo=C3=A3o. --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 26 14:50:20 2021 Received: (at 47388) by debbugs.gnu.org; 26 Mar 2021 18:50:20 +0000 Received: from localhost ([127.0.0.1]:42479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPrXI-0005sb-Is for submit@debbugs.gnu.org; Fri, 26 Mar 2021 14:50:20 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:56056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPrXH-0005sM-3B for 47388@debbugs.gnu.org; Fri, 26 Mar 2021 14:50:20 -0400 Received: by mail-wm1-f51.google.com with SMTP id 12so3469924wmf.5 for <47388@debbugs.gnu.org>; Fri, 26 Mar 2021 11:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=SW8O95qgj35qSejrH6gbxdRHIyMVy2Csv7iaRrLkwGs=; b=TvPjq39c65ySwem2Y72nQlBSt7NCGYV/pZ5QBXfURU+O9c1MoLLFK6WeqBaLewoUIc 54Q2AwZgQ24u5XWmmVxw5SQz1XAmdwWuzuBy0WdzRW0yM6mNA4KNGEhkOopQwSRRaIpQ 8aJwe9VBszZtSr2ysb6mUD44GoaLkg2jY40oSJUdXqwyJ9LRYlJBMffv5D2rHN4f9J+Y wZjORm6soSNRoeR5Ur6/o6mdCmCPPXHVXP0CxK7ZpOXcpKU6jIofpGnKRM2vgytCNYJd 42hsiU07JXJCIhXs+B5qERjjgwNcbV4mLteIW2ei+cYbPBRsO1aQXtmfA9uxLaWl/1on 3Ehw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=SW8O95qgj35qSejrH6gbxdRHIyMVy2Csv7iaRrLkwGs=; b=bAtkXCQJoKhy+oLL5JQlF/VDevU61pAorsO+555oo/J8CbCS8zqWLXpa84LT9PxNvn DZerXPH6dVihAHrfseaiD6Q8S4yXpffwNkdNkGBKbrZQ1UmpeHFsDHX+nBhk07mTgCVM EASLpZKUqEFRMvxlQnBHmRQW23EBovHqEBNaamPuLX/paSf7VboxfkDcUSVpn+LnsTzk czpuJLFctOQSeEdKa4XfKws5bL8pn8c1Ydp3/dpFDFq4wWTurgg8l92MRNIYkhZAC9E1 SUwO/rT8p4ZkPW1EXyUmfbl38viWBL5Tu1BLHKxY7QxgOOmF8t+gcQ80ptaPZQtCSYf7 OsmA== X-Gm-Message-State: AOAM530bJOh1HFEjoTOj/a1Dznp5NXjEjiUgRwL1z1BBR5+JdEhjH3yx +Fhvk3lX5lFeLcD6mfrN9AzIyN6oWTY= X-Google-Smtp-Source: ABdhPJzz+9gsQrKH1OhLAFX8xaaHhMShHfd+MrBTG2xjOZCva3VFHkTYptB01aIBrRDR0q2tjFmlaw== X-Received: by 2002:a05:600c:190c:: with SMTP id j12mr14548628wmq.133.1616784612803; Fri, 26 Mar 2021 11:50:12 -0700 (PDT) Received: from krug (89-180-154-241.net.novis.pt. [89.180.154.241]) by smtp.gmail.com with ESMTPSA id o7sm14618022wrs.16.2021.03.26.11.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 11:50:12 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: "Basil L. Contovounesios" Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> Date: Fri, 26 Mar 2021 18:50:10 +0000 In-Reply-To: <87o8f53h3q.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 26 Mar 2021 18:27:53 +0000") Message-ID: <87im5dg36l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47388 Cc: Alex Branham , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > Alex Branham writes: > >> Emacs 27.1 ships with eldoc that defines eldoc-documentation-function as >> #'ignore. If users install eglot from ELPA, this pulls in an updated >> eldoc that attempts to redefine eldoc-documentation-function. However, >> the value does not change (since eldoc-documentation-function is already >> bound, defcustom does not update it when called in >> eldoc--documentation-strategy-defcustom) so the value is still ignore, >> meaning users get: >> >> There is no ElDoc support in this buffer >> >> since eldoc-documentation-function is #'ignore, regardless of the value >> of eldoc-documentation-functions. >> >> Here's the bug report we received with the original issue: >> https://github.com/emacs-ess/ESS/issues/1130 > > Thanks, CCing Jo=C3=A3o. Thanks Basil, Alex, Alex, exactly under what circunstances do you see that "There is no ElDoc support in this buffer"? In what buffer, doing what? I appreciate that you have investigated the implementation, but I need to be able to understand -- and potentially reproduce -- the problem exactly as it happened to you, so please provide as clear a recipe as possible, perhaps starting with "downloaded Emacs 27.1, then cleared my ELPA directory, ..., installed Eglot from xyz, ..., ". Meanwhile (but not excluding the earlier valuable exercise), can you show the output of: C-h v eldoc-documentation-function RET C-h v eldoc-documentation-strategy RET ? Thanks again, Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 26 15:09:08 2021 Received: (at 47388) by debbugs.gnu.org; 26 Mar 2021 19:09:08 +0000 Received: from localhost ([127.0.0.1]:42508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPrpU-0006LR-5P for submit@debbugs.gnu.org; Fri, 26 Mar 2021 15:09:08 -0400 Received: from mail-qt1-f173.google.com ([209.85.160.173]:39833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPrpS-0006Kx-R4 for 47388@debbugs.gnu.org; Fri, 26 Mar 2021 15:09:07 -0400 Received: by mail-qt1-f173.google.com with SMTP id g24so5008192qts.6 for <47388@debbugs.gnu.org>; Fri, 26 Mar 2021 12:09:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=rEsqgceKOV+6Jt7D6orwUJhLPhaxcENAfb8NiBqAb9I=; b=Rvv1xKhlKKo9YpuAJlEhDt+zyWJoq5wyTE15woIAUCUYh6Yis9gtooksJ+jdwpBmxU OV6vdv7iUOvni89yVv0l79NuVZeaaycJ8Cu6X5dt7m0B1hh//vTe1tuPV9K50hojHGtc KdmzWY3W5g1uPD6WeB40IxrySrRQQYEsmGleaVwuAP6Ym+QuED9slV/B6y2bAHdSaDo0 qedBDTzLFuBYYNhIwievnQEgI6dgg0ZQ4tTURKC7O7QMTTTTMwG+Th9Cf+XfpqO1R0F+ ovxNI3U8jTREWRxGBfDhoNZCSPdNsYD6WolA+J3+JDLF2xwS1xItQEeQUQ3M9gz5ChHr 77/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=rEsqgceKOV+6Jt7D6orwUJhLPhaxcENAfb8NiBqAb9I=; b=M0i9hFSMpzoV3bLPdXNx0vk4r7BD4miK6keNahBAx+HWe8hO4k3aQIBzXwU8tPlrxY ANeRM1GAS2uYpQopKucjPShPux1gMf0oMD7fdEU67eSx3NSiJndiSMx7kLrezcLcGkXh 2MA/AsqOUFAJMVtHsFzBl1BuueMAX3hInMoHqwMmHPK4e4oWFGqo1JokmIzshPpL0aNS xJi9+pDKeACd5Z4uhimipWpL0vNak+1lsmKinblVzeaeL5ujj6jkGpsg5B1Y4umlNbad 8hSu7MaCoF3O3li6pSF0f687zX+FKXSk3AmCMQw4hVAeEwyQjeG+XX1H9zB+/DdbS2u2 SWEA== X-Gm-Message-State: AOAM531FF+qpMpZL0U6DmwJVDWuUEhjDEIh91f+JTNEhT1XUgo8tKb5J mLw4A7tlqqoTWx2wpgTH+a3yISBkLlaK3w== X-Google-Smtp-Source: ABdhPJz5yCHOs2XT1+GGSl4xg9/QxaFU1A9eBa7iYpANZzJAB4DMlIzmzV2gAZgmW6WdJ3JZmXLoUQ== X-Received: by 2002:a05:622a:1115:: with SMTP id e21mr13258185qty.192.1616785740948; Fri, 26 Mar 2021 12:09:00 -0700 (PDT) Received: from earth (c-73-163-194-78.hsd1.dc.comcast.net. [73.163.194.78]) by smtp.gmail.com with ESMTPSA id g2sm6430282qtu.0.2021.03.26.12.09.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 12:09:00 -0700 (PDT) From: Alex Branham To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> Date: Fri, 26 Mar 2021 15:08:59 -0400 In-Reply-To: <87im5dg36l.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Fri, 26 Mar 2021 18:50:10 +0000") Message-ID: <87czvlraus.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47388 Cc: "Basil L. Contovounesios" , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri 26 Mar 2021 at 18:50, Jo=C3=A3o T=C3=A1vora w= rote: > Alex, exactly under what circunstances do you see that "There is no > ElDoc support in this buffer"? In what buffer, doing what? I > appreciate that you have investigated the implementation, but I need to > be able to understand -- and potentially reproduce -- the problem > exactly as it happened to you, so please provide as clear a recipe as > possible, perhaps starting with "downloaded Emacs 27.1, then cleared my > ELPA directory, ..., installed Eglot from xyz, ..., ". Sure thing (though note I'm not the person who originally ran into the bug, just was able to reproduce). From a clean install of 27.1 (no init file, no packages), you should be able to reproduce by: 1. Add MELPA to package-archives 2. Install ESS 3. Update eldoc (potentially by installing eglot) 4. Restart Emacs 5. (require 'eglot) 6. Open an R file (eg ~/test.R) 7. At this point, eldoc-documentation-function will be #'ignore so eg M-x eldoc-mode will show "There is no ElDoc support in this buffer". That's because ESS sets up eldoc in R buffers like so: (if (boundp 'eldoc-documentation-functions) (add-hook 'eldoc-documentation-functions #'ess-r-eldoc-function nil t) (add-function :before-until (local 'eldoc-documentation-function) #'ess-r-eldoc-function)) so we don't touch eldoc-documentation-function in newer eldoc versions where it is supposed to be a user-facing customization. > Meanwhile (but not excluding the earlier valuable exercise), can you > show the output of: > > C-h v eldoc-documentation-function RET > C-h v eldoc-documentation-strategy RET Unfortunately I can't at the moment but from memory eldoc-documentation-strategy was an obsolete alias for eldoc-documentation-function and the value was the function ignore. Hope that helps. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 26 15:57:21 2021 Received: (at 47388) by debbugs.gnu.org; 26 Mar 2021 19:57:21 +0000 Received: from localhost ([127.0.0.1]:42554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPsa9-0001AZ-Lo for submit@debbugs.gnu.org; Fri, 26 Mar 2021 15:57:21 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:35544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPsa8-0001AM-6S for 47388@debbugs.gnu.org; Fri, 26 Mar 2021 15:57:20 -0400 Received: by mail-wr1-f53.google.com with SMTP id j18so6771686wra.2 for <47388@debbugs.gnu.org>; Fri, 26 Mar 2021 12:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=LeKnDOiNjBF3VWRxC6rXMOj4KhsOPDRxyePeh1fgvL0=; b=lFVoe3AUsKIUHCAfLh2nuOobTNMtDhVVClY9YKkiSc65kA6h6r5KsJ0ILHKirW9DMp WhGnc7D6w8b/hdAa6c0VuLuOmNaaQ2O/YELfDFpT9l2fH1+Nrxeel2yK1HEageo7Ottl ejh5HSI2r5/if+BdmQryH6rbpTaLUBJxlGUXJNKZSSh8nvT76Cuc6s0D83a7x6CGAOFQ HcuJaHg03uPn5TSr4+q8KLqM9slRKvKgAUQ/oboZdseQx8vtf6C9QTkswXyGUjN6gb6/ 7cUek7K5isfn+9JWl609NKI7dfqw0nq2OAF/VulaBSmcibemuelHUaMr4ju98uIcMKq4 9vVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=LeKnDOiNjBF3VWRxC6rXMOj4KhsOPDRxyePeh1fgvL0=; b=m7ub2hYxs4fRa9cMgU08I6LDRjCa4oeqNox598iXvJ/l9Mr0o9NJyi3WgdkhJG0kT5 aZlhQ0LVaxLKu5Rw7wBD6qauCIb495VEeYJgn7evQEG8tsX2DmmceFK9X0t6L2jcXSx7 5IPMQzqdglnoNAg94+lTPm02z6KLi7H2V4UzFSy9qLJclcswktoX77IuMxU2AKUVE6fz 64/ya/bsRNzLk6qC1VpyDh1my9uLvKGuVeZFnw80LhiiSda/3bp6u6jgfJKgMumM6DkC pCBH02DCNKftURNY3JfLV1yDJTv2AGs4Z7TdJrEeVTYOyN28KdAp6I3GOKdQgGvRP2F4 nylw== X-Gm-Message-State: AOAM5318QrItWF8+QQN1EHrqoTDI2gwt9Hy7Pywzi4/zX8AvMaUcZra6 Z3weXPQ023kR2CM/KDgj4caZbNrj+1A= X-Google-Smtp-Source: ABdhPJzW6YV1yNisuYXCPKwgkEmb7mQHH/I1fmOo5i2OUDAbpWYNwYY1NdeTp2ZT6D6nG2m4kI5J6w== X-Received: by 2002:a5d:6404:: with SMTP id z4mr16575627wru.109.1616788634042; Fri, 26 Mar 2021 12:57:14 -0700 (PDT) Received: from krug (89-180-154-241.net.novis.pt. [89.180.154.241]) by smtp.gmail.com with ESMTPSA id v189sm13178939wme.39.2021.03.26.12.57.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 12:57:13 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Alex Branham Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> Date: Fri, 26 Mar 2021 19:57:12 +0000 In-Reply-To: <87czvlraus.fsf@gmail.com> (Alex Branham's message of "Fri, 26 Mar 2021 15:08:59 -0400") Message-ID: <87a6qpg02v.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47388 Cc: "Basil L. Contovounesios" , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Branham writes: > On Fri 26 Mar 2021 at 18:50, Jo=C3=A3o T=C3=A1vora = wrote: > >> Alex, exactly under what circunstances do you see that "There is no >> ElDoc support in this buffer"? In what buffer, doing what? I >> appreciate that you have investigated the implementation, but I need to >> be able to understand -- and potentially reproduce -- the problem > 7. At this point, eldoc-documentation-function will be #'ignore so eg ^^^^^^^^=20 So this is where I'm completely baffled. You say this |||||||| But earlier you said, accurately, in fact it was your first sentence, that: >>>> Emacs 27.1 ships with eldoc that defines >>>> eldoc-documentation-function as #'ignore. So if it was #'ignore and still is #'ignore what exactly is the difference that (require 'eldoc) or (require 'eglot) is introducing?? Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 26 16:00:05 2021 Received: (at 47388) by debbugs.gnu.org; 26 Mar 2021 20:00:05 +0000 Received: from localhost ([127.0.0.1]:42559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPscn-0001FG-2c for submit@debbugs.gnu.org; Fri, 26 Mar 2021 16:00:05 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:60845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPsVZ-00012b-RT for 47388@debbugs.gnu.org; Fri, 26 Mar 2021 15:52:38 -0400 Received: from [192.168.1.127] (unknown [78.197.173.62]) (Authenticated sender: quietape@lunarhaven.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 183B5240004 for <47388@debbugs.gnu.org>; Fri, 26 Mar 2021 19:52:30 +0000 (UTC) To: 47388@debbugs.gnu.org From: QuietApe Message-ID: <524d9b74-0bf6-c662-eca4-f3a786c92d58@lunarhaven.net> Date: Fri, 26 Mar 2021 20:52:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="------------4B110CAC3EC7F0EADD208FFC" Content-Language: fr X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello, I'm the user that run into this bug, the exact output of the command are: > C-h v eldoc-documentation-function RET Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.178.230 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.70.178.230 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: 47388 X-Mailman-Approved-At: Fri, 26 Mar 2021 16:00:03 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) This is a multi-part message in MIME format. --------------4B110CAC3EC7F0EADD208FFC Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hello, I'm the user that run into this bug, the exact output of the command are: > C-h v eldoc-documentation-function RET eldoc-documentation-function is a variable defined in ‘eldoc.el’. Its value is ‘ignore’ Original value was ‘eldoc-documentation-default’ This variable has an alias: ‘eldoc-documentation-strategy’. > C-h v eldoc-documentation-strategy RET eldoc-documentation-strategy is a variable defined in ‘eldoc.el’. Its value is ‘ignore’ This variable is an alias for ‘eldoc-documentation-function’. This variable is obsolete since eldoc-1.1.0; use ‘eldoc-documentation-function’ instead. If it helps to add information to what Alex said. --------------4B110CAC3EC7F0EADD208FFC Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit Hello,

I'm the user that run into this bug, the exact output of the command are:

> C-h v eldoc-documentation-function RET

eldoc-documentation-function is a variable defined in ‘eldoc.el’.
Its value is ‘ignore’
Original value was ‘eldoc-documentation-default’
This variable has an alias: ‘eldoc-documentation-strategy’.

> C-h v eldoc-documentation-strategy RET

eldoc-documentation-strategy is a variable defined in ‘eldoc.el’.
Its value is ‘ignore’
This variable is an alias for ‘eldoc-documentation-function’.
This variable is obsolete since eldoc-1.1.0; use ‘eldoc-documentation-function’ instead.

If it helps to add information to what Alex said.
--------------4B110CAC3EC7F0EADD208FFC-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 26 16:24:09 2021 Received: (at 47388) by debbugs.gnu.org; 26 Mar 2021 20:24:09 +0000 Received: from localhost ([127.0.0.1]:42582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPt05-0001rN-6A for submit@debbugs.gnu.org; Fri, 26 Mar 2021 16:24:09 -0400 Received: from mail-oi1-f181.google.com ([209.85.167.181]:35700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPt03-0001r0-Ov for 47388@debbugs.gnu.org; Fri, 26 Mar 2021 16:24:08 -0400 Received: by mail-oi1-f181.google.com with SMTP id x2so6924077oiv.2 for <47388@debbugs.gnu.org>; Fri, 26 Mar 2021 13:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ujz1MSauD19vEazJVjWZ5OPLlXasD3vcs81JqnUcT6g=; b=mfjIceBZi0Vffb3QXvecf2BccObUBijh6/L6GDonzadbZMti5HIPYSmzXQCnUQlxlI OeXvys/IHKmWydDK9nQWm8gLLmtHEi87cdhSpxQ3ny0EqfLc/qBKF8FQfv5l0X/ubIC/ MaTyoLzeWZ/n9a/ZfdYh2B2djtStv956/RtADByUaIBv+fXF39+IjtCF6NvJAdRJossu DdpCTfqme9oyCuQJQOoTNaHBJqjsnPVDP26HkWunwGLFQixM0cIpiOR3XD6XSWltvVJx 09v0ca/tdkRdDyk7hXZi5tk+eybyytYaH/lu4ZB5lrRNMn+4MwvADg7GTVZVRBI6dAIv StSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ujz1MSauD19vEazJVjWZ5OPLlXasD3vcs81JqnUcT6g=; b=KgojZ3c6fOlwoPL5IGP3ogRlqdBI8OzIAhLZDkMmwI2kcK/WzmkdVcagcnt62K50Dk k4hU5sF2UH4rYxDjNKoOgn4vkD/TxPRlijHq2r0AvPxJyoJknzPqB38kGr4V2Ssk6Yn8 4oWAc9bguoSwMnygJtDo8fewCPEOgS0Bb3A4AaT/PcW86PBdkmcurDR1K2ULMWIpKlwf nkk1JuSeoSwEMFSjIb4TLQd6aVQlQW9PitPp7f4z+zQozovAZYbjMU4L+VX1IQyVkHRE vxfv0CYJHEA9Oz5PVU6Yz1STmILnSYYAIBe/eR+VYHs8+K+cxJsC6GyimtJ7ksEeTWa4 nQ+Q== X-Gm-Message-State: AOAM5312OkstDxUg2djvbhIHm9mV9KTHslEdHeI8hgkaIvH9S8XSK7OI TT3R9w8pVIGGbgJvh0g3mAb3TD0PuubHX4ee3RQ= X-Google-Smtp-Source: ABdhPJwnIuUv7pfIDbgXCfwBn7fk6LqyI1UUYnYWQ5PP/G5IC2t2yigzqSe24r+z6jSpoxi3lG1GUOnK9NfurGAoMFc= X-Received: by 2002:aca:170a:: with SMTP id j10mr10953643oii.128.1616790242284; Fri, 26 Mar 2021 13:24:02 -0700 (PDT) MIME-Version: 1.0 References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> In-Reply-To: <87a6qpg02v.fsf@gmail.com> From: Alex Branham Date: Fri, 26 Mar 2021 16:23:50 -0400 Message-ID: Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Content-Type: multipart/alternative; boundary="0000000000001159b505be7650fc" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47388 Cc: "Basil L. Contovounesios" , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000001159b505be7650fc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Because then we modify el-doc-functions because of the newer version of eldoc loaded. But the ignore value of el-doc-function prevents eldoc from working Hopefully that helps, sorry for the brevity am on phone On Fri, Mar 26, 2021, 3:57 PM Jo=C3=A3o T=C3=A1vora = wrote: > Alex Branham writes: > > > On Fri 26 Mar 2021 at 18:50, Jo=C3=A3o T=C3=A1vora wrote: > > > >> Alex, exactly under what circunstances do you see that "There is no > >> ElDoc support in this buffer"? In what buffer, doing what? I > >> appreciate that you have investigated the implementation, but I need t= o > >> be able to understand -- and potentially reproduce -- the problem > > > 7. At this point, eldoc-documentation-function will be #'ignore so eg > ^^^^^^^^ > So this is where I'm completely baffled. You say this |||||||| > > But earlier you said, accurately, in fact it was your first sentence, tha= t: > > >>>> Emacs 27.1 ships with eldoc that defines > >>>> eldoc-documentation-function as #'ignore. > > So if it was #'ignore and still is #'ignore what exactly is the > difference that (require 'eldoc) or (require 'eglot) is introducing?? > > Jo=C3=A3o > --0000000000001159b505be7650fc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Because then we modify el-doc-functions because of the ne= wer version of eldoc loaded.=C2=A0

But the ignore value of el-doc-function prevents eldoc from working

Hopefully that helps, sorr= y for the brevity am on phone

On Fri, Mar 26, 2021, 3:57 PM Jo=C3=A3o = T=C3=A1vora <joaotavora@gmail.co= m> wrote:
Alex Branham <<= a href=3D"mailto:alex.branham@gmail.com" target=3D"_blank" rel=3D"noreferre= r">alex.branham@gmail.com> writes:

> On Fri 26 Mar 2021 at 18:50, Jo=C3=A3o T=C3=A1vora <joaotavora@gm= ail.com> wrote:
>
>> Alex, exactly under what circunstances do you see that "There= is no
>> ElDoc support in this buffer"?=C2=A0 In what buffer, doing wh= at?=C2=A0 I
>> appreciate that you have investigated the implementation, but I ne= ed to
>> be able to understand -- and potentially reproduce -- the problem<= br>
> 7. At this point, eldoc-documentation-function will be #'ignore so= eg
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^^^^^^^^
So this is where I'm completely baffled.=C2=A0 You say this ||||||||
But earlier you said, accurately, in fact it was your first sentence, that:=

>>>> Emacs 27.1 ships with eldoc that defines
>>>> eldoc-documentation-function as #'ignore.

So if it was #'ignore and still is #'ignore what exactly is the
difference that (require 'eldoc) or (require 'eglot) is introducing= ??

Jo=C3=A3o
--0000000000001159b505be7650fc-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 26 16:34:35 2021 Received: (at 47388) by debbugs.gnu.org; 26 Mar 2021 20:34:35 +0000 Received: from localhost ([127.0.0.1]:42603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPtAA-000286-Pa for submit@debbugs.gnu.org; Fri, 26 Mar 2021 16:34:35 -0400 Received: from mail-io1-f52.google.com ([209.85.166.52]:35673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPtA9-00027u-7n for 47388@debbugs.gnu.org; Fri, 26 Mar 2021 16:34:33 -0400 Received: by mail-io1-f52.google.com with SMTP id x17so6725276iog.2 for <47388@debbugs.gnu.org>; Fri, 26 Mar 2021 13:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K2KODolrtIsIFXl235vFlwT6aCmODMiaFV25dPilGxE=; b=BrwFOJEUI/2QrPEjycQU4238TETmd+YpjLudDfvhglZXbYiKP6CtnIIviY84eXu6gI o4AA0KiDO1jjTviMXCZ7PjCt++4iL6QasChlrI2XKCHbd9Jee7SCXUsUt/Ds9ZhgGbuw pYLu/JTAJNwdy2eLjunt+Y0oIx4970Vfe1VRoxs+AhDFIpBP5CVCKexMDDo5yKc+Tx3z ufQgUoM9qewF5d8xLVPPM7VCbv/0F7fDcQaiyJHDPRdH8UH62eHoN4RAbf8FzKBI5UZT cBwlxIjjqBVgKbho2XCc13tF5bthmUEDbF+gP1yLeIh7jyxZhhIKzMYqBrUVqWF9gePB o17A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K2KODolrtIsIFXl235vFlwT6aCmODMiaFV25dPilGxE=; b=ouByaBiYnWIc5BqjIcqSoyd6jxTkFWKvq9fqa1FG6aupqUeuh8wLxTl8ah06lDUkRN TU9ejcDZiIP/ILrFcmpJRXqTyUswN3x12n6BYqsPhS7CuM1VCX8WAw4/iQc7M/L2ZO/6 /KElun2jT8pjEIRARkhG6pnsPF7SjZ0gczaqF1T6bvruoyrrpXJ5Pj0nhLmiqd1RplwT 8pFSvdXgK3rA+Ak8C6QkccWZZZ6L0DadYABdA1I6bvLMIaEaq6Kfs/fqIjSDZCIH5Lao dBOPUr9AO3df12U1jOnkV/CuArAQFY33rQibkXcBaJfBcpkjJvuz8h2zBh/uvQH3rXch gfYg== X-Gm-Message-State: AOAM531V94sU+qyxNHqHXfPe/IL7AcFLOY0AAMoiy2STcvOwuza2ILKv D/MgFX0Flj2j6v4va3egZaBujS/T7xgIf2zRDzU= X-Google-Smtp-Source: ABdhPJxyUAjeV3INfuo3CDN8y9lLg5WmofhmZ48M6IBfeTt+IXpaoIvSixRp22jAZzuHmCzZ0IsZB+cOET2jMG3GQro= X-Received: by 2002:a5e:c00a:: with SMTP id u10mr11645596iol.165.1616790867602; Fri, 26 Mar 2021 13:34:27 -0700 (PDT) MIME-Version: 1.0 References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Fri, 26 Mar 2021 20:34:16 +0000 Message-ID: Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc To: Alex Branham Content-Type: multipart/alternative; boundary="00000000000056efe905be7675d8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47388 Cc: "Basil L. Contovounesios" , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000056efe905be7675d8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Mar 26, 2021 at 8:24 PM Alex Branham wrote= : > Because then we modify el-doc-functions because of the newer version of > eldoc loaded. > > But the ignore value of el-doc-function prevents eldoc from working > > Hopefully that helps, sorry for the brevity am on phone > Ah, I get it, so ess-mode does something different. Then maybe it should also set eldoc-documentation-strategy to something sensible. Eldoc-documentation-strategy is just the new name of eldoc-documentation-function. If you find an `ignore` there, you're safe to change it , buffer-locally, as you did before. Maybe you should even do it even if you _don't_ find an ignore there. The fact that it's now defcustom doesn't change much in my opinion, I don't see defcustom's as off-limits to major/minor modes, as long as the user is still given override power in the mode hooks. Alternatively, ess-mode should just use the old interface. It's still available and functional. But I think you should select a strategy that suits `ess-mode`'s functions. Hope this helps, Jo=C3=A3o --00000000000056efe905be7675d8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Mar 26, 2021 at 8:24 PM Alex Branham <alex.branham@gmail.com> wro= te:
Because then we modify el-doc-functions because of the newer version = of eldoc loaded.=C2=A0

But the= ignore value of el-doc-function prevents eldoc from working

Hopefully that helps, sorry for the b= revity am on phone

Ah, I = get it, so ess-mode does something different.=C2=A0 Then
may= be it should also set eldoc-documentation-strategy
to something s= ensible.=C2=A0 Eldoc-documentation-strategy is
just the new name = of eldoc-documentation-function.
If you find an `ignore` there, y= ou're safe to change it
, buffer-locally, as you did bef= ore.=C2=A0 Maybe you should
even do it even if you _don't_ fi= nd an ignore there.
The fact that it's now defcustom doesn= 9;t change much
in my opinion, I don't see defcustom's as= off-limits to major/minor
modes, as long as the user is still gi= ven override power
in the mode hooks.

Al= ternatively, ess-mode should just use the old interface.
It&= #39;s still available and functional.=C2=A0

B= ut I think you should select a strategy that suits `ess-mode`'s
functions.=C2=A0

Hope this helps,
Jo=C3=A3o

--00000000000056efe905be7675d8-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 27 08:06:56 2021 Received: (at 47388) by debbugs.gnu.org; 27 Mar 2021 12:06:56 +0000 Received: from localhost ([127.0.0.1]:43516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQ7iR-0000HK-TI for submit@debbugs.gnu.org; Sat, 27 Mar 2021 08:06:56 -0400 Received: from mail-qk1-f173.google.com ([209.85.222.173]:37787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQ7iQ-0000H8-0T for 47388@debbugs.gnu.org; Sat, 27 Mar 2021 08:06:55 -0400 Received: by mail-qk1-f173.google.com with SMTP id g15so7991636qkl.4 for <47388@debbugs.gnu.org>; Sat, 27 Mar 2021 05:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=uwmZYS1olI/nvFOoI+nvUbqipsT77HOChDSxIdqq4+8=; b=jq0cxUgYDv14f3lrorw2kRNBp4XcZz9cMdZieeOtqYY0n0FWH76K1FTktaECntsM2f IAJoKwtfJUcsKpZemSI2k3s+RSs7EacON7W3uxcqzDQYIw96tjAu92q6hstd3JuejarR CpM5utgMCEbCfuOcV9+vFA4RtBwoJRGyxPGAIgGuJI4WaJ5ut6bBA0CP2QYvim5uy/7D MKGRp6YrnxOLvGdrJYKsV/dgiRTQIf6JxPYiZvfPq6JAMHcBGSFc0aGO5GZGuHLfPOvk sGfMC6GM003oOgOMzyrTdccSAKZ1bHJ1TCyDh9AVZZeKGRJgamqorDuooHJdp9ZiPrKn EAsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=uwmZYS1olI/nvFOoI+nvUbqipsT77HOChDSxIdqq4+8=; b=UevuQNY3B5+8zIZXHu4Ko+qqqfhnqU9Y72czJc3Lf0OVyNXwp4iBnOiHCiagYRNruT C9KK2YU7o3GKyENmm803W97Fknrp9Bs98NXQyjz4qKy+8jVwLcQDK1/lkegJpVi0qx9S QiavqZPXfM89R8MSHGaCy5BKxIQAkfRYu83oy6aUvz9/AG6Kpvb0/wNthLjEu5ws8+qj w+LZREI5+hWyEW6brRhIROFfDCKB3NQWYmLfkAPDX3fHwUiPYdE0f6hfaPCJaBrDkM7X sTxbAvC7kPHVW4BCIeW450olL2w1vVuxv0eN69kgZgBMUZ/3LQVh/nQ4GBG4n/Yrj0+U J+BQ== X-Gm-Message-State: AOAM532zA0nvDoqmX3wj1UXFBD1JFkVMFM2FpE+zRtYnT2pNO/JD0sZn m/kvqxfv262CCjKPMIPBvpuwBGf24zEQGA== X-Google-Smtp-Source: ABdhPJwZGcaUvT5c8OCyxhFjP1xmeNpKQUjtEkbG7oC+JT5O5eSZnMuIB4uRp9PfUj8k/HbNZ9pHnw== X-Received: by 2002:a37:a644:: with SMTP id p65mr17375154qke.20.1616846808157; Sat, 27 Mar 2021 05:06:48 -0700 (PDT) Received: from earth (c-73-163-194-78.hsd1.dc.comcast.net. [73.163.194.78]) by smtp.gmail.com with ESMTPSA id a20sm8793506qkg.61.2021.03.27.05.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Mar 2021 05:06:47 -0700 (PDT) From: Alex Branham To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> Date: Sat, 27 Mar 2021 08:06:45 -0400 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Fri, 26 Mar 2021 20:34:16 +0000") Message-ID: <87y2e894x6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47388 Cc: "Basil L. Contovounesios" , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri 26 Mar 2021 at 20:34, Jo=C3=A3o T=C3=A1vora w= rote: > Ah, I get it, so ess-mode does something different. I'm not sure I understand - different from what? > Then maybe it should also set eldoc-documentation-strategy to > something sensible. Eldoc-documentation-strategy is just the new name > of eldoc-documentation-function. If you find an `ignore` there, you're > safe to change it , buffer-locally, as you did before. Maybe you > should even do it even if you _don't_ find an ignore there. The fact > that it's now defcustom doesn't change much in my opinion, I don't see > defcustom's as off-limits to major/minor modes, as long as the user is > still given override power in the mode hooks. > > Alternatively, ess-mode should just use the old interface. > It's still available and functional. > > But I think you should select a strategy that suits `ess-mode`'s > functions. So the recommended strategy to support 27.1+old eldoc, 27.1+new eldoc, and 28.0+new eldoc is something like the below? (if (function-equal #'ignore eldoc-documentation-function) (add-hook 'eldoc-documentation-functions #'ess-r-eldoc-function nil t) (add-function :before-until (local 'eldoc-documentation-function) #'ess-r-eldoc-function)) From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 27 08:53:34 2021 Received: (at 47388) by debbugs.gnu.org; 27 Mar 2021 12:53:34 +0000 Received: from localhost ([127.0.0.1]:43536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQ8Ra-0001Pi-DE for submit@debbugs.gnu.org; Sat, 27 Mar 2021 08:53:34 -0400 Received: from mail-io1-f53.google.com ([209.85.166.53]:34531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQ8RX-0001PO-1H for 47388@debbugs.gnu.org; Sat, 27 Mar 2021 08:53:33 -0400 Received: by mail-io1-f53.google.com with SMTP id x16so8180794iob.1 for <47388@debbugs.gnu.org>; Sat, 27 Mar 2021 05:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yZpTCa8V8VwFCM1UaraoH9YRi5uh1j5VBrICuFEwc+k=; b=aJAy44IrBDw2Ez8SQZWF+rJLFh1IZFoLfSIjZ1SiCSvShPlMrO6q5CCnYmQA0BZhkb 7tG2hHk1VH4K/mAEWcNMiXiieExbmnZAMLlL6i8lqGRZCi0hQ4AJVFkb+P7SqyrfL4EI 2KP9/F4W8rY+PUn2U61kbcTVhalwhTvkvOYyI4njPdC0Yt8IzLfZQVP2Gvg/5seTsyWo 8hekSDRYUOTX6B79UMzFZMrAyIsnf5RRfJ2ze5cs6L2HpthZK+F6gbgkZLET97DEriIw PTDncV9SPTsDFaRQ9f6AOQbXuiaI7S2/og7er+opLm5X5KbckO1xXyZtlU62fVcTcAWO 2ofQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yZpTCa8V8VwFCM1UaraoH9YRi5uh1j5VBrICuFEwc+k=; b=loZsYQJp4ThPNMH+jwUrhNUP6rEiA6XWjgLRCkcRcDsSLg9+nQ8BT/rpltKA1/5EpG SVcnpB9BALxi+1jKsv8/AHam+TYre7nHt+LwUXY26/SvG6rD8nb2kmyBWJnIdC08r0Jf lhwaBrVXrx/GgQQ2WYJr64YsIXP0WWX9kxsiEnSKQt/uO3kRmjq3skCR6+nq1bjKeGtC XHEyU1cpXIoJ1AF26JSpDSvxdfsyBJiF9eoPduVVS+08gqDhOr55e/iAQjDJjrCr7kWd 6P6oNdulQ7Ioe5n+N8RyEko4peUtkKdRGlp/zzDuJswx1n//ZqRu2Z5LXic1mt6kZ6H5 8jvw== X-Gm-Message-State: AOAM532o8scosDqSZxEUKkWnDPLjnmRj+O/WwZwi8kr8UvDS4OnTb0AR ZeBcTYChNX+xd0xTh0jOEQvQscZ2kR8NScGyPk8= X-Google-Smtp-Source: ABdhPJymuTr0IcEEt+Mp6Lk2otUIG6PONlGr97A6A8eZOZReN3mAP6Y0kWcDhDD8uWqT9YkG/+e3DqCI7qr5izQF6I0= X-Received: by 2002:a5e:8610:: with SMTP id z16mr13494079ioj.57.1616849605144; Sat, 27 Mar 2021 05:53:25 -0700 (PDT) MIME-Version: 1.0 References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> <87y2e894x6.fsf@gmail.com> In-Reply-To: <87y2e894x6.fsf@gmail.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 27 Mar 2021 12:53:13 +0000 Message-ID: Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc To: Alex Branham , Stefan Monnier Content-Type: multipart/alternative; boundary="0000000000005eb28905be8422f0" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47388 Cc: "Basil L. Contovounesios" , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000005eb28905be8422f0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Mar 27, 2021 at 12:06 PM Alex Branham wrote: > On Fri 26 Mar 2021 at 20:34, Jo=C3=A3o T=C3=A1vora = wrote: > > > Ah, I get it, so ess-mode does something different. > > I'm not sure I understand - different from what? > It does different things depending on the situation it thinks it finds itself in. (if (function-equal #'ignore eldoc-documentation-function) > (add-hook 'eldoc-documentation-functions #'ess-r-eldoc-function nil t= ) > (add-function :before-until (local 'eldoc-documentation-function) > #'ess-r-eldoc-function)) > I'm not sure you're improving much here. My idea is that, if you find eldoc-documentation-functions (plural) to be bound you may need to check that eldoc-documentation-strategy (or eldoc-documentation-function (singular)) ISN'T #ignore and buffer-locally adjust it accordingly to something of your preference or your users' preference. Alternatively, you can just keep using the old technique which is a lot of parts of Emacs do (like elisp-mode in Emacs 27.1, for example), i.e. use the else branch in your if, and only that. You don't seem to be using = a ny of the new ElDoc features like multiple documentation functions anyway. That should also work for your Eglot-less rss-mode. When using Eglot-ified rss-mode Eglot will do the right thing regardless of the approach you take above. All this said, I think this issue should be kept open nonetheless. If indee= d the new package's defcustom could clobber the global value of eldoc-documentation-function if it finds it to be #'ignore I think it should be fine. CC-ing Stefan Monnier for an opinion on this last part. Jo=C3=A3o T=C3=A1vora --0000000000005eb28905be8422f0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Mar 27, 2021 at 12:06 PM Alex Bra= nham <alex.b= ranham@gmail.com> wrote:
On Fri 26 Mar 2021 at 20:34, Jo=C3=A3o T= =C3=A1vora <jo= aotavora@gmail.com> wrote:

> Ah, I get it, so ess-mode does something different.

I'm not sure I understand - different from what?
<= br>
It does different things depending on the situation it thinks=
it finds itself in.

(if (function-equal #'ignore eldoc-documentation-function)
=C2=A0 =C2=A0 (add-hook 'eldoc-documentation-functions #'ess-r-eldo= c-function nil t)
=C2=A0 (add-function :before-until (local 'eldoc-documentation-function= )
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #'ess-r-eldoc-f= unction))

I'm not sure you're i= mproving much here.=C2=A0 My idea is that,
if you find eldoc-docu= mentation-functions (plural) to be bound you
may need to check th= at eldoc-documentation-strategy (or
eldoc-documentation-func= tion (singular)) ISN'T #ignore and
buffer-locally adjust it = accordingly to something of your preference
or your users' pr= eference.

Alternatively, you can just keep usi= ng the old technique which is a lot
of parts of Emacs do (like el= isp-mode in Emacs 27.1, for example), i.e.
use the else branch i= n your if, and only that.=C2=A0 You don't seem to be using a
= ny of the new ElDoc features like multiple documentation functions anyway.<= /div>
That should also work for your Eglot-less rss-mode.
When using Eglot-ified rss-mode Eglot will do the right thing = regardless
of the approach you take above.

All this said, I think this issue should be kept open nonetheless. If in= deed
the new package's defcustom could clobber the global val= ue of
eldoc-documentation-function if it finds it to be #= 9;ignore I think it should
be fine.

CC-ing Stefan Monnier for an opinion on this last part.

=
Jo=C3=A3o T=C3=A1vora
--0000000000005eb28905be8422f0-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 28 07:23:57 2021 Received: (at 47388) by debbugs.gnu.org; 28 Mar 2021 11:23:57 +0000 Received: from localhost ([127.0.0.1]:45479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQTWP-0005rr-1b for submit@debbugs.gnu.org; Sun, 28 Mar 2021 07:23:57 -0400 Received: from mail-qk1-f171.google.com ([209.85.222.171]:35330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQTWN-0005rf-Dc for 47388@debbugs.gnu.org; Sun, 28 Mar 2021 07:23:55 -0400 Received: by mail-qk1-f171.google.com with SMTP id i9so9800663qka.2 for <47388@debbugs.gnu.org>; Sun, 28 Mar 2021 04:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=GTg1SnvwcNpICxu0v9tO6TBrbhKHOstvOF5fj5+bSgA=; b=dZKvknjR2uXg2KLzKMA3L/CCI0kYxcRVttrj/1iGTfHp65GVcVFX/pKDsupuFDs7fW GGxAbh/gNYtF/s8zCxDklFL2sYL0Vez7Xj8sNKfKXzDk+R9UGeXWEx2PphyyRI0zAYU+ keMPV8XWBqmq4/SmYzZmyunrw/zvZTlFft6KqPExBXCeGkuB4JAQFae/2Avpj1eRiHbP fy2fD6Fo5Bc/cHPIPrDZuK2/eHpm8nlon0V1t3NmJMNS0AmooXHF3dnsMXVDUhvvhE6n Jkf/e1bPCtANftbLe/rTclYt2gNNkbcOsYdXoq3WIEdxF5fc1/dtH2Dnq6FrJChrISE8 dqXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=GTg1SnvwcNpICxu0v9tO6TBrbhKHOstvOF5fj5+bSgA=; b=EghJZ4I14kWgHmK/18cGufB4sT0nH/b+mmjKVwiRXln46XRuEu0cMmgyhc1PcJ/+N/ Gqm0gZehJEqpP+m9k16ZlY/MWtSCCYH/kz3yJIfjvIbqcAEaEMa3HJU1uPzazgHelLgO k+3qw2adVWxOT8l8O8+jMxdY65V2j/Qa9PluOE+9gNo/gM7xuLTJMauv1Sp9nBvmv/YE Tswriuu2V4szFNvwxkx7NHaa/ile97xus/xQmsWJDi+j7Nf+ptx4A/SYHZT+uJWizLqp f0Y/NAkm2Hwq1ftdPhDvJ1qZGBFT4Hg8E4k507M59J6Tq8VZi9pekEcsDMR8SSCqFSKt DvuA== X-Gm-Message-State: AOAM5304eTP7JzrKyTXtl+7NvjB4Lq4J2Vk2d8Sb1eMmtZ13GLmQrmon TxFN9AAFleWS7JsexaPn4xr/1J8AYzM= X-Google-Smtp-Source: ABdhPJzVUkdCZL82F7v4DdJWd7u0Z27lKIpUrnKXAM2uajRHOy1dpfQxnepVpM6ndZpILBZY0Knjpw== X-Received: by 2002:a05:620a:22f5:: with SMTP id p21mr20483604qki.225.1616930629601; Sun, 28 Mar 2021 04:23:49 -0700 (PDT) Received: from earth (c-73-163-194-78.hsd1.dc.comcast.net. [73.163.194.78]) by smtp.gmail.com with ESMTPSA id j30sm9121679qtv.90.2021.03.28.04.23.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Mar 2021 04:23:48 -0700 (PDT) From: Alex Branham To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> <87y2e894x6.fsf@gmail.com> Date: Sun, 28 Mar 2021 07:23:47 -0400 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Sat, 27 Mar 2021 12:53:13 +0000") Message-ID: <87zgynbjy4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47388 Cc: "Basil L. Contovounesios" , Stefan Monnier , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat 27 Mar 2021 at 12:53, Jo=C3=A3o T=C3=A1vora w= rote: > I'm not sure you're improving much here. My idea is that, > if you find eldoc-documentation-functions (plural) to be bound you > may need to check that eldoc-documentation-strategy (or > eldoc-documentation-function (singular)) ISN'T #ignore and > buffer-locally adjust it accordingly to something of your preference > or your users' preference. Thanks! It sounds like the below is what you're suggesting modes do in order to support all the possible eldoc+Emacs versions, let me know if I've misunderstood. (if (not (boundp 'eldoc-documentation-functions)) ;; old eldoc (add-function :before-until (local 'eldoc-documentation-function) #'ess-r-eldoc-function) ;; new eldoc (add-hook 'eldoc-documentation-functions #'ess-r-eldoc-function nil t) ;; new eldoc + Emacs 27.1 (when (and (fboundp 'eldoc-documentation-default) (function-equal #'ignore eldoc-documentation-function)) (setq-local eldoc-documentation-function #'eldoc-documentation-default)= )) If that's right, it seems like a step backwards, ease-of-setup-wise at least, from the simple (add-function :before-until (local 'eldoc-documentation-function) #'ess-r-e= ldoc-function) that we did before new eldoc. But maybe it's necessary, I haven't really played around with the new eldoc features at all. Thanks again! From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 28 10:50:50 2021 Received: (at 47388) by debbugs.gnu.org; 28 Mar 2021 14:50:50 +0000 Received: from localhost ([127.0.0.1]:46740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQWkc-0004nX-5l for submit@debbugs.gnu.org; Sun, 28 Mar 2021 10:50:50 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:41720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQWka-0004nK-TY for 47388@debbugs.gnu.org; Sun, 28 Mar 2021 10:50:49 -0400 Received: by mail-wr1-f44.google.com with SMTP id b9so10275728wrt.8 for <47388@debbugs.gnu.org>; Sun, 28 Mar 2021 07:50:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=cQ9zv9Dd3sCurcy/07yjYR/xCD2B5Sf8c4UzbsIlcXU=; b=idfp/MaWCLy7L2+eYFBagA8DLDjad9ON4x8FDOvifHPEe/V3QtXYr2SKUBq23eqIZV OvsFPj33yPnB8CjiLJab4cHEf36m/MtsdmX+3MFZV/qNipjmVbkJTygcxxtVjIFamutZ WbYJjbhkLzKNjRMq3NQyl2PN6qqK832EP3rNfLU0LorWkSxLn+ng7JtvXuOaSL9bOl+X uHiINwwQaQrDfFF4MOv3BCEjyXV0HkaQDdUQhVW5iAgI2STJB17WjtQjNH9fRPvT2rMu +V8qsaGhXcKtY4M04mB5sUsdq2xp9LUl3RfckXFOoRfE+ML8n1yUHKHsm9uCfW6Nmghp jKpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=cQ9zv9Dd3sCurcy/07yjYR/xCD2B5Sf8c4UzbsIlcXU=; b=TlTmSsSA8MHGFw7IeuyxT/Stm0fMc2f6ZO5gI9XEE4RfauU6hUry0mZ0Zrtm9CzdEA D3ckRyP6ca5C21Z4XEOo0RAuF0NCW0sbiTDZ55TN4llW6jZSUWRcnkDFrQkFtNDt2wkK EPT4u3fTP0H6eD2dxD0+07hN2JQPHxpDS24keHhCOYL2S9RotI501OF6feD+kbxN+WeI eEzJVhTtxeuLbb6++dpoINnCh0A0Q9x46vIS0eyuLGkQIppXy9wQLO3CAptUMt02vMFS aEZqkbvN3BG9ng/+otiNEuQaeojti+KjZnwnIq7/05TFMtiFq/McrQrJI81iUW3Y4t4o Htow== X-Gm-Message-State: AOAM530iS03y8voCI4V4OP577YMdEEiXEAkn8UMzgsD77rBEXcdOShiE ox8KZRD0MA7NZaFHiwpV6N3HKKg5O6E= X-Google-Smtp-Source: ABdhPJzEW5uqeC81ijVfyS/KSFJi6gIXhKGV3qOzrwP0QHB5f1SQ/AYq18pDG4pewWL9zpfwgm9jCw== X-Received: by 2002:adf:e391:: with SMTP id e17mr24224380wrm.285.1616943042518; Sun, 28 Mar 2021 07:50:42 -0700 (PDT) Received: from krug (a94-133-179-151.cpe.netcabo.pt. [94.133.179.151]) by smtp.gmail.com with ESMTPSA id 18sm20411119wmj.21.2021.03.28.07.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Mar 2021 07:50:41 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Alex Branham Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> <87y2e894x6.fsf@gmail.com> <87zgynbjy4.fsf@gmail.com> Date: Sun, 28 Mar 2021 15:50:38 +0100 In-Reply-To: <87zgynbjy4.fsf@gmail.com> (Alex Branham's message of "Sun, 28 Mar 2021 07:23:47 -0400") Message-ID: <874kgvfi2p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47388 Cc: "Basil L. Contovounesios" , Stefan Monnier , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Branham writes: > On Sat 27 Mar 2021 at 12:53, Jo=C3=A3o T=C3=A1vora = wrote: > >> I'm not sure you're improving much here. My idea is that, >> if you find eldoc-documentation-functions (plural) to be bound you >> may need to check that eldoc-documentation-strategy (or >> eldoc-documentation-function (singular)) ISN'T #ignore and >> buffer-locally adjust it accordingly to something of your preference >> or your users' preference. > > Thanks! It sounds like the below is what you're suggesting modes do in > order to support all the possible eldoc+Emacs versions, let me know if > I've misunderstood. > > (if (not (boundp 'eldoc-documentation-functions)) > ;; old eldoc > (add-function :before-until (local 'eldoc-documentation-function) > #'ess-r-eldoc-function) > ;; new eldoc > (add-hook 'eldoc-documentation-functions #'ess-r-eldoc-function nil t) > ;; new eldoc + Emacs 27.1 > (when (and (fboundp 'eldoc-documentation-default)=20 > (function-equal #'ignore eldoc-documentation-function)) > (setq-local eldoc-documentation-function > #'eldoc-documentation-default))) You don't need to be as complex as this: (if (not (boundp 'eldoc-documentation-strategy)) (add-function :before-until (local 'eldoc-documentation-function) #'ess-r-eldoc-function) (add-hook 'eldoc-documentation-functions #'ess-r-eldoc-function nil t) (when (function-equal #'ignore eldoc-documentation-function) (setq-local eldoc-documentation-function #'eldoc-documentation-defa= ult|compose|whatever)))) > If that's right, it seems like a step backwards, ease-of-setup-wise at > least, from the simple > > (add-function :before-until (local 'eldoc-documentation-function) > #'ess-r-eldoc-function) You can still just that and call it a day. Just that, because the new eldoc in the yet-unreleased Emacs 28 is backward compatible. I've tried to explain this three times already in this exchange. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 28 12:05:55 2021 Received: (at 47388-done) by debbugs.gnu.org; 28 Mar 2021 16:05:55 +0000 Received: from localhost ([127.0.0.1]:46839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQXvH-0000NU-8j for submit@debbugs.gnu.org; Sun, 28 Mar 2021 12:05:55 -0400 Received: from mail-qk1-f170.google.com ([209.85.222.170]:41966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQXvF-0000NH-E5 for 47388-done@debbugs.gnu.org; Sun, 28 Mar 2021 12:05:53 -0400 Received: by mail-qk1-f170.google.com with SMTP id v70so10204237qkb.8 for <47388-done@debbugs.gnu.org>; Sun, 28 Mar 2021 09:05:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Db1NS6iQ4D18/eiy8ILvviqjScRpZOyIzuSHkq3hkBU=; b=KUmLjwSjbhppU6OAM9+aur4RoeBspxyUt2BA4OvJ6jiip5ugg0iKarIOBbOcd/3+44 /wtx2sSJ2+SHNSjiyZk7HOyO7JEyFREYUYSkHYvYj0/OoiIxpawKZpe4cbfQjCrzrugo a+8+rc3BP2R73Vkv3GzJ6vyG5MpjIJ8jz0bJIcGyE5JvDOaKHgOJbl18lVTrtEwpzZyH +mQAsd1h+5NdYwRKdaPqFWccQkWIRAGg33qwxbzbDvpuzr5ENCHvaU0uKL8iop2aEAB8 AeWXDkXK0Ex/toErcet99vL+BsbnTxCO0E/teDdQLnF2EvtY6rR0YV9XLAP8WodkDTh9 QzlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Db1NS6iQ4D18/eiy8ILvviqjScRpZOyIzuSHkq3hkBU=; b=cLoIutTY+Y/f1X53HBfLDnkDmPZpTiVjOLU9L93FhRyg9LWl1yUWAVPMfOwc/q/FF7 R6AUviiRwkTpjn/IqtnEkk2zcJnX92YG9dlbSs0BmqbxOGVahM9hIr+KRsC6glTvbAzp v2PtTiDkcr8XdXh8eGC+ZAjhxzZ7ws8XMbWy/7TM79C7yIUpjNWcIBoZDu5uKI4BE2P7 CdLPR72Glr7dmCg2TSO5liBhxCnXOnnNhiat6DmDjlzvozTxsqWdoigAAW4BRLnPwFmN GagiaszIA+bRM6D5wZhhkSM41AqulydAa7/kzfidPOMZsm/5O/eftR3Xg7V3gDkniHMh 4JbA== X-Gm-Message-State: AOAM532bamAlKlS5D44B16L6JYSt3rgChBE4Bp1us5KNTN07KfGTbeXo /1YrPHal1VMrxW//wO9H51y6BW7tmqs= X-Google-Smtp-Source: ABdhPJyP/d+ELE5uuDG3U/uqH6mpE3iXWcVQZchcnjj6qNPFs7FIVJGusnQfqI96mssU4WL2Ue/gQA== X-Received: by 2002:a05:620a:31c:: with SMTP id s28mr21424541qkm.342.1616947547667; Sun, 28 Mar 2021 09:05:47 -0700 (PDT) Received: from earth (c-73-163-194-78.hsd1.dc.comcast.net. [73.163.194.78]) by smtp.gmail.com with ESMTPSA id b15sm9441704qtr.58.2021.03.28.09.05.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Mar 2021 09:05:47 -0700 (PDT) From: Alex Branham To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> <87y2e894x6.fsf@gmail.com> <87zgynbjy4.fsf@gmail.com> <874kgvfi2p.fsf@gmail.com> Date: Sun, 28 Mar 2021 12:05:46 -0400 In-Reply-To: <874kgvfi2p.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Sun, 28 Mar 2021 15:50:38 +0100") Message-ID: <87v99buuud.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47388-done Cc: "Basil L. Contovounesios" , Stefan Monnier , 47388-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun 28 Mar 2021 at 15:50, Jo=C3=A3o T=C3=A1vora w= rote: > Alex Branham writes: > >> On Sat 27 Mar 2021 at 12:53, Jo=C3=A3o T=C3=A1vora wrote: >> >> Thanks! It sounds like the below is what you're suggesting modes do in >> order to support all the possible eldoc+Emacs versions, let me know if >> I've misunderstood. >> >> (if (not (boundp 'eldoc-documentation-functions)) >> ;; old eldoc >> (add-function :before-until (local 'eldoc-documentation-function) >> #'ess-r-eldoc-function) >> ;; new eldoc >> (add-hook 'eldoc-documentation-functions #'ess-r-eldoc-function nil t) >> ;; new eldoc + Emacs 27.1 >> (when (and (fboundp 'eldoc-documentation-default)=20 >> (function-equal #'ignore eldoc-documentation-function)) >> (setq-local eldoc-documentation-function >> #'eldoc-documentation-default))) > > You don't need to be as complex as this: > > (if (not (boundp 'eldoc-documentation-strategy)) > (add-function :before-until (local 'eldoc-documentation-function) > #'ess-r-eldoc-function) > (add-hook 'eldoc-documentation-functions #'ess-r-eldoc-function nil t) > (when (function-equal #'ignore eldoc-documentation-function) > (setq-local eldoc-documentation-function #'eldoc-documentation-de= fault|compose|whatever)))) The fboundp check will avoid a byte compiler warning on Emacs<28. >> If that's right, it seems like a step backwards, ease-of-setup-wise at >> least, from the simple >> >> (add-function :before-until (local 'eldoc-documentation-function) >> #'ess-r-eldoc-function) > > You can still just that and call it a day. Just that, because the new > eldoc in the yet-unreleased Emacs 28 is backward compatible. I've tried > to explain this three times already in this exchange. Thanks. I'd like to support the new way (so users can customize eldoc-documentation-function) and the old way, which I thought I had said previously. It seems like the above is the officially blessed way to do both so I suppose that's what we'll go with. Thanks again, closing this bug report. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 28 12:37:58 2021 Received: (at 47388) by debbugs.gnu.org; 28 Mar 2021 16:37:58 +0000 Received: from localhost ([127.0.0.1]:46906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQYQH-0001Ax-TQ for submit@debbugs.gnu.org; Sun, 28 Mar 2021 12:37:58 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:48431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQYQG-0001Ak-89 for 47388@debbugs.gnu.org; Sun, 28 Mar 2021 12:37:56 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7655D10022F; Sun, 28 Mar 2021 12:37:50 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E903B100216; Sun, 28 Mar 2021 12:37:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1616949468; bh=cmIRTaZd0CAH7CDC0HlRjFKNqYgEBkj00eQecLJ7TM0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=I7X5c89wHY/yds0A3zzX/tua7wExGtZbK1fhbQ9f9AihUksGAEjAFR46N8R0t4dX7 0guSWxjIszTq77kMzPpPo1mf/EWBdQAoygqBf4hJfEamU9szprynwopQG89mL3VJYA dm4ZKr8wPnWQdmj5xL0AGiyswy3+A7HIN31CooC918VpMbz0YNXuUKzqZefmuZuawy 8ZmRhw3XPmuYeWCAO0opj6gVZ8muJnkU8o0RwH8QNC6ahzwTDQe4LiwlCuqvHeo1Gd 879V52K3ftW+oJBYHqTsQjoarADj6taFjTrxZc1seam/kxQLI1ndmsNwekNme3VfEn 6j5Rt17nzFaAg== Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B25C012023B; Sun, 28 Mar 2021 12:37:48 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc Message-ID: References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> <87y2e894x6.fsf@gmail.com> <87zgynbjy4.fsf@gmail.com> <874kgvfi2p.fsf@gmail.com> Date: Sun, 28 Mar 2021 12:37:47 -0400 In-Reply-To: <874kgvfi2p.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Sun, 28 Mar 2021 15:50:38 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.102 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47388 Cc: "Basil L. Contovounesios" , Alex Branham , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > (when (function-equal #'ignore eldoc-documentation-function) > (setq-local eldoc-documentation-function #'eldoc-documentation-default|compose|whatever)))) BTW, using code like the one above is tolerable, usually for historical reasons, but new APIs should aim not to need such things: comparing functions is fundamentally always a hack. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 28 14:45:58 2021 Received: (at 47388-done) by debbugs.gnu.org; 28 Mar 2021 18:45:59 +0000 Received: from localhost ([127.0.0.1]:47045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQaQA-0006Pv-Jy for submit@debbugs.gnu.org; Sun, 28 Mar 2021 14:45:58 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:45702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQaQ8-0006Ph-KI for 47388-done@debbugs.gnu.org; Sun, 28 Mar 2021 14:45:57 -0400 Received: by mail-wr1-f42.google.com with SMTP id j9so8912466wrx.12 for <47388-done@debbugs.gnu.org>; Sun, 28 Mar 2021 11:45:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=EFqdD9k2lUI+uYCSxyJgdPQltLmwBEhfsnpQoOwUaoU=; b=AoE/c/5sBl7ZWByEMd/TXFmKwjCuvJm0FuL7spD7oIKmzd1yzmkfGsPaAdQXJfQUQ0 JMlJmgU1mx3HUyyRkIB/VrG2RhqlnFlp1+Kp9dqXl+sFr8j//U8SaXbyJWurNSx3vGtY ZTWKy5bbakaI+teqZLOIOUA4bWyq5CB/A3ptdN3Lqgb7AU1OfipOrNWdEz1n8OyzP4oe SONzDvcIROn1+ZESk02VBMJ3LJG0BBr43CBEpga1WByZNhtZBvIcB9453GyHdyyrVd2e nvLExTvJnmlwvfwqRxE5dryW307HivZYareQYBeNtzV6yd0GgNZh2NxP34kfhfGFZieG U9+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=EFqdD9k2lUI+uYCSxyJgdPQltLmwBEhfsnpQoOwUaoU=; b=EgdkUXnSPDImuxqDbG9NF8UWjC/iduvYy86+XUfj2v0ubut3qNUHd6usnIpBTCXe7v WMaGUR3kZumHPVfmce/DVFbwEkZbLz5IyKrYRTR3LeVr0yhcI4dnnksm+oOm1Kmx7JfO 2xNSo7JsfYY4M8zIz3IN7kt34UbJNJU8Uf/W6Q59tHO8QhA0g8npAs7wHlWO28sMFOuD fiQ9vB9bZhGyK3YLjbHSl2+3QtLaTTjXdRnOnAn4pR0+BMSezC3VfgxLRCe2NOS+OMJ9 bvHs57Lve2mMv3P+Id73PnH1wYHUOxQZOwp8zty5PjURUnfRxfR58rqAULV3jY/sTbr5 exkg== X-Gm-Message-State: AOAM53346XD/v7n5gX5Ii5bNSdQWet+FiurOUjtw5JE1SNuefuKe1/Ql bBp04ilIAYWYb0tQ0OpC6dDQZk3I5CA= X-Google-Smtp-Source: ABdhPJyHLdRkW502htPek5iEq5NmkhyxYMlM7DmhM0MukUW243OwqzevjtUlop248aD405TOfsrw5g== X-Received: by 2002:adf:c64a:: with SMTP id u10mr24845675wrg.412.1616957150446; Sun, 28 Mar 2021 11:45:50 -0700 (PDT) Received: from krug (a94-133-179-151.cpe.netcabo.pt. [94.133.179.151]) by smtp.gmail.com with ESMTPSA id w131sm21868312wmb.8.2021.03.28.11.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Mar 2021 11:45:49 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Alex Branham Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> <87y2e894x6.fsf@gmail.com> <87zgynbjy4.fsf@gmail.com> <874kgvfi2p.fsf@gmail.com> <87v99buuud.fsf@gmail.com> Date: Sun, 28 Mar 2021 19:45:47 +0100 In-Reply-To: <87v99buuud.fsf@gmail.com> (Alex Branham's message of "Sun, 28 Mar 2021 12:05:46 -0400") Message-ID: <87wntrdsmc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47388-done Cc: "Basil L. Contovounesios" , Stefan Monnier , 47388-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alex Branham writes: >>> If that's right, it seems like a step backwards, ease-of-setup-wise at >>> least, from the simple >>> >>> (add-function :before-until (local 'eldoc-documentation-function) >>> #'ess-r-eldoc-function) >> >> You can still just that and call it a day. Just that, because the new >> eldoc in the yet-unreleased Emacs 28 is backward compatible. I've tried >> to explain this three times already in this exchange. > > Thanks. I'd like to support the new way (so users can customize > eldoc-documentation-function) and the old way, which I thought I had > said previously. It seems like the above is the officially blessed way > to do both so I suppose that's what we'll go with. No idea what the "above" is, let me just summarize the cases: (1) You have Emacs <=3D 27.1 and no new eldoc.el package (2) You have Emacs <=3D 27.1 and a new eldoc.el package (3) You have Emacs >=3D 28 The typical (fboundp 'eldoc-documentation-functions) check works great for cases 1 and 3: you support the new and the old way. Now, sometime in 2020 I introduced the possibility of delivering new Eldoc features to released versions, via the Eldoc ELPA "core" package. That gave rise to case 2: it's offering a new possiblity to support new Eldoc features early, it doesn't remove any possibilities. So: a) If you want to support the new Eldoc features in cases 2 and 3, you have to use the more complex snippet (with or without the byte-compiler warning, you decide if it bothers you) b) If, on the other hand, you just want to support 1 and 3, just use a check on emacs-major-version, instead of the fboundp check. c) If you're confident that your users won't be missing the new eldoc.el features in rss-mode specifically (there's a good chance they won't since it's presumably what they're used to in rss-mode), just use the simple :before-until snippet. And if these users do install something like Eglot, it will take care to do the right thing. d) If you want to only support 2 and 3, and join the wave of the future, you can: Just make the eldoc.el ELPA package a dependency of the rss-mode, much like Eglot. So I think you have lots of options here. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 28 14:56:23 2021 Received: (at 47388) by debbugs.gnu.org; 28 Mar 2021 18:56:23 +0000 Received: from localhost ([127.0.0.1]:47049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQaaE-0006e7-Nf for submit@debbugs.gnu.org; Sun, 28 Mar 2021 14:56:22 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:43540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQaaD-0006dw-HH for 47388@debbugs.gnu.org; Sun, 28 Mar 2021 14:56:22 -0400 Received: by mail-wr1-f42.google.com with SMTP id x7so10640718wrw.10 for <47388@debbugs.gnu.org>; Sun, 28 Mar 2021 11:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=OhXPRlyOpLkah8CiReMcGt8wkPhf5btGCmUuzAFpM9M=; b=t5WL5YC0Wr/7i5DqbN5W3FxB0cRmdNdf0tPtnIw/lOMfMd5vroHajd14sVylnu8Hha zpmYywmDbsCjO1WopGPKRuxfuAgerqe9j0oVdDtdQWYEGDEGHAcbo6qxZqGn5AFn+uLj UzTzaAHp0bsnFTUsz2CI2wUsqM6eOeXkF0Uees0OcKb5DN4+vNNwOtGeDnx5WXszFv+l ngIXgqw4hPoNLULrUUFE1FbCcvZm0cnUYa6+Y/iXBDwPlzSmDBdFQKM0eyA97byJIQ0o ABDa4AYZskygmGjTRGqx4PihqSTprwRxnSIkt3JwhlADG29tdoLbsEhy5oFsFQGVh1vu 2cOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=OhXPRlyOpLkah8CiReMcGt8wkPhf5btGCmUuzAFpM9M=; b=A0YDEwwSPRHIe9vBMO/O0vTCLY7WCJXPO/Ht3E2NUK4Fc9XUG+p0JkWNCLKmRHXKcS EE13BTQV7hS1hBS36uNilxlFH1Wfkb6PBV3tRs/vdFwO2bb/RJUIG4TfQD0ELqhO0obS rn0NrzYvmUzIZXKNA5m0ad7dj4nWFFATWUDstnKMHVXLHaAAzTiuFv2DbHOT1uBqFgQ2 fYrN9AKvpTOJbV2UrcbPnlq4XPwT/jHxDc0XoOEcj5XF9NrrUsOJigoAUcb0cSEn6CNI N5kVJb6zCr43FM3X13RQtXvHxIZenOQ6opu+Gx6TIbWRZsH1dTlCrUrhydQNubGife5Y 4rUw== X-Gm-Message-State: AOAM531LFFNhg1JX9dZHcSdAq7/1DGV8QwLAHSbq52rKwPjsmPAvu3qB XUQpA4FanYqg71FDwXkTQyIQmXdjQz8= X-Google-Smtp-Source: ABdhPJzVsnbyXNqyT+4y9N1XZxNcrfx4FIN4OzEYDBtD6Kb35ywxgsmcW1VcURMOOTZZej6DuqtAQg== X-Received: by 2002:adf:ba87:: with SMTP id p7mr25349579wrg.298.1616957775416; Sun, 28 Mar 2021 11:56:15 -0700 (PDT) Received: from krug (a94-133-179-151.cpe.netcabo.pt. [94.133.179.151]) by smtp.gmail.com with ESMTPSA id x14sm25095537wrw.13.2021.03.28.11.56.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Mar 2021 11:56:14 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Stefan Monnier Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> <87y2e894x6.fsf@gmail.com> <87zgynbjy4.fsf@gmail.com> <874kgvfi2p.fsf@gmail.com> Date: Sun, 28 Mar 2021 19:56:13 +0100 In-Reply-To: (Stefan Monnier's message of "Sun, 28 Mar 2021 12:37:47 -0400") Message-ID: <87r1jzds4y.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47388 Cc: "Basil L. Contovounesios" , Alex Branham , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> (when (function-equal #'ignore eldoc-documentation-function) >> (setq-local eldoc-documentation-function #'eldoc-documentation-d= efault|compose|whatever)))) > > BTW, using code like the one above is tolerable, usually for historical > reasons, but new APIs should aim not to need such things: comparing > functions is fundamentally always a hack. So is run-time version checking, the risk is mostly the same. But sure, it's way uglier. It's what needs to be done, as long as the package developer want to support these features on a "as soon as possible" basis _without_ adding the Eldoc core package as dependency. But a simple version check on (< emacs-major-version 28) with two simple branches works fine as well. (if (< emacs-major-version 28) (the-before-until-thingy) (the-modern-thingy-but-no-comparing-functions)) Anyway, have you given thought to the possibility of having Eldoc.el clobber the default value of eldoc-documentation-function if it finds it unchanged? This would just fix the case of Emacs < 28 && new eldoc for developers who don't want to write the above snippet. Not sure if it's worth it, but Alex's original request goes in this direction. Note that that all this mess has to do with the silliness that is having eldoc.el be preloaded just becuase elisp-mode.el. How would we go about fixing that? Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 28 15:10:06 2021 Received: (at 47388) by debbugs.gnu.org; 28 Mar 2021 19:10:06 +0000 Received: from localhost ([127.0.0.1]:47054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQanV-0006yh-VG for submit@debbugs.gnu.org; Sun, 28 Mar 2021 15:10:06 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQanU-0006y6-3t for 47388@debbugs.gnu.org; Sun, 28 Mar 2021 15:10:04 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 64AED10022F; Sun, 28 Mar 2021 15:09:58 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1CE03100216; Sun, 28 Mar 2021 15:09:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1616958597; bh=kkdmXlMFizO3kRh+Geaz2Rg3ZSi2b6vtBb/I6YhwZgk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Jr2qOV7eJNxSOLDZM8dOvrp/uLUM0NC4JXaPfUc+TaLo5s9PYJ+dMfYkcHZY4v/sP iWPrdAroRwU/+DpfHYo2LTCCw27ymgyrhUlJhXJhqM17IWYvhZU/JRxxuTcZh0R85Z ykNF3KbEDN0MG2fk/5JxnOxGXWd0v7jg7O+mIo4ml5ShmnsvQFUyO5NVWasYTWmRIE KNRvtv2ec/S10UPlM7cWg9SfYg4q/7psqhmA8TnJCH5jnGyzOcmzDlJ35zh06DWiuJ PIfgQYfwb4U+OUDtSdvGTFtGKhVLNKZkP+Vj5ETp4JLE4pc43fckpv/EunytNSc98p CcNdukmO0YROQ== Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D70E81203D7; Sun, 28 Mar 2021 15:09:56 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc Message-ID: References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> <87y2e894x6.fsf@gmail.com> <87zgynbjy4.fsf@gmail.com> <874kgvfi2p.fsf@gmail.com> <87r1jzds4y.fsf@gmail.com> Date: Sun, 28 Mar 2021 15:09:56 -0400 In-Reply-To: <87r1jzds4y.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Sun, 28 Mar 2021 19:56:13 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.102 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47388 Cc: "Basil L. Contovounesios" , Alex Branham , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Note that that all this mess has to do with the silliness that is having > eldoc.el be preloaded just becuase elisp-mode.el. How would we go about > fixing that? We could stop preloading `elisp-mode`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 28 15:15:31 2021 Received: (at 47388) by debbugs.gnu.org; 28 Mar 2021 19:15:31 +0000 Received: from localhost ([127.0.0.1]:47059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQask-00076d-M8 for submit@debbugs.gnu.org; Sun, 28 Mar 2021 15:15:30 -0400 Received: from mail-il1-f181.google.com ([209.85.166.181]:35523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQasj-00076P-0x for 47388@debbugs.gnu.org; Sun, 28 Mar 2021 15:15:29 -0400 Received: by mail-il1-f181.google.com with SMTP id 19so9510135ilj.2 for <47388@debbugs.gnu.org>; Sun, 28 Mar 2021 12:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VCR4drNgfY6JdoW3J6ltgM8PdkVWv18WlCFA05mAv+o=; b=tsZZeo7Kbaqd0cT/HhC6IW8cRFb8d/6z2bCXrhT8+op4rf/CHEnxiNXBiptSKlrGFl TtexcLH4tm0VrTsr/2C4TZmqhH143pzg9bV3mtlsy+X5MA0N+jnb2QGvWQAWi1TcbwyS qfjQPVNZhX1W7C48DBAVnjybPK/i2rmqX2bM9bvNJQdj3zN5Pui1hm+S5IR8reGY+sq1 TjkcUEskKhrtB1BrKWXWNWQ6iNztaZGze8BzabT/TD04B1r0Xefq5RjM3hDrpMvn9kHU KgLycZml1Xua0jZNxZgCjCrcP59o+KnnxdoaMbjonduG/7NANmFfxcKc+U/daiPNWy7M yA2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VCR4drNgfY6JdoW3J6ltgM8PdkVWv18WlCFA05mAv+o=; b=hOCs71ahVqg7XB2Gs/ZVgSta76td092FLcNTbrXHrN+iTdPdAKN8/FVNTyTjd+r2IL Eav8sw2i927FzKh9gBiKpPQWQi5oeO7UKoROOAQSSd62N9+1yMYZdEibsvRCUTMSCLSb hTumIHY7MC+cB66/d4pvhmrT1R4ck8nssSPrhQLGnACPseHwwlZLFsNe1hH9mTTqwP3N 901EtHCupsaYM4V+ObXGNV/DB/s6yaVfbcTB2QZmIXLpHPHZhrlbqg+d3zFyHSnWfhmy F6z9tivDDnJhHtxvb1B4+hPd/m6N2NOcqma5kNbiUir1GmLSWT7lGNUil9xrJgcOKOEx mxaA== X-Gm-Message-State: AOAM530s9M7iqKxJuJ0oTPfTN1UPDizYhXI02Bv4iuTtJmG9i8MkodTa XRZX3hSr90uxju5apjsIUOp0GuBgqcRibPkNyWw= X-Google-Smtp-Source: ABdhPJyyPr6ZhRiOKFcnJ8PSGe113QCvQLIWc/gjDeiahqQua4b9sG6KHDLw3N3SbwJ9nxWpv7tjsM5DDhpJ1Q/MqDU= X-Received: by 2002:a92:da48:: with SMTP id p8mr17454406ilq.137.1616958923281; Sun, 28 Mar 2021 12:15:23 -0700 (PDT) MIME-Version: 1.0 References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> <87y2e894x6.fsf@gmail.com> <87zgynbjy4.fsf@gmail.com> <874kgvfi2p.fsf@gmail.com> <87r1jzds4y.fsf@gmail.com> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sun, 28 Mar 2021 19:15:12 +0000 Message-ID: Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc To: Stefan Monnier Content-Type: multipart/alternative; boundary="0000000000003d18c105be9d9673" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47388 Cc: "Basil L. Contovounesios" , Alex Branham , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000003d18c105be9d9673 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Mar 28, 2021 at 8:09 PM Stefan Monnier wrote: > > Note that that all this mess has to do with the silliness that is havin= g > > eldoc.el be preloaded just becuase elisp-mode.el. How would we go abou= t > > fixing that? > > We could stop preloading `elisp-mode`. Even better, but can you say why it's even preloaded at all? Certainly not somebody's whim, right? Jo=C3=A3o --0000000000003d18c105be9d9673 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Sun, Mar 28, 2021 at 8:09 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
<= /div>
> Note that that = all this mess has to do with the silliness that is having
> eldoc.el be preloaded just becuase elisp-mode.el.=C2=A0 How would we g= o about
> fixing that?

We could stop preloading `elisp-mode`.

Even better, but can you say why it's even preloaded at all?
Certainly not somebody's whim, right?

Jo= =C3=A3o
--0000000000003d18c105be9d9673-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 28 15:36:16 2021 Received: (at 47388) by debbugs.gnu.org; 28 Mar 2021 19:36:16 +0000 Received: from localhost ([127.0.0.1]:47078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQbCq-0007c4-7Z for submit@debbugs.gnu.org; Sun, 28 Mar 2021 15:36:16 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQbCn-0007br-Jq for 47388@debbugs.gnu.org; Sun, 28 Mar 2021 15:36:15 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EBCF1809CB; Sun, 28 Mar 2021 15:36:07 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 97B1380252; Sun, 28 Mar 2021 15:36:06 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1616960166; bh=dJcU30b9iYLQAqdIny9p2t2h+U5EBWr6plWHoqMy0/o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=j+1viWL5/cxgJSyAI9CJajje4NeDSrRIaF+Ius7E3gx8mMPj9qw8sAOOg8HWYgj2h XCm40VAUq7fsj7XB0cyH/hVhxg9x5qsTMca87VEp2ivYjjXpRt/rdiYFWyrwXytQsv yxwAJuNVgxqq4nqiJi4U2SEMs7zzkAuaweVsp2w3wxi+P4Tbv6fcAOOQUXyr2kfQU1 4kvBg08ZqDRCPaF8Tf0yr6psdaMhyXKDbN9EUWV5z2ctDJW94i+kN1c9bOSOBu/esi ZHjPZvCh78AMlvVilH1tIUIJpvf8DXAyQp6qH6R4QKD/uHgFRf6Ob4WePO+CKH7G/v To5CYzzz2tI7w== Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5A670120255; Sun, 28 Mar 2021 15:36:06 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc Message-ID: References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> <87y2e894x6.fsf@gmail.com> <87zgynbjy4.fsf@gmail.com> <874kgvfi2p.fsf@gmail.com> <87r1jzds4y.fsf@gmail.com> Date: Sun, 28 Mar 2021 15:36:05 -0400 In-Reply-To: (=?windows-1252?Q?=22Jo=E3o_T=E1vora=22's?= message of "Sun, 28 Mar 2021 19:15:12 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.099 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47388 Cc: "Basil L. Contovounesios" , Alex Branham , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> > Note that that all this mess has to do with the silliness that is having >> > eldoc.el be preloaded just becuase elisp-mode.el. How would we go about >> > fixing that? >> We could stop preloading `elisp-mode`. > Even better, but can you say why it's even preloaded at all? > Certainly not somebody's whim, right? The code for `emacs-lisp-mode` used to be in `lisp-mode.el` which also contains various functions useful in all modes, so it's been preloaded since before I started using Emacs. When I moved (some of) the code to `progmodes/elisp-mode.el` I just preserved that pre-existing situation. I don't know for a fact, but based on my vague memory of what's in `elisp-mode.el` I don't think there's a strong technical reason to preload it. IOW it's only preloaded because we expect it would be loaded sooner or later anyway in many/most Emacs sessions. I don't know if it's indeed the case (tho it is clearly the case for *my* sessions), so you could try to float the idea on `emacs-devel`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 28 15:37:51 2021 Received: (at 47388) by debbugs.gnu.org; 28 Mar 2021 19:37:52 +0000 Received: from localhost ([127.0.0.1]:47083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQbEN-0007eO-Kq for submit@debbugs.gnu.org; Sun, 28 Mar 2021 15:37:51 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQbEM-0007eC-Fk for 47388@debbugs.gnu.org; Sun, 28 Mar 2021 15:37:50 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 75B3344141D; Sun, 28 Mar 2021 15:37:45 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3E7CE441419; Sun, 28 Mar 2021 15:37:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1616960264; bh=fFYOTvemO33SU49n6HXBlNFxFRvtAmPVZbishJSGzH8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=J4hQ7mbB8JwHWsKu0348ADyvl4ooKB/N2GStBRbNLuyoeP6xplqGZa1sFVc4GgYy8 8qFdMdYUDjy6L4Ml6tV00UAGP4ZhnaLp+RTN0PdDENrr2csjqB6w2/jOGNyqa3ATv2 keNLBt4vkqJNzcO7xYtk7P6csrQ5NjIlPkmBeQtMX/SQo7tPLcZehyZi1bek26tv7b 6IZt7YxMlkR6ATACj30HhaiVNT+nx+MWXFoJNKk/osVyQ3cPgNKytQkXvXCnCtmrtw WHGvWNBp0JebqND0hw9KQUyCJ+fcnDRnRhnjNMKyS3aGIKqP5uhJCjoioxgKWSdsXk RYYjsT+5waZ8Q== Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AD2B012047D; Sun, 28 Mar 2021 15:37:43 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc Message-ID: References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> <87y2e894x6.fsf@gmail.com> <87zgynbjy4.fsf@gmail.com> <874kgvfi2p.fsf@gmail.com> <87r1jzds4y.fsf@gmail.com> Date: Sun, 28 Mar 2021 15:37:42 -0400 In-Reply-To: <87r1jzds4y.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Sun, 28 Mar 2021 19:56:13 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.104 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47388 Cc: "Basil L. Contovounesios" , Alex Branham , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Note that that all this mess has to do with the silliness that is having > eldoc.el be preloaded just becuase elisp-mode.el. How would we go about > fixing that? BTW, note also that the reason `eldoc.el` is preloaded is because `global-eldoc-mode` is enabled by default, rather than because `elisp-mode` is itself preloaded. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 28 15:39:11 2021 Received: (at 47388) by debbugs.gnu.org; 28 Mar 2021 19:39:11 +0000 Received: from localhost ([127.0.0.1]:47088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQbFf-0007gb-10 for submit@debbugs.gnu.org; Sun, 28 Mar 2021 15:39:11 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQbFd-0007gP-AN for 47388@debbugs.gnu.org; Sun, 28 Mar 2021 15:39:09 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0E5F010022F; Sun, 28 Mar 2021 15:39:04 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C4A8D100216; Sun, 28 Mar 2021 15:39:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1616960342; bh=lKUhDY89XEy6lFd4yTNiA2606GZJSFEUmv3zlP25ZGQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=dPRqUlFfpwCS13oxpu8y7QzDlf13doUggMr4rDWOZ+IqCUo6k0Pdf7hE2u2JtkVWa In7TRnKk55EQWm4olFj0aPi7wPg7z50jccr4fb6A8U3GlgoSib3zaEYm9I8evhUzCx u8ngLRJ31U9/e0OSbprie8EX9J+/lUPTVuS7iG3C95fqtW9hzZTDpTA0gLeX1qUjKI DB6JCscTDNZE4Sy3tly+ckrJnryfcJ9BjbAr/gDA0iHuWUidSIWf4wgXQXUYT71LuV TD/bPpEunvBJPrsLXLS6aPCghu2Nv2gcAC8HfpsvwuAzJlnJokcbeRgAeNHT9OuDZV pBBNjSRuwLUVw== Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9083912024A; Sun, 28 Mar 2021 15:39:02 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Subject: Re: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc Message-ID: References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> <87y2e894x6.fsf@gmail.com> <87zgynbjy4.fsf@gmail.com> <874kgvfi2p.fsf@gmail.com> <87r1jzds4y.fsf@gmail.com> Date: Sun, 28 Mar 2021 15:39:01 -0400 In-Reply-To: <87r1jzds4y.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Sun, 28 Mar 2021 19:56:13 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.102 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47388 Cc: "Basil L. Contovounesios" , Alex Branham , 47388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>> (when (function-equal #'ignore eldoc-documentation-function) >>> (setq-local eldoc-documentation-function >>> #'eldoc-documentation-default|compose|whatever)))) >> >> BTW, using code like the one above is tolerable, usually for historical >> reasons, but new APIs should aim not to need such things: comparing >> functions is fundamentally always a hack. > > So is run-time version checking, the risk is mostly the same. I just wanted to make sure that it's only needed for backward compatibility reasons. Stefan From unknown Sun Jun 22 11:44:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 26 Apr 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator