Subject: make check confused by ../../expect/expect directory

From: Rainer Orth <[email-masked]>
Date: Thu, 25 Mar 2021 13:24:56 +0100

When running make check on Solaris, I initially got lots of failures
like the following:

Running /vol/src/gnu/dejagnu/dejagnu-1.6.3-rc1/testsuite/runtest.libs/libs.exp .
..
ERROR: tcl error sourcing /vol/src/gnu/dejagnu/dejagnu-1.6.3-rc1/testsuite/runte
st.libs/libs.exp.
ERROR: tcl error code POSIX EACCES {permission denied}
ERROR: couldn't execute "/vol/gcc/obj/dejagnu/dejagnu-1.6.3-rc1/../../expect/exp
ect": permission denied
    while executing
"spawn $EXPECT"
    (procedure "start_expect" line 10)
    invoked from within
"start_expect"
    (file "/vol/src/gnu/dejagnu/dejagnu-1.6.3-rc1/testsuite/runtest.libs/libs.ex
p" line 99)
    invoked from within
"source /vol/src/gnu/dejagnu/dejagnu-1.6.3-rc1/testsuite/runtest.libs/libs.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source /vol/src/gnu/dejagnu/dejagnu-1.6.3-rc1/testsuite/runtest.libs
/libs.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name" msg"

It turns out that there I happened to have a ../../expect/expect
directory there.

Unfortunately, lib/runtest.exp (findfile), which is called from at the
beginning of testsuite/lib/runtest.exp, only uses "file exists" which
also works for directories, thus the diagnosis.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University