GNU bug report logs - #4737
23.1.50; C-j in *scratch* after a hash table constant errors with void-function

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4737 in the body.
You can then email your comments to 4737 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Aidan Kehoe <kehoea <at> parhasard.net>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.1.50; C-j in *scratch* after a hash table constant errors with void-function 
Date: Fri, 16 Oct 2009 15:40:12 +0100

Hello!

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug <at> gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

In *scratch*: 

(progn
  (setq print-length nil)
  (make-hash-table)) 
=> #s(hash-table size 65 test eql rehash-size 1.5 rehash-threshold 0.8 data ())

#s(hash-table size 65 test eql rehash-size 1.5 rehash-threshold 0.8 data
 ())
=> 
Debugger entered--Lisp error: (void-function hash-table)
  (hash-table size 65 test eql rehash-size 1.5 rehash-threshold 0.8 data nil)
  eval((hash-table size 65 test eql rehash-size 1.5 rehash-threshold 0.8 data nil))
  eval-last-sexp-1(t)
  eval-last-sexp(t)
  eval-print-last-sexp()
  call-interactively(eval-print-last-sexp nil nil)

However, this succeeds: 

(car (list
      #s(hash-table size 65 test eql rehash-size 1.5 rehash-threshold 0.8 data ())))
=> #s(hash-table size 65 test eql rehash-size 1.5 rehash-threshold 0.8 data ())

XEmacs handles the problem in #'forward-sexp, details here: 

http://hg.debian.org/hg/xemacs/xemacs/file/a27de91ae83c/lisp/lisp.el#l55

When I use the XEmacs version of #'forward-sexp, the problem goes away. 

Goodbye, 

Aidan

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/Sources/emacs/nextstep/Emacs.app/Contents/Resources/etc/DEBUG for instructions.


In GNU Emacs 23.1.50.1 (i386-apple-darwin8.11.1, NS apple-appkit-824.48)
 of 2009-09-30 on bonbon
Windowing system distributor `Apple', version 10.3.824
configured using `configure  '--with-ns' '--enable-asserts' '--enable-maintainer-mode' '--enable-cocoa-experimental-ctrl-g' '--with-xpm' '--with-jpeg' '--with-tiff' '--with-png' 'LDFLAGS=-L/opt/local/lib -L/usr/X11R6/lib -L/usr/local/lib' 'CPPFLAGS=-I/opt/local/include -I/usr/X11R6/include -I/usr/local/include''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-v C-v C-v C-v C-v C-v 
C-v C-v C-v C-v <escape> v C-v C-v C-v C-v C-v <prior> 
<next> <next> <prior> <prior> <prior> <prior> <prior> 
<prior> <prior> <prior> <prior> C-x b * s c <tab> <return> 
( k i l l e C-a C-k <f1> v p r i n t - l e <tab> n 
<tab> <return> C-x o C-n C-n C-n C-n C-n C-e C-b C-b 
C-b C-b <return> C-x o C-n C-x o C-e C-b C-b C-b <return> 
C-x o C-x b * s c <tab> C-g C-x o C-n C-n C-x o C-x 
b * s c <tab> <return> <escape> > <return> <return> 
( s e t q SPC e v a l - e x p r e s s i o n - p r i 
n t - l e n g t h SPC n i l ) C-j C-p C-p C-p C-p C-p 
C-p C-e C-j C-p C-d C-d ( l e n g t h SPC ' C-e ) C-j 
C-x o C-x o C-p C-p C-n C-n C-n C-p C-p C-p C-p C-k 
C-k C-k C-p C-e C-j C-p C-e C-j q <escape> x r e p 
o r t - e m a c s - b u g C-g C-p <return> <return> 
C-p ( c o n s SPC . C-a ( c a r SPC C-e C-n C-e <backspace> 
) <return> <tab> n i l ) ) C-j C-x o C-p C-p C-f C-f 
C-f C-f C-f C-f C-f C-f C-d C-n C-n C-j C-x o q <escape> 
x r e p o r t - e m a c s - b u g <return>

Recent messages:
Making completion list...
Type C-x 1 to delete the help window.
uncompressing simple.el.gz...done
Quit
Mark set
Entering debugger...
Back to top level.
Quit
Entering debugger...
Back to top level.

-- 
¿Dónde estará ahora mi sobrino Yoghurtu Nghe, que tuvo que huir
precipitadamente de la aldea por culpa de la escasez de rinocerontes?

Message #10 received at 4737 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Aidan Kehoe <kehoea <at> parhasard.net>
Cc: 4737 <at> debbugs.gnu.org
Subject: 23.1.50; C-j in *scratch* after a hash table constant errors with void-function
Date: Sat, 17 Oct 2009 23:43:46 -0400

> In *scratch*:
>
> (progn
>   (setq print-length nil)
>   (make-hash-table))
> => #s(hash-table size 65 test eql rehash-size 1.5 rehash-threshold 0.8 data ())
>
> #s(hash-table size 65 test eql rehash-size 1.5 rehash-threshold 0.8 data
>  ())
> =>
> Debugger entered--Lisp error: (void-function hash-table)
>   (hash-table size 65 test eql rehash-size 1.5 rehash-threshold 0.8 data nil)
>   eval((hash-table size 65 test eql rehash-size 1.5 rehash-threshold 0.8 data nil))
>   eval-last-sexp-1(t)
>   eval-last-sexp(t)
>   eval-print-last-sexp()
>   call-interactively(eval-print-last-sexp nil nil)

> However, this succeeds:

> (car (list
>       #s(hash-table size 65 test eql rehash-size 1.5 rehash-threshold 0.8 data ())))
> => #s(hash-table size 65 test eql rehash-size 1.5 rehash-threshold 0.8 data ())

> XEmacs handles the problem in #'forward-sexp

I think it's safer to handle it in preceding-sexp.  Could you test the
patch below?


*** emacs/lisp/emacs-lisp/lisp-mode.el.~1.247.~	2009-09-27 18:51:01.000000000 -0400
--- emacs/lisp/emacs-lisp/lisp-mode.el	2009-10-17 23:41:53.000000000 -0400
***************
*** 673,678 ****
--- 673,682 ----
  	  (when (eq (preceding-char) ??)
  	    (forward-char -1)))
  
+ 	;; Skip over hash table read syntax
+ 	(when (looking-back "#s")
+ 	  (forward-char -2))
+ 
  	;; Skip over `#N='s.
  	(when (eq (preceding-char) ?=)
  	  (let (labeled-p)

Message #15 received at 4737 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 4737 <at> debbugs.gnu.org, Aidan Kehoe <kehoea <at> parhasard.net>
Subject: Re: bug#4737: 23.1.50; C-j in *scratch* after a hash table constant errors with void-function
Date: Sun, 18 Oct 2009 10:43:05 -0400

> + 	;; Skip over hash table read syntax
> + 	(when (looking-back "#s")
> + 	  (forward-char -2))

Calling looking-back without a limit argument is asking for trouble (it
has complexity O(size of buffer) or worse).


        Stefan

Message #20 received at 4737 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, 4737 <at> debbugs.gnu.org
Cc: Chong Yidong <cyd <at> stupidchicken.com>, Aidan Kehoe <kehoea <at> parhasard.net>
Subject: Re: bug#4737: 23.1.50;	C-j in *scratch* after a hash table constant
 errors with	void-function
Date: Sun, 18 Oct 2009 17:34:12 +0200

> Calling looking-back without a limit argument is asking for trouble (it
> has complexity O(size of buffer) or worse).

Then we should make the limit argument non-optional.

martin

Message #25 received at 4737-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 4737-done <at> debbugs.gnu.org, Aidan Kehoe <kehoea <at> parhasard.net>
Subject: Re: bug#4737: 23.1.50; C-j in *scratch* after a hash table constant errors with void-function
Date: Sun, 18 Oct 2009 18:28:32 -0400

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> + 	;; Skip over hash table read syntax
>> + 	(when (looking-back "#s")
>> + 	  (forward-char -2))
>
> Calling looking-back without a limit argument is asking for trouble (it
> has complexity O(size of buffer) or worse).

I've checked in the patch, with a limit argument.  Thanks for pointing
this out.

Message #30 received at 4737 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 4737 <at> debbugs.gnu.org, Chong Yidong <cyd <at> stupidchicken.com>,
        Aidan Kehoe <kehoea <at> parhasard.net>
Subject: Re: bug#4737: 23.1.50;	C-j in *scratch* after a hash table constant errors with	void-function
Date: Sun, 18 Oct 2009 22:06:00 -0400

>> Calling looking-back without a limit argument is asking for trouble (it
>> has complexity O(size of buffer) or worse).

> Then we should make the limit argument non-optional.

Feel free to do that,


        Stefan


PS: Now that we can do it compatibly via set-advertised-calling-convention.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.