GNU bug report logs - #47356
[PATCH 0/2] Two Emacs packages related to Julia

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#47356: closed ([PATCH 0/2] Two Emacs packages related to Julia)
Date: Wed, 31 Mar 2021 07:20:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 31 Mar 2021 08:19:31 +0100
with message-id <87mtujzt6k.fsf <at> cbaines.net>
and subject line Re: [bug#47356] [PATCH 2/2] gnu: Add emacs-julia-snail.
has caused the debbugs.gnu.org bug report #47356,
regarding [PATCH 0/2] Two Emacs packages related to Julia
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
47356: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47356
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: zimoun <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH 0/2] Two Emacs packages related to Julia
Date: Wed, 24 Mar 2021 04:01:51 +0100

Hi,

This patch adds 2 Emacs packages to deal with Julia.  Since I am not confident
with what is the inputs / propagated-inputs, please give a look.  From my
understanding and experiments, it seems to make sense.

Last, the most recent version tagged 1.0.0rc5 of 'emacs-julia-snail' uses the
Julia package 'CSTParser' which is not packaged yet on the Julia side.  It is
straightforward since that depends only on another Julia package.

However, importing all the (gnu packages julia-xyz) module in (gnu packages
emacs-xyz)---or conversely---does not make sense, IMHO.

Waiting progress on the side of Julia packages, let consider this 'rc4'
version using an ELisp parser for the Julia language.

Last, 'emacs-julia-snail' requires the package 'julia' to work.  Since 'M-x
julia-snail' runs a "server" with the code JuliaSnail.jl.  From my
understanding of the standards, this package 'julia' is not propagated.  Does
it make sense?

Cheers,
simon


zimoun (2):
  gnu: Add emacs-julia-repl.
  gnu: Add emacs-julia-snail.

 gnu/packages/emacs-xyz.scm | 64 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)


base-commit: 8b2b5463963d5d4dee480b0cf73fa4a9eca414ba
-- 
2.29.2

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 47356-done <at> debbugs.gnu.org
Subject: Re: [bug#47356] [PATCH 2/2] gnu: Add emacs-julia-snail.
Date: Wed, 31 Mar 2021 08:19:31 +0100

[Message part 4 (text/plain, inline)]

zimoun <zimon.toutoune <at> gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-julia-snail): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 40 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 2d26cae5ca..71b88cca07 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -8720,6 +8720,46 @@ the help system and the debugger.  It is recommended that you use this minor
>  mode with the package emacs-julia-mode.")
>      (license license:expat)))
>  
> +(define-public emacs-julia-snail
> +  (package
> +    (name "emacs-julia-snail")
> +    (version "1.0.0rc4")               ;rc5 requires CSTParser (julia package)
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/gcv/julia-snail")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "065ix3jycsx3wvkq7a6060i93caxisdvgxgqb1l6rq15n4qln78y"))))
> +    (build-system emacs-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'JuliaSnail-jl
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out(assoc-ref outputs "out")))

I added a space here after out.

> +               (install-file "JuliaSnail.jl"
> +                             (string-append out "/share/emacs/site-lisp/")))
> +             #t)))))
> +    (inputs
> +     `(("emacs-dash" ,emacs-dash)
> +       ("emacs-s" ,emacs-s)
> +       ("emacs-spinner" ,emacs-spinner)
> +       ("emacs-xref" ,emacs-xref)))
> +    (propagated-inputs
> +     `(("libvterm" ,libvterm)
> +       ("emacs-julia-mode" ,emacs-julia-mode) ;required by parser
> +       ("emacs-parsec" ,emacs-parsec)         ;required by parser
> +       ("emacs-vterm" ,emacs-vterm)))
> +    (home-page "https://github.com/gcv/julia-snail")
> +    (synopsis "Development environment and REPL interaction package for Julia")
> +    (description "This package provides a development environment and REPL
> +interaction package for Julia in the spirit of Common Lisp’s SLIME and
> +Clojure’s CIDER.  It enables convenient and dynamic REPL-driven development.")
> +    (license license:gpl3)))
> +
>  (define-public emacs-smex
>    (package
>      (name "emacs-smex")

Both patches look good to me, and they build at least. They're on master
as of f27bdad0a7a3c3d6edbfa2c6809f19592fe5ba56.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.