GNU bug report logs - #47333
[PATCH 2/2] Enable test of minetest

Previous Next

Full log

Message #13 received at 47333 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: la snesne <lasnesne <at> lagunposprasihopre.org>, 47333 <at> debbugs.gnu.org
Subject: Re: [bug#47333] [PATCH 2/2] Enable test of minetest
Date: Tue, 23 Mar 2021 08:31:36 +0100

[Message part 1 (text/plain, inline)]

On Tue, 2021-03-23 at 09:06 +0900, la snesne wrote:
> -       #:tests? #f))                    ;no check target
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda _
> +             (setenv "HOME" "/tmp")
> +             (invoke (string-append "../" ,name "-" ,version
> +                                    "-checkout/bin/minetest")
> +                     "--run-unittests")
> +             #t)))))

For most packages, this is unlikely to work when cross-compiling.
I suggest replacing it with something like

> +           (unless ,(%current-target-system)
> +             (invoke (string-append "../" ,name "-" ,version
> +                                    "-checkout/bin/minetest")
> +                     "--run-unittests"))
> +           #t

Well, cross-compiling minetest won't work anyway as a dependency is not
cross-compilable:

$ guix build minetest --target=aarch64-linux-gnu
$ guix build: error: gnu/packages/gl.scm:236:2: mesa <at> 20.2.4: build system `meson' does not support cross builds

(and I see little reason to cross-compilable minetest)
... but it still seems a good idea to avoid introducing new
cross-compilation issues when we can avoid it.

Greetings,
Maxime

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.