Subject: Re: [bug#47333] [PATCH 2/2] Enable test of minetest

From: Maxime Devos <[email-masked]>
Date: Tue, 23 Mar 2021 08:31:36 +0100

On Tue, 2021-03-23 at 09:06 +0900, la snesne wrote:
> -       #:tests? #f))                    ;no check target
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda _
> +             (setenv "HOME" "/tmp")
> +             (invoke (string-append "../" ,name "-" ,version
> +                                    "-checkout/bin/minetest")
> +                     "--run-unittests")
> +             #t)))))

For most packages, this is unlikely to work when cross-compiling.
I suggest replacing it with something like

> +           (unless ,(%current-target-system)
> +             (invoke (string-append "../" ,name "-" ,version
> +                                    "-checkout/bin/minetest")
> +                     "--run-unittests"))
> +           #t

Well, cross-compiling minetest won't work anyway as a dependency is not
cross-compilable:

$ guix build minetest --target=aarch64-linux-gnu
$ guix build: error: gnu/packages/gl.scm:236:2: [email-masked]: build system `meson' does not support cross builds

(and I see little reason to cross-compilable minetest)
... but it still seems a good idea to avoid introducing new
cross-compilation issues when we can avoid it.

Greetings,
Maxime