GNU bug report logs - #47314
[Patch] two r packages (chromstardata and signac)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#47314: closed ([Patch] two r packages (chromstardata and signac))
Date: Mon, 22 Mar 2021 13:40:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 22 Mar 2021 14:39:09 +0100
with message-id <877dlzwbnm.fsf <at> elephly.net>
and subject line [Patch] two r packages (chromstardata and signac)
has caused the debbugs.gnu.org bug report #47314,
regarding [Patch] two r packages (chromstardata and signac)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
47314: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47314
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: hong li <hongli520 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [Patch] two r packages (chromstardata and signac)
Date: Mon, 22 Mar 2021 11:12:07 +0100

[Message part 3 (text/plain, inline)]

Dear Guixer,

I have sent a email last week to add two r packages into guix, here is the
patch.
please help to add them to the guix store.
Thanks.

best regards,
Hong Li

[Message part 4 (text/html, inline)]

[0001-adding-r-chromstardata-and-r-signac-packages.patch (application/octet-stream, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Ricardo Wurmus <rekado <at> elephly.net>
To: hli <at> mdc-berlin.de
Cc: 47314-done <at> debbugs.gnu.org
Subject: [Patch] two r packages (chromstardata and signac)
Date: Mon, 22 Mar 2021 14:39:09 +0100

Hi,

thank you taking the time to submit your first patch!

I pushed the changes to the “master” branch with these commits:

  ee4fc3b662 * gnu: Add r-signac.
  dd4670d40d * gnu: Add r-lsa.
  0ff888108a * gnu: Add r-chromstar.
  1f958631ef * gnu: Add r-chromstardata.

Some of the changes I performed:

- As you can see I split up the patch into one commit per affected
  package.

- I added r-lsa, which r-signac references.

- I changed all license values to use a “license:” prefix.  The importer
  does not do this.

- I placed r-signac in (gnu packages bioinformatics), r-lsa in (gnu
  packages cran), r-chromstar in (gnu package bioconductor), and
  r-chromstardata in the same module but in the section for experiment
  data.

- I modified the descriptions and synopses to remove the R-typical use
  of title case, and to use full sentences.

- r-chromstar was built from git in a version more recent than the
  version corresponding to the current Bioconductor release, so I used
  the published release instead.

- I reindented the code.  Note that etc/indent-code.el can do this for
  you.

The contribution process we follow and recommend is outlined in the
manual section “16.6 Submitting Patches”, which contains a few hints
that will make future contributions a little smoother :)

Also, feel free to Cc me for future submissions, so that I can apply
them more quickly.

Thanks again!

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.