GNU bug report logs - #47286
28.0.50; [PATCH] Replace "(default %s)" with 'format-prompt'

Previous Next

Full log

Message #32 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#47286: 28.0.50; [PATCH] Replace "(default %s)" with
 'format-prompt'
Date: Tue, 23 Mar 2021 00:47:55 -0300

[Message part 1 (text/plain, inline)]

>
> The files that have a line like
>
> ;; Package-Requires: ((emacs "26.1") (xref "1.0.2"))
>
> or similar should be handled with more care, yes -- they have to be
> backwards-compatible, and `format-prompt' is new in Emacs 28.  So if you
> could re-spin the patch without changes to files like that, I'll get it
> applied (it looks good otherwise).
>
> There are some packages that are maintained for older Emacs versions,
> too, but we unfortunately have no markup to say that explicitly.
> Looking over the list, I think this affects only these two files, and
> should also be removed from the patch:
>
>  lisp/progmodes/cc-styles.el
>  lisp/progmodes/verilog-mode.el

Hi Lars,

Thanks so much for your review. Here is an updated patch that removes
the mentioned files (project.el, cc-styles.el and verilog-mode.el) and
updates the 'format-prompt' function with the suggestion from Dmitry
Gutov to consider an empty DEFAULT as nil. Let me know if something
could be improved.

[0001-Replace-default-s-with-format-prompt.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.