GNU bug report logs - #47243
pr lacks -p

Previous Next

Full log

Message #34 received at 47243 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Collin Funk <collin.funk1 <at> gmail.com>
Cc: 47243 <at> debbugs.gnu.org
Subject: Re: bug#47243: pr lacks -p
Date: Mon, 28 Jul 2025 11:22:16 +0100

On 28/07/2025 03:21, Collin Funk wrote:
> Hi Paul,
> 
> Paul Eggert <eggert <at> cs.ucla.edu> writes:
> 
>> Thanks for looking into that. Unfortunately POSIX says -p should be
>> ignored only if standard output is a terminal, and that newline should
>> be read from /dev/tty, not from standard input. This is so that users
>> can pipe into 'pr -p'. So the proposed patch needs some changes. Here
>> are the issues I found:
> 
> Thanks for the thorough review.
> 
> I think that v3 attached should cover everything.
> 
> Collin
> 

write_error() manipulates stdout,
so for the putc(..., stderr) I'd just do a straight error(EXIT_FAILURE, ....)

The NEWS would be best in a "New Features" section.

thanks!
Padraig

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.