From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 09:41:17 2021 Received: (at submit) by debbugs.gnu.org; 18 Mar 2021 13:41:17 +0000 Received: from localhost ([127.0.0.1]:45414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMsto-0001wf-QV for submit@debbugs.gnu.org; Thu, 18 Mar 2021 09:41:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:35242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMstm-0001wX-RQ for submit@debbugs.gnu.org; Thu, 18 Mar 2021 09:41:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMstm-0004HU-FD for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 09:41:14 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:43658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMsti-0001CT-Kh for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 09:41:13 -0400 Received: by mail-wm1-x32c.google.com with SMTP id u5-20020a7bcb050000b029010e9316b9d5so3388311wmj.2 for ; Thu, 18 Mar 2021 06:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:subject:date:message-id:mime-version; bh=aalRJqdd8RnPsv2SPxMd69dm9NIANkVPbtXAdeEZhPU=; b=egxMcZQu3ljYxdD9OKiORqu0cWkwmjgTn8v5qL+oRNOy2FhstlmYRDc80AV6XIYBvf Tw9SRCkPrF2ICLwyeHZXCWSJg4lCknBEiCyuehpuLT5xA09UVlcEDSr9+Dg4lNmBBSA8 Jz3kRUvDAYPuw/xH35kb7KnRd2c6cehV86j10xsJEkX1HH3tRYw8VKSdL68O1lFL3ay+ PE7FuR84ZxcyCXsfgMIV083vUwhkho5v/FvzTgFHNcbZepMtlyoMW4jXmCZcBZeOieci Xv5xScjnHTfYUtGEp/+YqgmWJW05d6gBpccS538j+P58y++310CGenk+kTjTkUaSLVQx i3jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=aalRJqdd8RnPsv2SPxMd69dm9NIANkVPbtXAdeEZhPU=; b=mSBhqR+q0iqI35al2r+fCguYg+f4am2fDU4iAe6KI26puuAfeZW6vDhxeob2G9u0Q7 Xyqke2ouKL6DLmTjOZekMdzlbLmHqAD69yQWBMx55nbnjcGDDjuQw+iDdLpzM2NyvpqG UfRmlgSX+cGIUmBnxBta+Mmrhm5lhuKSqYGKCc8tpKzMPy3QTFMx7w/HThjHWogRDRVX dCqskrHqaOXWk6KyrI60SW8Sdv+BqzU0HxS3K/zb7g/c2a5P/5vwfbD2jL51cNDj8BR5 ICMiZivqDylvJHR3YT4EAvasQ2iGl00dVtPSPQ4RIN18JAM3EHjnNoGE50hcBtJh7usP G3Cg== X-Gm-Message-State: AOAM532vS7IQipPNo4U+sPAW6VJE2BwS2NiTYt0KmyUF5hHSLMpckWSr BCCE6q0VyF4OtqNrF99ux2CPu/R8g7ZZyw== X-Google-Smtp-Source: ABdhPJw2Q0yXLuLR4FWcc5ZJeDYLRDzzvXt2htSVbkmaiDpbP2Z99kX1v1j5HlMulc4nVvGmnO9yYQ== X-Received: by 2002:a05:600c:2254:: with SMTP id a20mr3886428wmm.115.1616074866007; Thu, 18 Mar 2021 06:41:06 -0700 (PDT) Received: from localhost ([51.37.106.140]) by smtp.gmail.com with ESMTPSA id u8sm3113101wrr.42.2021.03.18.06.41.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 06:41:05 -0700 (PDT) From: "Basil L. Contovounesios" To: bug-gnu-emacs@gnu.org Subject: 28.0.50; frame-inner-height fails without window system on tab-bar-height Date: Thu, 18 Mar 2021 13:41:04 +0000 Message-ID: <87zgz0wpe7.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=contovob@tcd.ie; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) X-Debbugs-Cc: Juri Linkov , Martin Rudalics In a build --without-x: 0. ./src/emacs -Q 1. (frame-inner-height) C-j Debugger entered--Lisp error: (void-function tab-bar-height) tab-bar-height(# t) frame-inner-height() (progn (frame-inner-height)) eval((progn (frame-inner-height)) t) elisp--eval-last-sexp(t) eval-last-sexp(t) eval-print-last-sexp(nil) funcall-interactively(eval-print-last-sexp nil) call-interactively(eval-print-last-sexp nil nil) command-execute(eval-print-last-sexp) The obvious band-aid is to check (fboundp 'tab-bar-height) in frame-inner-height, but shouldn't we count 1 line when tab-bar-mode is enabled even --without-x? IOW, can/should tab-bar-height or similar be defined regardless of HAVE_WINDOW_SYSTEM? What's TRT here? Thanks, -- Basil In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu) of 2021-03-18 built on tia Repository revision: ce1b4acd71e962b6a72a779ee04cb5aeb6ceb6f2 Repository branch: master System Description: Debian GNU/Linux bullseye/sid Configured using: 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache --prefix=/home/blc/.local --program-suffix=-nox --enable-checking=structs --with-file-notification=yes --with-x-toolkit=no --without-x' Configured features: ACL DBUS GMP GNUTLS GPM JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER SOUND THREADS XIM ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Debugger Minor modes in effect: mouse-wheel-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-fns radix-tree cl-print debug backtrace help-mode tool-bar find-func cl-loaddefs cl-lib term/xterm xterm byte-opt gv bytecomp byte-compile cconv regexp-opt mwheel iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 multi-tty make-network-process emacs) From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 10:30:56 2021 Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 14:30:56 +0000 Received: from localhost ([127.0.0.1]:47664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMtfs-0007xU-EQ for submit@debbugs.gnu.org; Thu, 18 Mar 2021 10:30:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMtfq-0007xH-NC for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 10:30:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56115) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMtfk-0005AI-D8; Thu, 18 Mar 2021 10:30:48 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3160 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lMtfj-00041O-B2; Thu, 18 Mar 2021 10:30:47 -0400 Date: Thu, 18 Mar 2021 16:30:43 +0200 Message-Id: <837dm4h6uk.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" In-Reply-To: <87zgz0wpe7.fsf@tcd.ie> (contovob@tcd.ie) Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height References: <87zgz0wpe7.fsf@tcd.ie> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47234 Cc: 47234@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: "Basil L. Contovounesios" > Date: Thu, 18 Mar 2021 13:41:04 +0000 > Cc: juri linkov > > In a build --without-x: > > 0. ./src/emacs -Q > 1. (frame-inner-height) C-j > > Debugger entered--Lisp error: (void-function tab-bar-height) > tab-bar-height(# t) > frame-inner-height() > (progn (frame-inner-height)) > eval((progn (frame-inner-height)) t) > elisp--eval-last-sexp(t) > eval-last-sexp(t) > eval-print-last-sexp(nil) > funcall-interactively(eval-print-last-sexp nil) > call-interactively(eval-print-last-sexp nil nil) > command-execute(eval-print-last-sexp) > > The obvious band-aid is to check (fboundp 'tab-bar-height) in > frame-inner-height, but shouldn't we count 1 line when tab-bar-mode is > enabled even --without-x? IOW, can/should tab-bar-height or similar be > defined regardless of HAVE_WINDOW_SYSTEM? What's TRT here? TRT is to teach Emacs to return the tab-bar height on TTY frames as well. But I don't think defining tab-bar-height on TTY frames is the right way: the tab-bar is always 1 line high on those frames, so we could simply use that hardcoded value instead of signaling an error, I think. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 10:58:03 2021 Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 14:58:03 +0000 Received: from localhost ([127.0.0.1]:47682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMu66-0000AU-NG for submit@debbugs.gnu.org; Thu, 18 Mar 2021 10:58:02 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:35516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMu64-0000A0-I3 for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 10:58:01 -0400 Received: by mail-wr1-f42.google.com with SMTP id j18so5868666wra.2 for <47234@debbugs.gnu.org>; Thu, 18 Mar 2021 07:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=EvbMqvUKy0YTWO7totu40phs3NmJ5AybPDwrE0SikTw=; b=fuqpMw8KGTBUARBJaY7Mpc5pmz5bL2ToGxlvVPXAZXLWLzXdP9TgaY2ryaF+0/o70D x/I0J+13cD/F3qdB5Eb5Lq/gNWvCQA79JctaoztpslElbp4q6I6F7qcPksvIbcjRXHOj qWBIpgmMCQYTUWfc9pGgncv5zI41a6+kzhg7323gdyofQDiSjh+aa+TIg+R3/YIE8zaM uZLLKaGhxpDWdzXHTKQT/Vp6s/YT+zVkk7MRmKv0lRjFXJPNcmNGvCoDIwroLrpNC8pc qEkMOmUocJFRSSyTdBFLoOzNtk++PmnKeVDFTs94AUaoJRRaPDFkoSWV6CetzABH+axy WDgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=EvbMqvUKy0YTWO7totu40phs3NmJ5AybPDwrE0SikTw=; b=kFGjN0dCszDXgsZ3Kg1Wb+gr96eVmG10SBha79KQSFNUKB+80Nprh1b5iXmCmuRxXx /2zh05pz/tdCDS9HQFX+GbzkW8im+H5V6k9GGHVTf7vuOQMk9ehXDn9B8/JzEpYZ4zqx THbiPblILGm6U9v5HLmboIGRLXPqTeYd6UZAbzm2nBQPndl3DeBkQ1s9/3fd4i+mrUbP xQ30GXRhHof7QhdNabFYp/o3WZ4dst0r6tuJr4iXLivGHqT+LEtIGdAAgTMVaWpak+f6 hrbeuywjodYmIoy4pHPSVfNPbL8e3AxDymNit6l8pIdxf7e2Nr90+sC7voryA/CNNRSN VaUg== X-Gm-Message-State: AOAM530QuwBSLv9Sn/h7/qtPqnR6qKB6kzOu7IkyKAja+fSxcDNjBRzT BJnJXF7m3WGHRqonpdYE3BBgAw== X-Google-Smtp-Source: ABdhPJzAEDNeUXhWNfm4wnC3ciKfM8eBIHHhHglXZ8RVkcn6NG7HI3u7iMpKbqJRNwHtEmgQBAFiuw== X-Received: by 2002:a5d:58ce:: with SMTP id o14mr10387650wrf.4.1616079474661; Thu, 18 Mar 2021 07:57:54 -0700 (PDT) Received: from localhost ([51.37.106.140]) by smtp.gmail.com with ESMTPSA id y16sm3321866wrh.3.2021.03.18.07.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 07:57:54 -0700 (PDT) From: "Basil L. Contovounesios" To: Eli Zaretskii Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> Date: Thu, 18 Mar 2021 14:57:52 +0000 In-Reply-To: <837dm4h6uk.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Mar 2021 16:30:43 +0200") Message-ID: <877dm4o6fj.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 47234 Cc: 47234@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: "Basil L. Contovounesios" >> Date: Thu, 18 Mar 2021 13:41:04 +0000 >> Cc: juri linkov >> >> The obvious band-aid is to check (fboundp 'tab-bar-height) in >> frame-inner-height, but shouldn't we count 1 line when tab-bar-mode is >> enabled even --without-x? IOW, can/should tab-bar-height or similar be >> defined regardless of HAVE_WINDOW_SYSTEM? What's TRT here? > > TRT is to teach Emacs to return the tab-bar height on TTY frames as > well. But I don't think defining tab-bar-height on TTY frames is the > right way: the tab-bar is always 1 line high on those frames, so we > could simply use that hardcoded value instead of signaling an error, I > think. I'm not familiar with the tab bar, but I get the impression it's not that simple. IIUC no lines should be subtracted if tab-bar-mode is off, and even if it's on, the tab bar can be hidden subject to tab-bar-show. That's why I was wondering whether this logic can/should be packed into a single place (whether Ftab_bar_height or other I don't know). Is the following close to TRT? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=tab-bar.diff diff --git a/lisp/frame.el b/lisp/frame.el index b5a8e0ed72..f4b8f1c418 100644 --- a/lisp/frame.el +++ b/lisp/frame.el @@ -1370,7 +1370,9 @@ frame-inner-height FRAME defaults to the selected frame." (setq frame (window-normalize-frame frame)) (- (frame-native-height frame) - (tab-bar-height frame t) + (if (fboundp 'tab-bar-height) + (tab-bar-height frame t) + (frame-parameter frame 'tab-bar-lines)) (* 2 (frame-internal-border-width frame)))) (defun frame-outer-width (&optional frame) --=-=-= Content-Type: text/plain Thanks, -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 11:12:28 2021 Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 15:12:28 +0000 Received: from localhost ([127.0.0.1]:47720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMuK4-0000ZO-D4 for submit@debbugs.gnu.org; Thu, 18 Mar 2021 11:12:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMuK2-0000ZC-6t for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 11:12:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57030) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMuJw-0004KH-F5; Thu, 18 Mar 2021 11:12:20 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1722 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lMuJv-0006Jk-4L; Thu, 18 Mar 2021 11:12:20 -0400 Date: Thu, 18 Mar 2021 17:12:19 +0200 Message-Id: <83zgz0fqcs.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" In-Reply-To: <877dm4o6fj.fsf@tcd.ie> (contovob@tcd.ie) Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47234 Cc: 47234@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: "Basil L. Contovounesios" > Cc: 47234@debbugs.gnu.org, juri@linkov.net > Date: Thu, 18 Mar 2021 14:57:52 +0000 > > > TRT is to teach Emacs to return the tab-bar height on TTY frames as > > well. But I don't think defining tab-bar-height on TTY frames is the > > right way: the tab-bar is always 1 line high on those frames, so we > > could simply use that hardcoded value instead of signaling an error, I > > think. > > I'm not familiar with the tab bar, but I get the impression it's not > that simple. To be sure, I didn't mean to use just the number 1 there. > IIUC no lines should be subtracted if tab-bar-mode is off, > and even if it's on, the tab bar can be hidden subject to tab-bar-show. > That's why I was wondering whether this logic can/should be packed into > a single place (whether Ftab_bar_height or other I don't know). > > Is the following close to TRT? If it produces the right result under all of the complications you mentioned, sure. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 11:22:57 2021 Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 15:22:57 +0000 Received: from localhost ([127.0.0.1]:47745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMuUD-0000qU-DM for submit@debbugs.gnu.org; Thu, 18 Mar 2021 11:22:57 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:45645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMuUB-0000qG-OY for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 11:22:56 -0400 Received: by mail-wr1-f49.google.com with SMTP id 61so5942348wrm.12 for <47234@debbugs.gnu.org>; Thu, 18 Mar 2021 08:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9Yz+VQJ+bdotpqkxrge4wzWXQL3Nkb8c2pXmDE8zSWg=; b=QHNP5pZh0C6I8CWngOtHVEaTq2ypDe8lfYb57DWuetZOm4EHy3R/oBu0zetXJGfHYj UnuMcT4pzue29GAy7haJI564+xwq2FRpOWC/R9tVhfjOVWo3CRYx+EKtVwQRU6OvDGnw A8op3NQwkzQp4bdBVnJvFATKhdSxYux5NBMidT0Aej9j2ASeRQOrpjZUFTWO9VT0lmRq XuuJZPC8CaC3jgKJxGMMNQrJfQ94ux6F5YV3IhD29EKrUDqBPF09aoj61L5A6hCcjlyF JR4N2mgktYwp4y+EvLTbDxNDq1nG83x0Kx630yzfUWz6bS/1nIja83pQlNCc3zgHk18h 3/1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9Yz+VQJ+bdotpqkxrge4wzWXQL3Nkb8c2pXmDE8zSWg=; b=TRJKGCK5tE6GUVv5+Ej1N/pIH1VA2OkWRBEpOzf0/A6ViHQQGRPmo7E1EVRVa57dNf IV6cx/9c3lRrJmE2EJzb93YBMawEENqnGDVs2zx1xrYpYYrQFD1i8nz3fV2ndMkJgulh c1ZMhyHSgtea0mZO0Zw41VycZBuNZ3MxaLq0iGe+dsU9NS+RVK+WRPLRWryF3XQoAov8 3qoDLHqUWB9e5nepoA01PYWLEvQWul2yuPkVaLpmbMtPhNUj4r5eKDAlMCk7QghStkpr eq3pP+QMN/9FGjJH+E/sKgYIR8Q44DamIiF6Skkms12b/fG7LnhZZ/DhUOJ5Ylro+NOV Rq8A== X-Gm-Message-State: AOAM531kOWBCrLppxJHsLHJ3YM4nxd/itLkpLsrYybC45GCrb27gl6Bp 4nLzy5YZWoryggPItMgbIVjrGg== X-Google-Smtp-Source: ABdhPJwfLBL8XUnLcggA81joOLurm2IT7Fb9uinRFrvChl8DvGRQ1hugn//cVVuqYnRbHDTTQiZt6g== X-Received: by 2002:adf:fbce:: with SMTP id d14mr9947481wrs.44.1616080969868; Thu, 18 Mar 2021 08:22:49 -0700 (PDT) Received: from localhost ([51.37.106.140]) by smtp.gmail.com with ESMTPSA id y16sm3399855wrh.3.2021.03.18.08.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 08:22:49 -0700 (PDT) From: "Basil L. Contovounesios" To: Eli Zaretskii Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> Date: Thu, 18 Mar 2021 15:22:48 +0000 In-Reply-To: <83zgz0fqcs.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Mar 2021 17:12:19 +0200") Message-ID: <87mtv0lc53.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 47234 Cc: 47234@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: "Basil L. Contovounesios" >> Cc: 47234@debbugs.gnu.org, juri@linkov.net >> Date: Thu, 18 Mar 2021 14:57:52 +0000 >> >> > TRT is to teach Emacs to return the tab-bar height on TTY frames as >> > well. But I don't think defining tab-bar-height on TTY frames is the >> > right way: the tab-bar is always 1 line high on those frames, so we >> > could simply use that hardcoded value instead of signaling an error, I >> > think. >> >> I'm not familiar with the tab bar, but I get the impression it's not >> that simple. > > To be sure, I didn't mean to use just the number 1 there. I assumed you meant something like: (cond ((fboundp 'tab-bar-height) (tab-bar-height frame t)) (tab-bar-mode 1) (0)) (At least that was my first thought.) >> IIUC no lines should be subtracted if tab-bar-mode is off, >> and even if it's on, the tab bar can be hidden subject to tab-bar-show. >> That's why I was wondering whether this logic can/should be packed into >> a single place (whether Ftab_bar_height or other I don't know). >> >> Is the following close to TRT? > > If it produces the right result under all of the complications you > mentioned, sure. Thanks, it does AFAICT. Hopefully Juri can confirm/deny for certain. (For example, I don't know when one would pick Ftab_bar_height over the frame property tab-bar-lines - maybe the latter can be used unconditionally?) -- Basil From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 11:52:01 2021 Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 15:52:01 +0000 Received: from localhost ([127.0.0.1]:47813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMuwK-0001br-OM for submit@debbugs.gnu.org; Thu, 18 Mar 2021 11:52:00 -0400 Received: from mout.gmx.net ([212.227.15.19]:47881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMuwI-0001bf-TT for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 11:51:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1616082711; bh=CB6nAjwZAhlKRcjejbYoTNGRIS/WbDuBmapBvpoEKXI=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=DaBwnJoVGMBMCSsly+WrvyO71rMO1sz8hc1nAAAboxcsd2feZT2WyaR1ruzb1Vo/k lQ0wxq0Ie0y49rvarFjBMDWpZTsRWl0JoBRvLfaf+DZZrjQUOjJzOP3oApSD3873Zy X7N+apHSmEephrqinJ7B7d9mUs36MiJnjotYWOSE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.21]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MC30Z-1lYi7P2P3V-00CQeE; Thu, 18 Mar 2021 16:51:50 +0100 Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height To: "Basil L. Contovounesios" , Eli Zaretskii References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> From: martin rudalics Message-ID: Date: Thu, 18 Mar 2021 16:51:48 +0100 MIME-Version: 1.0 In-Reply-To: <877dm4o6fj.fsf@tcd.ie> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:h+BjQ0D1Q9QEzefL/r4elzxRlcdMUqIXey0B1SIA72oqn6Q099m My07qzZzuAsXgCFQWTZIOe+Udw7nAyKR8UbKZqD3bA677yTEqY9q5FP1I35D0QLmn1+lSq9 rVZ3cpFE3B4qpHrAl7dk0+7+jIgeIXl0MWuhSLtf8JJjpdsQmWzDp8onVF7cjklW3A4MNxg mMchBECX22KpkYNncq++w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:hOtXYY+AZTQ=:cc1GocIJNSqcTkBR5Y9H5Q UsFU7gNp3JMzKUyAA7axu1LdAXYNktR7x6evr5c/dO/WGfu1cp8s8nMNo1YQnT81nKAG3dxYb AaMZJ+TuhbCL69eIa+/xjMcka9noL7cWlSPajrftCOFTbo63lNixN29ZEguaAErmuVkVKXmqW JBAHnlT0EMer4JIHV74tGfqVb11xlRbZfcIGgK9bSZ7JjgqQ2PFm2dSLhJQHeFgItDM8ft81m Hxx+cJERpgMolXd+1X8PPwp6/qFPBWj+o1h26nVb+s1c3igoNsQenyNOgquTOODbDjVox7USQ wLwwnT5wU6y2CcKw/Xf1lupohOf59myiu571auIwud4t4gz87Xm4MvNbi+dOnTMqTEGsbrAL6 6+GPOiWHBsLhgHRNPaXPi5eE4evOO/eHQB1BEEIuSdcmsMcJu5VHSmxyvvXWY4Er3PijH48Hs 1u9yf48hMG4m/PTffMZG9s/bGMqgmb7GBdre9vhLU0yxIjnLTw25WMJeqAezEA/RId8vWCbhu SO2I7cwXny+2qGgCCrQsy4Q+ewH8FttREVRgwBCBslKWzXAqgL8vf408Pw386Mnc4aZPtugjk hy1JUij9SBpJZwjoDQa4t9PtI9iNQyjxm1rgrm97dohU9dLlbjWXPXf+VVFuKrXqpEdLt6j5x Vj8JU/FIGyPm+pJkdxpFlbjmMcxvkHf4N/5UgmJlZxQq5DHVMxkR+vcgn7tXowihO0uA8v1v0 gipz6xJPP7YhRsTJTI5KnAUDSCW7bp9tRkMenJ2hCnfoe6l8SvZa8V2dePrrVoS8DckEU/Use 2NirMtWmZDOgaHPY0hCacH0Eo+rNBAdcj4aRRjsDiLBi9TNLfSar38EqtQsza749cJZpbGDzi qbRC3sPdX5Ieqh8NfbmQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47234 Cc: 47234@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Is the following close to TRT? > > + (if (fboundp 'tab-bar-height) > + (tab-bar-height frame t) > + (frame-parameter frame 'tab-bar-lines)) I think that `tab-bar-height' should be bound and return a meaningful value everywhere. The frame parameters (in particular for the menu and tool bar) are only a meaningless pain in this regard. Many thanks for spotting and working on this, martin From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 11:53:41 2021 Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 15:53:41 +0000 Received: from localhost ([127.0.0.1]:47823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMuxx-0001f2-CV for submit@debbugs.gnu.org; Thu, 18 Mar 2021 11:53:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMuxu-0001el-Km for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 11:53:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57945) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMuxp-0004fP-6x; Thu, 18 Mar 2021 11:53:33 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4448 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lMuxo-0005Ah-P1; Thu, 18 Mar 2021 11:53:33 -0400 Date: Thu, 18 Mar 2021 17:53:33 +0200 Message-Id: <83v99ofog2.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" In-Reply-To: <87mtv0lc53.fsf@tcd.ie> (contovob@tcd.ie) Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47234 Cc: 47234@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: "Basil L. Contovounesios" > Cc: 47234@debbugs.gnu.org, juri@linkov.net > Date: Thu, 18 Mar 2021 15:22:48 +0000 > > (For example, I don't know when one would pick Ftab_bar_height over the > frame property tab-bar-lines - maybe the latter can be used > unconditionally?) Not AFAIU, because Ftab_bar_height returns its result in pixels, not in lines. On TTY frames, each line is 1 pixel. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 13:08:58 2021 Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 17:08:58 +0000 Received: from localhost ([127.0.0.1]:47919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMw8n-0003Zm-TW for submit@debbugs.gnu.org; Thu, 18 Mar 2021 13:08:58 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:41251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMw8l-0003ZL-Tv for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 13:08:56 -0400 X-Originating-IP: 91.129.107.223 Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 37DA2FF810; Thu, 18 Mar 2021 17:08:47 +0000 (UTC) From: Juri Linkov To: "Basil L. Contovounesios" Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height Organization: LINKOV.NET References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> Date: Thu, 18 Mar 2021 19:07:55 +0200 In-Reply-To: <87mtv0lc53.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 18 Mar 2021 15:22:48 +0000") Message-ID: <87y2eko0js.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47234 Cc: martin rudalics , Eli Zaretskii , 47234@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> Is the following close to TRT? >> >> If it produces the right result under all of the complications you >> mentioned, sure. > > Thanks, it does AFAICT. Hopefully Juri can confirm/deny for certain. > (For example, I don't know when one would pick Ftab_bar_height over the > frame property tab-bar-lines - maybe the latter can be used > unconditionally?) I agree with Martin that `tab-bar-height' should return a meaningful value on --without-x builds too. Please note this should be fixed on the release branch in Emacs 27.2 because the change in commit 6c5ddf0e0b was recently made in emacs-27. I wonder why only tab-bar-height was added to frame-inner-height, why not menu-bar-height as well? Moreover, such function as menu-bar-height doesn't exist at all. Why only tab-bar-height is needed? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 13:37:43 2021 Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 17:37:43 +0000 Received: from localhost ([127.0.0.1]:47954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMwad-0006Ob-9Z for submit@debbugs.gnu.org; Thu, 18 Mar 2021 13:37:43 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:38467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMwaa-0006OK-Ml for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 13:37:41 -0400 Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id D1860240006; Thu, 18 Mar 2021 17:37:32 +0000 (UTC) From: Juri Linkov To: "Basil L. Contovounesios" Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height Organization: LINKOV.NET References: <87zgz0wpe7.fsf@tcd.ie> Date: Thu, 18 Mar 2021 19:36:57 +0200 In-Reply-To: <87zgz0wpe7.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 18 Mar 2021 13:41:04 +0000") Message-ID: <87wnu4mkhy.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47234 Cc: martin rudalics , 47234@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > In a build --without-x: > > 0. ./src/emacs -Q > 1. (frame-inner-height) C-j > > Debugger entered--Lisp error: (void-function tab-bar-height) > tab-bar-height(# t) There are the following warnings on the emacs-27 branch with --without-x: frame.el:2749:1:Warning: the following functions are not known to be defined: tab-bar-height, x-display-list tab-bar-height is handled here in bug#47234, and x-display-list in bug#29713. There are more warnings, I don't know how important they are: image.el:1145:1:Warning: the function `image-transforms-p' is not known to be defined. gnus/gnus-util.el:1734:1:Warning: the function `image-size' is not known to be defined. org/org-macs.el:1277:1:Warning: the function `image-size' is not known to be defined. international/mule-diag.el:1188:1:Warning: the function `x-list-fonts' is not known to be defined. term/w32-win.el:622:1:Warning: the function `x-list-fonts' is not known to be defined. emulation/edt-mapper.el:521:1:Warning: the function `x-server-vendor' is not known to be defined. emulation/edt.el:2546:1:Warning: the function `x-server-vendor' is not known to be defined. gnus/nnimap.el:2273:1:Warning: the function `x-server-version' is not known to be defined. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 13:52:04 2021 Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 17:52:04 +0000 Received: from localhost ([127.0.0.1]:47976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMwoW-0006mV-BI for submit@debbugs.gnu.org; Thu, 18 Mar 2021 13:52:04 -0400 Received: from mout.gmx.net ([212.227.15.19]:34313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMwoU-0006lr-Gm for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 13:52:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1616089914; bh=OL1SZbxLGgQ0e3nAdAXFRWXKSgxgC/LHP745r2zb+Ko=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=cIWWbRHLF8iA929fBro04Ap6jrWrJk3TJYAQ4OMArSJLaIdJ1tffgayRRWgr+OMMR tfDEevAxzM9eMPhUk0nP9nQQCXT8muGJtCBAeya6Kl6eIpFAYsyaSIm3o/fFcxlMrt XIRA5GcNOUU8KeDjsJQIGvX3jM7EAIEK4xGpQOfs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.21]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MjjCL-1m6DqL0bwB-00lDHX; Thu, 18 Mar 2021 18:51:54 +0100 Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height To: Juri Linkov , "Basil L. Contovounesios" References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> <87y2eko0js.fsf@mail.linkov.net> From: martin rudalics Message-ID: <75bea13b-8302-5317-c4bc-84a710383420@gmx.at> Date: Thu, 18 Mar 2021 18:51:51 +0100 MIME-Version: 1.0 In-Reply-To: <87y2eko0js.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:6+3J8ZBgs1NmjnLShwFg9SxegEujRsJHHgEou7QKmGO8EGYsUoz hxSCix4sDy55Ijr4EnswKfer0XUcP/CnSjYwbN+OSTVlF+RkJ9qIpHfZhl9vEjN+5c84K57 xmP8ZZ7JTmTd76JVD6DG5T367MjaiTR7sAKT2SAX+Vt50nJEpZcybGspz+1V8xHY/TJIuqm ysqva1sncjJtoFOgp1yBQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:BJCaxKHWJcg=:CS+Y2DM9R/Ke2LJoUxW8b8 h70G6bHvL22rYppB5ijR60AxVKSj27ttbDk/am47tklWPfq/plM5kRwg2YY9frsuQsJQ0XRV3 2sf9jzjcrSFygjuOB7RCmAEL+V/wRbEmXs1hze7ZQGYSaoe1UWsHxH28hEAWD/EUxOJS5pj54 qcrLIJ1E9x3SfKgYZMdnYeZNjWXOUTVDkLe0TbAs1dNvGButoXsaZih61RJlhosk+7yLVqcOf W9k5QA/F7gfwypsKTVFBfrzyzlnNTcfyP1u/0o9eqTivqEoJqBfF8WdaSBaTHpFlajswBOyvT I9RYX7PMyMr7RBSLgs3JC8svG7YRhjy4Z8Us14apxvPBvczcIqZIGhaiTPlGI+Bmv+lSWjGBt qgTBo+6MFHKSvehy4q1FgUI3gwG6aA5JmG8Jns/4TyTguy9x4J1JJO6hgZZe8wUzwxzHbpzE6 8edDAbJH40VF1zD9KU5Ds0zjNLPaST6RNL5MhnVOZtMGVBq3gFdS0WXlqAbhj2FGpRUslFEbb r4jQ+ECsBDo4ycr8vus18VzWQ/1JfVLbgLxks/CTyK3XUbbZqDvltVDLZm6aQll1DyqjvqYNU vkA4F4iS2epIz2RFYXYzLrMme5jIQpOopRBYisXoQ5bRA5hvfAeqcnDqxpIzm/VERfYVS5ylS FZ0Nh8QEEzoxVfyVuSOroG/jfl8z8FeM7/bNyEjEy4MMhcYTLv8KVoVfCNbgZlMHTVsMa09Aw cZShopuPQg+avNWkf71tfDXYelxoXb0P+G2cGMQkR7OMMSzG4SJTl5I0Oy7SW4hV8F4AgVmDU Jl6Bb28BFwKFqJeODZqcpJpVkeS6L+ZolGrcBFPMlexgpU/Ro4JqoqZgiLnTEtC6uztM/qBDn EwNCC8iA1qsEssKdVi+g== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47234 Cc: Eli Zaretskii , 47234@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I wonder why only tab-bar-height was added to frame-inner-height, > why not menu-bar-height as well? And `tool-bar-height' as well. Darn. > Please note this should be fixed on the release branch in Emacs 27.2 > because the change in commit 6c5ddf0e0b was recently made in emacs-27. Then it's best to revert the frame.el part of 6c5ddf0e0b. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 14:49:02 2021 Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 18:49:03 +0000 Received: from localhost ([127.0.0.1]:48065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMxhe-000266-Ee for submit@debbugs.gnu.org; Thu, 18 Mar 2021 14:49:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMxhb-00025c-TJ for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 14:49:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33670) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMxhV-0007TG-TI; Thu, 18 Mar 2021 14:48:53 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3390 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lMxhU-00041f-7O; Thu, 18 Mar 2021 14:48:53 -0400 Date: Thu, 18 Mar 2021 20:48:53 +0200 Message-Id: <83mtv0fgbu.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87y2eko0js.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 18 Mar 2021 19:07:55 +0200) Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> <87y2eko0js.fsf@mail.linkov.net> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47234 Cc: contovob@tcd.ie, rudalics@gmx.at, 47234@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Juri Linkov > Cc: martin rudalics , Eli Zaretskii , 47234@debbugs.gnu.org > Date: Thu, 18 Mar 2021 19:07:55 +0200 > > >>> Is the following close to TRT? > >> > >> If it produces the right result under all of the complications you > >> mentioned, sure. > > > > Thanks, it does AFAICT. Hopefully Juri can confirm/deny for certain. > > (For example, I don't know when one would pick Ftab_bar_height over the > > frame property tab-bar-lines - maybe the latter can be used > > unconditionally?) > > I agree with Martin that `tab-bar-height' should return a meaningful value > on --without-x builds too. How do you propose to do that? The design and implementation of the code in tab-bar-height was stolen from the tool bar, and that was written for GUI frames. The text-mode tab bar has an entirely different design and implementation, similar to the text-mode menu bar. There's almost nothing in common between these two. > Please note this should be fixed on the release branch in Emacs 27.2 > because the change in commit 6c5ddf0e0b was recently made in emacs-27. Why does it have to be done in Emacs 27.2? Please be aware that Emacs 27.2 is all but released at this point. > I wonder why only tab-bar-height was added to frame-inner-height, > why not menu-bar-height as well? Moreover, such function as > menu-bar-height doesn't exist at all. Why only tab-bar-height is needed? Maybe tab-bar-height is not needed in this case, either. We could instead modify the code that attempts to call it. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 14:56:10 2021 Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 18:56:10 +0000 Received: from localhost ([127.0.0.1]:48073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMxoU-0002GR-Ms for submit@debbugs.gnu.org; Thu, 18 Mar 2021 14:56:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMxoS-0002Fw-El for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 14:56:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33805) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMxoM-0002A6-2y; Thu, 18 Mar 2021 14:55:58 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3991 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lMxoL-0004oN-3L; Thu, 18 Mar 2021 14:55:57 -0400 Date: Thu, 18 Mar 2021 20:55:57 +0200 Message-Id: <83lfakfg02.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <75bea13b-8302-5317-c4bc-84a710383420@gmx.at> (message from martin rudalics on Thu, 18 Mar 2021 18:51:51 +0100) Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> <87y2eko0js.fsf@mail.linkov.net> <75bea13b-8302-5317-c4bc-84a710383420@gmx.at> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47234 Cc: contovob@tcd.ie, 47234@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Cc: Eli Zaretskii , 47234@debbugs.gnu.org > From: martin rudalics > Date: Thu, 18 Mar 2021 18:51:51 +0100 > > > Please note this should be fixed on the release branch in Emacs 27.2 > > because the change in commit 6c5ddf0e0b was recently made in emacs-27. > > Then it's best to revert the frame.el part of 6c5ddf0e0b. Ugh! From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 15:01:49 2021 Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 19:01:49 +0000 Received: from localhost ([127.0.0.1]:48084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMxu1-0002QO-3d for submit@debbugs.gnu.org; Thu, 18 Mar 2021 15:01:49 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:53501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMxtx-0002Px-4n for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 15:01:45 -0400 Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 9D40B200007; Thu, 18 Mar 2021 19:01:37 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height Organization: LINKOV.NET References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> <87y2eko0js.fsf@mail.linkov.net> <83mtv0fgbu.fsf@gnu.org> Date: Thu, 18 Mar 2021 21:00:41 +0200 In-Reply-To: <83mtv0fgbu.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Mar 2021 20:48:53 +0200") Message-ID: <87v99owali.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47234 Cc: contovob@tcd.ie, rudalics@gmx.at, 47234@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> I agree with Martin that `tab-bar-height' should return a meaningful value >> on --without-x builds too. > > How do you propose to do that? The design and implementation of the > code in tab-bar-height was stolen from the tool bar, and that was > written for GUI frames. The text-mode tab bar has an entirely > different design and implementation, similar to the text-mode menu > bar. There's almost nothing in common between these two. Then the fix is not straightforward, indeed. >> Please note this should be fixed on the release branch in Emacs 27.2 >> because the change in commit 6c5ddf0e0b was recently made in emacs-27. > > Why does it have to be done in Emacs 27.2? > > Please be aware that Emacs 27.2 is all but released at this point. Martin said that the commit 6c5ddf0e0b added recently in emacs-27 should be reverted from Emacs 27.2. >> I wonder why only tab-bar-height was added to frame-inner-height, >> why not menu-bar-height as well? Moreover, such function as >> menu-bar-height doesn't exist at all. Why only tab-bar-height is needed? > > Maybe tab-bar-height is not needed in this case, either. We could > instead modify the code that attempts to call it. Grepping shows that the only code that calls frame-inner-height is mouse-drag-frame-resize. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 16:05:13 2021 Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 20:05:13 +0000 Received: from localhost ([127.0.0.1]:48148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMytN-000408-8M for submit@debbugs.gnu.org; Thu, 18 Mar 2021 16:05:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMytK-0003zs-QP for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 16:05:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35021) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMytD-000846-EQ; Thu, 18 Mar 2021 16:05:03 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4233 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lMytC-0004fz-Ot; Thu, 18 Mar 2021 16:05:03 -0400 Date: Thu, 18 Mar 2021 22:05:02 +0200 Message-Id: <83ft0sfcsx.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87v99owali.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 18 Mar 2021 21:00:41 +0200) Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> <87y2eko0js.fsf@mail.linkov.net> <83mtv0fgbu.fsf@gnu.org> <87v99owali.fsf@mail.linkov.net> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47234 Cc: contovob@tcd.ie, rudalics@gmx.at, 47234@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Juri Linkov > Cc: contovob@tcd.ie, rudalics@gmx.at, 47234@debbugs.gnu.org > Date: Thu, 18 Mar 2021 21:00:41 +0200 > > >> Please note this should be fixed on the release branch in Emacs 27.2 > >> because the change in commit 6c5ddf0e0b was recently made in emacs-27. > > > > Why does it have to be done in Emacs 27.2? > > > > Please be aware that Emacs 27.2 is all but released at this point. > > Martin said that the commit 6c5ddf0e0b added recently in emacs-27 > should be reverted from Emacs 27.2. > > >> I wonder why only tab-bar-height was added to frame-inner-height, > >> why not menu-bar-height as well? Moreover, such function as > >> menu-bar-height doesn't exist at all. Why only tab-bar-height is needed? > > > > Maybe tab-bar-height is not needed in this case, either. We could > > instead modify the code that attempts to call it. > > Grepping shows that the only code that calls frame-inner-height > is mouse-drag-frame-resize. Thanks. After thinking some more about this, I think we should leave the frame.el part of 6c5ddf0e0b alone, but augment it with the fboundp test, such that on TTY frames the tab bar would be included in the frame's inner height, like the menu bar is. This is also consistent with what happens on TTY frames in a build with X: tab-bar-height returns zero. Basil, can you please install such a change on the emacs-27 branch? I will then make another RC. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 18:24:29 2021 Received: (at 47234) by debbugs.gnu.org; 18 Mar 2021 22:24:29 +0000 Received: from localhost ([127.0.0.1]:48267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lN149-0005L0-2g for submit@debbugs.gnu.org; Thu, 18 Mar 2021 18:24:29 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:36793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lN147-0005Kn-E6 for 47234@debbugs.gnu.org; Thu, 18 Mar 2021 18:24:27 -0400 Received: by mail-wr1-f54.google.com with SMTP id k8so7142738wrc.3 for <47234@debbugs.gnu.org>; Thu, 18 Mar 2021 15:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=T1PLcm5t+BmJdYwoLAS6/rr2vHCdQfOzF5NFAc3I9qM=; b=PugVNKxwE7zH4AnKxdUNuUi6hm/T8sTr/EW64WT6G1c9RdhN1mj1M+sINBKr8ssWZh 2YZPfiAfratyTHLEUV23e8GXCPRys98bsrBwXYBs2zwkH0jSMzWw87vYLGOb2Y2AsVrO XcfbBa3w2Q39TQ9XV2YtgE3AvLzN2VbFdufYdIe21lLOWu+kM0Ff4EH9ni3jLyhmb1yd LrqiDXHPnmOwAqzPua+mJN09qynFUmRweQHBSbkp+m0Ec5jzwsdcctF1WcNX0fJ8Y6U7 INQ+PHxVVelEAnpeLfXIMraBhn+qLydkJB/tDqqlUsXNDV6pMEcuYrLSKmupJ9TJH0xX 0fyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=T1PLcm5t+BmJdYwoLAS6/rr2vHCdQfOzF5NFAc3I9qM=; b=TkGe1vp3x1mvzMKGR7xyoKkL5b9AG+caOauuNrR5bPDrJg4sbDEqB+dPA0OCeGO7PI 8rgvgT2z5atS+iffL0bWMMx+ZG7imomfB3s0d6Q/8F1MDPoANJFNX9Jls9UETChtrM4s +G9W8EilqXH74XmGsY5G9HnoaBUj/iSutCbTY0Lqhk1EwDlahv55/1WD0HcjM7+UhiB9 SEbFY4Nsp6Z9q7C4FnaFF2HkZmX29gSMYaWf6ovuHkaQx9udVus9w2LlB3QVvvun4GCM LQoXOne7Lo+J5SY+NJv/OJeAyEEcbQ3V2+qcpYhs74+X5w4wUNcTZox2GmCZgCsAB0Ho bJUg== X-Gm-Message-State: AOAM533UgHxzDXKHYgL86sYNY1Zkjr2Zp+foK/LAkY3XDTO2xXBYqs7y uEx9Zv0AUsfYjlb0QhqkAb3fyA== X-Google-Smtp-Source: ABdhPJy/E3fvTrHgDzuqi/2QeUOAvJ5EAidpZlc/CWs70d+URCdMLE+/4dLMv2Y3xBvcpzJHNqj8gg== X-Received: by 2002:a5d:5051:: with SMTP id h17mr1384797wrt.80.1616106261648; Thu, 18 Mar 2021 15:24:21 -0700 (PDT) Received: from localhost ([51.37.106.140]) by smtp.gmail.com with ESMTPSA id t1sm970472wry.90.2021.03.18.15.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 15:24:20 -0700 (PDT) From: "Basil L. Contovounesios" To: Eli Zaretskii Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> <87y2eko0js.fsf@mail.linkov.net> <83mtv0fgbu.fsf@gnu.org> <87v99owali.fsf@mail.linkov.net> <83ft0sfcsx.fsf@gnu.org> Date: Thu, 18 Mar 2021 22:24:18 +0000 In-Reply-To: <83ft0sfcsx.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Mar 2021 22:05:02 +0200") Message-ID: <87h7l8umlp.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 47234 Cc: rudalics@gmx.at, 47234@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > After thinking some more about this, I think we should leave the > frame.el part of 6c5ddf0e0b alone, but augment it with the fboundp > test, such that on TTY frames the tab bar would be included in the > frame's inner height, like the menu bar is. This is also consistent > with what happens on TTY frames in a build with X: tab-bar-height > returns zero. > > Basil, can you please install such a change on the emacs-27 branch? I > will then make another RC. Done: Fix frame-inner-height in non-GUI builds bd991e3c9b 2021-03-18 22:13:05 +0000 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=bd991e3c9bc9c26e641036f52adf82e052d4319c Is there anything left to address here on the master branch, or can this report be closed? The other --without-x warnings in frame.el are benign, and I'll try to look into the rest of them soon, but none of them sound too alarming at first glance (famous last words). Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 18:29:07 2021 Received: (at control) by debbugs.gnu.org; 18 Mar 2021 22:29:07 +0000 Received: from localhost ([127.0.0.1]:48272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lN18c-0005Rg-SN for submit@debbugs.gnu.org; Thu, 18 Mar 2021 18:29:07 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:51813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lN18a-0005RD-VT for control@debbugs.gnu.org; Thu, 18 Mar 2021 18:29:05 -0400 Received: by mail-wm1-f46.google.com with SMTP id p19so4460541wmq.1 for ; Thu, 18 Mar 2021 15:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:subject:date:message-id:mime-version; bh=FqEi+/XTwhjJx+teh0VZHO9fGFkl45zKK9jGXXsLq8E=; b=VW5UIDgaLmz7cXEIAQx7YP3nxoDRO8RuzOqTdWBi7epnGOPmMquTFtDdeSlykBCNyO sQZtrfzJ9RWPuAutsxjknx080bikXvCDPAUuTYVdu0vWma3jGW8yDwyCmTTi++HXrpKA mYRbI71sfDc8QApXcNtIghr9y7WOPOqyKpEoC/ITPH7XQzjVBE3LggrfrFJ7WoEt9JzG ux/ji7OnACOSTQBRLPbd5ZuAetq56RyCcVxoVWYNGsEw96Q/TXVT1cTYzeA1IUCE6sI3 vhFmyn9V6IRjoyACj2GjsMw+hxQvCE2V2fcAfKDQwFhOr5BCRj2P49KHcufr6nKx1uEd Rogw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=FqEi+/XTwhjJx+teh0VZHO9fGFkl45zKK9jGXXsLq8E=; b=OFb5WeZ3jgmPJtWt/KY0rlCpQYH/izGtOUfz8aR6U6+2sfFG8F/ZQ3W+2MyqgV7etY bVVZAHqD0FL30dsfvcwSdeYF8q9sYMkPT4wJFFXZwa68qLsmCXb9yCOinAQenPsKh6pK Nw8+BQLx4+l1gAzwA2RlpF5UJqCTfE+PPcB97Y0U6pkJILbSOAU/aTKh17KRikhKRwCm ZKMKkjHhKzY/2KtQwreonLHBQE4mQoL8/QiVxsMjA7qmNNSsPsvcCGYHOk4ylccyuox0 CEuN1awlll/4UB+Sw9bwo37y70ZsPxQXjfTPurho1vAOB/6e2KxTpmv8sPPNiSrKi3DM NUyg== X-Gm-Message-State: AOAM532AB+lYvoX3Upo/RFUhjaS8PGUwxW9Rkyf7+q/aTJ9+ZXKtIntn oTPNOVgRVKFXGJlcFad2Eio9NDydIPXTBw== X-Google-Smtp-Source: ABdhPJziYp3J+vccafhZluJNSOIbcnmhm90TNhgsZDzgT/6yP+Q0+5JwkcB2lC96OZ7X2inSgrpJgA== X-Received: by 2002:a05:600c:21d4:: with SMTP id x20mr1090530wmj.58.1616106538991; Thu, 18 Mar 2021 15:28:58 -0700 (PDT) Received: from localhost ([51.37.106.140]) by smtp.gmail.com with ESMTPSA id j30sm5273062wrj.62.2021.03.18.15.28.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 15:28:58 -0700 (PDT) From: "Basil L. Contovounesios" To: control@debbugs.gnu.org Subject: control message for bug #47234 Date: Thu, 18 Mar 2021 22:28:57 +0000 Message-ID: <87eegcumdy.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) found 47234 27.1.91 quit From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 19 03:02:45 2021 Received: (at 47234) by debbugs.gnu.org; 19 Mar 2021 07:02:45 +0000 Received: from localhost ([127.0.0.1]:48637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lN99g-0003ey-Sj for submit@debbugs.gnu.org; Fri, 19 Mar 2021 03:02:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lN99f-0003el-1N for 47234@debbugs.gnu.org; Fri, 19 Mar 2021 03:02:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45266) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lN99Y-0007l3-8h; Fri, 19 Mar 2021 03:02:36 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4616 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lN99W-00059x-Ca; Fri, 19 Mar 2021 03:02:34 -0400 Date: Fri, 19 Mar 2021 09:02:37 +0200 Message-Id: <837dm3fwxe.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" In-Reply-To: <87h7l8umlp.fsf@tcd.ie> (contovob@tcd.ie) Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> <87y2eko0js.fsf@mail.linkov.net> <83mtv0fgbu.fsf@gnu.org> <87v99owali.fsf@mail.linkov.net> <83ft0sfcsx.fsf@gnu.org> <87h7l8umlp.fsf@tcd.ie> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47234 Cc: rudalics@gmx.at, 47234@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: "Basil L. Contovounesios" > Cc: Juri Linkov , rudalics@gmx.at, 47234@debbugs.gnu.org > Date: Thu, 18 Mar 2021 22:24:18 +0000 > > Eli Zaretskii writes: > > > After thinking some more about this, I think we should leave the > > frame.el part of 6c5ddf0e0b alone, but augment it with the fboundp > > test, such that on TTY frames the tab bar would be included in the > > frame's inner height, like the menu bar is. This is also consistent > > with what happens on TTY frames in a build with X: tab-bar-height > > returns zero. > > > > Basil, can you please install such a change on the emacs-27 branch? I > > will then make another RC. > > Done: Thanks. > Is there anything left to address here on the master branch, or can this > report be closed? I don't think we should do anything different on master, no. At least not without a good reason and/or a valid use case where this gets in the way. Martin, do you agree? > The other --without-x warnings in frame.el are benign, and I'll try to > look into the rest of them soon, but none of them sound too alarming at > first glance (famous last words). The only kind of problem they could reveal is if those functions are actually called at run time in a build --without-x. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 19 04:15:02 2021 Received: (at 47234) by debbugs.gnu.org; 19 Mar 2021 08:15:02 +0000 Received: from localhost ([127.0.0.1]:48717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNAHe-0005SN-3C for submit@debbugs.gnu.org; Fri, 19 Mar 2021 04:15:02 -0400 Received: from mout.gmx.net ([212.227.17.22]:57321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNAHc-0005Rr-Au for 47234@debbugs.gnu.org; Fri, 19 Mar 2021 04:15:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1616141692; bh=cvt8v99SUmp4EaplO7cRwrcdtYbvWlioDaYKicX1kDg=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=RvWS2oC4BdMOfZYBFBYVS6dkFcX6Jdrv+IdmBj3l1xtVCPxSP3Cj94yrFNzi1O/hs C/DSIZrp7RCyFGiMiU2Kp5+uWcUQ3mBNZvnH7m2dJU7BwWd89+99q8tBWASGVaabLf sEWt2K0kUZYXDJgo4iUHVwSqJWjMo3f2353nx0HY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([213.142.96.218]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N8XU1-1ljWVZ2M2j-014PPu; Fri, 19 Mar 2021 09:14:52 +0100 Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height To: Eli Zaretskii References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> <87y2eko0js.fsf@mail.linkov.net> <75bea13b-8302-5317-c4bc-84a710383420@gmx.at> <83lfakfg02.fsf@gnu.org> From: martin rudalics Message-ID: <776ace20-0dfd-d810-639b-ce4c2257ddb1@gmx.at> Date: Fri, 19 Mar 2021 09:14:50 +0100 MIME-Version: 1.0 In-Reply-To: <83lfakfg02.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:eoOqHYVI9Pf+G6fKZwjoWBeV12N8NgtxY5Sus0gssmpX1qxEZMN LHFZ4CE5qRiX7F75qEHrG15XMHpNWGRhVblKsd8b/HK86SNEZtr1+IMUJDvKy1WIqQqnRTX WRr9JPPUNvy93D4uRpKoKYbliQ6YJx1idwQr27FL3uMwIyYjjngMHjZZCxnIeJLs3H/UtRc 5Dqr+pYtuA6wi4wnLl5gQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:cNc36H+eDmQ=:2mIl+Km108p8NuIokJ0vuv wtnOyxhfMWK+G9IKMev/txulP5yvSX2VDtQE20KYJsfIZbG+tL57hMBu65EdgeLUlqLf7sLpx q0WR09zh0MSC6d9/jMwkCe4zmaRuDgnR3apUCSpD+2txHy3ZNy1fX64mhvTFmDlo3hR/iEM5+ LNFYsY0BB2WF0j0cwrZscWwprHtt/StG6QEyRAVL/sl1CfvxH5mqJgd++Vu1wd8aCV770L6E6 I72ZkDLTCdu121c7SXOtq2afqgC8qwvPob7L4H+9MuSEHKSMrMOOhZOgS/ioyXP6VC7EktD1+ UZs4MpjIAKEiZjsb4L8ksYBwUwQ5h1NO+IgDdGQMpNHg/8YAM8jurMHmWR/RohGAhDoPCR3lZ wGv2TWObxQRoSCbGyik67w4WBAxLnK/f4FqPCnnNkP+XTQDsseQfBHogUN8L0/ecR9mkDGluu Hu/iD6TNaHA7KNa6nfHcJHmyUakQO7pBgpnA2446zsmAGQZ1Xw+5RfzAf/2FcwpRi32nIVmAQ Jb8hCnktzTKz7mCK2OZTBrNwrZQIi7JSW7LqkQn1MQGX4jKDwx8pXvGcY2y/4A/cZvZTx+dqd D6fwA+tdSZ+Ko8OTh/5PAdDrSbsSlZaBUkrtGT7JV9UJhNWQGzvHE4BQ60qiNobzLfMQo8Vvp A5MpzbT1KgKI6IT5ugJrGt7GPA5qoHQXUbDBqzhM320AHV6KGXDi/ewjGIhPN4cZnbVha2t6t z/eu2CGs/hhfTm6GwSZQfKQxeR3LFEE1r3cK5Yw9itAycLoK36JfTkMfd8ZACWBtL782m70V+ fAIyGiAP9Ha4eZgCtjcH8G2mb0a2HJDQ2OPnmc6ps5zWwkE65HMYsv3o/qUkXY93BizuV+fyr 1XymxlkJvVmBPR5CDTww== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47234 Cc: contovob@tcd.ie, 47234@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Then it's best to revert the frame.el part of 6c5ddf0e0b. > > Ugh! My apologies. I didn't expect anyone to care about this. For the interested, a short history of that function: When I started to implement child frames for Emacs, I noticed that while on Windows everything worked OOTB, the various GNU/Linux systems I use provided no mouse support for them at all. So to avoid any unpleasant discussions, I had to emulate the entire functionality in Elisp, several hundred lines of code in mouse.el. There, to make sure that child frames don't get too small during dragging, I added a test where I compare the inner height of a frame with that of the minimum size of its root window. It's the inner height because I have to drag the inner border of a frame - GNU/Linux doesn't give me another choice. And I wrote a separate function for retrieving the inner height because `frame-edges' then appeared to expensive for a function running in a tight loop like `mouse-drag-frame-resize'. I didn't care about the menu bar (GNU/Linux generally doesn't like menu bars on child frames) and the tool bar (so far I've not been able to make a tool bar reliably show up on a GTK child frame). So I silently ignored these in `frame-inner-height'. But I did notice recently, that there's no reason why a child frame should _not_ have a tab bar and that's why I made the change. Hence, basically `frame-inner-height' is just an internal function (it lacks the second "-" because it's defined in frame.el and used in mouse.el) supposed to work exclusively in the very limited context of frame dragging. It's of absolutely no use on TTY frames but something born out of the necessity to make Emacs work on systems lacking support for certain features. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 19 04:15:28 2021 Received: (at 47234) by debbugs.gnu.org; 19 Mar 2021 08:15:28 +0000 Received: from localhost ([127.0.0.1]:48723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNAI3-0005tJ-Qf for submit@debbugs.gnu.org; Fri, 19 Mar 2021 04:15:27 -0400 Received: from mout.gmx.net ([212.227.17.22]:36255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNAHz-0005jZ-J0 for 47234@debbugs.gnu.org; Fri, 19 Mar 2021 04:15:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1616141716; bh=m6zPqumsyHU5Ta5eebV8aHSbEHOPxM6R+BIIOgFIes4=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=hkiMIY5TO0ihbDArGFBcktLYwYEBvA5h3/itIGDmo5eAjlviPKwgVT/tO78LDkPaL gfm5vd9sjETCgDyEK+RIUsgPVwum4h8LGW41+TBk1Qh61lRrlSGr1oZWdhOZw0H3t0 WsrhOBX2WAjScXwQWh86jgaSD9AEbK9x1CIYbHEA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([213.142.96.218]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MjS54-1m84pq1lf8-00kz0Y; Fri, 19 Mar 2021 09:15:16 +0100 Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height To: Eli Zaretskii , "Basil L. Contovounesios" References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> <87y2eko0js.fsf@mail.linkov.net> <83mtv0fgbu.fsf@gnu.org> <87v99owali.fsf@mail.linkov.net> <83ft0sfcsx.fsf@gnu.org> <87h7l8umlp.fsf@tcd.ie> <837dm3fwxe.fsf@gnu.org> From: martin rudalics Message-ID: <5c591bb9-c29d-dd00-c474-9b9b925ea63f@gmx.at> Date: Fri, 19 Mar 2021 09:15:15 +0100 MIME-Version: 1.0 In-Reply-To: <837dm3fwxe.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:WCBqyw1T8W6uBWArexNyj4+wKBWBnuTZFd52P0qhZEFPuf6i+fB uA/5M9L/sIo0lzstloBu879azAm9PU37l+SyEEh5zFS4elzKR/5k08ReVU5TWCVLfXC/KYo b4liFWArF1NHGPIiIuoMCvOsiXoGTcpQr+n8IQkwhqTqfLOcKaPCcyKtRKv1DG/mR3lsdq4 hitn0XcuFNu1f8reKQfiA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ig3mKldQWsE=:efijIVXoh0w61QUZ4tKW25 gm4VVGh/ECclbM6YBjdjITUpxAtoAfcrj7tbfFCu4e7xWNoVqAurGG6jqe+Z3rYHPTeEbaY/R 2Tj/uzlO1QWtNULVH0Z3/dfzoJfw3vvDsH/+3s3a9cmdX4weN1Ka0D6r3bFGBGj+nydlVMA+5 SM18y3XChhEISc2jD+0iA9m6rgFIHMeG/QwrT78wdEMRKSRBTGlage6XnbKDtErjp1dHDj+lS KKDIWq9Nr3H0Ign4CPz5v4jVmMIeIjBcHr71cvTUsTZqvhCwiWSclMDi91TZ4kvitk4gmiPOS 2DJWGlOwMS3lnDpVXcgQXl+XFfMQmcfScG0UhTa3OK6yafCtA1cdo09pgfxW/tMIHlZTtMEVz E+Ao1QNdNXjWeH6ycqs1wxXBMmQyY94XsRx5wuvN/UJk78r4PyL+KIGShnJR0OwKWPGdCd8k9 A2DYNPLfPUUidtQK0IV0rpzIk0nOmkjViJxjwFn+lC91ViBEcfaeXEbsRgsD9s3k/Z0CjNG9e 93LmGKHh8zZ0jsxL8q77PtQRHAzb03BwPpfX2zByEpbCH0H54EViadrY7/vLOwYcQpS71lFwz u9l9X4a4Q/6nlWQjVB8nn6BRj54SoYiKzbNJczrSr0QAGbV+5nsogq3nDjMsfYdRial4pU4vz 9na5okXk452f9FqM4fAlMcxqbuZX1NZO9XgZZc+8v695SPM6iv+l6Hm1AYOHwoKRsFx/ETFyc JrOB9CzXbmhEzfDriXHwNAcjUXhfRzqel++r/9xrXlQuSgdX9qiauOr8ZTI4cFVzZMqZQif0l 08p3sdngNiUXiqEkdzl8H0NBsAM8hg6cLo0p0VMWVrY3dLS8urZSTfZCGJpldVbZPJVUlj8RK tOP7cflS7jzD4WY7C6IQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47234 Cc: 47234@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I don't think we should do anything different on master, no. At least > not without a good reason and/or a valid use case where this gets in > the way. > > Martin, do you agree? Yes. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 19 04:22:06 2021 Received: (at 47234) by debbugs.gnu.org; 19 Mar 2021 08:22:06 +0000 Received: from localhost ([127.0.0.1]:48733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNAOT-0007lU-Ps for submit@debbugs.gnu.org; Fri, 19 Mar 2021 04:22:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNAOS-0007kz-1w for 47234@debbugs.gnu.org; Fri, 19 Mar 2021 04:22:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46231) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNAOM-0008Lg-9V; Fri, 19 Mar 2021 04:21:58 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1545 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lNAOL-0006y6-P9; Fri, 19 Mar 2021 04:21:58 -0400 Date: Fri, 19 Mar 2021 10:22:00 +0200 Message-Id: <83wnu3eeon.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <776ace20-0dfd-d810-639b-ce4c2257ddb1@gmx.at> (message from martin rudalics on Fri, 19 Mar 2021 09:14:50 +0100) Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> <87y2eko0js.fsf@mail.linkov.net> <75bea13b-8302-5317-c4bc-84a710383420@gmx.at> <83lfakfg02.fsf@gnu.org> <776ace20-0dfd-d810-639b-ce4c2257ddb1@gmx.at> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47234 Cc: contovob@tcd.ie, 47234@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Cc: juri@linkov.net, contovob@tcd.ie, 47234@debbugs.gnu.org > From: martin rudalics > Date: Fri, 19 Mar 2021 09:14:50 +0100 > > >> Then it's best to revert the frame.el part of 6c5ddf0e0b. > > > > Ugh! > > My apologies. I didn't expect anyone to care about this. I care because this change, which was made 1.5 months ago, popped up just hours after I made RC1, which I hoped could become Emacs 27.2. Murphy's law in its finest, I guess. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 26 13:44:50 2021 Received: (at control) by debbugs.gnu.org; 26 Mar 2021 17:44:50 +0000 Received: from localhost ([127.0.0.1]:42371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPqVu-00028x-Ap for submit@debbugs.gnu.org; Fri, 26 Mar 2021 13:44:50 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:33380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPqVs-00028c-Fr for control@debbugs.gnu.org; Fri, 26 Mar 2021 13:44:48 -0400 Received: by mail-wr1-f52.google.com with SMTP id o16so6490222wrn.0 for ; Fri, 26 Mar 2021 10:44:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nG7a/AzHORN4Uf63Q2CTopMVq68cjVmcebUg1anR+BU=; b=WozUMssojpXQdDHDKQrUMznCsNb//nln9nhNxGRMcvw/6Rj2uZImqAX0ZnfCsitcVn KniI2ncJUcK1WUaR+qBFUFCNVgj/NmG0EGTXML+2yUzie8/12mb3Zcgq+M68qUch5fDs ezkMupsvYf2vR0NNiM1YXtsFzc9reRojlL0Hx3PyVZ6Qe6JU75OwfD7TJx9DPDl0d36i ENUtQPHvv8QbFN47uf+Bm+ornhJ1hI0hb8mqjqiioCfAiYYercCVbTQ/pc/OhVWgouck kAxGTpMdBu89ibHz8f/uBq3AiKh3qr/+Px2EjUdDXbSdtd7QaXl2c5WA2QBME6kjeRIH CTVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=nG7a/AzHORN4Uf63Q2CTopMVq68cjVmcebUg1anR+BU=; b=FQY9QAvoVY2XmWuGIv/ahmhBm870r8r3jsdqrZJbjg4s0uC0SteD98CY4ljgHEcGt8 LlUlPheoZw+3xdYt6Up0qRN+MmPTnH0q94jJm0wYDJciDaJtn5hZV+R06SvrkoS29kmn jJ9ICMi5GxJOZZeDB8sPYz5G4zgPyRqnFc4qRmIPonfhvJG//AOxPjrhCZuvI2qcDlcU J/SAFDoah5olyGnZKsUaOLMS9zNyMpVC9QU5fS0EeesTkWzgBxMXbydf2/v2/BCsz6zx cbWwXKBpMo6O8Ibnhpci+K8BO3OC2nu0ZKhNLJTn6tcEbz+WJQRZ578IhONjjx6XqsD9 YiIw== X-Gm-Message-State: AOAM531ssYjVRWm8Rg8bUWhymMsb+lAlu1AWpvMbwGJFBzt27ZtI1RL0 PoL6zIWOFk61xDekzqvEZf9ZqA== X-Google-Smtp-Source: ABdhPJxyZn6oikxxtGHy4ui3zIa0BOu17Bq5aM4p75d1Qp19f1CWQWIdSofbhTYLf3XmXgqYfpuNEA== X-Received: by 2002:adf:8523:: with SMTP id 32mr2224598wrh.375.1616780682874; Fri, 26 Mar 2021 10:44:42 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id a14sm14693756wrg.84.2021.03.26.10.44.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 10:44:42 -0700 (PDT) From: "Basil L. Contovounesios" To: martin rudalics Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height References: <87zgz0wpe7.fsf@tcd.ie> <837dm4h6uk.fsf@gnu.org> <877dm4o6fj.fsf@tcd.ie> <83zgz0fqcs.fsf@gnu.org> <87mtv0lc53.fsf@tcd.ie> <87y2eko0js.fsf@mail.linkov.net> <83mtv0fgbu.fsf@gnu.org> <87v99owali.fsf@mail.linkov.net> <83ft0sfcsx.fsf@gnu.org> <87h7l8umlp.fsf@tcd.ie> <837dm3fwxe.fsf@gnu.org> <5c591bb9-c29d-dd00-c474-9b9b925ea63f@gmx.at> Date: Fri, 26 Mar 2021 17:44:40 +0000 In-Reply-To: <5c591bb9-c29d-dd00-c474-9b9b925ea63f@gmx.at> (martin rudalics's message of "Fri, 19 Mar 2021 09:15:15 +0100") Message-ID: <87im5dlshj.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: Eli Zaretskii , 47234-done@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 47234 fixed close 47234 27.2 quit martin rudalics writes: >> I don't think we should do anything different on master, no. At least >> not without a good reason and/or a valid use case where this gets in >> the way. >> >> Martin, do you agree? > > Yes. Thanks, then I'm closing this report. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 26 13:46:12 2021 Received: (at 47234) by debbugs.gnu.org; 26 Mar 2021 17:46:12 +0000 Received: from localhost ([127.0.0.1]:42391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPqXE-0002Cr-4k for submit@debbugs.gnu.org; Fri, 26 Mar 2021 13:46:12 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:38702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPqXB-0002Cd-EN for 47234@debbugs.gnu.org; Fri, 26 Mar 2021 13:46:11 -0400 Received: by mail-wr1-f43.google.com with SMTP id z2so6442938wrl.5 for <47234@debbugs.gnu.org>; Fri, 26 Mar 2021 10:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=tEwybjdVpP6h3z8khAwhiidlyoutg+c5T68c5E6ddQU=; b=WUduppFKxUBvesxePdmh3hHYrutx54wjd2xeCyr0wJWKCI8rWFSEYZpmCSOZeWkQle WUiCA5XS8IQzshBUuC/CQlpUu9KLHCrSwa5lOV4BmKEWogiMDFeLSAQgOh60WNWL6/4G roR4CnUHaZJqMz1/VR6SXRFXbE9KgwEV8+C3bb3/+nLvUY/eT12KTRnv6D5EiRUa7t8V 3xz2LtVXckN6XjqCQtzHqznHzu/URhNXevK0seuLq79syCeYgtsTVpcyT0IOLv7OSmir HbFt1pDOy/msWiu9Ob0co6jZzrMEizf4UBonWBTkwZ5WjTvF/R7uLtI+kf8fdIjgkyxP pK7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=tEwybjdVpP6h3z8khAwhiidlyoutg+c5T68c5E6ddQU=; b=PCt1j+3OCkJDjhIwRR8ovtDHNVSVnYFlP5qQlXkRM4Ctz23+8Ttuj/Qx6Zp8IWeXEI TIvHmaaL2VIxYr8V50Bj0qeR3FnIVOqd4L++2jVsZj01X/3fr6Od6x4wSlnm8ukAgv0u 0HjsE5YHpN86ZzV3HWnUBnMswva1aSTmvDM9qmHn0DKl2BW8R/UAU+hfQF2B4EoreXY4 htZH9B/MXQoFrcMPpM5Z6ZkWwHYYkg6bRT/p+29MIJCRJWIr6NdKE2e5oQzSv35OsTmm +Xn4dvRM0qnjaMTmT/VXSwqWBjnmxAsIHMlBqs1Iwyc353tBv8+WT8AS3Xl+yusEvjd0 cmLA== X-Gm-Message-State: AOAM530K20kh8QJ9G0lAFMEwDACVeH4BpHjIziVPpENFHImG0ZiPJDX1 HnW4byBs1CLJJLKt2Cf0V0LGllddy9WxbTOI X-Google-Smtp-Source: ABdhPJy6/6oalNdaVjnrP5SCi6yKJWIl7tgbQjQFp4r5bMV6Ch4BSTrdRp/bCBYn1wkTa8JEmUptRg== X-Received: by 2002:adf:f743:: with SMTP id z3mr15818923wrp.304.1616780763790; Fri, 26 Mar 2021 10:46:03 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id o7sm14332953wrs.16.2021.03.26.10.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 10:46:03 -0700 (PDT) From: "Basil L. Contovounesios" To: Juri Linkov Subject: Re: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height References: <87zgz0wpe7.fsf@tcd.ie> <87wnu4mkhy.fsf@mail.linkov.net> Date: Fri, 26 Mar 2021 17:46:02 +0000 In-Reply-To: <87wnu4mkhy.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 18 Mar 2021 19:36:57 +0200") Message-ID: <87blb5lsf9.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 47234 Cc: martin rudalics , 47234@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > There are the following warnings on the emacs-27 branch with --without-x: Thanks, should now be pacified on master: Address some --without-x byte-compilation warnings 331ddd803a 2021-03-26 17:35:34 +0000 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=331ddd803a72056d0f0c70e5a677e0d4a6300584 -- Basil From unknown Wed Sep 10 15:50:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 24 Apr 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator