From ken.manheimer@gmail.com Mon Jun 23 10:45:03 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.9 required=4.0 tests=BAYES_00,FOURLA, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 23 Jun 2008 17:45:03 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5NHiwb9024517 for ; Mon, 23 Jun 2008 10:44:59 -0700 Received: from mail.gnu.org ([199.232.76.166]:42534 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KAq60-0000J7-Fu for emacs-pretest-bug@gnu.org; Mon, 23 Jun 2008 13:44:52 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KAq64-0005xq-49 for emacs-pretest-bug@gnu.org; Mon, 23 Jun 2008 13:44:58 -0400 Received: from wf-out-1314.google.com ([209.85.200.173]:55957) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KAq63-0005xK-Co for emacs-pretest-bug@gnu.org; Mon, 23 Jun 2008 13:44:55 -0400 Received: by wf-out-1314.google.com with SMTP id 28so2168156wfc.24 for ; Mon, 23 Jun 2008 10:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=BFiYrm+uHvYhYl1juV9NteNrKdxU+pgBanPt5YINoVY=; b=xjliKNOtky0n5An1qegifeq5nxjDWQH441VVqOxtup3TIrd3bySAtcRDnXFeOC0lP7 PMNkRwGtWf42O/pEXjAfYWmTF6GQBGL4ePZnB2LswgPTSTnf/VjPSzjKpcp0+PzNt5w4 ueOXY8p77rwNXIYkuDS1OzX6fkvl1cz7epnJU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=PcJf+wXW+akOLNyZT62a4EE05u9A4SLGUm26YjCEYzuPB4DBzDD+NeZEGJ6Kbryx3T gn2XEWCanloceR3GoQK6Cjjvc0qlMzIdSDQFVamNwDIljh1PcBbJMlKLnjRZqQEN3pnB No3PdZg1l5s5oto1BBxVqebZE+DNO1cg0ISVM= Received: by 10.143.7.5 with SMTP id k5mr4182058wfi.327.1214243092669; Mon, 23 Jun 2008 10:44:52 -0700 (PDT) Received: by 10.114.201.14 with HTTP; Mon, 23 Jun 2008 10:44:52 -0700 (PDT) Message-ID: <2cd46e7f0806231044w6410b825s9611ba713e9ac353@mail.gmail.com> Date: Mon, 23 Jun 2008 13:44:52 -0400 From: "ken manheimer" To: "Thien-Thi Nguyen" Subject: Re: pgg-gpg.el - pgg-gpg-process-region timing problem Cc: wilde@sha-bang.de, emacs-pretest-bug@gnu.org, ueno@unixuser.org, emacs-devel In-Reply-To: <873an4b898.fsf@ambire.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <2cd46e7f0806221037h6d16839bp567eb5b901313375@mail.gmail.com> <87zlpc8t00.fsf@ambire.localdomain> <87r6ao8rty.fsf@ambire.localdomain> <873an4b898.fsf@ambire.localdomain> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) hi, thi. thanks for the responses - i'm glad to see investigation into this. i've tried both the patches, and both hang for me on the pggprob.el test. the hang is interruptable with Ctl-G keyboard quit. i tried stepping through the second patched version with edebug (including disabling the '(inhibit-redisplay t)' let-binding, which thwarts edebug stepping), and found the hang happens at the first '(accept-process-output process)'. (it hangs at the second one if i don't provide a passphrase.) i'm not sure what's happening. in case it helps, gpg 1.4.6 is what's running on my system. -- ken http://myriadicity.net On Mon, Jun 23, 2008 at 9:17 AM, Thien-Thi Nguyen wrote: > Delving into this, i got a little carried away... full func below. > This adds GOOD_PASSPHRASE checking (necessary for GNUPG 1.4.6, at > least) and some other coding-system related finessing, but removes > the sentinel proposed in the first attempt. In its place, we zonk > the baleful `process-adaptive-read-buffering' and remove timeout > parameters from `accept-process-output' calls. > > With this func things seem to work fine for `pgg-sign' on a small > buffer, and mostly for large buffers (270KB), but sometimes (~10%) > with large buffers, i see a "file error: bad address *GnuPG*". Hmmm... > > thi > > ______________________________________________________________________ > (defun pgg-gpg-process-region (start end passphrase program args) > (let* ((use-agent (and (null passphrase) (pgg-gpg-use-agent-p))) > (output-file-name (pgg-make-temp-file "pgg-output")) > (args > `("--status-fd" "2" > ,@(if use-agent '("--use-agent") > (if passphrase '("--passphrase-fd" "0"))) > "--yes" ; overwrite > "--output" ,output-file-name > ,@pgg-gpg-extra-args ,@args)) > (output-buffer pgg-output-buffer) > (errors-buffer pgg-errors-buffer) > (orig-mode (default-file-modes)) > (inhibit-redisplay t)) > (with-current-buffer (get-buffer-create errors-buffer) > (buffer-disable-undo) > (erase-buffer)) > (unwind-protect > (let* ((coding-system-for-write 'binary) > ;; GNUPG 1.4.6 does not terminate on bad passphrase, eg: > ;; [GNUPG:] BAD_PASSPHRASE (long hex # here) > ;; gpg: skipped "ttn": bad passphrase > ;; gpg: [stdin]: clearsign failed: bad passphrase > ;; so we need to check that condition ourselves and bail out. > ;; > ;; To check if the passphrase is accepted, we need to parse the > ;; errors-buffer, but `process-adaptive-read-buffering' non-nil > ;; sometimes prevents it from filling. So turn it off. > (process-adaptive-read-buffering (not passphrase)) > (process (progn > (set-default-file-modes 448) > (apply #'start-process "*GnuPG*" > errors-buffer program args))) > (status (process-status process)) > > exit-status) > (set-process-sentinel process nil) > (when passphrase > (let ((coding-system-for-write (or pgg-passphrase-coding-system > 'binary))) > (process-send-string process passphrase)) > (process-send-string process "\n") > ;; Bail out if passphrase is not accepted. > ;; MAINTAIN ME: Tested against GNUPG 1.4.6. > (let (result) > (while (not result) > (accept-process-output process) > (with-current-buffer errors-buffer > (save-excursion > (goto-char (point-min)) > (when (re-search-forward > ;; BGM: BAD, GOOD, MISSING. > "^.GNUPG:. \\([BGM][A-Z]+\\)_PASSPHRASE" > nil t) > (setq result (match-string 1)))))) > (unless (string= "GOOD" result) > (error "Passphrase no good")))) > (process-send-region process start end) > (process-send-eof process) > ;; TODO: Re-enable `process-adaptive-read-buffering' here. > (while (eq 'run (setq status (process-status process))) > (accept-process-output process)) > (delete-process process) > (setq exit-status (process-exit-status process)) > (with-current-buffer (get-buffer-create output-buffer) > (buffer-disable-undo) > (erase-buffer) > (if (file-exists-p output-file-name) > (let ((coding-system-for-read (if pgg-text-mode > 'raw-text > 'binary))) > (insert-file-contents output-file-name))) > (set-buffer errors-buffer) > (if (memq status '(stop signal)) > (error "%s exited abnormally: '%s'" program exit-status)) > (if (= 127 exit-status) > (error "%s could not be found" program)))) > (if (file-exists-p output-file-name) > (delete-file output-file-name)) > (when (get-process "*GnuPG*") > (kill-process "*GnuPG*")) > (set-default-file-modes orig-mode)))) From rgm@gnu.org Fri Jun 27 17:05:40 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.8 required=4.0 tests=AWL,BAYES_00,ONEWORD, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at control) by emacsbugs.donarmstrong.com; 28 Jun 2008 00:05:41 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5S05cWK021577 for ; Fri, 27 Jun 2008 17:05:39 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KCNwU-0007Gc-Mf; Fri, 27 Jun 2008 20:05:26 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18533.32838.630845.565243@fencepost.gnu.org> Date: Fri, 27 Jun 2008 20:05:26 -0400 From: Glenn Morris To: control@debbugs.gnu.org Subject: merge X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: red X-Ran: 0l8Y8"+,#K:tVUK4-6)g~|Bq0yDez#"#7T(`&1glAAW`CxxS4PDCnpVNF]uO#]E-9tm'k4 merge 465 469 470 471 472 474 476 486 487 From unknown Mon Jun 16 23:45:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Sun, 31 Aug 2008 14:24:04 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator