From unknown Thu Aug 21 14:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47167: Multi-line comment-region with empty comment-continue Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Mar 2021 17:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 47167@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16158282513283 (code B ref -1); Mon, 15 Mar 2021 17:11:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Mar 2021 17:10:51 +0000 Received: from localhost ([127.0.0.1]:36663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLqjz-0000qs-56 for submit@debbugs.gnu.org; Mon, 15 Mar 2021 13:10:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:44772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLqjx-0000qd-6L for submit@debbugs.gnu.org; Mon, 15 Mar 2021 13:10:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLqjw-0005OW-Tn for bug-gnu-emacs@gnu.org; Mon, 15 Mar 2021 13:10:48 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:56527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLqjq-0003eA-4N for bug-gnu-emacs@gnu.org; Mon, 15 Mar 2021 13:10:46 -0400 X-Originating-IP: 91.129.108.46 Received: from mail.gandi.net (m91-129-108-46.cust.tele2.ee [91.129.108.46]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 4D422E0004 for ; Mon, 15 Mar 2021 17:10:36 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET Date: Mon, 15 Mar 2021 19:03:22 +0200 Message-ID: <87a6r4muw5.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=217.70.183.196; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Tags: patch Tried to customize 'comment-region' to use multi-line comments, so when commenting out such region in html-mode: line 1 line 2 line 3 instead of adding comments to each line: to add comments only at the beginning/end: According to the documentation, a legitimate way to do this is to use such customization: (setq-local comment-style 'extra-line comment-continue "") But currently it has no effect. So needed to fix newcomment.el. One possible fix is to return the original string from 'comment-padright' even when the string contains only whitespace. Maybe this would be the right fix, but still not sure about other calls of 'comment-padright'. So a safer fix would be to do this in the caller: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=comment-region-padright-continue.patch diff --git a/lisp/newcomment.el b/lisp/newcomment.el index ea47eec4fd..a5bfb06795 100644 --- a/lisp/newcomment.el +++ b/lisp/newcomment.el @@ -1300,7 +1300,11 @@ comment-region-default-1 (let ((s (comment-padleft comment-end numarg))) (and s (if (string-match comment-end-skip s) s (comment-padright comment-end)))) - (if multi (comment-padright comment-continue numarg)) + (if multi + (or (comment-padright comment-continue numarg) + ;; `comment-padright' returns nil when + ;; `comment-continue' contains only whitespace + (and (stringp comment-continue) comment-continue))) (if multi (comment-padleft (comment-string-reverse comment-continue) numarg)) block --=-=-=-- From unknown Thu Aug 21 14:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47167: [External] : bug#47167: Multi-line comment-region with empty comment-continue Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Mar 2021 17:36:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov , "47167@debbugs.gnu.org" <47167@debbugs.gnu.org> Received: via spool by 47167-submit@debbugs.gnu.org id=B47167.161582973614792 (code B ref 47167); Mon, 15 Mar 2021 17:36:03 +0000 Received: (at 47167) by debbugs.gnu.org; 15 Mar 2021 17:35:36 +0000 Received: from localhost ([127.0.0.1]:36834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLr7w-0003qW-6w for submit@debbugs.gnu.org; Mon, 15 Mar 2021 13:35:36 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:52444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLr7u-0003q5-Ik for 47167@debbugs.gnu.org; Mon, 15 Mar 2021 13:35:35 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12FHV8g9035679; Mon, 15 Mar 2021 17:35:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=YkM78DTw9LC16pxPO47q+FqHbcoeLr0WSUO44+M5QxI=; b=SU52KATdZgpobl1lnKtIeH5iqmVoAIBlH7Ndu0HhUOs7PM+6kJNnF65xxIWonvB01Sh1 dOsoJqGuqE5Ww0ZMr6U3z6mORSeJE+znJ07GNdRdEagCeVKTPhFnimPhHBqi5cygm2DC B53SA6lLFYf16L85bGKkCjnKt6py8gR9jyMa9zuoPecz7NyyySfqEyToH+YTM1PFW8RU AKcXUBsTkkUYl6JnFPAzmLF76RHqDfxPdSB1JpW0jeZgfjrht9EO2y95RpZARkitFENI syLqF/1G8Pr87k7wY/OtQyYE++1IAWkYPsWfa7ip7ZeYDA7dL5zIG9dMo7SAD0P8sxIa kQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 37a4ekhqkt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Mar 2021 17:35:27 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12FHV9fl007209; Mon, 15 Mar 2021 17:35:27 GMT Received: from nam04-bn3-obe.outbound.protection.outlook.com (mail-bn3nam04lp2054.outbound.protection.outlook.com [104.47.46.54]) by userp3020.oracle.com with ESMTP id 37a4erufyd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Mar 2021 17:35:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lpv5o05UnN61sFe0CQqyEO0j/afmPtqh5s4vGNE8W+tQflcWFeaiGi8ajhIX9VaCUM4IlHwKVf+0WCX0YI+c/zewK20StHX/fVQRAzS5OjXyy9v6Iw+UV9xWiQlGt4p1UtP1fPQQdmaNJwPQG2VuZpM9TuKjyYfY8IYeofy3Ht0YRUhhKaW3iXelpAkAdmUGzg5D2SmWPFs6vBLeq3lVXjt/YUMOgfuDlai7HsS1SEcwlocVA06gIG8Kim7Yt2p7Z0iT1/lcHmy5oJx+tpTKNrt1EXakqh0YEcvLgOshTwh+Qag+1ygF5PtJxjuAFdXKKchGOXd5C+qPo/dVrFm4wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YkM78DTw9LC16pxPO47q+FqHbcoeLr0WSUO44+M5QxI=; b=XAUbkkbyJTWtrQIrtRR2qYUvICy3JXoBy5QbB4ZfIZuoGEIkx/tsiexhD3+1VYhJO4rMc/B0IOLRUSJ/hzLEjG7Uk2ZLnnfo6aG91kaIVlLbfKtHQ+e1YQRyiz3kDj1LAWPZeuDW6peQlI/ZjvbEpMlXsbAJgH8sf3KySi6ffCjSgbajK4XPc5tp0y9E18LRLcy8GnS1aBNz50W27/S2djwsahg9ofMV9RgDbg98LsIaStH3TAioqvO+tF96pmz1HrGO5yz7pqxqLiGaW9PVnf24vJR7Xw3CrZpPfZ9AQ2sd+oKaZ+5PI+gk0QDZa9kwqBUrncz16bCj5O4MS0DSiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YkM78DTw9LC16pxPO47q+FqHbcoeLr0WSUO44+M5QxI=; b=Ad6MNAq0VNObdpQHbv729oDjNbpfN7CBp77WX7siwC1dOb9qBsPEdm8jGmGs95klAGQTCqQGy1Tk9xklN/NAHKN5O/3bK0hKCaRWTyl6LzxyhClz4vC9eVo33hoJtKnxp+4w5M+97uuFfNh+NNA4sJQ4uHDB1qFAKzaQlRMeios= Received: from SA2PR10MB4474.namprd10.prod.outlook.com (2603:10b6:806:11b::15) by SN6PR10MB2480.namprd10.prod.outlook.com (2603:10b6:805:4f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.26; Mon, 15 Mar 2021 17:35:24 +0000 Received: from SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::b8d2:db6d:3e4b:d315]) by SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::b8d2:db6d:3e4b:d315%5]) with mapi id 15.20.3933.032; Mon, 15 Mar 2021 17:35:24 +0000 From: Drew Adams Thread-Topic: [External] : bug#47167: Multi-line comment-region with empty comment-continue Thread-Index: AQHXGcCZgstCO5Bu3kWz98Afppx7g6qFTnBA Date: Mon, 15 Mar 2021 17:35:24 +0000 Message-ID: References: <87a6r4muw5.fsf@mail.linkov.net> In-Reply-To: <87a6r4muw5.fsf@mail.linkov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linkov.net; dkim=none (message not signed) header.d=none;linkov.net; dmarc=none action=none header.from=oracle.com; x-originating-ip: [73.170.83.28] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a51de7c7-e21c-4720-6991-08d8e7d8b70c x-ms-traffictypediagnostic: SN6PR10MB2480: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: n9yRQoSTtU0bMgWFe/fEcqI5ARO862XY4+ZOCdlCM1RY63GFcdBRCt31Nck/+Ak5FC4Qsewm6V56zC7B+CRiVPA/+NTWM2UytlBFans2zMJR1IXgXQ130MvzV48K26jwpqGXxl68sJMxvw0zKyM0LhXGtKUNfpU/MmE5RdWhDMhm0pD/8Eq8SXk3KO/57EL0iDJlv/dH1k1UnXbC724DQBF/AP5jSrSThJ+vq6P7jzsAg3ZM7mAa8mOAPYwVkvcMiPbjNszpEIKRlY/KX4/YqSt/zyP/LTz1c1Bj5TYlYnY3QDhCDfuWCWOjuaduJ0dzfBT5NJ+AdQH5AOX+NUqV4hFRo8qNyZF2QHMymT4s/CyrD0ECVIJoPyiEeOvdJwyGAC7+DwLhT8fdDPMrVcePtVer98Etp1USsG+PYQFEqnCY7FhO/L14IS2oxpFYteugsSi7/Z5bEW1yWicacJ1R+R9kj0srBBi/xyDMctojqX+N5D+1nLcVRtcrD9+NeelxUYJeg77mWLxTr+vAFBf4Hg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4474.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(376002)(346002)(366004)(396003)(136003)(6506007)(7696005)(186003)(33656002)(26005)(64756008)(52536014)(55016002)(8936002)(76116006)(86362001)(71200400001)(66556008)(44832011)(2906002)(66946007)(5660300002)(66476007)(4744005)(478600001)(66446008)(8676002)(9686003)(316002)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: DkGUCL0FI5/5WzEcSPyihyvroyuwY3B7vmtuvW+tPM+m7Uixab/efJOXs3QnB5po+wnnqyfUyEE7n6wi2K+LUY87aHTRL3xRp9gAgTW7M5SJkocX8sJR3brFAX5wzvyT/bvzvXFY0O89u6b+7uijNXfX8wJ0GN7OAwTZnwHaxUQGeKNcoSvt9qfYNv/2W0ZkEaXyM6Dv9yTjTQDlBGI5Zff3iP2vHI2EX674FdeQMbbu+4xdiwqPcNeVGX2Q45fAqIAa3gb7uJQkrZvUK3rJOHSWOr0pAr6ML60DEssvRsZ4yvzdqhUlQprIguQCkxhfYVk/R+rCSf6pA7rIwhgZDjQ+SdIql0jdyFwvMe9+UrooNUBTQSdnnZ8wDByHPz4v4r4BOBDGAPkh4mCk+l60KX08GRNl42J8I8fDVBIIuWVUqh3pKmdhLTqGW7FND9pTsYiQ45+vxpG6Ag3+h3TzzKLNkjDAA0QQgN94K0f6FF+UTOKXBqKluIvu4J1us7VkhyAkwLj01l1jK4Gkg5QAMLdEDvRXekK+Pt7ssphNyPLYK1cQGRnq2WnpGPCw1pJf7GCFjrQr+XhxWFuAO6Ess+p2wwTKgXoNzODOiuu34NDKBOYXBoBq++SSxfcFaAWK4FIGi2/PnWJvODtoXEDt6sOqtoWL5Ki0CXza5pODVnOLAiPCVSk+ojbTIX75fWgYL2BflasuA1fgCEc4wB9iIzjOH4KUDvtxukdLCEYPhgHxgN2UzqXySY9WS6AVeCODOKRm8n5eYxqjYqfn9A2sqatOoBhwv6uY8rkb9fhqs6lkFmMTAF3yYo2FEyuE4iYVnOyz3XfMsT9QoSNZ3bXIvX2J5ywSxDf7xt1HyFtQ1bBXzpZWm3xwUCR6D3j4GydMU7d70dfLGBii/YKNtg6T1Ycz4aHnLJlikTpvUzMRKYZz1pIWtGHTZqwZy9HttTNN9kGDvXEzLOXwKnkruFYNYmpej6/Akt7t9MUxn67V7WwdOxnSg3gOooLiITwXl2LEk0p84+9xI/9qLgjhKsAf/N4ijsTOsRmfjeVsZvQiSgMCkAzfVo6ac2uLsjPrH57aThfTMyzkojHY9x8bCPLYBhKxufrdgkjNzqpi3GPJFMK204jSzVGOEkpx6MMmz3kIQeCofQj0l0cc/jFNsZNj+FyRpXsXLR35GzwPxDe6o3JSVctkkrkDgm7HaRzYtPWDpQ7daEHRVILL8zxMR6j8vsQMiD3aGios40XNLiTOfjQunaNKtpE2aZ4XID2kNpicD51M/3WXKzWInGD6TZ1aGoYz9Mw6bTOHf8KHwQXWWY1a4fV0HP59ueDU15bZmnVq x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4474.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a51de7c7-e21c-4720-6991-08d8e7d8b70c X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2021 17:35:24.1756 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3kSTTsuRQizPm0e1hy471egY7dbaDyIey1MhL6w0lbwTWGG46alUhPNxuDK4ePiCpP1EPgAc+KdqAVUfTQ+Qag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2480 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9923 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 mlxscore=0 mlxlogscore=874 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103150118 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9923 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 adultscore=0 phishscore=0 suspectscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103150118 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Tried to customize 'comment-region' to use multi-line comments, > so when commenting out such region in html-mode: >=20 > line 1 > line 2 > line 3 >=20 > instead of adding comments to each line: >=20 > > > >=20 > to add comments only at the beginning/end: >=20 > (Haven't looked at your patch.) Sounds like a reasonable, and useful thing to do. However, `comment-region' also has optional behaviors that involve its use of a prefix arg. How with those interact with what you propose? Do they even make sense (e.g. nesting comment levels and unnesting them)? My guess is that what's needed is a separate command. I'm guessing completely different prefix-arg behavior would be appropriate for multi-line comments. Maybe you can find a way to merge the two without confusing users (and the doc). Or maybe it's not worth trying to do that, and a separate command makes more sense. Dunno. From unknown Thu Aug 21 14:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47167: [External] : bug#47167: Multi-line comment-region with empty comment-continue Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Mar 2021 17:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: "47167@debbugs.gnu.org" <47167@debbugs.gnu.org> Received: via spool by 47167-submit@debbugs.gnu.org id=B47167.161591752420763 (code B ref 47167); Tue, 16 Mar 2021 17:59:01 +0000 Received: (at 47167) by debbugs.gnu.org; 16 Mar 2021 17:58:44 +0000 Received: from localhost ([127.0.0.1]:40970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMDxs-0005Op-4u for submit@debbugs.gnu.org; Tue, 16 Mar 2021 13:58:44 -0400 Received: from relay13.mail.gandi.net ([217.70.178.233]:21093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMDxo-0005OW-ND for 47167@debbugs.gnu.org; Tue, 16 Mar 2021 13:58:43 -0400 Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay13.mail.gandi.net (Postfix) with ESMTPSA id EB82780006; Tue, 16 Mar 2021 17:58:32 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <87a6r4muw5.fsf@mail.linkov.net> Date: Tue, 16 Mar 2021 19:47:37 +0200 In-Reply-To: (Drew Adams's message of "Mon, 15 Mar 2021 17:35:24 +0000") Message-ID: <87ft0vwhty.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > (Haven't looked at your patch.) > > Sounds like a reasonable, and useful thing to do. > > However, `comment-region' also has optional behaviors > that involve its use of a prefix arg. How with those > interact with what you propose? Do they even make > sense (e.g. nesting comment levels and unnesting them)? With (setq-local comment-style 'extra-line comment-continue ""), `comment-region' currently breaks HTML syntax because HTML doesn't support nested comments: --> With the proposed patch, HTML syntax stays valid: From unknown Thu Aug 21 14:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47167: [External] : bug#47167: Multi-line comment-region with empty comment-continue Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Mar 2021 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: "47167@debbugs.gnu.org" <47167@debbugs.gnu.org> Received: via spool by 47167-submit@debbugs.gnu.org id=B47167.16159227074628 (code B ref 47167); Tue, 16 Mar 2021 19:26:02 +0000 Received: (at 47167) by debbugs.gnu.org; 16 Mar 2021 19:25:07 +0000 Received: from localhost ([127.0.0.1]:41086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMFJS-0001CY-JM for submit@debbugs.gnu.org; Tue, 16 Mar 2021 15:25:06 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:44758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMFJN-0001Bv-Bu for 47167@debbugs.gnu.org; Tue, 16 Mar 2021 15:25:05 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12GJJbgG077580; Tue, 16 Mar 2021 19:24:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=iC2LGO5Gj9yw1txqutBmj76c5Q+h91r4eRnJRxFZEuM=; b=ZOlVADZDBW+o+xYQDiI5m5S1l470ei36V9TxX7Q4yWxW881s9NZTmvwDHygyQQntdVlt I9MvLtGCw/kqFoXX0WHsY7VMWeBpPmZ15OHQK/QGWW2fmgd5OgCkxCJGkn9vkziER25Z Zs5RBnqQOc7KSTfc9m9iQZEiiKiXYQyUlJOSXKPTnecpYqEacE3m+Z4KX94Q+mJvnA2c nrL7C3xkrG6fRPmhUtkgpnqK6hbD5hEZfukN+hWOgiLAJRX0v1inb6WIkPazafVeYlyQ RWkRlzj0cQQbcR3QMI9swUGCD4FNbkHudgpfWMdl5XJzTOoqan2H0btc4TuGdLJ2GQCA ng== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 378p1nspxn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Mar 2021 19:24:49 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12GJKgLE019422; Tue, 16 Mar 2021 19:24:49 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2103.outbound.protection.outlook.com [104.47.55.103]) by aserp3030.oracle.com with ESMTP id 3796ytvtrm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Mar 2021 19:24:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ByLuJSPuRufzAKaY+PbU68PIf+Ys1AJ9YAAHwji2gVcEC2GN2AOgUSNP9zF6PWlVufA3A/uzaB9unlrCn7LnZpAWWU2x7rkoEH0jp7jNcPDnp4YOlfdZ9/sUlIK+xsS/aKBpCfrj4KwV4LG6kLeRkOdLIyzpy8E5cBbk8iyJSuoCTSYIZkorNyB4umd/2kDH7rJdJdm2dvOzPJxYXB3Ds/6dsKxS6iti3xW8NRs9eyAe/YwjrvW3WH+NosB3XDtIK8+gvA66+z8JR5q7BgTbZrF3kKbVJWnS+bHFhjWj9k1ZW6BLsai9iB0lkCADj2IhgXdkN7BreGsyADQ0ZoKpDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iC2LGO5Gj9yw1txqutBmj76c5Q+h91r4eRnJRxFZEuM=; b=LRsMNy3fjiAavdqVksm1+40P2pNCXSf+VjvSjuJ/5a4LCkjooMqitDWEVCBbrKoZmoHTdJUNniykZR5wtnaufk18jNpwrmyGqcKxTVm60S3c++ofIbz3HwWi8oOMCaV3JcPodcqodNRwI1CVUt4N7L/0NwUS9E9ECO3dNiCodQ/cnB0JwOcj+YOIvTmmdAbZ1daN3b+/kops9MsOMbV5mytBdX+A5cnafkw3z3mL1jVlMkr78BKtp7sqjmDPHYYV+v2tUHkMsDirPWc9rKm1e5rVfEHsMo1IusDXOSgpklyaSDFSte0R4sAJVeSRGUYbSM/PwPwade5UdFjKfkqAXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iC2LGO5Gj9yw1txqutBmj76c5Q+h91r4eRnJRxFZEuM=; b=F3IvV01ZtsPwD1pe3PV7ydK811+RGEkk0BqPQQFSUNoY6oo9isNWMXhdzAK9F6p0Ki9cRUDQJg/m4tEO5q9LCnwtP1pIQIsNIrU2l/7IpbYxw6aKo+9N+BUObYF5I+4s/h6o5eP37mKP2ND0aaUh9O2+w25gjY6boK8ohx0TAPg= Received: from SA2PR10MB4474.namprd10.prod.outlook.com (2603:10b6:806:11b::15) by SN6PR10MB2735.namprd10.prod.outlook.com (2603:10b6:805:46::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.22; Tue, 16 Mar 2021 19:24:47 +0000 Received: from SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::b8d2:db6d:3e4b:d315]) by SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::b8d2:db6d:3e4b:d315%5]) with mapi id 15.20.3933.032; Tue, 16 Mar 2021 19:24:47 +0000 From: Drew Adams Thread-Topic: [External] : bug#47167: Multi-line comment-region with empty comment-continue Thread-Index: AQHXGo4CRjuSRAdAp0Ke3RoD5t9cgqqG/aBQ Date: Tue, 16 Mar 2021 19:24:47 +0000 Message-ID: References: <87a6r4muw5.fsf@mail.linkov.net> <87ft0vwhty.fsf@mail.linkov.net> In-Reply-To: <87ft0vwhty.fsf@mail.linkov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linkov.net; dkim=none (message not signed) header.d=none;linkov.net; dmarc=none action=none header.from=oracle.com; x-originating-ip: [73.170.83.28] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ba489203-ae36-4946-92ca-08d8e8b12940 x-ms-traffictypediagnostic: SN6PR10MB2735: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xRT7+yaERWTMBF3hAYDv5/b77uTeXbtVoVAFjabVlFgMbW0CWw51YrF6dTk7zDyKsts2gHxGRCRcTqLvUqP20lVoYfm64JufRXekB2tsIa8QzLssyThFDr7FMDU389FHs/dHoaDWgAcZc8qpOOZXt4fkoc7ikA5KSN6Un9QR5vLh50w8ObkNOj4hEC3adtVz2kKdmWfGtZBwSRwhBrmKsZE25xnCQFwSqZ20CSVUh9D4+FyB/+X5yhgXgxj3fcjZ6/pqLPn0Mwrl8PvsCaLttModw6CnXQbbrHoIsllWAPk1CBmO5Q/qzI+s5rcEuG6526xp/JZiQgkwVuuX/evytFLri2XmDHqpfJJ6HNsqC+sMIb2hE7dcT/plsVTADX1ax2Y1s3jjOaXOvB2TTOOlvkcfypXR+ZGGY/gcc6Hy0eS35MUCqqJz+bZkpCTrlD+Pj6w9lAUEubs35SYaEP7/K3Iy/P3usxueeHPD9/6+os1zGJhCx/51PDPH+ADORZT/M0YUXnA9p7IJL/z4nRa/Ew== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4474.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(376002)(346002)(136003)(396003)(39860400002)(44832011)(2906002)(26005)(4744005)(186003)(33656002)(66946007)(316002)(76116006)(66476007)(6916009)(8676002)(6506007)(66446008)(64756008)(5660300002)(66556008)(55016002)(9686003)(7696005)(52536014)(8936002)(4326008)(83380400001)(478600001)(71200400001)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 6WVUiGXR0xBuqnspUPC7/hMGAowHtpH5T5Uvdtzi6wqbHULIj02CPU3hH4awKtYKlENWsUINRrxx4STNPbfEyH8MhJ3VKiKGDbe+vqtX88zWp9bPxeqxMOwVu5V7ldBhMK1cHT9f/SRzPIlQIIpbpLZ6xqaP1jH658EHs9IuC6W3bGsmSTlSl0UTmVR2KbrDKq9ItFtWrlzyt32OOg5HPByMMFaKbHuVB3b3qXaaBKsJ3IjybA0j1VULyUOgphUmO8sq3wUK0ExEHeqky83b1OC2xiMe+wvnTG9GGRp8PE/1CPnnV3kyubav0l0KMDeecODeGtz4WW0Nx7ehWV27+MZFTypIEIm6/yjFIH4F61WsbKoWuUaYtYXLe+XWMmlfLEgTsuSYJMiVkwPnVe6Ge6+tWtnNDLtpLx2NiE7u9ygaH7nPMSJ6q+EKeWRiQ9bG28bI7+oLjYd3mw4pQ/Z0pyHWmoQjSZ409YLbbjgyLARkcxchktgD+EceeLzEQEulsSxi+w4ivgL5KpIC2ngJnXwn2KtJwUL7wMdc9YgttwNqG7XwBZuOluA7HIje8wthM8L+e0XE7tQRDmKdvK5U2V+Inf5QRoFMD3bGLpsq1iLL0X9UEG0/sET/NhkJpgqqi7n2l9fIME61tprDauuQQvqAAsl6X7Ae5RDcEctwJ1WT15xEe7m/PTAvRmIMRWOnjQnAjdttsSh1QbXBjtC2yCo5tWUPt+j/HHm2mIzdAkDMxzR+gtqdSL2S5UyJRPFVxfxiD6gIrXa9bH9kVZxrUpAFeGWrODiG4pl2qryDZ2MS8sBNClKneaI98Ed/eOTLxuMvMYC4GqJ34qSY1sYAHt376NLHURoC5Fy0RINnlYF1sOL9AND4cxK2nB4enVduz+c1Fmu3KFSlez6JtcO+LJXcoNYvAVga2r+HUgzSMPreEfVxrveAg8BINWddxvHIIQklaOxCdFnoWqUteXsJkxxGKYXydzacPnBgkNIfwK2JKfagOCayoLVjbTtYt1OBzsmErxHSmEwSZRgTsk1hF94MMawcuMsS35/zYshg67PqEW9wCvYClLmZjX2FAWxud09DaKDbmnm9RwWU9L+UDEL0cWgXRGj43lX0uee79kFk7gJYAZRlvBlTmsTIURKLcoU1ilzSeq7jOjYhl0m8fDQ0MDwXSH3lbYpwB0YMFRlx5zTup+67wpRk0ou3w8zdC5ya3nrdQaluDg4BNziWGl87WcOgZ4l6DC25T5G7MzF94RE/bL7PqPHqQ4oS0a3yrx1Tb0JjqURVnZH5R5CvicIymUS9vMeQG5aJ9FOfn2Jq0CJuwntCmAJqIbRuHYkw x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4474.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba489203-ae36-4946-92ca-08d8e8b12940 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2021 19:24:47.1061 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rZ+vgIr8oiiw857UyT+y8pNxL+CnuJMcbVWOW1R9MgBuDmB/gawmgPnaKec3VLDCDgk4Z0/WoU2jtsHxmiTE+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2735 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 mlxlogscore=959 mlxscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103160120 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 adultscore=0 spamscore=0 clxscore=1015 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103160120 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > (Haven't looked at your patch.) > > Sounds like a reasonable, and useful thing to do. > > > > However, `comment-region' also has optional behaviors > > that involve its use of a prefix arg. How with those > > interact with what you propose? Do they even make > > sense (e.g. nesting comment levels and unnesting them)? >=20 > With (setq-local comment-style 'extra-line comment-continue ""), > `comment-region' currently breaks HTML syntax > because HTML doesn't support nested comments: >=20 > > > > --> >=20 > With the proposed patch, HTML syntax stays valid: >=20 > I see, I guess. But why change `comment-region', instead of creating a new command for multi-line (aka block) commenting? If there's a bug now (e.g. wrt `comment-continue') when someone uses `comment-region', then maybe either that can be fixed (without involving multiline) or that command can be made to ignore, DTRT, or raise an error when `comment-continue' is used. (Just a wild guess, without looking at any code.) From unknown Thu Aug 21 14:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47167: [External] : bug#47167: Multi-line comment-region with empty comment-continue Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Mar 2021 17:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: "47167@debbugs.gnu.org" <47167@debbugs.gnu.org> Received: via spool by 47167-submit@debbugs.gnu.org id=B47167.161600189918497 (code B ref 47167); Wed, 17 Mar 2021 17:25:02 +0000 Received: (at 47167) by debbugs.gnu.org; 17 Mar 2021 17:24:59 +0000 Received: from localhost ([127.0.0.1]:43915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMZul-0004oH-6X for submit@debbugs.gnu.org; Wed, 17 Mar 2021 13:24:59 -0400 Received: from relay13.mail.gandi.net ([217.70.178.233]:64521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMZui-0004o2-RG for 47167@debbugs.gnu.org; Wed, 17 Mar 2021 13:24:57 -0400 Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay13.mail.gandi.net (Postfix) with ESMTPSA id 93A9C80003; Wed, 17 Mar 2021 17:24:49 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <87a6r4muw5.fsf@mail.linkov.net> <87ft0vwhty.fsf@mail.linkov.net> Date: Wed, 17 Mar 2021 19:04:20 +0200 In-Reply-To: (Drew Adams's message of "Tue, 16 Mar 2021 19:24:47 +0000") Message-ID: <875z1piw91.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> With (setq-local comment-style 'extra-line comment-continue ""), >> `comment-region' currently breaks HTML syntax >> because HTML doesn't support nested comments: >> >> >> >> >> --> >> >> With the proposed patch, HTML syntax stays valid: >> >> > > I see, I guess. But why change `comment-region', > instead of creating a new command for multi-line > (aka block) commenting? 'multi-line' is just one of possible styles in 'comment-styles'. I'm not interested in creating separate commands for each style. If you want, you can create a separate bug report. > If there's a bug now (e.g. wrt `comment-continue') > when someone uses `comment-region', then maybe > either that can be fixed (without involving > multiline) or that command can be made to ignore, Indeed, there is a bug. The documentation of 'comment-continue' says: Continuation string to insert for multiline comments. If it is nil a value will be automatically derived from ‘comment-start’ by replacing its first character with a space. The problem is that currently the empty string behaves as if it's nil. The patch fixes it. From unknown Thu Aug 21 14:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47167: Multi-line comment-region with empty comment-continue Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Mar 2021 05:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: 47167@debbugs.gnu.org Received: via spool by 47167-submit@debbugs.gnu.org id=B47167.161604476730675 (code B ref 47167); Thu, 18 Mar 2021 05:20:02 +0000 Received: (at 47167) by debbugs.gnu.org; 18 Mar 2021 05:19:27 +0000 Received: from localhost ([127.0.0.1]:44628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMl49-0007yP-6V for submit@debbugs.gnu.org; Thu, 18 Mar 2021 01:19:26 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMl45-0007wx-HN for 47167@debbugs.gnu.org; Thu, 18 Mar 2021 01:19:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2VYEpYFNVSkDS23ZBtduq4BrEe5LFGivp5BreH3JkVI=; b=SsgDAamYcxv1mmkvZrpEo/u8Of 9eqLeRWxcg7cRVBtbfLA6tY1wDyeCLaTKW4ruvvHN2FkncPUHlmM7fQh0UGSjditZw2JQcy/3CwNG qst48929hnGq1mbdKq2Qts5m3fHF1r7Ag/84rqqjWYuMF17JZuE+uEO/oghE3plUJ00M=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMl3x-0008Mg-Ek; Thu, 18 Mar 2021 06:19:15 +0100 From: Lars Ingebrigtsen References: <87a6r4muw5.fsf@mail.linkov.net> X-Now-Playing: Themselves's _CrownsDown_: "gangster of disbelief" Date: Thu, 18 Mar 2021 06:19:12 +0100 In-Reply-To: <87a6r4muw5.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 15 Mar 2021 19:03:22 +0200") Message-ID: <878s6lt4xb.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > But currently it has no effect. So needed to fix newcomment.el. > One possible fix is to return the original string from 'comment-padright' > even when the string contains only whitespace. Maybe thi [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > But currently it has no effect. So needed to fix newcomment.el. > One possible fix is to return the original string from 'comment-padright' > even when the string contains only whitespace. Maybe this would be > the right fix, but still not sure about other calls of 'comment-padright'. > So a safer fix would be to do this in the caller: Looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Thu Aug 21 14:54:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47167: Multi-line comment-region with empty comment-continue Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Mar 2021 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 47167@debbugs.gnu.org Received: via spool by 47167-submit@debbugs.gnu.org id=B47167.161609053027259 (code B ref 47167); Thu, 18 Mar 2021 18:03:02 +0000 Received: (at 47167) by debbugs.gnu.org; 18 Mar 2021 18:02:10 +0000 Received: from localhost ([127.0.0.1]:47995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMwyI-00075a-Ik for submit@debbugs.gnu.org; Thu, 18 Mar 2021 14:02:10 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:54059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMwyG-00075H-Rh; Thu, 18 Mar 2021 14:02:09 -0400 Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 586C9100002; Thu, 18 Mar 2021 18:02:00 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <87a6r4muw5.fsf@mail.linkov.net> <878s6lt4xb.fsf@gnus.org> Date: Thu, 18 Mar 2021 20:01:42 +0200 In-Reply-To: <878s6lt4xb.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 18 Mar 2021 06:19:12 +0100") Message-ID: <87eegcmjcp.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) tags 47167 fixed close 47167 28.0.50 quit >> But currently it has no effect. So needed to fix newcomment.el. >> One possible fix is to return the original string from 'comment-padright' >> even when the string contains only whitespace. Maybe this would be >> the right fix, but still not sure about other calls of 'comment-padright'. >> So a safer fix would be to do this in the caller: > > Looks good to me. Now pushed to master.