GNU bug report logs - #47128
28.0.50; Be more helpful regarding message-syntax-checks

Previous Next

Package: emacs;

Reported by: Eric Abrahamsen <eric <at> ericabrahamsen.net>

Date: Sat, 13 Mar 2021 22:40:01 UTC

Severity: minor

Tags: patch

Found in version 28.0.50

Done: Eric Abrahamsen <eric <at> ericabrahamsen.net>

Bug is archived. No further changes may be made.

Full log


Message #18 received at 47128-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 47128-done <at> debbugs.gnu.org
Subject: Re: bug#47128: 28.0.50; Be more helpful regarding
 message-syntax-checks
Date: Tue, 13 Apr 2021 08:46:35 -0700
On 04/13/21 09:47 AM, Lars Ingebrigtsen wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>>> What would be even better is to obsolete this in favor of a new
>>> `message-disabled-syntax-checks' option that was simply a plain list of
>>> symbols.
>>
>> I feel like this is fairly uncontroversial -- does anyone have any
>> objections? I may just go ahead and push, otherwise. (I've since tweaked
>> the patch so that `message-syntax-checks' belongs to the
>> 'message-headers group, in line with the other changes.)
>
> The patch looks fine to me -- obsoleting the variable in favour of an
> opposite variable doesn't seem to be optimal, though.

That's fine, it wasn't a big deal -- it just seemed oddly verbose to
require the 'disabled symbol, when 'disabled the only viable option. But
no actual harm in it, of course.

Closing this now...




This bug report was last modified 4 years and 98 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.