GNU bug report logs - #47128
28.0.50; Be more helpful regarding message-syntax-checks

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#47128: closed (28.0.50; Be more helpful regarding
 message-syntax-checks)
Date: Tue, 13 Apr 2021 15:47:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 13 Apr 2021 08:46:35 -0700
with message-id <87mtu2gpb8.fsf <at> ericabrahamsen.net>
and subject line Re: bug#47128: 28.0.50; Be more helpful regarding message-syntax-checks
has caused the debbugs.gnu.org bug report #47128,
regarding 28.0.50; Be more helpful regarding message-syntax-checks
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
47128: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47128
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Be more helpful regarding message-syntax-checks
Date: Sat, 13 Mar 2021 14:38:56 -0800

[Message part 3 (text/plain, inline)]

The `message-syntax-checks' option doesn't have a very useful
customization :type, and the manual section explaining what it does
isn't in the most obvious spot. This patch moves the manual explanation
from "News Headers" to the more general "Message Headers" section, as
the option governs both mail and news. It also expands the :type
definition to explicitly list all the possible options.

The defcustom originally had two comments on it, one saying "Guess this
one shouldn't be easy to customize...", and another on the :type line
saying "improve this". That seems a bit contradictory.

Anyway, I don't see the point of actually obfuscating the use of this
option; this patch should make it a little more discoverable.

What would be even better is to obsolete this in favor of a new
`message-disabled-syntax-checks' option that was simply a plain list of
symbols.

Eric

[0001-Improvements-to-message-syntax-checks-docs-and-optio.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 47128-done <at> debbugs.gnu.org
Subject: Re: bug#47128: 28.0.50; Be more helpful regarding
 message-syntax-checks
Date: Tue, 13 Apr 2021 08:46:35 -0700

On 04/13/21 09:47 AM, Lars Ingebrigtsen wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>>> What would be even better is to obsolete this in favor of a new
>>> `message-disabled-syntax-checks' option that was simply a plain list of
>>> symbols.
>>
>> I feel like this is fairly uncontroversial -- does anyone have any
>> objections? I may just go ahead and push, otherwise. (I've since tweaked
>> the patch so that `message-syntax-checks' belongs to the
>> 'message-headers group, in line with the other changes.)
>
> The patch looks fine to me -- obsoleting the variable in favour of an
> opposite variable doesn't seem to be optimal, though.

That's fine, it wasn't a big deal -- it just seemed oddly verbose to
require the 'disabled symbol, when 'disabled the only viable option. But
no actual harm in it, of course.

Closing this now...

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.