GNU bug report logs - #47124
28.0.50; [PATCH] Init archive and add noconfirm to 'package-install-selected-packages'

Previous Next

Package: emacs;

Reported by: Gabriel <gabriel376 <at> hotmail.com>

Date: Sat, 13 Mar 2021 17:16:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 28.0.50

Fixed in version 28.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Gabriel <gabriel376 <at> hotmail.com>
To: 47124 <at> debbugs.gnu.org
Subject: bug#47124: 28.0.50; [PATCH] Init archive and add noconfirm to 'package-install-selected-packages'
Date: Sat, 13 Mar 2021 16:16:32 -0300
[Message part 1 (text/plain, inline)]
>>  ;;;###autoload
>> -(defun package-install-selected-packages ()
>> +(defun package-install-selected-packages (&optional noconfirm)
>>    "Ensure packages in `package-selected-packages' are installed.
>> -If some packages are not installed propose to install them."
>> +If some packages are not installed, propose to install them.
>> +If optional argument NOCONFIRM is non-nil, don't ask for
>> +confirmation to install packages."
>>    (interactive)
>>    ;; We don't need to populate `package-selected-packages' before
>>    ;; using here, because the outcome is the same either way (nothing
>>    ;; gets installed).
>> +  (package--archives-initialize)
>
> I would put this new line above the comment, as the comment relates to
> this next line:

Hi Stefan, good catch! Thank you for the suggestion. Here is an updated
patch.

[0001-Init-archive-and-add-noconfirm-to-package-install-se.patch (text/x-diff, attachment)]

This bug report was last modified 4 years and 132 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.