From unknown Sun Jun 15 08:48:48 2025 X-Loop: don@donarmstrong.com Subject: bug#471: pgg-gpg.el - pgg-gpg-process-region timing problem Reply-To: Thien-Thi Nguyen , 471@debbugs.gnu.org Resent-From: Thien-Thi Nguyen Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 23 Jun 2008 13:30:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 471 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.121422724825258 (code B ref -1); Mon, 23 Jun 2008 13:30:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.4 required=4.0 tests=AWL,BAYES_00,FOURLA, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 23 Jun 2008 13:20:48 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5NDKfZQ025252 for ; Mon, 23 Jun 2008 06:20:42 -0700 Received: from mx10.gnu.org ([199.232.76.166]:50368) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KAlyD-0002sf-S0 for emacs-pretest-bug@gnu.org; Mon, 23 Jun 2008 09:20:34 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KAlyF-00055G-0v for emacs-pretest-bug@gnu.org; Mon, 23 Jun 2008 09:20:38 -0400 Received: from [151.61.141.75] (port=46002 helo=ambire.localdomain) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KAlyD-00052G-Mb; Mon, 23 Jun 2008 09:20:34 -0400 Received: from ttn by ambire.localdomain with local (Exim 4.63) (envelope-from ) id 1KAlvP-00024h-GV; Mon, 23 Jun 2008 15:17:39 +0200 From: Thien-Thi Nguyen To: "ken manheimer" Cc: wilde@sha-bang.de, emacs-pretest-bug@gnu.org, ueno@unixuser.org, emacs-devel References: <2cd46e7f0806221037h6d16839bp567eb5b901313375@mail.gmail.com> <87zlpc8t00.fsf@ambire.localdomain> <87r6ao8rty.fsf@ambire.localdomain> Date: Mon, 23 Jun 2008 15:17:39 +0200 In-Reply-To: <87r6ao8rty.fsf@ambire.localdomain> (Thien-Thi Nguyen's message of "Mon, 23 Jun 2008 10:43:05 +0200") Message-ID: <873an4b898.fsf@ambire.localdomain> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Delving into this, i got a little carried away... full func below. This adds GOOD_PASSPHRASE checking (necessary for GNUPG 1.4.6, at least) and some other coding-system related finessing, but removes the sentinel proposed in the first attempt. In its place, we zonk the baleful `process-adaptive-read-buffering' and remove timeout parameters from `accept-process-output' calls. With this func things seem to work fine for `pgg-sign' on a small buffer, and mostly for large buffers (270KB), but sometimes (~10%) with large buffers, i see a "file error: bad address *GnuPG*". Hmmm... thi ______________________________________________________________________ (defun pgg-gpg-process-region (start end passphrase program args) (let* ((use-agent (and (null passphrase) (pgg-gpg-use-agent-p))) (output-file-name (pgg-make-temp-file "pgg-output")) (args `("--status-fd" "2" ,@(if use-agent '("--use-agent") (if passphrase '("--passphrase-fd" "0"))) "--yes" ; overwrite "--output" ,output-file-name ,@pgg-gpg-extra-args ,@args)) (output-buffer pgg-output-buffer) (errors-buffer pgg-errors-buffer) (orig-mode (default-file-modes)) (inhibit-redisplay t)) (with-current-buffer (get-buffer-create errors-buffer) (buffer-disable-undo) (erase-buffer)) (unwind-protect (let* ((coding-system-for-write 'binary) ;; GNUPG 1.4.6 does not terminate on bad passphrase, eg: ;; [GNUPG:] BAD_PASSPHRASE (long hex # here) ;; gpg: skipped "ttn": bad passphrase ;; gpg: [stdin]: clearsign failed: bad passphrase ;; so we need to check that condition ourselves and bail out. ;; ;; To check if the passphrase is accepted, we need to parse the ;; errors-buffer, but `process-adaptive-read-buffering' non-nil ;; sometimes prevents it from filling. So turn it off. (process-adaptive-read-buffering (not passphrase)) (process (progn (set-default-file-modes 448) (apply #'start-process "*GnuPG*" errors-buffer program args))) (status (process-status process)) exit-status) (set-process-sentinel process nil) (when passphrase (let ((coding-system-for-write (or pgg-passphrase-coding-system 'binary))) (process-send-string process passphrase)) (process-send-string process "\n") ;; Bail out if passphrase is not accepted. ;; MAINTAIN ME: Tested against GNUPG 1.4.6. (let (result) (while (not result) (accept-process-output process) (with-current-buffer errors-buffer (save-excursion (goto-char (point-min)) (when (re-search-forward ;; BGM: BAD, GOOD, MISSING. "^.GNUPG:. \\([BGM][A-Z]+\\)_PASSPHRASE" nil t) (setq result (match-string 1)))))) (unless (string= "GOOD" result) (error "Passphrase no good")))) (process-send-region process start end) (process-send-eof process) ;; TODO: Re-enable `process-adaptive-read-buffering' here. (while (eq 'run (setq status (process-status process))) (accept-process-output process)) (delete-process process) (setq exit-status (process-exit-status process)) (with-current-buffer (get-buffer-create output-buffer) (buffer-disable-undo) (erase-buffer) (if (file-exists-p output-file-name) (let ((coding-system-for-read (if pgg-text-mode 'raw-text 'binary))) (insert-file-contents output-file-name))) (set-buffer errors-buffer) (if (memq status '(stop signal)) (error "%s exited abnormally: '%s'" program exit-status)) (if (= 127 exit-status) (error "%s could not be found" program)))) (if (file-exists-p output-file-name) (delete-file output-file-name)) (when (get-process "*GnuPG*") (kill-process "*GnuPG*")) (set-default-file-modes orig-mode))))