From unknown Sat Aug 16 19:18:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47071: 28.0.50; Show ERT failure reason in batch mode Resent-From: Julian Scheid Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Mar 2021 15:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 47071@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: Julian Scheid Received: via spool by submit@debbugs.gnu.org id=B.16154762028522 (code B ref -1); Thu, 11 Mar 2021 15:24:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Mar 2021 15:23:22 +0000 Received: from localhost ([127.0.0.1]:54650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKN9l-0002DN-Bt for submit@debbugs.gnu.org; Thu, 11 Mar 2021 10:23:22 -0500 Received: from lists.gnu.org ([209.51.188.17]:36662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKIlx-0007LC-NC for submit@debbugs.gnu.org; Thu, 11 Mar 2021 05:42:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKIlx-0006u7-EI for bug-gnu-emacs@gnu.org; Thu, 11 Mar 2021 05:42:29 -0500 Received: from mail-40134.protonmail.ch ([185.70.40.134]:11251) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKIlu-0002lp-PG for bug-gnu-emacs@gnu.org; Thu, 11 Mar 2021 05:42:28 -0500 Date: Thu, 11 Mar 2021 10:42:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1615459343; bh=2VbFHyhrJ7DBJ5zLfJYSflqbpimhVUfkBUZ6WTFhSdU=; h=Date:To:From:Reply-To:Subject:From; b=R0mJopsnQFOja7X4PnxqAt/KiFrArRjjOMMd73La5s6lzdOeQOXj9+wn96hpC+/WH pSPIOEjUrGAFrl1oCm+WFnwI0lV810b1KaNyz2mFMTg7GaL0GddznqCor5Zp+0ageY GDJBzWIqKhHuPiMWSLmbIKuJVKi0xxoiEhXDEi6Q= From: Julian Scheid Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.40.134; envelope-from=jscheid@protonmail.com; helo=mail-40134.protonmail.ch X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Mailman-Approved-At: Thu, 11 Mar 2021 10:23:19 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Severity: normal Tags: patch `ert-fail' and `ert-skip' both require an argument described as "[data that] is displayed to the user and should state the reason of the failure [or the reason for skipping]." The data is only displayed in interactive mode as a side-effect however, not in batch mode. I think it's useful to see the failure or skip reason in batch mode as well, which is why I would like to suggest the following change. (I've borrowed `print-level' etc. from other parts of ERT code but don't have a strong opinion on it. I'd imagine that most of the time people would just pass in a short string anyway. That's what a quick grep of Emacs code seems to point to as well.) >From 053abfe6e9a35a76b7f0af866a6336fb35d959f9 Mon Sep 17 00:00:00 2001 From: Julian Scheid Date: Thu, 11 Mar 2021 22:49:11 +1300 Subject: [PATCH] Output test failure or skip reason in batch mode * lisp/emacs-lisp/ert.el (ert-reason-for-test-result): New function. (ert-run-tests-batch): Output failure or skip reason. --- lisp/emacs-lisp/ert.el | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/lisp/emacs-lisp/ert.el b/lisp/emacs-lisp/ert.el index e91ec0af44..05edbb6fd1 100644 --- a/lisp/emacs-lisp/ert.el +++ b/lisp/emacs-lisp/ert.el @@ -1279,6 +1279,23 @@ ert-string-for-test-result (ert-test-quit '("quit" "QUIT"))))) (elt s (if expectedp 0 1)))) +(defun ert-reason-for-test-result (result) + "Return the reason given for RESULT, as a string. + +The reason is the argument given when invoking `ert-fail' or `ert-skip'. +It is output using `prin1' prefixed by two spaces. + +If no reason was given, or for a successful RESULT, return the +empty string." + (let ((reason + (and + (ert-test-result-with-condition-p result) + (cadr (ert-test-result-with-condition-condition result)))) + (print-escape-newlines t) + (print-level 6) + (print-length 10)) + (if reason (format " %S" reason) ""))) + (defun ert--pp-with-indentation-and-newline (object) "Pretty-print OBJECT, indenting it to the current column of point. Ensures a final newline is inserted." @@ -1369,18 +1386,20 @@ ert-run-tests-batch (cl-loop for test across (ert--stats-tests stats) for result =3D (ert-test-most-recent-result test) d= o (when (not (ert-test-result-expected-p test result)= ) - (message "%9s %S" + (message "%9s %S%s" (ert-string-for-test-result result nil) - (ert-test-name test)))) + (ert-test-name test) + (ert-reason-for-test-result result)))) (message "%s" "")) (unless (zerop skipped) (message "%s skipped results:" skipped) (cl-loop for test across (ert--stats-tests stats) for result =3D (ert-test-most-recent-result test) d= o (when (ert-test-result-type-p result :skipped) - (message "%9s %S" + (message "%9s %S%s" (ert-string-for-test-result result nil) - (ert-test-name test)))) + (ert-test-name test) + (ert-reason-for-test-result result)))) (message "%s" ""))))) (test-started ) -- 2.30.2 From unknown Sat Aug 16 19:18:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47071: 28.0.50; Show ERT failure reason in batch mode Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 May 2021 15:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Julian Scheid Cc: 47071@debbugs.gnu.org Received: via spool by 47071-submit@debbugs.gnu.org id=B47071.162126566220269 (code B ref 47071); Mon, 17 May 2021 15:35:02 +0000 Received: (at 47071) by debbugs.gnu.org; 17 May 2021 15:34:22 +0000 Received: from localhost ([127.0.0.1]:53566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lifG9-0005Gq-PT for submit@debbugs.gnu.org; Mon, 17 May 2021 11:34:22 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lifG8-0005GZ-23 for 47071@debbugs.gnu.org; Mon, 17 May 2021 11:34:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k+YF+RVxrPmlZUgtITV+LOXwcC4U1PFAAxKsHKJJ4JA=; b=Md0MngvCSJF+QCyjGuZSFzY3YL M+eYQAMB1MP1oZlVmcU3jDX5pgTFicZyxOpfyOWWCHWOOvYRezfTnYU5he7AFEjyftNYInhN+vY2p lFZ56Xl1dUW2KCSG14Ht3CkbmUHcysIKWRqRV498VuDK08v/AyZz/a05dN2wbMry1l/o=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lifFz-0000xP-9R; Mon, 17 May 2021 17:34:13 +0200 From: Lars Ingebrigtsen References: X-Now-Playing: d'Eon's _LP_: "audio_15.mp3" Date: Mon, 17 May 2021 17:34:10 +0200 In-Reply-To: (Julian Scheid's message of "Thu, 11 Mar 2021 10:42:19 +0000") Message-ID: <87eee5idcd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Julian Scheid writes: > The data is only displayed in interactive mode as a side-effect > however, not in batch mode. I think it's useful to see the failure or > skip reason in batch mode as well, which is why I would like [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Julian Scheid writes: > The data is only displayed in interactive mode as a side-effect > however, not in batch mode. I think it's useful to see the failure or > skip reason in batch mode as well, which is why I would like to > suggest the following change. Thanks, but I'm not sure this level of detail is helpful in batch mode. For instance, in python-tests, you get the wall of text included below, which I think would be excessive. Does anybody else have an opinion here? 14 skipped results: SKIPPED python-shell-get-process-1 ((skip-unless (executable-find python-tests-shell-interpreter)) :form (executable-find "python") :value nil) SKIPPED python-shell-internal-get-or-create-process-1 ((skip-unless (executable-find python-tests-shell-interpreter)) :form (executable-find "python") :value nil) SKIPPED python-shell-make-comint-1 ((skip-unless (executable-find python-tests-shell-interpreter)) :form (executable-find "python") :value nil) SKIPPED python-shell-make-comint-2 ((skip-unless (executable-find python-tests-shell-interpreter)) :form (executable-find "python") :value nil) SKIPPED python-shell-make-comint-3 ((skip-unless (executable-find python-tests-shell-interpreter)) :form (executable-find "python") :value nil) SKIPPED python-shell-make-comint-4 ((skip-unless (executable-find python-tests-shell-interpreter)) :form (executable-find "python") :value nil) SKIPPED python-shell-prompt-detect-1 ((skip-unless (executable-find python-tests-shell-interpreter)) :form (executable-find "python") :value nil) SKIPPED python-shell-prompt-detect-2 ((skip-unless (executable-find python-tests-shell-interpreter)) :form (executable-find "python") :value nil) SKIPPED python-shell-prompt-detect-3 ((skip-unless (executable-find python-tests-shell-interpreter)) :form (executable-find "python") :value nil) SKIPPED python-shell-prompt-detect-4 ((skip-unless (executable-find python-tests-shell-interpreter)) :form (executable-find "python") :value nil) SKIPPED python-shell-prompt-detect-5 ((skip-unless (executable-find python-tests-shell-interpreter)) :form (executable-find "python") :value nil) SKIPPED python-shell-prompt-detect-6 ((skip-unless (executable-find python-tests-shell-interpreter)) :form (executable-find "python") :value nil) SKIPPED python-shell-prompt-set-calculated-regexps-6 ((skip-unless (executable-find python-tests-shell-interpreter)) :form (executable-find "python") :value nil) SKIPPED python-tests--bug31398 ((skip-unless (executable-find python-tests-shell-interpreter)) :form (executable-find "python") :value nil) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon May 17 11:34:32 2021 Received: (at control) by debbugs.gnu.org; 17 May 2021 15:34:32 +0000 Received: from localhost ([127.0.0.1]:53569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lifGK-0005HE-3U for submit@debbugs.gnu.org; Mon, 17 May 2021 11:34:32 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lifGF-0005Gy-RU for control@debbugs.gnu.org; Mon, 17 May 2021 11:34:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ld/bZ3T0/FZB9qsgldOsqtNbNwtPqP0xYfBOSjBAI4s=; b=WQ9ZVAgRAqP6ED4t20YtLm3WzT oj5ag0M0jq1RZ/2uWgG8XNLXzXBdpHOJCbqFgNcILXvcwGsP03mg67xR1f7I8in6boof45f3Jol6M sCTsFCfBIbzjNk+jT9j/yVjWllmW2hbnTPHS2TOxz6KDFuZj78XuiEgUtxnUfadF2iSw=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lifG8-0000xa-EA for control@debbugs.gnu.org; Mon, 17 May 2021 17:34:22 +0200 Date: Mon, 17 May 2021 17:34:19 +0200 Message-Id: <87cztpidc4.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #47071 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 47071 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 47071 + moreinfo quit From unknown Sat Aug 16 19:18:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47071: 28.0.50; Show ERT failure reason in batch mode Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 May 2021 15:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo To: Lars Ingebrigtsen Cc: 47071@debbugs.gnu.org, Julian Scheid Received: via spool by 47071-submit@debbugs.gnu.org id=B47071.162126678430471 (code B ref 47071); Mon, 17 May 2021 15:54:02 +0000 Received: (at 47071) by debbugs.gnu.org; 17 May 2021 15:53:04 +0000 Received: from localhost ([127.0.0.1]:53602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lifYG-0007vP-E6 for submit@debbugs.gnu.org; Mon, 17 May 2021 11:53:04 -0400 Received: from mail-oi1-f178.google.com ([209.85.167.178]:41926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lifYF-0007uh-2l for 47071@debbugs.gnu.org; Mon, 17 May 2021 11:53:03 -0400 Received: by mail-oi1-f178.google.com with SMTP id c3so6889522oic.8 for <47071@debbugs.gnu.org>; Mon, 17 May 2021 08:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vc4HIsXiR0kmK34QzTA0OwD7ass7pkCVOVGniX5es9w=; b=liDgn0gOMKvmcSXMbV7oNNa6+g/lnd2KHuMLt9AblQb0COP0x+/QtNRkZyPvldgFEy EBngWOwAtPZ6giMafMLGZsy9L+q6VCPBIUZW1jVj/2zVWJwj4VrMox2QZuUv8c0UwTNQ xWdtOTj668hvCi2yNQoM0aZ/q8Te+eGEOJUKM/HJeHb9IV1OXWMrOuAsBuenRXS5rF/k x9F/Kh1YLz2sz7JZ4o6Y5u8f6YftpixniAA6yXuSi9b1X/Z5vuRwgsh9f+lLEMEpj8PU CJUfO70187+TeXpqlpnSbUmxDHadDAydvO5/qVDRDMYRYnRa4EflJ593gk2rltJJkgDz xXTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vc4HIsXiR0kmK34QzTA0OwD7ass7pkCVOVGniX5es9w=; b=hfpktunMa0uVcB+242tXTlzkF9EogkuRbyW2uu1OZ0BzL9CMJB7ABeMuoXAd6elVYd dhY8wQxzKag7rIUHv6MyKIO7CB4AANt26dCwAofdaVyYDxTzO6D7WMCshu7uE+tezS24 rtHq8QFNF7WGzj4DRXpPz8Dd3QRY4DRHnAt9Pwv7KyyPvBQiFzTBsQTo5cI/RoTgwPL8 RyrTgL1FsqNW2wVzaXbdkyM1bKMPT0P7oSiEwrlUbYbo2Nmjc0bhhHbIipzTzbVuSAa7 YVkZ1cp6kM1dCE9qe0o4JmXlB2joDwQ41nWrymlDQoirQqYELB13via9lv3sXgVcoydA JiFQ== X-Gm-Message-State: AOAM533sFbDwx0ZKrf9fQIBcI1LS+OKIyCLw6meOUCdp2zLGB0Fg3qZe EAPOe6xfp9Z3FwrvIiK49wmH9h9gQuzJdpysYb8= X-Google-Smtp-Source: ABdhPJwyxkn1xYg3Z2Tt6B7AixBWBMO4u3U4PfdKQzH5qP9QUX63Sj6gCyFBrGq+sAZZDr9PrL0O8w6JibTwLyIPWVc= X-Received: by 2002:aca:f5c5:: with SMTP id t188mr328869oih.25.1621266777306; Mon, 17 May 2021 08:52:57 -0700 (PDT) MIME-Version: 1.0 References: <87eee5idcd.fsf@gnus.org> In-Reply-To: <87eee5idcd.fsf@gnus.org> From: Philipp Stephani Date: Mon, 17 May 2021 17:52:46 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Am Mo., 17. Mai 2021 um 17:36 Uhr schrieb Lars Ingebrigtsen : > > Julian Scheid writes: > > > The data is only displayed in interactive mode as a side-effect > > however, not in batch mode. I think it's useful to see the failure or > > skip reason in batch mode as well, which is why I would like to > > suggest the following change. > > Thanks, but I'm not sure this level of detail is helpful in batch mode. > > For instance, in python-tests, you get the wall of text included below, > which I think would be excessive. > > Does anybody else have an opinion here? On CI systems, you only have the logs written in batch mode. The more complete they are, the better, since you can always filter out information you don't need later, but not add missing information after the fact. So printing lots of information is fine IMO. A middle ground would be to support some kind of 'verbosity' command-line option so that the environment could decide how much to print. From unknown Sat Aug 16 19:18:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47071: 28.0.50; Show ERT failure reason in batch mode Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 May 2021 13:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo To: Philipp Stephani Cc: 47071@debbugs.gnu.org, Julian Scheid Received: via spool by 47071-submit@debbugs.gnu.org id=B47071.16213453375851 (code B ref 47071); Tue, 18 May 2021 13:43:02 +0000 Received: (at 47071) by debbugs.gnu.org; 18 May 2021 13:42:17 +0000 Received: from localhost ([127.0.0.1]:54709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lizzE-0001WH-RB for submit@debbugs.gnu.org; Tue, 18 May 2021 09:42:17 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lizzA-0001W2-5q for 47071@debbugs.gnu.org; Tue, 18 May 2021 09:42:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tCYAwK0GdN/EMbBUaN1XIhjve/wU1BYtbb1TJhxy/zU=; b=B4gnByM865IzLhooECFwJD2CJr tXJ8LFRwfWhMwZcnI3DBiY3imE0801jQsr8TLAK+QSDuA6C2KJwDDgF+gahcrqoNsseXmrWupi7x0 jEBc/pLNl92gr53cS4Ej3jeYxjGU3TWu0EFR/x5SQyEgLq7W96clgoDaS3ACW1waAs1c=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lizz1-0005iP-Dw; Tue, 18 May 2021 15:42:05 +0200 From: Lars Ingebrigtsen References: <87eee5idcd.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEX+/vzlzZ6/lWz7 98+XbEs2Lif///9n/utRAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+UFEg0PE7NT/rcAAAGpSURBVDjL ddRLdusgDABQJ7TzAO68UsncDukCqoj5ey3sfyuVIORLPXAc3YMEipxpul7OrzHG6ekyEOMQNju5 XeFr6U+Huiz27+W7g32A0gHq/ZKrlPe/4N/5iWAyfok9V7kUOdnFSPwKvQjhYuJ0OYnArp1PYIO7 W2hFjJfI/Yr/DXbnXfVtuVTOsNyDUI2Y9yc4N/e02qXC8gR+GsH0tcYx0AE/hsAr+CGEKMXlmE/w qSdcB/BykrgdpNqytdYPYMOEQ9gygR+NVuC24BGOzNhm8T6XY2Yq5B9gdUEgp5LhNpd1YEOoUEq2 lyVbQrkCJ1YohTrNEoZag0u7oGUTADvfQmHfAGwtjpS61Mn5RGu1BiHtO2SFV5A4EkvGuQZTbnO7 Bd0Vkm4hl5Q5/TQwkqcSAuTC3ylJyjpjR5Y1TtfBnIn2bN8aHAIgoEOy6DjvCVNQMHElhxJDuVnC ULdVIWpZmLWQlR/LhgbSzVkhBDkIEEinzFzqCxOP2kZpSajgo9EebuIVWE8jo7Iq6D/OAZAFpFvy KUOk74OOXnRLYO2iJMvyy0uy6RfLPnvmOhjsugAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMS0wNS0x OFQxMzoxNToxOCswMDowMCmsDEEAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMDUtMThUMTM6MTU6 MTgrMDA6MDBY8bT9AAAAAElFTkSuQmCC X-Now-Playing: Zola Jesus's _Taiga_: "It's Not Over" Date: Tue, 18 May 2021 15:42:02 +0200 In-Reply-To: (Philipp Stephani's message of "Mon, 17 May 2021 17:52:46 +0200") Message-ID: <87mtssf9at.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philipp Stephani writes: > On CI systems, you only have the logs written in batch mode. The more > complete they are, the better, since you can always filter out > information you don't need later, but not add missing informa [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philipp Stephani writes: > On CI systems, you only have the logs written in batch mode. The more > complete they are, the better, since you can always filter out > information you don't need later, but not add missing information > after the fact. So printing lots of information is fine IMO. Yeah, that's true -- on CI systems the added information would be useful indeed. > A middle ground would be to support some kind of 'verbosity' > command-line option so that the environment could decide how much to > print. Yup. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Aug 16 19:18:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47071: 28.0.50; Show ERT failure reason in batch mode Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Jun 2021 15:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo To: Philipp Stephani Cc: 47071@debbugs.gnu.org, Julian Scheid Received: via spool by 47071-submit@debbugs.gnu.org id=B47071.16237693959422 (code B ref 47071); Tue, 15 Jun 2021 15:04:02 +0000 Received: (at 47071) by debbugs.gnu.org; 15 Jun 2021 15:03:15 +0000 Received: from localhost ([127.0.0.1]:50458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltAax-0002Ru-4I for submit@debbugs.gnu.org; Tue, 15 Jun 2021 11:03:15 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltAav-0002Rf-IE for 47071@debbugs.gnu.org; Tue, 15 Jun 2021 11:03:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LoKVq9UpzqCR9sKs4nmwE/tzP30wfeB6qV5dLVxf4vo=; b=MumgosSlyihzHAXfxDG0toMfuq /TsbvQXHjHJQa8HVGM4mc6cYMXZadxn+MoXl71PIF3r/7V9Sqsle5vio8Lm90GH2CtvvTYkz+dPK5 ItiGHerzTqGVABR4p/bwlyk25FRTwCODo8sa4sPjfHT2GXGeEM29gNYlh1CGaVqx96tk=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltAaj-0008FJ-A5; Tue, 15 Jun 2021 17:03:07 +0200 From: Lars Ingebrigtsen References: <87eee5idcd.fsf@gnus.org> <87mtssf9at.fsf@gnus.org> X-Now-Playing: Ana Roxanne's _Ana Roxanne_: "I'm Every Sparkly Woman " Date: Tue, 15 Jun 2021 17:03:00 +0200 In-Reply-To: <87mtssf9at.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 18 May 2021 15:42:02 +0200") Message-ID: <87bl87tbkr.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: >> On CI systems, you only have the logs written in batch mode. The more >> complete they are, the better, since you can always filter out >> information you don't need later, but not add missing info [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: >> On CI systems, you only have the logs written in batch mode. The more >> complete they are, the better, since you can always filter out >> information you don't need later, but not add missing information >> after the fact. So printing lots of information is fine IMO. > > Yeah, that's true -- on CI systems the added information would be useful > indeed. > >> A middle ground would be to support some kind of 'verbosity' >> command-line option so that the environment could decide how much to >> print. > > Yup. I went with an environment variable to control this -- that seemed the most flexible way here. Feel free to tweak or change the name of the variable. Julian -- I pushed your patch to Emacs 28 with those small changes. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 15 11:03:24 2021 Received: (at control) by debbugs.gnu.org; 15 Jun 2021 15:03:24 +0000 Received: from localhost ([127.0.0.1]:50461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltAb6-0002SG-BG for submit@debbugs.gnu.org; Tue, 15 Jun 2021 11:03:24 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltAb4-0002S2-2B for control@debbugs.gnu.org; Tue, 15 Jun 2021 11:03:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tMYtVyNLRm+/hijOCKKZvnhqbDWadhJ3Kpv9FLzq7yc=; b=UJhTpzq0gwhkg/4DlNkAQKi8gs 1patZZvBfH7xqIT+ors9v/ouuJfQn1iGoWV3jI4aqTvKff5SINuJouB51ADNVdjistLqW9k4ef9yj j96vXF38ZlEUQKj8WSiE83Qjzdb+Lg6dpU3gOS2qqzQswQ9G8/s1sSxmZovEN9Li0FXM=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltAas-0008G4-U2 for control@debbugs.gnu.org; Tue, 15 Jun 2021 17:03:16 +0200 Date: Tue, 15 Jun 2021 17:03:10 +0200 Message-Id: <87a6nrtbkh.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #47071 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 47071 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 47071 28.1 quit