From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 11 09:42:43 2021 Received: (at submit) by debbugs.gnu.org; 11 Mar 2021 14:42:43 +0000 Received: from localhost ([127.0.0.1]:52923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKMWR-0000lD-Dy for submit@debbugs.gnu.org; Thu, 11 Mar 2021 09:42:43 -0500 Received: from lists.gnu.org ([209.51.188.17]:48546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKMWP-0000l5-MN for submit@debbugs.gnu.org; Thu, 11 Mar 2021 09:42:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKMWP-0005mt-Ds for guix-patches@gnu.org; Thu, 11 Mar 2021 09:42:41 -0500 Received: from tobias.gr ([2a02:c205:2020:6054::1]:35018) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKMWN-0007UN-4s for guix-patches@gnu.org; Thu, 11 Mar 2021 09:42:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=Bve35tBXKFPQ4/d83uyCRc0f5HqrpQiL7u7Lk5T8FpU=; h=date:subject:to: from; b=iWYFq8AAvQeOivqq6W+epu7ZTn9rV2AY0PcNfcMd66rzRFnHm6lio9B/jvENm8 j8S4dFW5XMOtob3YtdXvgZAzGB4K+WJlOKK94XyzS7WPwaIB3+OdwxbjPVPxmaPC1iiQfc cr6q5OAF8OVW1l5HkLxwzGMNfbZepEcZP9AtvOPLdVE6jYKFNIlpZEjY5/qJGPY0YYMKfb wVqaE180lasPxoe1Mh62oB8W9+F23NKN9WmqfYliRSzkNuTBFxmiRGs7JS6qR7RDvuq8Ki 2M7SOpFybyVv37at/8lbt94OqtGJ7dp9yu7Ay+P749zvPKfR8WPcMMmqTY28RHLy2NaEpQ == Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 8b9d5fbf (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for ; Thu, 11 Mar 2021 14:43:35 +0000 (UTC) From: Tobias Geerinckx-Rice To: guix-patches@gnu.org Subject: [PATCH] etc: Run pre-push make in guix environment. Date: Thu, 11 Mar 2021 15:42:57 +0100 Message-Id: <20210311144257.4203-1-me@tobias.gr> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * etc/git/pre-push: Exec make in a guix development environment. --- Guix, The pre-push assumes you have make installed, which I didn't. Now it assumes that Guix developers have a vaguely up-to-date guix command, which seems reasonable. Kind regards, T G-R etc/git/pre-push | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etc/git/pre-push b/etc/git/pre-push index 59671b0d58..372c7dece0 100755 --- a/etc/git/pre-push +++ b/etc/git/pre-push @@ -32,7 +32,7 @@ do # Only use the hook when pushing to Savannah. case "$2" in *.gnu.org*) - exec make authenticate check-channel-news + exec guix environment guix -- make authenticate check-channel-news exit 127 ;; *) -- 2.30.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 26 04:23:03 2021 Received: (at 47069) by debbugs.gnu.org; 26 Mar 2021 08:23:03 +0000 Received: from localhost ([127.0.0.1]:40318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPhkF-0004cJ-3l for submit@debbugs.gnu.org; Fri, 26 Mar 2021 04:23:03 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:37684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPhkD-0004bb-8m for 47069@debbugs.gnu.org; Fri, 26 Mar 2021 04:23:01 -0400 Received: by mail-wr1-f51.google.com with SMTP id x16so4764189wrn.4 for <47069@debbugs.gnu.org>; Fri, 26 Mar 2021 01:23:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=IzROwI8cWXQQJBcg73mzLVv2GxXHEkxGWq1t0ciw8a8=; b=pAIA0SmrUKZkxWZ3WsJJPC70KwiCSzPfBlNj7vMueTzFpTjAJkSQtqcJopgUXZRe3j cn/LrCV3Jg7Z+jV1I1he5f37Ok7eyrI0XzAYzxL8p1bxtxErX34wFCL4eT3tFRxOFgLZ ghkKOkBEsF2lEoG3EZwZUewzGe8WOocqsLD+oSDZgUY+JIQ7Xp06Mw5JhYwlzAdnAYqF KekTEsTGey1ds99zAG7aXGRkWYhekXihHDsDTKVMD9ep31ydZoNCh6wr+v8jZ+7n67Z8 5hMtiiYqUa9fQzrWe5pCjfaLVFqHC0QIKYSxUuX15wnHhtWo03nHX/Pdt84nSyhOsqxz uDTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=IzROwI8cWXQQJBcg73mzLVv2GxXHEkxGWq1t0ciw8a8=; b=FWXICrJc73rAMWtSgY1XNSXsEhJdShJlJMYXag9xKJWB7XjAl7C/9bAh1c2dEpX4fF S1jAZsmq9ykG+JWWRMdf4htsIfItuVtkYG59FdS/VUUg4abLSvv2xArgyNqoMBk8c8jO yKfmbfsg+MXhCpFmqfZZvb5InAjLiADWdEqMOjpdgTW1vfiCOl/0cRrn3xDMMZKXaL2X tXt4XGjUXHCiNsx3t4O/ZG+5NHXvSl8rK6c2V7owYhE33w4n/9v38OXGwCUX4NViaJ8/ rImU53sLuXsLzaXICI/EMM4hVgLlp6thtoYoueBJVXZl9aVVHUbK6c5Z+cEvQFYGYoyu RuFg== X-Gm-Message-State: AOAM533XT8DMoo7wxF6QfXlqAcEBDHBp8RpTRphRggFIPvkK2HkVPpun Ppcwuxo1b9BcrYPVbUfAtWjFbfeSzTM= X-Google-Smtp-Source: ABdhPJyBUnFQVo15mzVumCeW2bWxG8fwCe/xmQf5br8RcPlD9z6DsTgXdwaRgv4NVHbN+wFgv/ZnnQ== X-Received: by 2002:a05:6000:137b:: with SMTP id q27mr13354035wrz.168.1616746975447; Fri, 26 Mar 2021 01:22:55 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id c8sm9874345wmb.34.2021.03.26.01.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 01:22:55 -0700 (PDT) From: zimoun To: Tobias Geerinckx-Rice Subject: Re: [bug#47069] [PATCH] etc: Run pre-push make in guix environment. References: <20210311144257.4203-1-me@tobias.gr> Date: Fri, 26 Mar 2021 09:20:17 +0100 In-Reply-To: <20210311144257.4203-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Thu, 11 Mar 2021 15:42:57 +0100") Message-ID: <86lfaaba2m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 47069 Cc: 47069@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Tobias, On Thu, 11 Mar 2021 at 15:42, Tobias Geerinckx-Rice wrote: > * etc/git/pre-push: Exec make in a guix development environment. > --- > The pre-push assumes you have make installed, which I didn't. How do you rebuild Guix before pushing? Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 26 06:12:07 2021 Received: (at 47069) by debbugs.gnu.org; 26 Mar 2021 10:12:07 +0000 Received: from localhost ([127.0.0.1]:40497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPjRm-00011h-W6 for submit@debbugs.gnu.org; Fri, 26 Mar 2021 06:12:07 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:46685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPjRk-00011U-FZ for 47069@debbugs.gnu.org; Fri, 26 Mar 2021 06:12:05 -0400 Received: from nijino.local (194-96-13-79.adsl.highway.telekom.at [194.96.13.79]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4F6Hnr0Yhjz1LZW9; Fri, 26 Mar 2021 11:11:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4F6Hnr0Yhjz1LZW9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1616753520; bh=SQTdHjk6AbZv5DaYKv6yj7bVZnBjS+DTOt64CafyeKo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Zcf+oAchUilotFcz8JMtrGbbSUcELJuE1aOQhnfHHVo6p2ebCvgAKwD1jbKJrQaV6 twRbHafE/iL6Gw+l6rLUAcwUj82htz27Q1PblJP+G9yvlFzrmsf+GDFvqbwVaZJAff L07iizL+pKOhxAAqtSo0Vy9TitJ6Oecvn64V6Z3A= Message-ID: <60a9423555bdb4202c8684d3a5b5780b13422599.camel@student.tugraz.at> Subject: Re: [bug#47069] [PATCH] etc: Run pre-push make in guix environment. From: Leo Prikler To: zimoun , Tobias Geerinckx-Rice Date: Fri, 26 Mar 2021 11:11:59 +0100 In-Reply-To: <86lfaaba2m.fsf@gmail.com> References: <20210311144257.4203-1-me@tobias.gr> <86lfaaba2m.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47069 Cc: 47069@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Freitag, den 26.03.2021, 09:20 +0100 schrieb zimoun: > Hi Tobias, > > On Thu, 11 Mar 2021 at 15:42, Tobias Geerinckx-Rice > wrote: > > * etc/git/pre-push: Exec make in a guix development environment. > > --- > > The pre-push assumes you have make installed, which I didn't. > > How do you rebuild Guix before pushing? If that's a problem for the script, you could add an explicit 'all' target. That said, I think, that many developers (myself included), who would suffer from the problem mentioned by Tobias already run 'git push' inside a guix environment. I know I do. @Tobias: would it make sense to detect that case (via GUIX_ENVIRONMENT) and only optionally construct the guix environment? Regards, Leo