From unknown Sun Jun 22 00:22:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 Resent-From: Eyal Soha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Mar 2021 22:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 47060@debbugs.gnu.org, monnier@iro.umontreal.ca X-Debbugs-Original-To: bug-gnu-emacs@gnu.org, monnier@iro.umontreal.ca Received: via spool by submit@debbugs.gnu.org id=B.16154167539420 (code B ref -1); Wed, 10 Mar 2021 22:53:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Mar 2021 22:52:33 +0000 Received: from localhost ([127.0.0.1]:52093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK7gu-0002Rr-GI for submit@debbugs.gnu.org; Wed, 10 Mar 2021 17:52:33 -0500 Received: from lists.gnu.org ([209.51.188.17]:33284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK5yQ-0008GU-9v for submit@debbugs.gnu.org; Wed, 10 Mar 2021 16:02:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lK5yQ-0007Dx-2T for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 16:02:30 -0500 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:46414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lK5yN-0007fH-EM for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 16:02:29 -0500 Received: by mail-lj1-x233.google.com with SMTP id p15so27418202ljc.13 for ; Wed, 10 Mar 2021 13:02:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=nmQQcw15lqVd+s7NVAPQeIlTw4djQ8c+d2oD1lT6Ji8=; b=kAPW/O1jYFSe6p3fpee4x5gNYLwGlzmYBvKeJjZPVzYYI0Hylw2cbDUsMONGAfWfZ2 6HB+Hl4sDeHfj+t2wvNu9CeeRVgZrdmHIV896rf9KwWv8W0GmEPg+J19eJwc+V8gBTds D0pCdYy/845xImWvxrY2qvkGVIVKztiiLPAjNSKdMx4zVDHh5sH9pH/JzFu8/ed1dTmz BOwpkKOXLhYXcNdvr6HkHhsT89umNxRJkbEztfXe1/o2c2peVO9vMf6FiJFKkTtoY+8F +DlTEgkvcEDRvrZ4ub4bexuautVnbyQpNYCoD/+T5Q5F8eg/8EPhvRqjmL784EO/3SEN 2fyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=nmQQcw15lqVd+s7NVAPQeIlTw4djQ8c+d2oD1lT6Ji8=; b=KBoHfV67wK/fGvI8QmPFnB+h1U3Xi+E82xLRJqCWnRjhEMbRWm4s003qqgNE03WlBB hCIgy20Gid/nihsRKJ/gvAk0N8XQiP0GIhSvu/4tS3Zj0CbHGJmQPqaG2lrSGqybTGKc KaXyDvS+iBtLQ/AlnvXoSFJhdJ/+XPqA/U/pqflYTAZgxv8ROG5wqJWdUey6FQkmsUDv ypxi6cqpa6OiR/+EWiNKcZU6NR2mpvfaPSFYuAK3l//ju3JZv1brSmI+Bqk+YgX8kA3Z SaDs2+Y5tqPBzFFxqA0x8P7NBV+v0fX+30+RK2dE0BPlqPdhUzUvL096kGd5ygLvMlTm rN0Q== X-Gm-Message-State: AOAM530o9mYatpMmWyrPm04ooR7QGXuDKycKXQvmrLJOdu8W5VJ0Ifu9 NAa26m5MGvjvVPeois4vbxgSbcHWLd9qU/35RfjjMW8iozT3Ww== X-Google-Smtp-Source: ABdhPJzwSxF3Kck61hhyn74O7j1ovvQtXUhBjSke9qBhh6IsxBb5xI0n9w+ZygDRMFzLQWHDEBIAW00ToezWc9oa5yQ= X-Received: by 2002:a05:651c:2047:: with SMTP id t7mr3004821ljo.325.1615410143950; Wed, 10 Mar 2021 13:02:23 -0800 (PST) MIME-Version: 1.0 From: Eyal Soha Date: Wed, 10 Mar 2021 14:02:12 -0700 Message-ID: Content-Type: multipart/alternative; boundary="000000000000cbfc7405bd34fb0e" Received-SPF: pass client-ip=2a00:1450:4864:20::233; envelope-from=shawarmakarma@gmail.com; helo=mail-lj1-x233.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Mailman-Approved-At: Wed, 10 Mar 2021 17:52:31 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000cbfc7405bd34fb0e Content-Type: text/plain; charset="UTF-8" Setting the variable mouse-1-click-follows-link to 'double was broken by the commit 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 . To test this, customize the mouse-1-click-follows-link variable to `double. Then try to double click on a link, such at the word "back" that appears in many of the info help pages. Double click will not work. Building on the version directly before that, double click does work. In GNU Emacs 28.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2021-03-03 built on mx Repository revision: 43b40bc880f66cb3f48318ba3a480a76b149b815 Repository branch: feature/native-comp Windowing system distributor 'The X.Org Foundation', version 11.0.12009000 System Description: Debian GNU/Linux 10 (buster) Configured using: 'configure --with-native-compilation --prefix=/home/esoha/.local --with-x-toolkit=gtk3' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LIBSELINUX LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: C/*l Minor modes in effect: gpm-mouse-mode: t hideshowvis-minor-mode: t global-diff-hl-mode: t diff-hl-mode: t xterm-mouse-mode: t global-color-identifiers-mode: t color-identifiers-mode: t global-flycheck-mode: t flycheck-mode: t company-quickhelp-mode: t company-quickhelp-local-mode: t global-company-mode: t company-mode: t recentf-mode: t savehist-mode: t save-place-mode: t show-paren-mode: t beacon-mode: t spaceline-info-mode: t spaceline-helm-mode: t counsel-mode: t ivy-mode: t delete-selection-mode: t global-git-commit-mode: t magit-auto-revert-mode: t global-auto-revert-mode: t shell-dirtrack-mode: t which-key-mode: t global-whitespace-mode: t ws-butler-mode: t goto-address-mode: t global-goto-address-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t hs-minor-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug sendmail mc-edit-lines mc-hide-unmatched-lines-mode mc-mark-more mc-cycle-cursors multiple-cursors-core t-mouse strokes msb avoid artist picture reporter rect cus-edit pp cl-print eieio-opt speedbar ezimage dframe shortdoc help-fns radix-tree ffap misearch multi-isearch vc-git cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs hideshow hideshowvis init diff-hl log-view vc-dir ewoc vc vc-dispatcher scons-mode xt-mouse llvm-mode tablegen-mode sanityinc-tomorrow-night-theme color-theme-sanityinc-tomorrow image-file image-converter cus-start cus-load color-identifiers-mode python tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat parse-time iso8601 ls-lisp flycheck find-func ace-jump-mode cl company-quickhelp pos-tip company-oddmuse company-keywords company-etags etags fileloop generator company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb company rainbow-delimiters recentf tree-widget wid-edit savehist saveplace paren beacon spaceline-config spaceline-segments s spaceline powerline powerline-separators powerline-themes counsel xdg xref project compile swiper ivy delsel ivy-faces ivy-overlay colir color region-bindings-mode edmacro kmacro magit-submodule magit-obsolete magit-popup magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff diff-mode git-commit log-edit message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor shell pcomplete comint ring server ansi-color magit-mode transient comp comp-cstr warnings rx format-spec magit-git magit-section magit-utils crm which-key advice disp-table whitespace ws-butler goto-addr thingatpt diminish time-date auto-package-update dash cl-extra help-mode use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core finder-inf info package easymenu browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face pcase macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process nativecomp emacs) Memory information: ((conses 16 682782 115976) (symbols 48 36240 2) (strings 32 156281 6872) (string-bytes 1 5629612) (vectors 16 69564) (vector-slots 8 1952275 168183) (floats 8 365 557) (intervals 56 14064 6666) (buffers 992 22)) --000000000000cbfc7405bd34fb0e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Setting the variable mouse-1-click-follows-link to = 9;double was broken by
the commit 3d5e31eceb9dc1fb62b2b27bcab549df3bd04c= e9 .

To test this, customize the mouse-1-click-follows-link variable= to
`double.=C2=A0 Then try to double click on a link, such at the word = "back"
that appears in many of the info help pages.=C2=A0 Doub= le click will not
work.=C2=A0 Building on the version directly before th= at, double click does
work.



In GNU Emacs 28.0.50 (build 3= , x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0)
=C2=A0= of 2021-03-03 built on mx
Repository revision: 43b40bc880f66cb3f48318ba3= a480a76b149b815
Repository branch: feature/native-comp
Windowing syst= em distributor 'The X.Org Foundation', version 11.0.12009000
Sys= tem Description: Debian GNU/Linux 10 (buster)

Configured using:
= =C2=A0'configure --with-native-compilation --prefix=3D/home/esoha/.loca= l
=C2=A0--with-x-toolkit=3Dgtk3'

Configured features:
CAIR= O DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG
LIBSELINUX L= IBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG
SOUND THREADS= TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB

Important setti= ngs:
=C2=A0 value of $LC_ALL: en_US.UTF-8
=C2=A0 value of $LANG: en_U= S.UTF-8
=C2=A0 locale-coding-system: utf-8-unix

Major mode: C/*l<= br>
Minor modes in effect:
=C2=A0 gpm-mouse-mode: t
=C2=A0 hidesho= wvis-minor-mode: t
=C2=A0 global-diff-hl-mode: t
=C2=A0 diff-hl-mode:= t
=C2=A0 xterm-mouse-mode: t
=C2=A0 global-color-identifiers-mode: t=
=C2=A0 color-identifiers-mode: t
=C2=A0 global-flycheck-mode: t
= =C2=A0 flycheck-mode: t
=C2=A0 company-quickhelp-mode: t
=C2=A0 compa= ny-quickhelp-local-mode: t
=C2=A0 global-company-mode: t
=C2=A0 compa= ny-mode: t
=C2=A0 recentf-mode: t
=C2=A0 savehist-mode: t
=C2=A0 s= ave-place-mode: t
=C2=A0 show-paren-mode: t
=C2=A0 beacon-mode: t
= =C2=A0 spaceline-info-mode: t
=C2=A0 spaceline-helm-mode: t
=C2=A0 co= unsel-mode: t
=C2=A0 ivy-mode: t
=C2=A0 delete-selection-mode: t
= =C2=A0 global-git-commit-mode: t
=C2=A0 magit-auto-revert-mode: t
=C2= =A0 global-auto-revert-mode: t
=C2=A0 shell-dirtrack-mode: t
=C2=A0 w= hich-key-mode: t
=C2=A0 global-whitespace-mode: t
=C2=A0 ws-butler-mo= de: t
=C2=A0 goto-address-mode: t
=C2=A0 global-goto-address-mode: t<= br>=C2=A0 override-global-mode: t
=C2=A0 tooltip-mode: t
=C2=A0 globa= l-eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mod= e: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t<= br>=C2=A0 font-lock-mode: t
=C2=A0 blink-cursor-mode: t
=C2=A0 auto-c= omposition-mode: t
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compres= sion-mode: t
=C2=A0 column-number-mode: t
=C2=A0 line-number-mode: t<= br>=C2=A0 transient-mark-mode: t
=C2=A0 abbrev-mode: t
=C2=A0 hs-mino= r-mode: t

Load-path shadows:
None found.

Features:
(sha= dow sort mail-extr emacsbug sendmail mc-edit-lines
mc-hide-unmatched-lin= es-mode mc-mark-more mc-cycle-cursors
multiple-cursors-core t-mouse stro= kes msb avoid artist picture reporter
rect cus-edit pp cl-print eieio-op= t speedbar ezimage dframe shortdoc
help-fns radix-tree ffap misearch mul= ti-isearch vc-git cc-mode cc-fonts
cc-guess cc-menus cc-cmds cc-styles c= c-align cc-engine cc-vars cc-defs
hideshow hideshowvis init diff-hl log-= view vc-dir ewoc vc vc-dispatcher
scons-mode xt-mouse llvm-mode tablegen= -mode
sanityinc-tomorrow-night-theme color-theme-sanityinc-tomorrow imag= e-file
image-converter cus-start cus-load color-identifiers-mode python<= br>tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x
tram= p-compat parse-time iso8601 ls-lisp flycheck find-func ace-jump-mode
cl = company-quickhelp pos-tip company-oddmuse company-keywords
company-etags= etags fileloop generator company-gtags
company-dabbrev-code company-dab= brev company-files company-clang
company-capf company-cmake company-sema= ntic company-template
company-bbdb company rainbow-delimiters recentf tr= ee-widget wid-edit
savehist saveplace paren beacon spaceline-config spac= eline-segments s
spaceline powerline powerline-separators powerline-them= es counsel xdg
xref project compile swiper ivy delsel ivy-faces ivy-over= lay colir color
region-bindings-mode edmacro kmacro magit-submodule magi= t-obsolete
magit-popup magit-blame magit-stash magit-reflog magit-bisect= magit-push
magit-pull magit-fetch magit-clone magit-remote magit-commit=
magit-sequence magit-notes magit-worktree magit-tag magit-merge
magi= t-branch magit-reset magit-files magit-refs magit-status magit
magit-rep= os magit-apply magit-wip magit-log which-func imenu magit-diff
smerge-mo= de diff diff-mode git-commit log-edit message rmc puny dired
dired-loadd= efs rfc822 mml mml-sec epa derived epg epg-config gnus-util
rmail rmail-= loaddefs text-property-search mm-decode mm-bodies mm-encode
mail-parse r= fc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr
mailabbrev mail-uti= ls gmm-utils mailheader pcvs-util add-log magit-core
magit-autorevert au= torevert filenotify magit-margin magit-transient
magit-process with-edit= or shell pcomplete comint ring server ansi-color
magit-mode transient co= mp comp-cstr warnings rx format-spec magit-git
magit-section magit-utils= crm which-key advice disp-table whitespace
ws-butler goto-addr thingatp= t diminish time-date auto-package-update
dash cl-extra help-mode use-pac= kage use-package-ensure
use-package-delight use-package-diminish use-pac= kage-bind-key bind-key
easy-mmode use-package-core finder-inf info packa= ge easymenu browse-url
url url-proxy url-privacy url-expand url-methods = url-history url-cookie
url-domsuf url-util mailcap url-handlers url-pars= e auth-source cl-seq
eieio eieio-core cl-macs eieio-loaddefs password-ca= che json subr-x map
url-vars seq byte-opt gv bytecomp byte-compile cconv= cl-loaddefs cl-lib
iso-transl tooltip eldoc electric uniquify ediff-hoo= k vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd= tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace new= comment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar m= enu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-= lock
syntax facemenu font-core term/tty-colors frame minibuffer cl-gener= ic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet l= ao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czecheuropean ethiopic indian cyrillic chinese composite charscript charpropcase-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloa= ded nadvice button loaddefs faces cus-face pcase macroexp files
window t= ext-properties overlay sha1 md5 base64 format env code-pages
mule custom= widget hashtable-print-readable backquote threads dbusbind
inotify dyna= mic-setting system-font-setting font-render-setting cairo
move-toolbar g= tk x-toolkit x multi-tty make-network-process nativecomp
emacs)

M= emory information:
((conses 16 682782 115976)
=C2=A0(symbols 48 36240= 2)
=C2=A0(strings 32 156281 6872)
=C2=A0(string-bytes 1 5629612)
= =C2=A0(vectors 16 69564)
=C2=A0(vector-slots 8 1952275 168183)
=C2=A0= (floats 8 365 557)
=C2=A0(intervals 56 14064 6666)
=C2=A0(buffers 992= 22))
--000000000000cbfc7405bd34fb0e-- From unknown Sun Jun 22 00:22:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 Resent-From: Eyal Soha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Mar 2021 00:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 47060@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161542114724449 (code B ref -1); Thu, 11 Mar 2021 00:06:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Mar 2021 00:05:47 +0000 Received: from localhost ([127.0.0.1]:52248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK8pm-0006MG-Nn for submit@debbugs.gnu.org; Wed, 10 Mar 2021 19:05:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:44602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK7NH-0001yw-KC for submit@debbugs.gnu.org; Wed, 10 Mar 2021 17:32:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lK7NH-000211-D0 for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 17:32:15 -0500 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:42976) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lK7NF-0000oy-7X for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 17:32:15 -0500 Received: by mail-lj1-x233.google.com with SMTP id k12so27738917ljg.9 for ; Wed, 10 Mar 2021 14:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=K+zMZ+XuMb538v5qwBXQW4niiuFfaiwRnmtWleq9epc=; b=CeCHqyC/2kC53OE1CJd2aNANUJQO4q2GnaU8D7DMWMypSUZrcrMHphmPmi29ycvGpU ogwbpnaqXjjs723XjFP6BB8FMkxKRUC2QEHSmDM3dN0+/7WYCc265IRvYxi4oPzc7iqb GJm3tC2gYllvU30dElotOPTvcg7ar5KuQNhcwVwDM1nYWs8psEZCL+HxQibHBTqF0CSx 7M9D1N5zM45aK20R1YqmN42BILtPqvEfVWJd6xO2vU2cptOnBsDdy3d/kWAsjlk7PyJ4 h0yekHSJ3+PpVSaaDBDZ3VkWX0XWQuwz+bCfqLTqMucpJevV4hj2lcvHP7QnA9RSAH0t 0skg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=K+zMZ+XuMb538v5qwBXQW4niiuFfaiwRnmtWleq9epc=; b=AAhBY3HmzsHWKXx6AMpCdUijWKYL3SjO9Yv8EnrubduM1Kcqe2t3f8ao3IZ3940kNr QhLYbW2wsJ694T6qLn35XIXEBYPCzvVNbfOuRNAiSUSdY/tUKWXyPjueC25zhnpay3iT upHxjy9nLq/ns910odjrCxc1mscUPL2S6InvMmzuGwe1AuFQRfChSxH5RLgRMjgtSGjs bHRWYGKL7Pl9a+n9ZMC6g7JT50j9lZX5nsoXT4M27Scjkxw8zpez36VGE8v57HbCjeFj YMjfszs9Qp0CFGxYq3VYS8t8xyYlJYU7YDMjcMx8JkuzorrFW6GpJW9M+TFoPJd+Or+h 8IDQ== X-Gm-Message-State: AOAM532ZjVlgZw9xV/I8jN0Z35z1puTqY0rpvOcb5+PSA6Otg7V1NUsT qYQrO/jMl12tQG62ReoM6iZUphtopX8A/CCIGR5GI+lQZAQ= X-Google-Smtp-Source: ABdhPJwtMXzHtztyRfBqNXlCSu4NkgHkyqANJC4NvbB/Q7Qtq9SHj21pDU0TKlGRYioijCKUPJhq3ufdLJzlzA9pxes= X-Received: by 2002:a2e:5c7:: with SMTP id 190mr3081322ljf.164.1615415528376; Wed, 10 Mar 2021 14:32:08 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Eyal Soha Date: Wed, 10 Mar 2021 15:31:57 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::233; envelope-from=shawarmakarma@gmail.com; helo=mail-lj1-x233.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Mailman-Approved-At: Wed, 10 Mar 2021 19:05:45 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On Wed, Mar 10, 2021 at 2:02 PM Eyal Soha wrote: > > > Setting the variable mouse-1-click-follows-link to 'double was broken by > the commit 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 . > > To test this, customize the mouse-1-click-follows-link variable to > `double. Then try to double click on a link, such at the word "back" > that appears in many of the info help pages. Double click will not > work. Building on the version directly before that, double click does > work. > > > > In GNU Emacs 28.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) > of 2021-03-03 built on mx > Repository revision: 43b40bc880f66cb3f48318ba3a480a76b149b815 > Repository branch: feature/native-comp > Windowing system distributor 'The X.Org Foundation', version 11.0.12009000 > System Description: Debian GNU/Linux 10 (buster) > > Configured using: > 'configure --with-native-compilation --prefix=/home/esoha/.local > --with-x-toolkit=gtk3' > > Configured features: > CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG > LIBSELINUX LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG > SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB > > Important settings: > value of $LC_ALL: en_US.UTF-8 > value of $LANG: en_US.UTF-8 > locale-coding-system: utf-8-unix > > Major mode: C/*l > > Minor modes in effect: > gpm-mouse-mode: t > hideshowvis-minor-mode: t > global-diff-hl-mode: t > diff-hl-mode: t > xterm-mouse-mode: t > global-color-identifiers-mode: t > color-identifiers-mode: t > global-flycheck-mode: t > flycheck-mode: t > company-quickhelp-mode: t > company-quickhelp-local-mode: t > global-company-mode: t > company-mode: t > recentf-mode: t > savehist-mode: t > save-place-mode: t > show-paren-mode: t > beacon-mode: t > spaceline-info-mode: t > spaceline-helm-mode: t > counsel-mode: t > ivy-mode: t > delete-selection-mode: t > global-git-commit-mode: t > magit-auto-revert-mode: t > global-auto-revert-mode: t > shell-dirtrack-mode: t > which-key-mode: t > global-whitespace-mode: t > ws-butler-mode: t > goto-address-mode: t > global-goto-address-mode: t > override-global-mode: t > tooltip-mode: t > global-eldoc-mode: t > electric-indent-mode: t > mouse-wheel-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > blink-cursor-mode: t > auto-composition-mode: t > auto-encryption-mode: t > auto-compression-mode: t > column-number-mode: t > line-number-mode: t > transient-mark-mode: t > abbrev-mode: t > hs-minor-mode: t > > Load-path shadows: > None found. > > Features: > (shadow sort mail-extr emacsbug sendmail mc-edit-lines > mc-hide-unmatched-lines-mode mc-mark-more mc-cycle-cursors > multiple-cursors-core t-mouse strokes msb avoid artist picture reporter > rect cus-edit pp cl-print eieio-opt speedbar ezimage dframe shortdoc > help-fns radix-tree ffap misearch multi-isearch vc-git cc-mode cc-fonts > cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs > hideshow hideshowvis init diff-hl log-view vc-dir ewoc vc vc-dispatcher > scons-mode xt-mouse llvm-mode tablegen-mode > sanityinc-tomorrow-night-theme color-theme-sanityinc-tomorrow image-file > image-converter cus-start cus-load color-identifiers-mode python > tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x > tramp-compat parse-time iso8601 ls-lisp flycheck find-func ace-jump-mode > cl company-quickhelp pos-tip company-oddmuse company-keywords > company-etags etags fileloop generator company-gtags > company-dabbrev-code company-dabbrev company-files company-clang > company-capf company-cmake company-semantic company-template > company-bbdb company rainbow-delimiters recentf tree-widget wid-edit > savehist saveplace paren beacon spaceline-config spaceline-segments s > spaceline powerline powerline-separators powerline-themes counsel xdg > xref project compile swiper ivy delsel ivy-faces ivy-overlay colir color > region-bindings-mode edmacro kmacro magit-submodule magit-obsolete > magit-popup magit-blame magit-stash magit-reflog magit-bisect magit-push > magit-pull magit-fetch magit-clone magit-remote magit-commit > magit-sequence magit-notes magit-worktree magit-tag magit-merge > magit-branch magit-reset magit-files magit-refs magit-status magit > magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff > smerge-mode diff diff-mode git-commit log-edit message rmc puny dired > dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util > rmail rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode > mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr > mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log magit-core > magit-autorevert autorevert filenotify magit-margin magit-transient > magit-process with-editor shell pcomplete comint ring server ansi-color > magit-mode transient comp comp-cstr warnings rx format-spec magit-git > magit-section magit-utils crm which-key advice disp-table whitespace > ws-butler goto-addr thingatpt diminish time-date auto-package-update > dash cl-extra help-mode use-package use-package-ensure > use-package-delight use-package-diminish use-package-bind-key bind-key > easy-mmode use-package-core finder-inf info package easymenu browse-url > url url-proxy url-privacy url-expand url-methods url-history url-cookie > url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq > eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map > url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib > iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks > lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar > dnd fontset image regexp-opt fringe tabulated-list replace newcomment > text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar > rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock > syntax facemenu font-core term/tty-colors frame minibuffer cl-generic > cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao > korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech > european ethiopic indian cyrillic chinese composite charscript charprop > case-table epa-hook jka-cmpr-hook help simple abbrev obarray > cl-preloaded nadvice button loaddefs faces cus-face pcase macroexp files > window text-properties overlay sha1 md5 base64 format env code-pages > mule custom widget hashtable-print-readable backquote threads dbusbind > inotify dynamic-setting system-font-setting font-render-setting cairo > move-toolbar gtk x-toolkit x multi-tty make-network-process nativecomp > emacs) > > Memory information: > ((conses 16 682782 115976) > (symbols 48 36240 2) > (strings 32 156281 6872) > (string-bytes 1 5629612) > (vectors 16 69564) > (vector-slots 8 1952275 168183) > (floats 8 365 557) > (intervals 56 14064 6666) > (buffers 992 22)) From unknown Sun Jun 22 00:22:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Mar 2021 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eyal Soha Cc: 47060@debbugs.gnu.org Received: via spool by 47060-submit@debbugs.gnu.org id=B47060.16154745356011 (code B ref 47060); Thu, 11 Mar 2021 14:56:02 +0000 Received: (at 47060) by debbugs.gnu.org; 11 Mar 2021 14:55:35 +0000 Received: from localhost ([127.0.0.1]:54642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKMit-0001Yt-26 for submit@debbugs.gnu.org; Thu, 11 Mar 2021 09:55:35 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:13683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKMiq-0001Q7-V8 for 47060@debbugs.gnu.org; Thu, 11 Mar 2021 09:55:33 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 095AE8078F; Thu, 11 Mar 2021 09:55:27 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5B94980618; Thu, 11 Mar 2021 09:55:25 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1615474525; bh=tdy+m7ckOZ3jY2vqxQ92j/4pTdE7bsHEEivmm+IiFcI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CAc/DAtzoqSyOah3Cq04BWti3O1hGFiPA/ovq4o1MNf3gVSWZ8SLIlCXLyiuJU/rc wAE/4WJeLdHKXQ/L+9uj/NSdCNr50RxUtMtmOSA8HRs8MzVaBbnzc5zKy3sbsoCn9Y WX2RcqYUqB2VAWGytVnV8x20Z2bigpkgw9/mjDtqKK8joXUfTtdtcf0udtWS21tE8h 7kUZEwzBJETwSkPLKXrpAtv0r0YAahgX/OuPMe+W3SYqgBi+DMyJJP/yrLFgWzwkOe C8lSVXh/UCbk49PvlBQFB6OxUwrSxuzvmHKoYMjoaUhm04o9xMqzn5HzCYLFDFYfGP Q09DdQxkr7Gvg== Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 337A212023A; Thu, 11 Mar 2021 09:55:25 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Thu, 11 Mar 2021 09:55:24 -0500 In-Reply-To: (Eyal Soha's message of "Wed, 10 Mar 2021 14:02:12 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.344 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Setting the variable mouse-1-click-follows-link to 'double was broken by > the commit 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 . Indeed! And since this code can be sometimes tricky to debug and tune, your report got me scared that I was going to have to rethink the way it works, but ... it was a silly mistake: I called `event-convert-list` with a list whose last element was not always a "basic" event, so we ended up comparing `down-double-mouse-1` and `double-down-mouse-1` and deciding these are different events. The patch below should fix it. I think this patch should go to `emacs-27`. Eli any objection? Stefan diff --git a/lisp/mouse.el b/lisp/mouse.el index 8732fb8086..f4979e37b0 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -119,7 +119,9 @@ mouse--click-1-maybe-follows-link (time-since (cdr mouse--last-down)) (/ (abs mouse-1-click-follows-link) 1000.0)))))) (eq (car mouse--last-down) - (event-convert-list (list 'down (car-safe last-input-event)))) + (event-convert-list + `(down ,@(event-modifiers last-input-event) + ,(event-basic-type last-input-event)))) (let* ((action (mouse-on-link-p (event-start last-input-event)))) (when (and action (or mouse-1-click-in-non-selected-windows From unknown Sun Jun 22 00:22:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Mar 2021 15:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 47060@debbugs.gnu.org, eyalsoha@gmail.com Received: via spool by 47060-submit@debbugs.gnu.org id=B47060.161547811211434 (code B ref 47060); Thu, 11 Mar 2021 15:56:01 +0000 Received: (at 47060) by debbugs.gnu.org; 11 Mar 2021 15:55:12 +0000 Received: from localhost ([127.0.0.1]:54679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKNea-0002yM-HA for submit@debbugs.gnu.org; Thu, 11 Mar 2021 10:55:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKNeX-0002y4-MD for 47060@debbugs.gnu.org; Thu, 11 Mar 2021 10:55:10 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43441) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKNeS-0007Pj-0M; Thu, 11 Mar 2021 10:55:04 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2602 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lKNeP-0002eK-3K; Thu, 11 Mar 2021 10:55:01 -0500 Date: Thu, 11 Mar 2021 17:55:00 +0200 Message-Id: <83czw5n0rv.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Monnier on Thu, 11 Mar 2021 09:55:24 -0500) References: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Stefan Monnier > Date: Thu, 11 Mar 2021 09:55:24 -0500 > Cc: 47060@debbugs.gnu.org > > > Setting the variable mouse-1-click-follows-link to 'double was broken by > > the commit 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 . > > Indeed! And since this code can be sometimes tricky to debug and tune, > your report got me scared that I was going to have to rethink the way it > works, but ... it was a silly mistake: I called `event-convert-list` > with a list whose last element was not always a "basic" event, > so we ended up comparing `down-double-mouse-1` and `double-down-mouse-1` > and deciding these are different events. > > The patch below should fix it. > I think this patch should go to `emacs-27`. Eli any objection? No, please go ahead, and thanks. From unknown Sun Jun 22 00:22:54 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Eyal Soha Subject: bug#47060: closed (Re: bug#47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9) Message-ID: References: X-Gnu-PR-Message: they-closed 47060 X-Gnu-PR-Package: emacs Reply-To: 47060@debbugs.gnu.org Date: Thu, 11 Mar 2021 17:15:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1615482902-19169-1" This is a multi-part message in MIME format... ------------=_1615482902-19169-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27= bcab549df3bd04ce9 which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 47060@debbugs.gnu.org. --=20 47060: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D47060 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1615482902-19169-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 47060-done) by debbugs.gnu.org; 11 Mar 2021 17:14:57 +0000 Received: from localhost ([127.0.0.1]:54783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKOtk-0004yo-T1 for submit@debbugs.gnu.org; Thu, 11 Mar 2021 12:14:57 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9101) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKOtj-0004yW-MF for 47060-done@debbugs.gnu.org; Thu, 11 Mar 2021 12:14:56 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 476B410023D; Thu, 11 Mar 2021 12:14:50 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C40CD1001D2; Thu, 11 Mar 2021 12:14:48 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1615482888; bh=yb/ICdThUIV9v9IJxLLg7xDcPeZwdP+Zsuuoc2FSWiI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IybEj8q+E7js+WX4llCIOAh8dfblo4+x0k1LbiSUrcwSwr86fBJgll+pNllB9coC7 IU3rlZNzymKPVVT+sn6Bm7PdYx4hRKogdHwTe1lC5w1rPt/dJtBTNklKmqkNiWbVRD LGQG0Fr4JEPR6MeVtz2Pyjk4w81cwigny1j4s0TZAA0NvHxZHMwrgoKCeBfOqfpZoa sBrgzAFKjRYh/81Po9b9SrNm0gxRVr+PkwAWEdvBhsrG53/PMbq/dtH3hPGLnkSDz/ Ijv4Ai57ahndWJGQZkKFPG4mba56peHHvDNtFFaRnOoo4LyQIa0ReIDdWpnINs7UfL y3XxKbdGz1SUw== Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 94F041203CE; Thu, 11 Mar 2021 12:14:48 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 Message-ID: References: <83czw5n0rv.fsf@gnu.org> Date: Thu, 11 Mar 2021 12:14:47 -0500 In-Reply-To: <83czw5n0rv.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 11 Mar 2021 17:55:00 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.346 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 47060-done Cc: 47060-done@debbugs.gnu.org, eyalsoha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> The patch below should fix it. >> I think this patch should go to `emacs-27`. Eli any objection? > No, please go ahead, and thanks. Thanks, pushed, Stefan ------------=_1615482902-19169-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 10 Mar 2021 22:52:33 +0000 Received: from localhost ([127.0.0.1]:52093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK7gu-0002Rr-GI for submit@debbugs.gnu.org; Wed, 10 Mar 2021 17:52:33 -0500 Received: from lists.gnu.org ([209.51.188.17]:33284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK5yQ-0008GU-9v for submit@debbugs.gnu.org; Wed, 10 Mar 2021 16:02:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lK5yQ-0007Dx-2T for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 16:02:30 -0500 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:46414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lK5yN-0007fH-EM for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 16:02:29 -0500 Received: by mail-lj1-x233.google.com with SMTP id p15so27418202ljc.13 for ; Wed, 10 Mar 2021 13:02:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=nmQQcw15lqVd+s7NVAPQeIlTw4djQ8c+d2oD1lT6Ji8=; b=kAPW/O1jYFSe6p3fpee4x5gNYLwGlzmYBvKeJjZPVzYYI0Hylw2cbDUsMONGAfWfZ2 6HB+Hl4sDeHfj+t2wvNu9CeeRVgZrdmHIV896rf9KwWv8W0GmEPg+J19eJwc+V8gBTds D0pCdYy/845xImWvxrY2qvkGVIVKztiiLPAjNSKdMx4zVDHh5sH9pH/JzFu8/ed1dTmz BOwpkKOXLhYXcNdvr6HkHhsT89umNxRJkbEztfXe1/o2c2peVO9vMf6FiJFKkTtoY+8F +DlTEgkvcEDRvrZ4ub4bexuautVnbyQpNYCoD/+T5Q5F8eg/8EPhvRqjmL784EO/3SEN 2fyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=nmQQcw15lqVd+s7NVAPQeIlTw4djQ8c+d2oD1lT6Ji8=; b=KBoHfV67wK/fGvI8QmPFnB+h1U3Xi+E82xLRJqCWnRjhEMbRWm4s003qqgNE03WlBB hCIgy20Gid/nihsRKJ/gvAk0N8XQiP0GIhSvu/4tS3Zj0CbHGJmQPqaG2lrSGqybTGKc KaXyDvS+iBtLQ/AlnvXoSFJhdJ/+XPqA/U/pqflYTAZgxv8ROG5wqJWdUey6FQkmsUDv ypxi6cqpa6OiR/+EWiNKcZU6NR2mpvfaPSFYuAK3l//ju3JZv1brSmI+Bqk+YgX8kA3Z SaDs2+Y5tqPBzFFxqA0x8P7NBV+v0fX+30+RK2dE0BPlqPdhUzUvL096kGd5ygLvMlTm rN0Q== X-Gm-Message-State: AOAM530o9mYatpMmWyrPm04ooR7QGXuDKycKXQvmrLJOdu8W5VJ0Ifu9 NAa26m5MGvjvVPeois4vbxgSbcHWLd9qU/35RfjjMW8iozT3Ww== X-Google-Smtp-Source: ABdhPJzwSxF3Kck61hhyn74O7j1ovvQtXUhBjSke9qBhh6IsxBb5xI0n9w+ZygDRMFzLQWHDEBIAW00ToezWc9oa5yQ= X-Received: by 2002:a05:651c:2047:: with SMTP id t7mr3004821ljo.325.1615410143950; Wed, 10 Mar 2021 13:02:23 -0800 (PST) MIME-Version: 1.0 From: Eyal Soha Date: Wed, 10 Mar 2021 14:02:12 -0700 Message-ID: Subject: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 To: bug-gnu-emacs@gnu.org, monnier@iro.umontreal.ca Content-Type: multipart/alternative; boundary="000000000000cbfc7405bd34fb0e" Received-SPF: pass client-ip=2a00:1450:4864:20::233; envelope-from=shawarmakarma@gmail.com; helo=mail-lj1-x233.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 10 Mar 2021 17:52:31 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000cbfc7405bd34fb0e Content-Type: text/plain; charset="UTF-8" Setting the variable mouse-1-click-follows-link to 'double was broken by the commit 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 . To test this, customize the mouse-1-click-follows-link variable to `double. Then try to double click on a link, such at the word "back" that appears in many of the info help pages. Double click will not work. Building on the version directly before that, double click does work. In GNU Emacs 28.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2021-03-03 built on mx Repository revision: 43b40bc880f66cb3f48318ba3a480a76b149b815 Repository branch: feature/native-comp Windowing system distributor 'The X.Org Foundation', version 11.0.12009000 System Description: Debian GNU/Linux 10 (buster) Configured using: 'configure --with-native-compilation --prefix=/home/esoha/.local --with-x-toolkit=gtk3' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LIBSELINUX LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: C/*l Minor modes in effect: gpm-mouse-mode: t hideshowvis-minor-mode: t global-diff-hl-mode: t diff-hl-mode: t xterm-mouse-mode: t global-color-identifiers-mode: t color-identifiers-mode: t global-flycheck-mode: t flycheck-mode: t company-quickhelp-mode: t company-quickhelp-local-mode: t global-company-mode: t company-mode: t recentf-mode: t savehist-mode: t save-place-mode: t show-paren-mode: t beacon-mode: t spaceline-info-mode: t spaceline-helm-mode: t counsel-mode: t ivy-mode: t delete-selection-mode: t global-git-commit-mode: t magit-auto-revert-mode: t global-auto-revert-mode: t shell-dirtrack-mode: t which-key-mode: t global-whitespace-mode: t ws-butler-mode: t goto-address-mode: t global-goto-address-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t hs-minor-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug sendmail mc-edit-lines mc-hide-unmatched-lines-mode mc-mark-more mc-cycle-cursors multiple-cursors-core t-mouse strokes msb avoid artist picture reporter rect cus-edit pp cl-print eieio-opt speedbar ezimage dframe shortdoc help-fns radix-tree ffap misearch multi-isearch vc-git cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs hideshow hideshowvis init diff-hl log-view vc-dir ewoc vc vc-dispatcher scons-mode xt-mouse llvm-mode tablegen-mode sanityinc-tomorrow-night-theme color-theme-sanityinc-tomorrow image-file image-converter cus-start cus-load color-identifiers-mode python tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat parse-time iso8601 ls-lisp flycheck find-func ace-jump-mode cl company-quickhelp pos-tip company-oddmuse company-keywords company-etags etags fileloop generator company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb company rainbow-delimiters recentf tree-widget wid-edit savehist saveplace paren beacon spaceline-config spaceline-segments s spaceline powerline powerline-separators powerline-themes counsel xdg xref project compile swiper ivy delsel ivy-faces ivy-overlay colir color region-bindings-mode edmacro kmacro magit-submodule magit-obsolete magit-popup magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff diff-mode git-commit log-edit message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor shell pcomplete comint ring server ansi-color magit-mode transient comp comp-cstr warnings rx format-spec magit-git magit-section magit-utils crm which-key advice disp-table whitespace ws-butler goto-addr thingatpt diminish time-date auto-package-update dash cl-extra help-mode use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core finder-inf info package easymenu browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face pcase macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process nativecomp emacs) Memory information: ((conses 16 682782 115976) (symbols 48 36240 2) (strings 32 156281 6872) (string-bytes 1 5629612) (vectors 16 69564) (vector-slots 8 1952275 168183) (floats 8 365 557) (intervals 56 14064 6666) (buffers 992 22)) --000000000000cbfc7405bd34fb0e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Setting the variable mouse-1-click-follows-link to = 9;double was broken by
the commit 3d5e31eceb9dc1fb62b2b27bcab549df3bd04c= e9 .

To test this, customize the mouse-1-click-follows-link variable= to
`double.=C2=A0 Then try to double click on a link, such at the word = "back"
that appears in many of the info help pages.=C2=A0 Doub= le click will not
work.=C2=A0 Building on the version directly before th= at, double click does
work.



In GNU Emacs 28.0.50 (build 3= , x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0)
=C2=A0= of 2021-03-03 built on mx
Repository revision: 43b40bc880f66cb3f48318ba3= a480a76b149b815
Repository branch: feature/native-comp
Windowing syst= em distributor 'The X.Org Foundation', version 11.0.12009000
Sys= tem Description: Debian GNU/Linux 10 (buster)

Configured using:
= =C2=A0'configure --with-native-compilation --prefix=3D/home/esoha/.loca= l
=C2=A0--with-x-toolkit=3Dgtk3'

Configured features:
CAIR= O DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG
LIBSELINUX L= IBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG
SOUND THREADS= TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB

Important setti= ngs:
=C2=A0 value of $LC_ALL: en_US.UTF-8
=C2=A0 value of $LANG: en_U= S.UTF-8
=C2=A0 locale-coding-system: utf-8-unix

Major mode: C/*l<= br>
Minor modes in effect:
=C2=A0 gpm-mouse-mode: t
=C2=A0 hidesho= wvis-minor-mode: t
=C2=A0 global-diff-hl-mode: t
=C2=A0 diff-hl-mode:= t
=C2=A0 xterm-mouse-mode: t
=C2=A0 global-color-identifiers-mode: t=
=C2=A0 color-identifiers-mode: t
=C2=A0 global-flycheck-mode: t
= =C2=A0 flycheck-mode: t
=C2=A0 company-quickhelp-mode: t
=C2=A0 compa= ny-quickhelp-local-mode: t
=C2=A0 global-company-mode: t
=C2=A0 compa= ny-mode: t
=C2=A0 recentf-mode: t
=C2=A0 savehist-mode: t
=C2=A0 s= ave-place-mode: t
=C2=A0 show-paren-mode: t
=C2=A0 beacon-mode: t
= =C2=A0 spaceline-info-mode: t
=C2=A0 spaceline-helm-mode: t
=C2=A0 co= unsel-mode: t
=C2=A0 ivy-mode: t
=C2=A0 delete-selection-mode: t
= =C2=A0 global-git-commit-mode: t
=C2=A0 magit-auto-revert-mode: t
=C2= =A0 global-auto-revert-mode: t
=C2=A0 shell-dirtrack-mode: t
=C2=A0 w= hich-key-mode: t
=C2=A0 global-whitespace-mode: t
=C2=A0 ws-butler-mo= de: t
=C2=A0 goto-address-mode: t
=C2=A0 global-goto-address-mode: t<= br>=C2=A0 override-global-mode: t
=C2=A0 tooltip-mode: t
=C2=A0 globa= l-eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mod= e: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t<= br>=C2=A0 font-lock-mode: t
=C2=A0 blink-cursor-mode: t
=C2=A0 auto-c= omposition-mode: t
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compres= sion-mode: t
=C2=A0 column-number-mode: t
=C2=A0 line-number-mode: t<= br>=C2=A0 transient-mark-mode: t
=C2=A0 abbrev-mode: t
=C2=A0 hs-mino= r-mode: t

Load-path shadows:
None found.

Features:
(sha= dow sort mail-extr emacsbug sendmail mc-edit-lines
mc-hide-unmatched-lin= es-mode mc-mark-more mc-cycle-cursors
multiple-cursors-core t-mouse stro= kes msb avoid artist picture reporter
rect cus-edit pp cl-print eieio-op= t speedbar ezimage dframe shortdoc
help-fns radix-tree ffap misearch mul= ti-isearch vc-git cc-mode cc-fonts
cc-guess cc-menus cc-cmds cc-styles c= c-align cc-engine cc-vars cc-defs
hideshow hideshowvis init diff-hl log-= view vc-dir ewoc vc vc-dispatcher
scons-mode xt-mouse llvm-mode tablegen= -mode
sanityinc-tomorrow-night-theme color-theme-sanityinc-tomorrow imag= e-file
image-converter cus-start cus-load color-identifiers-mode python<= br>tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x
tram= p-compat parse-time iso8601 ls-lisp flycheck find-func ace-jump-mode
cl = company-quickhelp pos-tip company-oddmuse company-keywords
company-etags= etags fileloop generator company-gtags
company-dabbrev-code company-dab= brev company-files company-clang
company-capf company-cmake company-sema= ntic company-template
company-bbdb company rainbow-delimiters recentf tr= ee-widget wid-edit
savehist saveplace paren beacon spaceline-config spac= eline-segments s
spaceline powerline powerline-separators powerline-them= es counsel xdg
xref project compile swiper ivy delsel ivy-faces ivy-over= lay colir color
region-bindings-mode edmacro kmacro magit-submodule magi= t-obsolete
magit-popup magit-blame magit-stash magit-reflog magit-bisect= magit-push
magit-pull magit-fetch magit-clone magit-remote magit-commit=
magit-sequence magit-notes magit-worktree magit-tag magit-merge
magi= t-branch magit-reset magit-files magit-refs magit-status magit
magit-rep= os magit-apply magit-wip magit-log which-func imenu magit-diff
smerge-mo= de diff diff-mode git-commit log-edit message rmc puny dired
dired-loadd= efs rfc822 mml mml-sec epa derived epg epg-config gnus-util
rmail rmail-= loaddefs text-property-search mm-decode mm-bodies mm-encode
mail-parse r= fc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr
mailabbrev mail-uti= ls gmm-utils mailheader pcvs-util add-log magit-core
magit-autorevert au= torevert filenotify magit-margin magit-transient
magit-process with-edit= or shell pcomplete comint ring server ansi-color
magit-mode transient co= mp comp-cstr warnings rx format-spec magit-git
magit-section magit-utils= crm which-key advice disp-table whitespace
ws-butler goto-addr thingatp= t diminish time-date auto-package-update
dash cl-extra help-mode use-pac= kage use-package-ensure
use-package-delight use-package-diminish use-pac= kage-bind-key bind-key
easy-mmode use-package-core finder-inf info packa= ge easymenu browse-url
url url-proxy url-privacy url-expand url-methods = url-history url-cookie
url-domsuf url-util mailcap url-handlers url-pars= e auth-source cl-seq
eieio eieio-core cl-macs eieio-loaddefs password-ca= che json subr-x map
url-vars seq byte-opt gv bytecomp byte-compile cconv= cl-loaddefs cl-lib
iso-transl tooltip eldoc electric uniquify ediff-hoo= k vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd= tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace new= comment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar m= enu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-= lock
syntax facemenu font-core term/tty-colors frame minibuffer cl-gener= ic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet l= ao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czecheuropean ethiopic indian cyrillic chinese composite charscript charpropcase-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloa= ded nadvice button loaddefs faces cus-face pcase macroexp files
window t= ext-properties overlay sha1 md5 base64 format env code-pages
mule custom= widget hashtable-print-readable backquote threads dbusbind
inotify dyna= mic-setting system-font-setting font-render-setting cairo
move-toolbar g= tk x-toolkit x multi-tty make-network-process nativecomp
emacs)

M= emory information:
((conses 16 682782 115976)
=C2=A0(symbols 48 36240= 2)
=C2=A0(strings 32 156281 6872)
=C2=A0(string-bytes 1 5629612)
= =C2=A0(vectors 16 69564)
=C2=A0(vector-slots 8 1952275 168183)
=C2=A0= (floats 8 365 557)
=C2=A0(intervals 56 14064 6666)
=C2=A0(buffers 992= 22))
--000000000000cbfc7405bd34fb0e-- ------------=_1615482902-19169-1-- From unknown Sun Jun 22 00:22:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 Resent-From: Eyal Soha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Mar 2021 04:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 47060-done@debbugs.gnu.org, Eli Zaretskii Received: via spool by 47060-done@debbugs.gnu.org id=D47060.161552227431824 (code D ref 47060); Fri, 12 Mar 2021 04:12:02 +0000 Received: (at 47060-done) by debbugs.gnu.org; 12 Mar 2021 04:11:14 +0000 Received: from localhost ([127.0.0.1]:55780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKZ8s-0008HE-CZ for submit@debbugs.gnu.org; Thu, 11 Mar 2021 23:11:14 -0500 Received: from mail-lf1-f50.google.com ([209.85.167.50]:45727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKZ8q-0008H2-Mj for 47060-done@debbugs.gnu.org; Thu, 11 Mar 2021 23:11:13 -0500 Received: by mail-lf1-f50.google.com with SMTP id k9so43498438lfo.12 for <47060-done@debbugs.gnu.org>; Thu, 11 Mar 2021 20:11:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6cUZfXtreRfT5nsZ3z7pKu4jed4LHttSmJXH6HFbGEI=; b=oU9RnLcpEfeB5A8diOQqjuZd0y2HqUE9p4bzKJSKAT8eVVBHSXxUV4R8401lp2CTgn +7+I6Y2GC4d6Pj3i4S12HN3j0UATY4aLfoCf33HS8xVPZb0SuKZ+48SEV+YvvnZPHxhW v+oi+6aF/Zwm8qHBI3K68j19izlmQw0XO/wND4jr6DPjiQRWlE5Gq/G6XfcMlPzZDofz ejfMbr+wstsDbTFlAsSJpMUhbYJLu1Pj46CL6hOf75Rtu+HQnDSUQ+FN3R4KWG/22FNv qIuD8OfPvq7oWLoi1E9r3tI9TTXkTDWAD9sceQXaRgIK69zy77x51FHVVoJyQdD34axl 3mMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6cUZfXtreRfT5nsZ3z7pKu4jed4LHttSmJXH6HFbGEI=; b=icjaivWdN8zn7v3XHPBgchiFqFow6LN7jfGLh5O/iXNG05i34Tyjp5BBLaEcavICHe bkPGfY1nDgeQ0MABRXdj52O+EiQWrqT94dQQILVPQCwBRjz8wqms8oLg+z5KNc601ccb PxzDung2wromQdj8Ayam4Po31h11/NWQy0nQU/ckijiJRTW1tWtminvYAIBhkT+T2nYK UFBR6i9X0PWaS5osBmrVQdm+pR8nVcppc1uv6MhdlmR56eB7CDuPSkk/uu0K2YJFjzyg YO7HfaBjoA3H30lbFGnv6WTUu2UAbMz07wbpyhGudOurDK4VPv1t1uIiLB78biBwMyct acEA== X-Gm-Message-State: AOAM533DP7daHamA+TYi/PkzhJ3ZHo7PVTCrsfMr2dFeP3foG9k1dFco rl6ZCurH1sfcFdhQ4Z50wPBOwvFLG81Oxd0kHvM= X-Google-Smtp-Source: ABdhPJwLuUdDZSWapuOJVZg77N3QKh11E3GwcljI7phx7MfZU+OykfiNYF3qoZVTQVDnwMxQmlyFkDlnrW2nh9KxyPI= X-Received: by 2002:a05:6512:504:: with SMTP id o4mr4012553lfb.438.1615522266514; Thu, 11 Mar 2021 20:11:06 -0800 (PST) MIME-Version: 1.0 References: <83czw5n0rv.fsf@gnu.org> In-Reply-To: From: Eyal Soha Date: Thu, 11 Mar 2021 21:10:55 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I tested it using the same procedure as before on feature/native-comp branch and it works. Thanks! Eyal On Thu, Mar 11, 2021 at 10:14 AM Stefan Monnier wrote: > > >> The patch below should fix it. > >> I think this patch should go to `emacs-27`. Eli any objection? > > No, please go ahead, and thanks. > > Thanks, pushed, > > > Stefan > From unknown Sun Jun 22 00:22:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 Resent-From: Jimmy Yuen Ho Wong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Mar 2021 07:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 47060@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161553508220082 (code B ref -1); Fri, 12 Mar 2021 07:45:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Mar 2021 07:44:42 +0000 Received: from localhost ([127.0.0.1]:55919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKcTR-0005Dq-U7 for submit@debbugs.gnu.org; Fri, 12 Mar 2021 02:44:42 -0500 Received: from lists.gnu.org ([209.51.188.17]:53650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKcTQ-0005Di-6T for submit@debbugs.gnu.org; Fri, 12 Mar 2021 02:44:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKcTP-0007vW-VH for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 02:44:39 -0500 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]:39306) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKcTO-00029d-JC for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 02:44:39 -0500 Received: by mail-ej1-x636.google.com with SMTP id p7so40178637eju.6 for ; Thu, 11 Mar 2021 23:44:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=NnT8xGLJx+cKlLrytDFEp0Zx3e7FHdV+kDN4CyigyRY=; b=GMYVzyfQeg3IAPl+8po5AJ4vNsdaozSn0VSDZwVcQI/I2Ei5+1leycoiRKSTh7QHFT Ox1Em0e3KYH2kEX81wwUUGYzTBdi2FRwe7Xa2Zj+idBiJkJcki1KfrThwJWjQBfSki4+ CgnnImTCHnRiJ+vuEORZ2kDAjXRZocB0Ks1g1eJgVU5srghcTxIqz9f7q1cWCtlyl7kF AvXyPDuNb3an+qKHhjQjN4o8z7JnqVHIV8KQ7rQ0wUEjamH8v5w1/B+Egm+sEI6isJSJ ns9Z5WE5mls6oqk72rtPVfgk57ULi48t3x/kbaQp3rCBG6FWxrhHwJ/fNyqt1t6e7kko AC7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=NnT8xGLJx+cKlLrytDFEp0Zx3e7FHdV+kDN4CyigyRY=; b=Cl8rkyFCwocLvpuHKSrIe/DaLO0X7fjG5OSb23VRoTN1sHMVkyzNRKNBX67ZC0uFDy CkQ95qhdeG2atGqgeyRCX5hpnL0M9ZaiWQ1EIKB+smdBxpafNvXpm5NXWsk7iKexVmsv XIEH0cBGAKrvh3kQ4kjWMZ3Vh9aegp3t9vninZJ6pOPHkW+BYCXT40k78CVK0WUF9Yce InyN1FmSYASTx8/yl54q5Ls3u57uRTPhIG/vxF5U7iY2SbkRKFD66xxAq/rlkUT493Xx ErWGJBPCIH6k65x4NakGRtLVQR2Gj4ryqNd/aso7Rw6EueV47KwWB2ZUOMa/3s+vv8i9 +8GQ== X-Gm-Message-State: AOAM531TzZNViDaDkdU0CU9mYHRmDehVB+S9qe+h+Z0Ln8CVhgVmNFem OpeDjqwqB4fKCVsspGW26zZcs+tV7ow= X-Google-Smtp-Source: ABdhPJyBiqF6V7DZh7IArUIInM9/OK1PTZgFl7LMSXeO+fbWgcdMO/wSFQ6ssbmsebfCo2ABsheGxA== X-Received: by 2002:a17:906:e0d6:: with SMTP id gl22mr7093028ejb.444.1615535075977; Thu, 11 Mar 2021 23:44:35 -0800 (PST) Received: from MobileCat.local ([188.214.11.130]) by smtp.gmail.com with ESMTPSA id c20sm2383288eja.22.2021.03.11.23.44.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Mar 2021 23:44:35 -0800 (PST) References: <83czw5n0rv.fsf@gnu.org> From: Jimmy Yuen Ho Wong Message-ID: <1f6ddf77-57bb-f8c0-de5d-ff98df56bc58@gmail.com> Date: Fri, 12 Mar 2021 07:44:34 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=wyuenho@gmail.com; helo=mail-ej1-x636.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This patch now results in this error whenever I left click on the NS port. The mouse is now completely broken. Debugger entered--Lisp error: (error "Two bases given in one event") =?UTF-8?Q?=C2=A0?= event-convert-list((down click mouse-1)) =?UTF-8?Q?=C2=A0?= mouse--click-1-maybe-follows-link(nil) Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [188.214.11.130 listed in zen.spamhaus.org] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (wyuenho[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.51.188.17 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 NICE_REPLY_A Looks like a legit reply (A) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This patch now results in this error whenever I left click on the NS port. The mouse is now completely broken. Debugger entered--Lisp error: (error "Two bases given in one event") =?UTF-8?Q?=C2=A0?= event-convert-list((down click mouse-1)) =?UTF-8?Q?=C2=A0?= mouse--click-1-maybe-follows-link(nil) Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.51.188.17 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [188.214.11.130 listed in zen.spamhaus.org] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (wyuenho[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 NICE_REPLY_A Looks like a legit reply (A) This patch now results in this error whenever I left click on the NS port. The mouse is now completely broken. Debugger entered--Lisp error: (error "Two bases given in one event")   event-convert-list((down click mouse-1))   mouse--click-1-maybe-follows-link(nil) Jimmy On 12/03/2021 4:10 AM, Eyal Soha wrote: > I tested it using the same procedure as before on feature/native-comp > branch and it works. Thanks! > > Eyal > > > On Thu, Mar 11, 2021 at 10:14 AM Stefan Monnier > wrote: >>>> The patch below should fix it. >>>> I think this patch should go to `emacs-27`. Eli any objection? >>> No, please go ahead, and thanks. >> Thanks, pushed, >> >> >> Stefan >> > > From unknown Sun Jun 22 00:22:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Mar 2021 16:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jimmy Yuen Ho Wong Cc: 47060@debbugs.gnu.org, Stefan Monnier Received: via spool by 47060-submit@debbugs.gnu.org id=B47060.16155678391303 (code B ref 47060); Fri, 12 Mar 2021 16:51:02 +0000 Received: (at 47060) by debbugs.gnu.org; 12 Mar 2021 16:50:39 +0000 Received: from localhost ([127.0.0.1]:58236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKkzn-0000Kw-7C for submit@debbugs.gnu.org; Fri, 12 Mar 2021 11:50:39 -0500 Received: from quimby.gnus.org ([95.216.78.240]:60576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKkzl-0000Ki-5K for 47060@debbugs.gnu.org; Fri, 12 Mar 2021 11:50:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eceD9pDfViHvSACE2wURrHHQv2FQ3nUEZjpeVopQsFQ=; b=T5cOcUYNXqy4HF84akoCnlUi7u Wn5G+uPQ0+oeK8fcVHS0Gh3l89BWdzHMTuU9x39LiTEfp7w7aAJLjnCRU5sYd2r0qI3GHuUs//yAv 62GKs3OOuZl+bJkmb2tx8nx+TJjcEkIX8Ia6WwWX8MusgWQegK+fqyS1uiz5jHuRsMyo=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKkza-0007Ma-U3; Fri, 12 Mar 2021 17:50:29 +0100 From: Lars Ingebrigtsen References: <83czw5n0rv.fsf@gnu.org> <1f6ddf77-57bb-f8c0-de5d-ff98df56bc58@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEU7MjeVWmXe1cr/ //9HfuA7AAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UDDBAxKGjl6cEAAAFLSURBVCjPTZFBbsIwEEX/ WEmksjJSsiBHyClsqek6SDYL1kUqOUXgBHRB11RKKuJTdmzHgBfWPM/4j/0H4FVc/I467KvhBWr1 Ao0CGS6IAFQ2wREwunsA/cwGRQAH9PNBRWiGvJktdlFzoH5usY9Nod2cUwQg70fSHwvg8wtbSsCZ LsWoL0/IAVIJysxzggLZEmYw4pbAwtC0xNSiFFOq05BikktKE8SYlCmHuD3atCh+8VRY3RJU76jH cMrvq9iMeyjvQNZCzB7eFBtocQovaBU4xjkMQimybLX+jpOoGHK6RG3qWmyyboxftp08Bvd9xpbZ vVI9SxCDovnI1kusQVvF7sLxLGSwyd2Fc4MHRTyExjkvXknQ/to7LpUw/Pv+unJ8SYOHjkPLd/7Y M7/MTvuMiePxMC2ZcqO9GreHQlacQsas2fms2DL8A0kSVvj+DBcIAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIxLTAzLTEyVDE2OjQ5OjQwKzAwOjAwTYgCogAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0w My0xMlQxNjo0OTo0MCswMDowMDzVuh4AAAAASUVORK5CYII= X-Now-Playing: Joni Mitchell's _Dog Eat Dog_: "Dog Eat Dog" Date: Fri, 12 Mar 2021 17:50:25 +0100 In-Reply-To: <1f6ddf77-57bb-f8c0-de5d-ff98df56bc58@gmail.com> (Jimmy Yuen Ho Wong's message of "Fri, 12 Mar 2021 07:44:34 +0000") Message-ID: <87czw4uxim.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jimmy Yuen Ho Wong writes: > This patch now results in this error whenever I left click on the NS > port. The mouse is now completely broken. > > Debugger entered--Lisp error: (error "Two bases given in one event") > =?UTF-8?Q?=C2=A0?= event-c [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jimmy Yuen Ho Wong writes: > This patch now results in this error whenever I left click on the NS > port. The mouse is now completely broken. > > Debugger entered--Lisp error: (error "Two bases given in one event") > =C2=A0 event-convert-list((down click mouse-1)) > =C2=A0 mouse--click-1-maybe-follows-link(nil) You dropped Stefan M from the CCs, so he might not see your message. I've now added him back. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 00:22:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Mar 2021 17:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jimmy Yuen Ho Wong Cc: 47060@debbugs.gnu.org Received: via spool by 47060-submit@debbugs.gnu.org id=B47060.16155706156127 (code B ref 47060); Fri, 12 Mar 2021 17:37:02 +0000 Received: (at 47060) by debbugs.gnu.org; 12 Mar 2021 17:36:55 +0000 Received: from localhost ([127.0.0.1]:58270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKliZ-0001al-32 for submit@debbugs.gnu.org; Fri, 12 Mar 2021 12:36:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKliW-0001aX-Ns for 47060@debbugs.gnu.org; Fri, 12 Mar 2021 12:36:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58021) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKliR-0005i8-Fr; Fri, 12 Mar 2021 12:36:47 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1lKliP-0000bU-Tu; Fri, 12 Mar 2021 12:36:46 -0500 From: Glenn Morris References: <83czw5n0rv.fsf@gnu.org> <1f6ddf77-57bb-f8c0-de5d-ff98df56bc58@gmail.com> X-Spook: grom Recovery Croatian Exercise Blacklisted 411 X-Ran: O8w.0Je~M(Z=9o=0Od71k!@Rj7iVQc3J9vH*C4!}h X-Hue: white X-Attribution: GM Date: Fri, 12 Mar 2021 12:36:45 -0500 In-Reply-To: <1f6ddf77-57bb-f8c0-de5d-ff98df56bc58@gmail.com> (Jimmy Yuen Ho Wong's message of "Fri, 12 Mar 2021 07:44:34 +0000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Jimmy Yuen Ho Wong wrote: > This patch now results in this error whenever I left click on the NS > port. The mouse is now completely broken. > > Debugger entered--Lisp error: (error "Two bases given in one event") > =C2=A0 event-convert-list((down click mouse-1)) > =C2=A0 mouse--click-1-maybe-follows-link(nil) This was also flagged by the test suite. I wish people would at least run foo-tests.el before pushing foo.el changes (especially to the release branch). From unknown Sun Jun 22 00:22:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Mar 2021 17:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 47060@debbugs.gnu.org, Jimmy Yuen Ho Wong Received: via spool by 47060-submit@debbugs.gnu.org id=B47060.16155707346311 (code B ref 47060); Fri, 12 Mar 2021 17:39:02 +0000 Received: (at 47060) by debbugs.gnu.org; 12 Mar 2021 17:38:54 +0000 Received: from localhost ([127.0.0.1]:58278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKlkT-0001dj-SB for submit@debbugs.gnu.org; Fri, 12 Mar 2021 12:38:54 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKlkQ-0001dU-NF for 47060@debbugs.gnu.org; Fri, 12 Mar 2021 12:38:52 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B4CA0440CD1; Fri, 12 Mar 2021 12:38:44 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 69E7D440ADB; Fri, 12 Mar 2021 12:38:43 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1615570723; bh=1TJi28u+HxegkTVLb0NU4zcNuFEUGYzbtgcdzYiv4L8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=c4isWKUg/aPF2cABzU63Q/IFjV1JmS8+nQy1wDthlUKyo5MImt7S1go6F57pDEyIT BKH/mufTx4xE06ig4emA6zqv7tL0X3BgYjVkOVFpQE6sNawcEpBQZ6/3OLrBJnA9nR hnEwFDpwhbwtZi+WAMRhlxmImOWR9w0/23yu7pcvYv61X+FDgWrpkY1Vx7esYZMk+5 8lXrTJ4UpkLgu/oeGDBOfkED8rzCR/4xohjzW3bdvkE6QynHBTZWy3kKQWZW2HXV4B am21raca9JeY8hLjaatBSEZeq2xWFg4jqQD5Ihc8HGeZ4wUQlpR6xchoszDMcZusXL Zv1R4htp0ONVg== Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 43CC112024D; Fri, 12 Mar 2021 12:38:43 -0500 (EST) From: Stefan Monnier Message-ID: References: <83czw5n0rv.fsf@gnu.org> <1f6ddf77-57bb-f8c0-de5d-ff98df56bc58@gmail.com> <87czw4uxim.fsf@gnus.org> Date: Fri, 12 Mar 2021 12:38:42 -0500 In-Reply-To: <87czw4uxim.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 12 Mar 2021 17:50:25 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.354 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> This patch now results in this error whenever I left click on the NS >> port. The mouse is now completely broken. >> >> Debugger entered--Lisp error: (error "Two bases given in one event") >> =A0 event-convert-list((down click mouse-1)) >> =A0 mouse--click-1-maybe-follows-link(nil) > > You dropped Stefan M from the CCs, so he might not see your message. > I've now added him back. Oh, my! Indeed, I forgot that I tested that with my local Emacs which has included the patch below for some years. Hmm... Eli, what do you say, should I revert the patch on `emacs-27` (seeing how it's obviously not as safe as I thought), or should I add the patch below to `emacs-27`? The problem is that currently `event-convert-list` disagrees with `event-modifiers` about which set of symbols can be used as modifiers: `event-modifiers` will sometimes include `click` as a modifier, whereas `event-convert-list` doesn't accept it. Stefan diff --git a/src/keyboard.c b/src/keyboard.c index e3fc6adf81..512fa279b3 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -6679,6 +6679,7 @@ #define MULTI_LETTER_MOD(BIT, NAME, LEN) \ case 'c': MULTI_LETTER_MOD (ctrl_modifier, "ctrl", 4); MULTI_LETTER_MOD (ctrl_modifier, "control", 7); + MULTI_LETTER_MOD (click_modifier, "click", 5); break; =20 case 'H': From unknown Sun Jun 22 00:22:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Mar 2021 19:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 47060@debbugs.gnu.org, larsi@gnus.org, wyuenho@gmail.com Received: via spool by 47060-submit@debbugs.gnu.org id=B47060.161557735824665 (code B ref 47060); Fri, 12 Mar 2021 19:30:02 +0000 Received: (at 47060) by debbugs.gnu.org; 12 Mar 2021 19:29:18 +0000 Received: from localhost ([127.0.0.1]:58423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKnTJ-0006Pl-Tw for submit@debbugs.gnu.org; Fri, 12 Mar 2021 14:29:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKnTI-0006PX-2g for 47060@debbugs.gnu.org; Fri, 12 Mar 2021 14:29:16 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33544) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKnTC-0006kV-Lh; Fri, 12 Mar 2021 14:29:10 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1737 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lKnT9-0001NF-CF; Fri, 12 Mar 2021 14:29:08 -0500 Date: Fri, 12 Mar 2021 21:29:12 +0200 Message-Id: <83r1kkjhmf.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Monnier on Fri, 12 Mar 2021 12:38:42 -0500) References: <83czw5n0rv.fsf@gnu.org> <1f6ddf77-57bb-f8c0-de5d-ff98df56bc58@gmail.com> <87czw4uxim.fsf@gnus.org> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Stefan Monnier > Date: Fri, 12 Mar 2021 12:38:42 -0500 > Cc: 47060@debbugs.gnu.org, Jimmy Yuen Ho Wong > > Oh, my! Indeed, I forgot that I tested that with my local Emacs which > has included the patch below for some years. > > Hmm... Eli, what do you say, should I revert the patch on `emacs-27` > (seeing how it's obviously not as safe as I thought), or should I add > the patch below to `emacs-27`? > > The problem is that currently `event-convert-list` disagrees with > `event-modifiers` about which set of symbols can be used as modifiers: > `event-modifiers` will sometimes include `click` as a modifier, whereas > `event-convert-list` doesn't accept it. Too bad. I think we must revert the change you made. From unknown Sun Jun 22 00:22:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47060: mouse-1-click-follows-link double broken by 3d5e31eceb9dc1fb62b2b27bcab549df3bd04ce9 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Mar 2021 19:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47060 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 47060@debbugs.gnu.org, larsi@gnus.org, wyuenho@gmail.com Received: via spool by 47060-submit@debbugs.gnu.org id=B47060.161557742326237 (code B ref 47060); Fri, 12 Mar 2021 19:31:02 +0000 Received: (at 47060) by debbugs.gnu.org; 12 Mar 2021 19:30:23 +0000 Received: from localhost ([127.0.0.1]:58429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKnUN-0006op-7k for submit@debbugs.gnu.org; Fri, 12 Mar 2021 14:30:23 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKnUK-0006gl-VJ for 47060@debbugs.gnu.org; Fri, 12 Mar 2021 14:30:21 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 29FEF80712; Fri, 12 Mar 2021 14:30:15 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 89C1380D35; Fri, 12 Mar 2021 14:30:13 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1615577413; bh=OYr51NNlk5giJQG2ujCT9E0uHXCQR+gPxlEXc74xZWs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=dzDTvPbgWPvjmNz+wl5wPBThd/K2UZVwKMGWNyoWVaH7kLjKumEKC26UoyPVO4hNT jVBpg7ktD1X8sRoFs9bgC6lsQ8AcQRwxTCBEXeclR8BclaEcCaiEVqDF5hwR5BS1ae 5sHVRb+cQ8oC+zOM1cR6OGRQk8WExb/Qr8+GvHSq13wkuP6Q7ZfpUZEySVxTdJi1Mm mtds838qjl3VHHKWp5kU8WIIvhYxSh0/GoZ8atqUU/RumZ8MdIin+uYvXkvDyah10K 9rrW/kM7V2OGmX909JksdHUf7I2PNw51zY+hQHBlscN7gfMdxVVwtz+tvDOrvA3d2r BNoEfxVDnmLfA== Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 591B61202A8; Fri, 12 Mar 2021 14:30:13 -0500 (EST) From: Stefan Monnier Message-ID: References: <83czw5n0rv.fsf@gnu.org> <1f6ddf77-57bb-f8c0-de5d-ff98df56bc58@gmail.com> <87czw4uxim.fsf@gnus.org> <83r1kkjhmf.fsf@gnu.org> Date: Fri, 12 Mar 2021 14:30:11 -0500 In-Reply-To: <83r1kkjhmf.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Mar 2021 21:29:12 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.346 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Too bad. I think we must revert the change you made. OK, Stefan