GNU bug report logs - #47042
gnu: qtsolutions: Enable examples.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47042 in the body.
You can then email your comments to 47042 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: guix-patches <at> gnu.org
Cc: Leo Prikler <leo.prikler <at> student.tugraz.at>
Subject: gnu: qtsolutions: Enable examples.
Date: Wed, 10 Mar 2021 06:09:35 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

Currently with this patch, we have following issues:

[1] When examples are enabled for QtSingleApplication, it doesn't get 
linked to QtLockFile. (Try building without `;; Disable building of 
examples for QtSingleApplication.` block)

[2] For installation of examples, the binaries get installed in sub-dirs 
as `/bin/foo` instead of `/bin`.

Any ideas?

Regards,
RG.

[0001-gnu-qtsolutions-Enable-examples.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #8 received at 47042 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 47042 <at> debbugs.gnu.org
Subject: Re: gnu: qtsolutions: Enable examples.
Date: Wed, 10 Mar 2021 13:58:35 +0100

Am Mittwoch, den 10.03.2021, 06:09 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> Currently with this patch, we have following issues:
> 
> [1] When examples are enabled for QtSingleApplication, it doesn't
> get 
> linked to QtLockFile. (Try building without `;; Disable building of 
> examples for QtSingleApplication.` block)
Then I guess we have to rewrite that Makefile (or pseudo-Makefile) in
the snippet as well? 

> [2] For installation of examples, the binaries get installed in sub-
> dirs 
> as `/bin/foo` instead of `/bin`.
I don't think the compiled examples need to be installed at all –
rather their source code etc. should be installed to share/doc (in a
qtsolutions subfolder of course).  The act of compiling them is merely
a check, that they (plus the code they are an example of) "work as
intended" or at least compile as intended.

If I read your patch correctly, I made an indentation mistake during
the review process, is that correct?

Regards,
Leo

Message #11 received at 47042 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 47042 <at> debbugs.gnu.org
Subject: Re: gnu: qtsolutions: Enable examples.
Date: Wed, 10 Mar 2021 09:49:23 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> Then I guess we have to rewrite that Makefile (or pseudo-Makefile) in
> the snippet as well?
> 
> I don't think the compiled examples need to be installed at all –
> rather their source code etc. should be installed to share/doc (in a
> qtsolutions subfolder of course).  The act of compiling them is merely
> a check, that they (plus the code they are an example of) "work as
> intended" or at least compile as intended.

Never mind this patch then. I started working on this, thinking that 
example binaries might be useful. So I'll close this report.

Regards,
RG.

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #16 received at 47042 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 47042 <at> debbugs.gnu.org
Subject: Re: gnu: qtsolutions: Enable examples.
Date: Wed, 10 Mar 2021 10:00:55 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

>> Then I guess we have to rewrite that Makefile (or pseudo-Makefile) in
>> the snippet as well?
>>
>> I don't think the compiled examples need to be installed at all –
>> rather their source code etc. should be installed to share/doc (in a
>> qtsolutions subfolder of course).  The act of compiling them is merely
>> a check, that they (plus the code they are an example of) "work as
>> intended" or at least compile as intended.
> 
> Never mind this patch then. I started working on this, thinking that 
> example binaries might be useful. So I'll close this report.

FWIW, can you merge the attached patch please? It enables building of 
examples, except for qtsingleapplication.

Regards,
RG.

[0001-gnu-qtsolutions-Enable-building-of-examples-except-f.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #19 received at 47042 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Raghav Gururajan <rg <at> raghavgururajan.name>, 47042 <at> debbugs.gnu.org
Subject: Re: gnu: qtsolutions: Enable examples.
Date: Wed, 10 Mar 2021 16:15:13 +0100

Am Mittwoch, den 10.03.2021, 10:00 -0500 schrieb Raghav Gururajan:
> Hi Leo!
> 
> > > Then I guess we have to rewrite that Makefile (or pseudo-
> > > Makefile) in
> > > the snippet as well?
> > > 
> > > I don't think the compiled examples need to be installed at all –
> > > rather their source code etc. should be installed to share/doc
> > > (in a
> > > qtsolutions subfolder of course).  The act of compiling them is
> > > merely
> > > a check, that they (plus the code they are an example of) "work
> > > as
> > > intended" or at least compile as intended.
> > 
> > Never mind this patch then. I started working on this, thinking
> > that 
> > example binaries might be useful. So I'll close this report.
> 
> FWIW, can you merge the attached patch please? It enables building
> of 
> examples, except for qtsingleapplication.
I don't think the problem with disabling examples is bad enough to
warrant this kind of "hot fix".  I'd rather patch in all examples at
once if that's possible.

Regards,
Leo

Message #22 received at 47042 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 47042 <at> debbugs.gnu.org
Subject: Re: gnu: qtsolutions: Enable examples.
Date: Wed, 10 Mar 2021 10:28:27 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

> I don't think the problem with disabling examples is bad enough to
> warrant this kind of "hot fix".  I'd rather patch in all examples at
> once if that's possible.

Cool!

Regards,
RG.

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.