GNU bug report logs - #47026
28.0.50; Allow Gnus summary faces to extend to end of line

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47026 in the body.
You can then email your comments to 47026 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Allow Gnus summary faces to extend to end of line
Date: Tue, 09 Mar 2021 19:51:10 +0100

[Message part 1 (text/plain, inline)]

Hello,

Some themes add a background to the faces Gnus uses to highlight summary
lines (e.g. gnus-summary-selected, gnus-summary-cancelled); I'd like to
be able to extend that background beyond EOL.

Right now Gnus only applies these faces right up to the char *before*
EOL; if it were to apply them one char further, users could then set (or
unset) the :extend property on these faces.

I'm attaching a patch only for demonstration purposes; I do not know
whether it should be applied as-is.  It does Work For Me®, but:

(1) Maybe we want to be as flexible as Org, i.e. let users control this
behaviour with a user option instead of messing with faces.
(Cf. org-fontify-whole-heading-line in org-set-font-lock-defaults)

(2) I haven't looked at the whole beg/end vs. from/to vs. mouse-face
affair in gnus-highlight-selected-summary, so my patch may fail to DTRT
in some circumstances… ?


Thank you for your time.

[Message part 2 (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.25, cairo version 1.16.0)
 of 2021-03-06 built on my-little-tumbleweed
Repository revision: 6c498786fed219ee8f98092f7921b5a5b1aaca29
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12010000
System Description: openSUSE Tumbleweed

Configured using:
 'configure --with-xwidgets --with-cairo'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY
PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM
XWIDGETS GTK3 ZLIB

Important settings:
  value of $LC_CTYPE: en_US.UTF-8
  value of $LC_TIME: en_GB.UTF-8
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=local
  locale-coding-system: utf-8-unix

Message #8 received at 47026 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
Cc: 47026 <at> debbugs.gnu.org
Subject: Re: bug#47026: 28.0.50; Allow Gnus summary faces to extend to end
 of line
Date: Wed, 10 Mar 2021 16:15:52 +0100

Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:

> Right now Gnus only applies these faces right up to the char *before*
> EOL; if it were to apply them one char further, users could then set (or
> unset) the :extend property on these faces.
>
> I'm attaching a patch only for demonstration purposes; I do not know
> whether it should be applied as-is.  It does Work For Me®, but:

Makes sense to me, so I've applied it to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 47026 <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 47026 <at> debbugs.gnu.org
Subject: Re: 28.0.50; Allow Gnus summary faces to extend to end of line
Date: Fri, 12 Mar 2021 19:13:12 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:
>
>> Right now Gnus only applies these faces right up to the char *before*
>> EOL; if it were to apply them one char further, users could then set (or
>> unset) the :extend property on these faces.
>>
>> I'm attaching a patch only for demonstration purposes; I do not know
>> whether it should be applied as-is.  It does Work For Me®, but:
>
> Makes sense to me, so I've applied it to Emacs 28.

Thanks (publicly this time) for the prompt reply!

Thinking about it some more, I wonder whether the summary faces
(e.g. gnus-summary-selected, gnus-summary-selected) should be defined
with :extend t?

It's not a decision to make lightly of course, since :extend is special
in that themes inherit the value from the original definition.  I do
think it makes sense though; for gnus-summary-selected at least, I find
that it makes it easier to keep track of the currently selected article.

Obligatory "everybody else does it this way®" lightning round:

KMail
https://commons.wikimedia.org/wiki/File:Kmail-screenshot.png

Thunderbird
https://commons.wikimedia.org/wiki/File:Thunderbird_screenshot_2.png
https://screenshots.debian.net/package/thunderbird#gallery-2

aerc
https://yukari.sr.ht/aerc-intro.webm (t=35s)

Zimbra
https://www.zimbra.com/wp-content/uploads/2015/12/screenshot_messaging_and_collaboration.png

Message #18 received at 47026 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
Cc: 47026 <at> debbugs.gnu.org
Subject: Re: 28.0.50; Allow Gnus summary faces to extend to end of line
Date: Tue, 16 Mar 2021 01:25:18 +0100

Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:

> Thinking about it some more, I wonder whether the summary faces
> (e.g. gnus-summary-selected, gnus-summary-selected) should be defined
> with :extend t?
>
> It's not a decision to make lightly of course, since :extend is special
> in that themes inherit the value from the original definition.  I do
> think it makes sense though; for gnus-summary-selected at least, I find
> that it makes it easier to keep track of the currently selected article.

I think that makes sense -- I mean, that's how Gnus displayed these
things before Emacs was changed (incompatibly) in how faces on newline
characters is displayed.

That is, I think adding :extend t to most Gnus summary faces just brings
us back to how it was designed to be displayed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #21 received at 47026 <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 47026 <at> debbugs.gnu.org
Subject: Re: 28.0.50; Allow Gnus summary faces to extend to end of line
Date: Tue, 16 Mar 2021 19:15:32 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:
>
>> Thinking about it some more, I wonder whether the summary faces
>> (e.g. gnus-summary-selected, gnus-summary-selected) should be defined
>> with :extend t?
>>
>> It's not a decision to make lightly of course, since :extend is special
>> in that themes inherit the value from the original definition.  I do
>> think it makes sense though; for gnus-summary-selected at least, I find
>> that it makes it easier to keep track of the currently selected article.
>
> I think that makes sense -- I mean, that's how Gnus displayed these
> things before Emacs was changed (incompatibly) in how faces on newline
> characters is displayed.
>
> That is, I think adding :extend t to most Gnus summary faces just brings
> us back to how it was designed to be displayed.

Mmm, unless I'm missing something, before my patch, the face was not
applied to the final newline, so even with :extend t the rest of the
line was not highlighted.

To double-check, I just fired up 26.3, removed %( and %) from
gnus-summary-line-format, added a background to gnus-summary-selected,
and opened a summary buffer: sure enough, the background stopped at the
last character, without extending to the window edge.

(Sorry if I'm misunderstanding your point)

Regardless, if we agree that :extend t makes sense, I'll cook up a patch
sometime next week if nobody beats me to it (a bit swamped at the
moment).

Thank you for your time.

Message #24 received at 47026 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
Cc: 47026 <at> debbugs.gnu.org
Subject: Re: 28.0.50; Allow Gnus summary faces to extend to end of line
Date: Wed, 17 Mar 2021 00:15:42 +0100

Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:

>> That is, I think adding :extend t to most Gnus summary faces just brings
>> us back to how it was designed to be displayed.
>
> Mmm, unless I'm missing something, before my patch, the face was not
> applied to the final newline, so even with :extend t the rest of the
> line was not highlighted.
>
> To double-check, I just fired up 26.3, removed %( and %) from
> gnus-summary-line-format, added a background to gnus-summary-selected,
> and opened a summary buffer: sure enough, the background stopped at the
> last character, without extending to the window edge.

I didn't mean `gnus-summary-selected' here, but other Gnus summary
faces, like `gnus-summary-normal-ticked'.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.