From unknown Tue Sep 09 19:17:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47025: 28.0.50; [feature/native-comp] pcase is preloaded, but not eln-compiled Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Mar 2021 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47025 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 47025@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161531279028517 (code B ref -1); Tue, 09 Mar 2021 18:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 9 Mar 2021 17:59:50 +0000 Received: from localhost ([127.0.0.1]:47887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJge6-0007Pt-HN for submit@debbugs.gnu.org; Tue, 09 Mar 2021 12:59:50 -0500 Received: from lists.gnu.org ([209.51.188.17]:60266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJge2-0007Pi-BW for submit@debbugs.gnu.org; Tue, 09 Mar 2021 12:59:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJge0-0005Te-Nw for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 12:59:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42663) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJge0-0000jr-Gq for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 12:59:44 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2213 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lJgdx-0000Lw-7t for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 12:59:43 -0500 Date: Tue, 09 Mar 2021 19:59:37 +0200 Message-Id: <83r1kop5rq.fsf@gnu.org> From: Eli Zaretskii X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I've noticed that the native-comp branch preloads pcase: Loading files (native compiled elisp)... Loading emacs-lisp/macroexp (native compiled elisp)... Loading emacs-lisp/pcase... Loading emacs-lisp/macroexp (native compiled elisp)... whereas on master this doesn't happen. Why is that? Do we really need to preload pcase? If that's unavoidable, it should be added to shortlisp, so that we eln-compile it. In GNU Emacs 28.0.50 (build 1076, i686-pc-mingw32) of 2021-03-09 built on HOME-C4E4A596F7 Repository revision: 40d8f83e53ba64355035da78967c994d09a7802d Repository branch: master Windowing system distributor 'Microsoft Corp.', version 5.1.2600 System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600) Configured using: 'configure -C --prefix=/d/usr --with-wide-int --with-modules --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3'' Configured features: ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XPM ZLIB Important settings: value of $LANG: ENU locale-coding-system: cp1255 Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 56671 11176) (symbols 48 7803 1) (strings 16 21563 1999) (string-bytes 1 626919) (vectors 16 13076) (vector-slots 8 172294 12605) (floats 8 23 106) (intervals 40 263 114) (buffers 888 10)) From unknown Tue Sep 09 19:17:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47025: 28.0.50; [feature/native-comp] pcase is preloaded, but not eln-compiled Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Mar 2021 20:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47025 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 47025@debbugs.gnu.org Received: via spool by 47025-submit@debbugs.gnu.org id=B47025.161532128525403 (code B ref 47025); Tue, 09 Mar 2021 20:22:02 +0000 Received: (at 47025) by debbugs.gnu.org; 9 Mar 2021 20:21:25 +0000 Received: from localhost ([127.0.0.1]:48031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJir7-0006bf-HC for submit@debbugs.gnu.org; Tue, 09 Mar 2021 15:21:25 -0500 Received: from mx.sdf.org ([205.166.94.24]:60443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJir4-0006bW-OO for 47025@debbugs.gnu.org; Tue, 09 Mar 2021 15:21:24 -0500 Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 129KLL3e016938 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 9 Mar 2021 20:21:21 GMT From: Andrea Corallo References: <83r1kop5rq.fsf@gnu.org> Date: Tue, 09 Mar 2021 20:21:21 +0000 In-Reply-To: <83r1kop5rq.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Mar 2021 19:59:37 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I've noticed that the native-comp branch preloads pcase: > > Loading files (native compiled elisp)... > Loading emacs-lisp/macroexp (native compiled elisp)... > Loading emacs-lisp/pcase... > Loading emacs-lisp/macroexp (native compiled elisp)... > > whereas on master this doesn't happen. Why is that? Mmhh, I think is because of this from loadup.el: ==== (load "emacs-lisp/macroexp") (if (byte-code-function-p (symbol-function 'macroexpand-all)) nil ;; Since loaddefs is not yet loaded, macroexp's uses of pcase will simply ;; fail until pcase is explicitly loaded. This also means that we have to ;; disable eager macro-expansion while loading pcase. (let ((macroexp--pending-eager-loads '(skip))) (load "emacs-lisp/pcase")) ;; Re-load macroexp so as to eagerly macro-expand its uses of pcase. (let ((max-lisp-eval-depth (* 2 max-lisp-eval-depth))) (load "emacs-lisp/macroexp"))) ==== > need to preload pcase? I fear I don't have an answer as ATM I don't uderstand why it should be different compared to master. Andrea From unknown Tue Sep 09 19:17:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47025: 28.0.50; [feature/native-comp] pcase is preloaded, but not eln-compiled Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Mar 2021 13:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47025 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andrea Corallo , Stefan Monnier Cc: 47025@debbugs.gnu.org Received: via spool by 47025-submit@debbugs.gnu.org id=B47025.161538181616661 (code B ref 47025); Wed, 10 Mar 2021 13:11:01 +0000 Received: (at 47025) by debbugs.gnu.org; 10 Mar 2021 13:10:16 +0000 Received: from localhost ([127.0.0.1]:49123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJybQ-0004Kf-Gx for submit@debbugs.gnu.org; Wed, 10 Mar 2021 08:10:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJybP-0004KP-Gv for 47025@debbugs.gnu.org; Wed, 10 Mar 2021 08:10:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60718) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJybJ-0005Ax-Sf; Wed, 10 Mar 2021 08:10:09 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1535 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lJybF-0000bn-Kb; Wed, 10 Mar 2021 08:10:09 -0500 Date: Wed, 10 Mar 2021 15:10:02 +0200 Message-Id: <838s6vp32t.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Andrea Corallo on Tue, 09 Mar 2021 20:21:21 +0000) References: <83r1kop5rq.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Andrea Corallo > Cc: 47025@debbugs.gnu.org > Date: Tue, 09 Mar 2021 20:21:21 +0000 > > Eli Zaretskii writes: > > > I've noticed that the native-comp branch preloads pcase: > > > > Loading files (native compiled elisp)... > > Loading emacs-lisp/macroexp (native compiled elisp)... > > Loading emacs-lisp/pcase... > > Loading emacs-lisp/macroexp (native compiled elisp)... > > > > whereas on master this doesn't happen. Why is that? > > Mmhh, I think is because of this from loadup.el: > > ==== > (load "emacs-lisp/macroexp") > (if (byte-code-function-p (symbol-function 'macroexpand-all)) > nil > ;; Since loaddefs is not yet loaded, macroexp's uses of pcase will simply > ;; fail until pcase is explicitly loaded. This also means that we have to > ;; disable eager macro-expansion while loading pcase. > (let ((macroexp--pending-eager-loads '(skip))) (load "emacs-lisp/pcase")) > ;; Re-load macroexp so as to eagerly macro-expand its uses of pcase. > (let ((max-lisp-eval-depth (* 2 max-lisp-eval-depth))) > (load "emacs-lisp/macroexp"))) > ==== > > > need to preload pcase? > > I fear I don't have an answer as ATM I don't uderstand why it should be > different compared to master. Stefan, any ideas why this happens on the native-comp branch but not on master? From unknown Tue Sep 09 19:17:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47025: 28.0.50; [feature/native-comp] pcase is preloaded, but not eln-compiled Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Mar 2021 14:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47025 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 47025@debbugs.gnu.org, Andrea Corallo Received: via spool by 47025-submit@debbugs.gnu.org id=B47025.161538496522338 (code B ref 47025); Wed, 10 Mar 2021 14:03:01 +0000 Received: (at 47025) by debbugs.gnu.org; 10 Mar 2021 14:02:45 +0000 Received: from localhost ([127.0.0.1]:49261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJzQC-0005oE-OD for submit@debbugs.gnu.org; Wed, 10 Mar 2021 09:02:44 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61347) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJzQA-0005o0-Sl for 47025@debbugs.gnu.org; Wed, 10 Mar 2021 09:02:43 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6A105440BBF; Wed, 10 Mar 2021 09:02:37 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1AF32440B38; Wed, 10 Mar 2021 09:02:36 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1615384956; bh=UIXwt0KDcOFogo1aDsTB0RHCAya8nCRLiMCkJWl90U4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RTghNZkBIXkUsiNAYWCGt9Am33w0K1LokgaBENF+swS+mX123nDhIQo5shvdBFROC anGBslf8bX6fC30DPAYJ63sfJr7vr6bISHU9t9nV0FTzILS64dN7Tl2T7cHr3lVqUL 7GZP71+yHfvGdjdhlu5zDJfZ64lTOETKZBpy4+6VXv6Vq8KIFWlNjDQBAaR4SZ2ZPv 1sKXwQ6ja+2ylZImNsI7FX7IB1HV9Qfnav0V76VrHU3W5pXJ3+W/SmuRwONmJTXfIu KjV9UjLFxZVU5zFa3uMkyES7HIH2cCUF70s+F+IEUfR6s7bcFpklzLxwucmUQszJ8G bAJAfQ6JunoBg== Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D5101120470; Wed, 10 Mar 2021 09:02:35 -0500 (EST) From: Stefan Monnier Message-ID: References: <83r1kop5rq.fsf@gnu.org> <838s6vp32t.fsf@gnu.org> Date: Wed, 10 Mar 2021 09:02:35 -0500 In-Reply-To: <838s6vp32t.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 10 Mar 2021 15:10:02 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.104 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> (load "emacs-lisp/macroexp") >> (if (byte-code-function-p (symbol-function 'macroexpand-all)) >> nil >> ;; Since loaddefs is not yet loaded, macroexp's uses of pcase will simply >> ;; fail until pcase is explicitly loaded. This also means that we have to >> ;; disable eager macro-expansion while loading pcase. >> (let ((macroexp--pending-eager-loads '(skip))) (load "emacs-lisp/pcase")) >> ;; Re-load macroexp so as to eagerly macro-expand its uses of pcase. >> (let ((max-lisp-eval-depth (* 2 max-lisp-eval-depth))) >> (load "emacs-lisp/macroexp"))) >> ==== >> >> > need to preload pcase? >> >> I fear I don't have an answer as ATM I don't uderstand why it should be >> different compared to master. > > Stefan, any ideas why this happens on the native-comp branch but not > on master? It's probably the `byte-code-function-p` which tries to distinguish the case where macroexp has not yet been compiled, but on the native branch, I suspect that (byte-code-function-p (symbol-function 'macroexpand-all)) will return nil when macroexp has been compiled because it's now a `subrp`. So we could replace (byte-code-function-p (symbol-function 'macroexpand-all)) with (or (byte-code-function-p (symbol-function 'macroexpand-all)) (subrp (symbol-function 'macroexpand-all))) or with (not (consp (symbol-function 'macroexpand-all))) -- Stefan From unknown Tue Sep 09 19:17:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#47025: 28.0.50; [feature/native-comp] pcase is preloaded, but not eln-compiled Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Mar 2021 15:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47025 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 47025@debbugs.gnu.org, Eli Zaretskii Received: via spool by 47025-submit@debbugs.gnu.org id=B47025.161538976824274 (code B ref 47025); Wed, 10 Mar 2021 15:23:02 +0000 Received: (at 47025) by debbugs.gnu.org; 10 Mar 2021 15:22:48 +0000 Received: from localhost ([127.0.0.1]:51614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK0ff-0006JS-TT for submit@debbugs.gnu.org; Wed, 10 Mar 2021 10:22:48 -0500 Received: from mx.sdf.org ([205.166.94.24]:55914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK0fe-0006JK-1q for 47025@debbugs.gnu.org; Wed, 10 Mar 2021 10:22:46 -0500 Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 12AFMjXc025602 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Wed, 10 Mar 2021 15:22:45 GMT From: Andrea Corallo References: <83r1kop5rq.fsf@gnu.org> <838s6vp32t.fsf@gnu.org> Date: Wed, 10 Mar 2021 15:22:45 +0000 In-Reply-To: (Stefan Monnier's message of "Wed, 10 Mar 2021 09:02:35 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >>> (load "emacs-lisp/macroexp") >>> (if (byte-code-function-p (symbol-function 'macroexpand-all)) >>> nil >>> ;; Since loaddefs is not yet loaded, macroexp's uses of pcase will simply >>> ;; fail until pcase is explicitly loaded. This also means that we have to >>> ;; disable eager macro-expansion while loading pcase. >>> (let ((macroexp--pending-eager-loads '(skip))) (load "emacs-lisp/pcase")) >>> ;; Re-load macroexp so as to eagerly macro-expand its uses of pcase. >>> (let ((max-lisp-eval-depth (* 2 max-lisp-eval-depth))) >>> (load "emacs-lisp/macroexp"))) >>> ==== >>> >>> > need to preload pcase? >>> >>> I fear I don't have an answer as ATM I don't uderstand why it should be >>> different compared to master. >> >> Stefan, any ideas why this happens on the native-comp branch but not >> on master? > > It's probably the `byte-code-function-p` which tries to distinguish the > case where macroexp has not yet been compiled, but on the native branch, > I suspect that (byte-code-function-p (symbol-function 'macroexpand-all)) > will return nil when macroexp has been compiled because it's now > a `subrp`. Ops should have spotted that :/ thanks for the suggestion. 711b2c8349 fix this for me. Eli let me know if we are okay to close. Thanks Andrea From unknown Tue Sep 09 19:17:28 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Eli Zaretskii Subject: bug#47025: closed (Re: bug#47025: 28.0.50; [feature/native-comp] pcase is preloaded, but not eln-compiled) Message-ID: References: <83sg53ng1n.fsf@gnu.org> <83r1kop5rq.fsf@gnu.org> X-Gnu-PR-Message: they-closed 47025 X-Gnu-PR-Package: emacs Reply-To: 47025@debbugs.gnu.org Date: Wed, 10 Mar 2021 16:14:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1615392842-4810-1" This is a multi-part message in MIME format... ------------=_1615392842-4810-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #47025: 28.0.50; [feature/native-comp] pcase is preloaded, but not eln-comp= iled which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 47025@debbugs.gnu.org. --=20 47025: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D47025 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1615392842-4810-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 47025-done) by debbugs.gnu.org; 10 Mar 2021 16:13:09 +0000 Received: from localhost ([127.0.0.1]:51670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK1SO-0001EI-Ve for submit@debbugs.gnu.org; Wed, 10 Mar 2021 11:13:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK1SK-0001Dk-EY for 47025-done@debbugs.gnu.org; Wed, 10 Mar 2021 11:13:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36764) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lK1SE-0007sZ-AL; Wed, 10 Mar 2021 11:12:58 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1316 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lK1SB-0000yp-Mz; Wed, 10 Mar 2021 11:12:56 -0500 Date: Wed, 10 Mar 2021 18:12:52 +0200 Message-Id: <83sg53ng1n.fsf@gnu.org> From: Eli Zaretskii To: Andrea Corallo In-Reply-To: (message from Andrea Corallo on Wed, 10 Mar 2021 15:22:45 +0000) Subject: Re: bug#47025: 28.0.50; [feature/native-comp] pcase is preloaded, but not eln-compiled References: <83r1kop5rq.fsf@gnu.org> <838s6vp32t.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 47025-done Cc: 47025-done@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Andrea Corallo > Cc: Eli Zaretskii , 47025@debbugs.gnu.org > Date: Wed, 10 Mar 2021 15:22:45 +0000 > > > It's probably the `byte-code-function-p` which tries to distinguish the > > case where macroexp has not yet been compiled, but on the native branch, > > I suspect that (byte-code-function-p (symbol-function 'macroexpand-all)) > > will return nil when macroexp has been compiled because it's now > > a `subrp`. > > Ops should have spotted that :/ thanks for the suggestion. > > 711b2c8349 fix this for me. > > Eli let me know if we are okay to close. This is fixed, closing. Thanks. ------------=_1615392842-4810-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 9 Mar 2021 17:59:50 +0000 Received: from localhost ([127.0.0.1]:47887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJge6-0007Pt-HN for submit@debbugs.gnu.org; Tue, 09 Mar 2021 12:59:50 -0500 Received: from lists.gnu.org ([209.51.188.17]:60266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJge2-0007Pi-BW for submit@debbugs.gnu.org; Tue, 09 Mar 2021 12:59:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJge0-0005Te-Nw for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 12:59:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42663) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJge0-0000jr-Gq for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 12:59:44 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2213 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lJgdx-0000Lw-7t for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 12:59:43 -0500 Date: Tue, 09 Mar 2021 19:59:37 +0200 Message-Id: <83r1kop5rq.fsf@gnu.org> From: Eli Zaretskii To: bug-gnu-emacs@gnu.org Subject: 28.0.50; [feature/native-comp] pcase is preloaded, but not eln-compiled X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I've noticed that the native-comp branch preloads pcase: Loading files (native compiled elisp)... Loading emacs-lisp/macroexp (native compiled elisp)... Loading emacs-lisp/pcase... Loading emacs-lisp/macroexp (native compiled elisp)... whereas on master this doesn't happen. Why is that? Do we really need to preload pcase? If that's unavoidable, it should be added to shortlisp, so that we eln-compile it. In GNU Emacs 28.0.50 (build 1076, i686-pc-mingw32) of 2021-03-09 built on HOME-C4E4A596F7 Repository revision: 40d8f83e53ba64355035da78967c994d09a7802d Repository branch: master Windowing system distributor 'Microsoft Corp.', version 5.1.2600 System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600) Configured using: 'configure -C --prefix=/d/usr --with-wide-int --with-modules --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3'' Configured features: ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XPM ZLIB Important settings: value of $LANG: ENU locale-coding-system: cp1255 Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 56671 11176) (symbols 48 7803 1) (strings 16 21563 1999) (string-bytes 1 626919) (vectors 16 13076) (vector-slots 8 172294 12605) (floats 8 23 106) (intervals 40 263 114) (buffers 888 10)) ------------=_1615392842-4810-1--