From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 07 18:07:40 2021 Received: (at submit) by debbugs.gnu.org; 7 Mar 2021 23:07:40 +0000 Received: from localhost ([127.0.0.1]:41730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJ2Uu-0003Tf-0K for submit@debbugs.gnu.org; Sun, 07 Mar 2021 18:07:40 -0500 Received: from lists.gnu.org ([209.51.188.17]:34100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJ2Up-0003TV-0w for submit@debbugs.gnu.org; Sun, 07 Mar 2021 18:07:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJ2Uo-0005e6-Sc for guix-patches@gnu.org; Sun, 07 Mar 2021 18:07:34 -0500 Received: from w4.tutanota.de ([81.3.6.165]:35108) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJ2Un-0001A6-3l for guix-patches@gnu.org; Sun, 07 Mar 2021 18:07:34 -0500 Received: from w3.tutanota.de (unknown [192.168.1.164]) by w4.tutanota.de (Postfix) with ESMTP id 0C1DE1060160 for ; Sun, 7 Mar 2021 23:07:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1615158448; s=s1; d=tuta.io; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Date:Date:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:Sender; bh=Kbt8FyzmyG+m/CNtAmuyixvMUYI5PlY8NmfR5aot3fQ=; b=S2yud9FWXR4SrfxHEorv2GxSV+ZTNQQNCT0elfV4CoR10UX+lkr9Uo9zMmimn9I1 7wotCnLvpPjrkRyGGi3hNKEllsTrx0DcfE4zJqI54pkoWk3s1sGv77j6ZgH5S/9wa2H MpxKSpJND1szGYpOT8nOmEQ1o+mb3xD3dkOANjW9iXMtlGJGy8vrexizDzjvbO4bTaa RDzeKK7kH+WjCAtYfUJR6im028nocw+fbNjLJiMGuU4LslD6UXOAlUkzle3haJ7ipZJ J44X/VXoT0QYAqFk1IHRhdWyUgz8y6MLPpoi8dJjLifu8Javvr5qhI0Rvn02rLpiehF J0HKiItJkg== Date: Mon, 8 Mar 2021 00:07:28 +0100 (CET) From: Adam Kandur To: Guix Patches Message-ID: Subject: [PATCH] gnu: Add mangband. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=81.3.6.165; envelope-from=rndd@tuta.io; helo=w4.tutanota.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) master 921bea8c76a52d10091585f3f4ebf0b950c9b758 Author:=C2=A0=C2=A0=C2=A0=C2=A0 Adam Kandur AuthorDate: Mon Mar 8 02:03:00 2021 +0300 Commit:=C2=A0=C2=A0=C2=A0=C2=A0 Adam Kandur CommitDate: Mon Mar 8 02:03:00 2021 +0300 Parent:=C2=A0=C2=A0=C2=A0=C2=A0 76c32fcab4 gnu: nimf: Disable qt4 support. Merged:=C2=A0=C2=A0=C2=A0=C2=A0 master Contained:=C2=A0 master Follows:=C2=A0=C2=A0=C2=A0 bootstrap-20190815 (28240) gnu: Add mangband. * gnu/packages/games.scm (mangband): New variable. 1 file changed, 30 insertions(+) gnu/packages/games.scm | 30 ++++++++++++++++++++++++++++++ modified=C2=A0=C2=A0 gnu/packages/games.scm @@ -2952,6 +2952,36 @@ the depths below Angband, seeking riches, fighting m= onsters, and preparing to =C2=A0fight Morgoth, the Lord of Darkness.") =C2=A0=C2=A0=C2=A0=C2=A0 (license license:gpl2))) =C2=A0 +(define-public mangband +=C2=A0 (package +=C2=A0=C2=A0=C2=A0 (name "mangband") +=C2=A0=C2=A0=C2=A0 (version "v1.5.3") +=C2=A0=C2=A0=C2=A0 (source +=C2=A0=C2=A0=C2=A0=C2=A0 (origin +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (method git-fetch) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (uri (git-reference +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 (url "https://github.com/mangb= and/mangband") +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 (commit version))) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (file-name (git-file-name name versio= n)) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (sha256 +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (base32 "1m7fixv0cbcdzrvxqrjs3j= fpzkhq2aj3zip3y67w38a3fbhwdq1k")))) +=C2=A0=C2=A0=C2=A0 (build-system gnu-build-system) +=C2=A0=C2=A0=C2=A0 (inputs +=C2=A0=C2=A0=C2=A0=C2=A0 `(("ncurses" ,ncurses) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("sdl2" ,sdl2) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("automake", automake) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("autoconf", autoconf))) +=C2=A0=C2=A0=C2=A0 (home-page "https://github.com/mangband/mangband") +=C2=A0=C2=A0=C2=A0 (synopsis "A free online multi-player realtime roguelik= e game based on Angband.") +=C2=A0=C2=A0=C2=A0 (description "To win the game you must build up a chara= cter, selected from any one +of 10 races and 6 classes, to be powerful enough to defeat Morgoth, Lord o= f Darkness,=20 +who lives in the dungeon 5000 feet below the surface of the town.=C2=A0 As= you work towards +this near-impossible goal, you will chart unexplored dungeon passageways, +do battle with legendary creatures, and find lost artifacts.=C2=A0 And of = course +throughout your journeys you will encounter many=20 +other adventurers -- whether they be friend or foe is up to you to decide!= ") +=C2=A0=C2=A0=C2=A0 (license license:expat))) + =C2=A0(define-public pingus =C2=A0=C2=A0 (package =C2=A0=C2=A0=C2=A0=C2=A0 (name "pingus") From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 13 06:05:13 2021 Received: (at submit) by debbugs.gnu.org; 13 Mar 2021 11:05:13 +0000 Received: from localhost ([127.0.0.1]:59166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lL252-000645-Ud for submit@debbugs.gnu.org; Sat, 13 Mar 2021 06:05:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:55442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lL24z-00063l-IV for submit@debbugs.gnu.org; Sat, 13 Mar 2021 06:05:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lL24z-0007Ca-Di for guix-patches@gnu.org; Sat, 13 Mar 2021 06:05:09 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:45057) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lL24w-0003Ff-QN for guix-patches@gnu.org; Sat, 13 Mar 2021 06:05:09 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id AB5041BF207; Sat, 13 Mar 2021 11:05:02 +0000 (UTC) From: Nicolas Goaziou To: Adam Kandur via Guix-patches via Subject: Re: [bug#46997] [PATCH] gnu: Add mangband. References: Date: Sat, 13 Mar 2021 12:05:01 +0100 In-Reply-To: (Adam Kandur via Guix-patches via's message of "Mon, 8 Mar 2021 00:07:28 +0100 (CET)") Message-ID: <875z1vz542.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=217.70.183.201; envelope-from=mail@nicolasgoaziou.fr; helo=relay8-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 46997@debbugs.gnu.org, Adam Kandur X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, Adam Kandur via Guix-patches via writes: > gnu: Add mangband. > > * gnu/packages/games.scm (mangband): New variable. Thank you. Some comments follow. > 1 file changed, 30 insertions(+) > gnu/packages/games.scm | 30 ++++++++++++++++++++++++++++++ > > modified=C2=A0=C2=A0 gnu/packages/games.scm > @@ -2952,6 +2952,36 @@ the depths below Angband, seeking riches, fighting= monsters, and preparing to > =C2=A0fight Morgoth, the Lord of Darkness.") > =C2=A0=C2=A0=C2=A0=C2=A0 (license license:gpl2))) Something is wrong with your indentation, as there are nbsp inserted throughout your patch. I couldn't also apply your patch cleanly. Did you try using git format-patch? > +(define-public mangband > +=C2=A0 (package > +=C2=A0=C2=A0=C2=A0 (name "mangband") > +=C2=A0=C2=A0=C2=A0 (version "v1.5.3") Version should be "1.5.3", the "v" is prepended in the commit. > +=C2=A0=C2=A0=C2=A0 (source > +=C2=A0=C2=A0=C2=A0=C2=A0 (origin > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (method git-fetch) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (uri (git-reference > +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 (url "https://github.com/man= gband/mangband") > +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 (commit version))) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (file-name (git-file-name name vers= ion)) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (sha256 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (base32 "1m7fixv0cbcdzrvxqrjs= 3jfpzkhq2aj3zip3y67w38a3fbhwdq1k")))) > +=C2=A0=C2=A0=C2=A0 (build-system gnu-build-system) > +=C2=A0=C2=A0=C2=A0 (inputs > +=C2=A0=C2=A0=C2=A0=C2=A0 `(("ncurses" ,ncurses) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("sdl2" ,sdl2) I don't think this is sufficient, MAngband also looks for sdl2-image and sdl2-ttf. > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("automake", automake) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("autoconf", autoconf))) automake and autoconf belong to native-inputs, not inputs. Also, inputs ought to be sorted alphabetically (nitpick). > +=C2=A0=C2=A0=C2=A0 (home-page "https://github.com/mangband/mangband") The home page is https://www.mangband.org > +=C2=A0=C2=A0=C2=A0 (synopsis "A free online multi-player realtime roguel= ike game based on Angband.") Synopsis must not start with an article, and "free" should be removed as everything in Guix is free. There is no final full stop either in a synopsis. You may want to run guix lint mangband to catch some common errors. > +=C2=A0=C2=A0=C2=A0 (license license:expat))) I think this is more complex than that. Looking at the COPYING file, there's also, at least, public-domain and bsd-2 involved. But, more importantly, I couldn't make this game work. Running mangclient fails with a segmentation error, while running mangband fails with the following fatal error: "Cannot create the '/gnu/store/=E2=80=A6-mangband-1.5.3/var/mangband/data/scores.raw' file!" Could you look into it. I paste here my "improved" version of the package definition, if that helps. --8<---------------cut here---------------start------------->8--- (define-public mangband (package (name "mangband") (version "1.5.3") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/mangband/mangband") (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 (base32 "1m7fixv0cbcdzrvxqrjs3jfpzkhq2aj3zip3y67w38a3fbhwdq1k")))) (build-system gnu-build-system) (arguments `(#:phases (modify-phases %standard-phases (add-after 'set-paths 'set-sdl-paths (lambda* (#:key inputs #:allow-other-keys) (setenv "CPATH" (string-append (assoc-ref inputs "sdl-union") "/include/SDL2:" (or (getenv "CPATH") ""))) #t))))) (native-inputs `(("autoconf", autoconf) ("automake", automake))) (inputs `(("ncurses" ,ncurses) ("sdl-union" ,(sdl-union (list sdl2 sdl2-image sdl2-ttf))))) (home-page "https://www.mangband.org") (synopsis "Online multi-player realtime roguelike game based on Angband= ") (description "MAngband is a free online multiplayer real-time roguelike game, deriv= ed from the single player game Angband. To win the game you must build up a character, selected from any one of 10 races and 6 classes, to be powerful enough to defeat Morgoth, Lord of Darkness, who lives in the dungeon 5000 feet below the surface of the town. As you work towards this near-impossible goal, you will chart unexplored dungeon passageways, do battle with legendary creatures, and find lost artifacts. And of course throughout your journeys you will encounter many other adventurers -- whether they be friend or foe is up to you to decide!") (license (list license:expat license:bsd-2 license:public-domain)))) --8<---------------cut here---------------end--------------->8--- Regards, --=20 Nicolas Goaziou