GNU bug report logs - #46996
[PATCH] gnu: Add emacs-tup-mode.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#46996: closed ([PATCH] gnu: Add emacs-tup-mode.)
Date: Sun, 07 Mar 2021 23:17:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 08 Mar 2021 00:16:27 +0100
with message-id <87sg564ks4.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#46996] [PATCH] gnu: Add emacs-tup-mode.
has caused the debbugs.gnu.org bug report #46996,
regarding [PATCH] gnu: Add emacs-tup-mode.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
46996: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46996
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Reichör <stefan <at> xsteve.at>
To: guix-patches <at> gnu.org
Cc: Stefan Reichör <stefan <at> xsteve.at>
Subject: [PATCH] gnu: Add emacs-tup-mode.
Date: Sun,  7 Mar 2021 22:57:41 +0100

* gnu/packages/emacs-xyz.scm (emacs-tup-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 960a5668ca..21713dbf79 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -94,6 +94,7 @@
 ;;; Copyright © 2021 Yurii Kholodkov <urist.mckorobochka <at> gmail.com>
 ;;; Copyright © 2021 Alexey Abramov <levenson <at> mmer.org>
 ;;; Copyright © 2021 Xinglu Chen <public <at> yoctocell.xyz>
+;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5313,6 +5314,27 @@ view the build status of those servers' build jobs, and possibly to trigger
 build jobs.")
     (license license:gpl3+)))
 
+(define-public emacs-tup-mode
+  (package
+    (name "emacs-tup-mode")
+    (version "1.3.1")
+    (home-page "https://github.com/ejmr/tup-mode")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url home-page)
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0asd024n5v23wdsg1959sszq568wg3a1bp4jrk0cllfji1z0n78y"))))
+    (build-system emacs-build-system)
+    (synopsis "An Emacs major mode for editing Tup files")
+    (description
+     "Major mode for Emacs made for editing ‘tupfiles’.  These are files used
+by the Tup build system.")
+    (license license:gpl3+)))
+
 (define-public emacs-company
   (package
     (name "emacs-company")
-- 
2.25.1

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 46996-done <at> debbugs.gnu.org
Subject: Re: [bug#46996] [PATCH] gnu: Add emacs-tup-mode.
Date: Mon, 08 Mar 2021 00:16:27 +0100

Hello,

Stefan Reichör <stefan <at> xsteve.at> writes:

> * gnu/packages/emacs-xyz.scm (emacs-tup-mode): New variable.

Applied. Thank you.

> +(define-public emacs-tup-mode
> +  (package
> +    (name "emacs-tup-mode")
> +    (version "1.3.1")
> +    (home-page "https://github.com/ejmr/tup-mode")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url home-page)

Nitpick: I'm not a big fan of this hack, since modifying the home-page
can break the build. So I moved it changed it.

> +    (synopsis "An Emacs major mode for editing Tup files")

I changed the synopsis so it does not start with "An" anymore (see "guix
lint")

> +    (description
> +     "Major mode for Emacs made for editing ‘tupfiles’.  These are files used
> +by the Tup build system.")

I used full sentences for the description.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.