GNU bug report logs - #46996
[PATCH] gnu: Add emacs-tup-mode.

Previous Next

Full log

Message #10 received at 46996-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 46996-done <at> debbugs.gnu.org
Subject: Re: [bug#46996] [PATCH] gnu: Add emacs-tup-mode.
Date: Mon, 08 Mar 2021 00:16:27 +0100

Hello,

Stefan Reichör <stefan <at> xsteve.at> writes:

> * gnu/packages/emacs-xyz.scm (emacs-tup-mode): New variable.

Applied. Thank you.

> +(define-public emacs-tup-mode
> +  (package
> +    (name "emacs-tup-mode")
> +    (version "1.3.1")
> +    (home-page "https://github.com/ejmr/tup-mode")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url home-page)

Nitpick: I'm not a big fan of this hack, since modifying the home-page
can break the build. So I moved it changed it.

> +    (synopsis "An Emacs major mode for editing Tup files")

I changed the synopsis so it does not start with "An" anymore (see "guix
lint")

> +    (description
> +     "Major mode for Emacs made for editing ‘tupfiles’.  These are files used
> +by the Tup build system.")

I used full sentences for the description.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.