Subject: bug#46996: closed (Re: [bug#46996] [PATCH] gnu: Add emacs-tup-mode.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 07 Mar 2021 23:17:02 +0000

Your bug report

#46996: [PATCH] gnu: Add emacs-tup-mode.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
46996: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46996
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#46996] [PATCH] gnu: Add emacs-tup-mode.
From: Nicolas Goaziou <[email-masked]>
To: Stefan Reichör <[email-masked]>
Cc: [email-masked]
Date: Mon, 08 Mar 2021 00:16:27 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Stefan Reichör <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-tup-mode): New variable.

Applied. Thank you.

> +(define-public emacs-tup-mode
> +  (package
> +    (name "emacs-tup-mode")
> +    (version "1.3.1")
> +    (home-page "https://github.com/ejmr/tup-mode")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url home-page)

Nitpick: I'm not a big fan of this hack, since modifying the home-page
can break the build. So I moved it changed it.

> +    (synopsis "An Emacs major mode for editing Tup files")

I changed the synopsis so it does not start with "An" anymore (see "guix
lint")

> +    (description
> +     "Major mode for Emacs made for editing ‘tupfiles’.  These are files used
> +by the Tup build system.")

I used full sentences for the description.

Regards,
-- 
Nicolas Goaziou

Subject: [PATCH] gnu: Add emacs-tup-mode.
From: Stefan Reichör <[email-masked]>
To: [email-masked]
Cc: Stefan Reichör <[email-masked]>
Date: Sun, 7 Mar 2021 22:57:41 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/emacs-xyz.scm (emacs-tup-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 960a5668ca..21713dbf79 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -94,6 +94,7 @@
 ;;; Copyright © 2021 Yurii Kholodkov <[email-masked]>
 ;;; Copyright © 2021 Alexey Abramov <[email-masked]>
 ;;; Copyright © 2021 Xinglu Chen <[email-masked]>
+;;; Copyright © 2021 Stefan Reichör <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5313,6 +5314,27 @@ view the build status of those servers' build jobs, and possibly to trigger
 build jobs.")
     (license license:gpl3+)))
 
+(define-public emacs-tup-mode
+  (package
+    (name "emacs-tup-mode")
+    (version "1.3.1")
+    (home-page "https://github.com/ejmr/tup-mode")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url home-page)
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0asd024n5v23wdsg1959sszq568wg3a1bp4jrk0cllfji1z0n78y"))))
+    (build-system emacs-build-system)
+    (synopsis "An Emacs major mode for editing Tup files")
+    (description
+     "Major mode for Emacs made for editing ‘tupfiles’.  These are files used
+by the Tup build system.")
+    (license license:gpl3+)))
+
 (define-public emacs-company
   (package
     (name "emacs-company")
-- 
2.25.1