GNU bug report logs - #46990
28.0.50; popup menu not navigable via arrow keys on lucid build

Previous Next

Package: emacs;

Reported by: Colin Baxter <m43cap <at> yandex.com>

Date: Sun, 7 Mar 2021 16:59:02 UTC

Severity: normal

Tags: moreinfo

Found in version 28.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: Colin Baxter <m43cap <at> yandex.com>, 46990 <at> debbugs.gnu.org, "Jan D." <jan.h.d <at> swipnet.se>
Subject: bug#46990: 28.0.50; popup menu not navigable via arrow keys on lucid build
Date: Mon, 20 Jun 2022 17:38:55 +0200
Po Lu <luangruo <at> yahoo.com> writes:

> Ah.  Then it's this:
>
> /* For debug, if installation-directory is non-nil this is not an installed
>    Emacs.   In that case we do not grab the keyboard to make it easier to
>    debug. */
> #define GRAB_KEYBOARD  (EQ (Vinstallation_directory, Qnil))
>
> and it's not a bug.

It's always nice when behaviour like this has a logical explanation.  😀

But I'm not sure whether we actually want this.  The commit message is
somewhat vague -- what's the debugging this simplifies?  Is it still
relevant?  I've added Jan to the CCs; perhaps he remembers the reasoning
for the 20 year old change:

diff --git a/lwlib/ChangeLog b/lwlib/ChangeLog
index 28626ddc25..3ead711d79 100644
--- a/lwlib/ChangeLog
+++ b/lwlib/ChangeLog
@@ -1,3 +1,8 @@
+2002-04-28  Jan D.  <jan.h.d <at> swipnet.se>
+
+	* xlwmenu.c: Do not grab keyboard if installation-directory is
+	non-nil (not installed Emacs).  To simplify debugging.
+


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 3 years and 24 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.