GNU bug report logs - #4698
23.1; C-l in gnus differs from other modes

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4698 in the body.
You can then email your comments to 4698 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Tom Tromey <tromey <at> redhat.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1; C-l in gnus differs from other modes
Date: Sat, 10 Oct 2009 19:22:54 -0600

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs <at> gnu.org mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Emacs changed the default C-l binding to recenter-top-bottom.
However, C-l in the gnus summary buffer is still gnus-recenter,
which just calls recenter.
I think it would be nice if gnus followed the user's setting here.


If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.1/etc/DEBUG for instructions.


In GNU Emacs 23.1.1 (i386-redhat-linux-gnu, GTK+ Version 2.16.6)
 of 2009-09-29 on x86-7.fedora.phx.redhat.com
Windowing system distributor `The X.Org Foundation', version 11.0.10603901
configured using `configure  '--build=i386-redhat-linux-gnu' '--host=i386-redhat-linux-gnu' '--target=i586-redhat-linux-gnu' '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/var/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-dbus' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xft' '--with-xpm' '--with-x-toolkit=gtk' 'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu' 'target_alias=i586-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i586 -mtune=generic -fasynchronous-unwind-tables''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-netsplit-mode: t
  erc-spelling-mode: t
  erc-truncate-mode: t
  flyspell-mode: t
  eldoc-mode: t
  erc-status-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
n SPC n SPC SPC n SPC SPC n SPC SPC SPC n SPC SPC SPC 
n SPC SPC n n RET RET n C-u RET RET RET RET RET RET 
RET RET SPC n SPC n SPC n SPC n SPC n SPC n SPC SPC 
SPC SPC DEL DEL SPC SPC SPC n q s C-f C-l n SPC k n 
c SPC C-f C-f = c SPC SPC c SPC SPC C-u C-n C-n C-p 
d SPC C-u RET RET RET C-u d d q C-l n SPC c SPC n n 
SPC E q SPC E SPC q SPC SPC E q SPC C-n n SPC SPC E 
SPC SPC E SPC SPC SPC SPC E SPC SPC SPC SPC SPC E SPC 
P SPC SPC SPC SPC N E SPC E SPC SPC E SPC E SPC E SPC 
E SPC C-u RET E q C-l SPC SPC SPC E SPC SPC SPC SPC 
E SPC E SPC P SPC N E SPC E SPC SPC SPC E SPC E SPC 
E SPC SPC E SPC SPC E SPC P SPC N E SPC E SPC P N E 
SPC E SPC C-f E q SPC q SPC SPC E q C-l n n SPC q n 
SPC E E q n n SPC 5 0 RET ESC > ESC < C-v Q y SPC 1 
0 0 RET C-v C-v C-u C-n C-u C-n C-l C-l C-l C-l C-l 
SPC C-h k C-l C-x o C-n C-n C-x o C-x o C-n C-e C-b 
C-b C-b C-b RET C-x 1 C-l C-h c C-l C-h k C-g C-h k 
C-l C-x o C-x 1 C-c b C-x k C-g ESC x r e p o r t - 
e m TAB b TAB RET

Recent messages:
Retrieving newsgroup: nnml:mail.other...
Fetching headers for nnml:mail.other...done
Scoring...done
Scoring...done
Generating summary...done
Type "q" to restore this window.
uncompressing gnus-sum.el.gz...done
Note: file is write protected
C-l runs the command recenter-top-bottom
Type C-x 1 to delete the help window.
Quit
Tom

Message #10 received at 4698 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Reiner Steib <reinersteib+gmane <at> imap.cc>
To: Tom Tromey <tromey <at> redhat.com>
Cc: 4698 <at> debbugs.gnu.org, ding <at> gnus.org
Subject: Re: bug#4698: 23.1; C-l in gnus differs from other modes
Date: Wed, 14 Oct 2009 20:23:56 +0200

On Sun, Oct 11 2009, Tom Tromey wrote:

> Emacs changed the default C-l binding to recenter-top-bottom.
> However, C-l in the gnus summary buffer is still gnus-recenter,
> which just calls recenter.
> I think it would be nice if gnus followed the user's setting here.

Here's a mostly untested patch:

--8<---------------cut here---------------start------------->8---
--- gnus-sum.el	9 Sep 2009 09:31:35 -0000	7.240
+++ gnus-sum.el	14 Oct 2009 18:19:46 -0000
@@ -6722,7 +6725,9 @@
   (when (and gnus-auto-center-summary
 	     (not (eq gnus-auto-center-summary 'vertical)))
     (gnus-horizontal-recenter))
-  (recenter n))
+  (if (fboundp 'recenter-top-bottom)
+      (recenter-top-bottom n)
+    (recenter n)))
 
 (defun gnus-summary-recenter ()
   "Center point in the summary window.
--8<---------------cut here---------------end--------------->8---

Could you please test it for a while and report back? 

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Message #17 received at 4698 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Tom Tromey <tromey <at> redhat.com>
Cc: 4698 <at> debbugs.gnu.org, Gnus <ding <at> gnus.org>
Subject: Re: bug#4698: 23.1; C-l in gnus differs from other modes
Date: Fri, 16 Oct 2009 16:46:38 +0900

>>>>> Reiner Steib wrote:
> On Sun, Oct 11 2009, Tom Tromey wrote:

>> Emacs changed the default C-l binding to recenter-top-bottom.
>> However, C-l in the gnus summary buffer is still gnus-recenter,
>> which just calls recenter.
>> I think it would be nice if gnus followed the user's setting here.

> Here's a mostly untested patch:

[...]

> Could you please test it for a while and report back?

Looks good.  Thanks.

Message #22 received at 4698 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Reiner Steib <reinersteib+gmane <at> imap.cc>
To: Tom Tromey <tromey <at> redhat.com>, 4698 <at> debbugs.gnu.org,
        ding <at> gnus.org
Subject: Re: bug#4698: 23.1; C-l in gnus differs from other modes
Date: Mon, 30 Nov 2009 19:24:43 +0100

On Fri, Oct 16 2009, Katsumi Yamaoka wrote:

>>>>>> Reiner Steib wrote:
>> On Sun, Oct 11 2009, Tom Tromey wrote:
>
>>> Emacs changed the default C-l binding to recenter-top-bottom.
>>> However, C-l in the gnus summary buffer is still gnus-recenter,
>>> which just calls recenter.
>>> I think it would be nice if gnus followed the user's setting here.
>
>> Here's a mostly untested patch:
>
> [...]
>
>> Could you please test it for a while and report back?
>
> Looks good.  Thanks.

Closing this bug as it was fixed by this change:

2009-11-29  Juri Linkov  <juri <at> jurta.org>

	* gnus-sum.el (gnus-recenter): Use `recenter-top-bottom'
	when it is fboundp in GNU Emacs 23.1.  Put `isearch-scroll' property
	on `gnus-recenter'. (Bug#4698, Bug#4981)

Bye, Reiner

Message #32 received at 4698 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Reiner Steib <Reiner.Steib <at> gmx.de>
Cc: 4698 <at> debbugs.gnu.org
Subject: Re: bug#4698: 23.1; C-l in gnus differs from other modes
Date: Mon, 30 Nov 2009 21:49:00 +0200

> Closing this bug as it was fixed by this change:

Thanks.  I don't know how I missed this bug report.

> 2009-11-29  Juri Linkov  <juri <at> jurta.org>
>
> 	* gnus-sum.el (gnus-recenter): Use `recenter-top-bottom'
> 	when it is fboundp in GNU Emacs 23.1.  Put `isearch-scroll' property
> 	on `gnus-recenter'. (Bug#4698, Bug#4981)
                             =========
Could you please also update gnus/ChangeLog in CVS adding a reference
to Bug#4698 to gnus/ChangeLog.  Or did you already update this in Gnus CVS
that will be later synced to the Emacs CVS?

-- 
Juri Linkov
http://www.jurta.org/emacs/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.