GNU bug report logs - #46964
[ELPA]: [PATCH] Replace modus-*-theme with modus-themes from :core

Previous Next

Package: emacs;

Reported by: Protesilaos Stavrou <info <at> protesilaos.com>

Date: Sat, 6 Mar 2021 11:59:01 UTC

Severity: normal

Tags: patch

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log


Message #38 received at 46964 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: "Basil L. Contovounesios" <contovob <at> tcd.ie>, 46964 <at> debbugs.gnu.org
Subject: Re: bug#46964: [ELPA]: [PATCH] Replace modus-*-theme with
 modus-themes from :core
Date: Wed, 10 Mar 2021 07:43:20 +0200
On 2021-03-09, 22:48 -0500, Stefan Monnier <monnier <at> iro.umontreal.ca> wrote:

>>> No, the build always gives me errors.  Though I assumed something was
>>> wrong on my end (I am not familiar with makefiles).  This is not just
>>> with the modus-themes.  Same for something like project.el.  Please see
>>> the attached file with the backtrace.
>>
>> Hmm... indeed.  Can you check if the patch below fixes it for you?
>
> I pushed that workaround along with a more real fix for what I believe
> is the same problem that was preventing building new :core packages on
> elpa.gnu.org.

It no longers returns an error.  Thank you!

Below is what I get now, provided this:

    ("modus-themes"
      :core ("etc/themes/modus-themes.el"
             "etc/themes/modus-operandi-theme.el"
             "etc/themes/modus-vivendi-theme.el"
             "doc/misc/modus-themes.org")
      :doc "modus-themes.org")


make clean
make build/modus-themes
[...]
Linking files for package: modus-themes
  etc/themes/modus-themes.el -> modus-themes.el
  etc/themes/modus-operandi-theme.el -> modus-operandi-theme.el
  etc/themes/modus-vivendi-theme.el -> modus-vivendi-theme.el
  doc/misc/modus-themes.org -> modus-themes.org


The resulting archive does not include the Org file or derivatives:

 drwxr-xr-x    prot/prot          0 modus-themes-1.2.3/
 -rw-r--r--    prot/prot       2550 modus-themes-1.2.3/modus-operandi-theme.el
 -rw-r--r--    prot/prot       2544 modus-themes-1.2.3/modus-vivendi-theme.el
 -rw-r--r--    prot/prot        397 modus-themes-1.2.3/modus-themes-pkg.el
 -rw-r--r--    prot/prot     343994 modus-themes-1.2.3/modus-themes.el

While in archive-devel, the Org file is present, though the Info file is
practically empty:

 drwxr-xr-x    prot/prot          0 modus-themes-1.2.3.0.20210306.91600/
 -rw-r--r--    prot/prot     122691 modus-themes-1.2.3.0.20210306.91600/modus-themes.org
 -rw-r--r--    prot/prot       2550 modus-themes-1.2.3.0.20210306.91600/modus-operandi-theme.el
 -rw-r--r--    prot/prot        541 modus-themes-1.2.3.0.20210306.91600/dir
 -rw-r--r--    prot/prot       2544 modus-themes-1.2.3.0.20210306.91600/modus-vivendi-theme.el
 -rw-r--r--    prot/prot        414 modus-themes-1.2.3.0.20210306.91600/modus-themes-pkg.el
 -rw-r--r--    prot/prot     343994 modus-themes-1.2.3.0.20210306.91600/modus-themes.el
 -rw-r--r--    prot/prot        218 modus-themes-1.2.3.0.20210306.91600/modus-themes.info


-- 
Protesilaos Stavrou
protesilaos.com




This bug report was last modified 4 years and 124 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.