GNU bug report logs - #46955
Add python-sparse, Update python-cooler

Previous Next

Full log

Message #37 received at 46955 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>, 46955 <at> debbugs.gnu.org
Cc: rekado <at> elephly.net
Subject: Re: [bug#46955] [PATCH 3/3] gnu: python-cooler: Update to 0.8.11.
Date: Sat, 05 Jun 2021 12:06:01 +0200

[Message part 1 (text/plain, inline)]

A comment about a build phase.

> [...]
> +         (replace 'check
> +           (lambda _
> +             (invoke "python" "-m" "pytest" "-v")
> +            #t)))))

This needs to be something like

+ (replace 'check
+   (lambda* (#:key tests? #:allow-other-keys)
+     (when tests?
+       (invoke "python" "-m" "pytest" "-v"))))

By respecting 'tests?', the --without-tests build transformation can be used.
(Try "guix build python-cooler --without-tests=python-cooler").
This can also be important for cross-compilation (dunno if it applies here
though).

Trailing #t are not required anymore. The warning that results if it is removed
will disappear once core-updates is merged.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.