GNU bug report logs - #46953
[PATCH] gnu: Add xzgv.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46953 in the body.
You can then email your comments to 46953 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Reichör <stefan <at> xsteve.at>
To: guix-patches <at> gnu.org
Cc: Stefan Reichör <stefan <at> xsteve.at>
Subject: [PATCH] gnu: Add xzgv.
Date: Fri,  5 Mar 2021 22:46:42 +0100

* gnu/packages/image-viewers.scm (xzgv): New variable.
---
 gnu/packages/image-viewers.scm | 38 ++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index bddf86568c..8fa6743020 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -17,6 +17,7 @@
 ;;; Copyright © 2020 Pierre Neidhardt <mail <at> ambrevar.xyz>
 ;;; Copyright © 2021 Rovanion Luckey <rovanion.luckey <at> gmail.com>
 ;;; Copyright © 2021 Xinglu Chen <public <at> yoctocell.xyz>
+;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -748,3 +749,40 @@ allows creating false color images.  A unique feature of Nomacs is the
 synchronization of multiple instances.")
     (home-page "https://nomacs.org/")
     (license license:gpl3+)))
+
+(define-public xzgv
+  (package
+    (name "xzgv")
+    (version "0.9.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://sourceforge/xzgv/"
+                                  version "/" name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "17l1xr9v07ggwga3vn0z1i4lnwjrr20rr8z1kjbw71aaijxl18i5"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'override-target-directory
+           (lambda* (#:key outputs #:allow-other-keys)
+             (substitute* "config.mk"
+               (("/usr/local") (assoc-ref outputs "out")))))
+         (delete 'configure)                     ; no configure script
+         (replace 'install
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (bin (string-append out "/bin")))
+               (install-file "src/xzgv" bin))))) ; just install the executable
+       #:tests? #f))                             ; no rule for target 'test'
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("gtk+" ,gtk+-2)
+       ("libexif" ,libexif)))
+    (synopsis "Picture viewer for X with a thumbnail-based selector")
+    (description
+     "xzgv is a fast image viewer that provides extensive keyboard support.")
+    (home-page "https://sourceforge.net/projects/xzgv/")
+    (license license:gpl2+)))
-- 
2.25.1

Message #10 received at 46953-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 46953-done <at> debbugs.gnu.org
Subject: Re: [bug#46953] [PATCH] gnu: Add xzgv.
Date: Mon, 08 Mar 2021 00:08:28 +0100

Hello,

Stefan Reichör <stefan <at> xsteve.at> writes:

> * gnu/packages/image-viewers.scm (xzgv): New variable.

Applied. Thank you.

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://sourceforge/xzgv/"
> +                                  version "/" name "-" version ".tar.gz"))

Nitpick: we usually hard-code name here. So did I.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.