GNU bug report logs - #46882
26.3; Let `dired-omit-mode' match lines, as well as file names

Previous Next

Full log

Message #19 received at 46882 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Juri Linkov <juri <at> linkov.net>, Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: "46882 <at> debbugs.gnu.org" <46882 <at> debbugs.gnu.org>
Subject: RE: [External] : Re: bug#46882: 26.3; Let `dired-omit-mode' match
 lines, as well as file names
Date: Mon, 20 Jun 2022 19:36:56 +0000

> Its counterpart variable is `dired-omit-files' that is a regexp.
> Shouldn't the new variable be named with the same naming scheme
> for consistency?  I.e. just `dired-omit-lines'.  Even so that
> it's not just a regexp, but can be a symbol of a function name.

It's a valid question, but it opens a can of
worms.  There's no consistency already. ;-)

Consider option `dired-garbage-files-regexp',
for example.

Generally, an option whose value is a regexp
is better named with `regexp' in the name.

`dired-omit-files' would be better named
`dired-omit-files-regexp' or similar.

FWIW, Dired+ has these additional options:

diredp-visit-ignore-regexps
diredp-omit-files-font-lock-regexp

And of course diredp-omit-lines-regexp.

If you really want to aim for consistency
then consider renaming `dired-omit-files'
to `dired-omit-files-regexp'. ;-)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.