GNU bug report logs - #46873
[PATCH 0/2] gnu: knot-resolver: Fix phase return value; update to 5.3.0

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46873 in the body.
You can then email your comments to 46873 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simon South <simon <at> simonsouth.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] gnu: knot-resolver: Fix phase return value;
 update to 5.3.0
Date: Tue,  2 Mar 2021 08:52:21 -0500

These patches update the Knot Resolver package to

- Ensure the custom "move-doc" phase returns #t on success, eliminating this
  warning message while building:

    ## WARNING: phase `move-doc' returned `#<unspecified>'.  Return values other than #t
    ## are deprecated.  Please migrate this package so that its phase
    ## procedures report errors by raising an exception, and otherwise
    ## always return #t.

- Update Knot Resolver itself to 5.3.0.

I've tested these changes on x86_64 and aarch64, and have been running the new
version on aarch64-linux without issue.

--
Simon South
simon <at> simonsouth.net


Simon South (2):
  gnu: knot-resolver: Ensure all custom phases return #t on success.
  gnu: knot-resolver: Update to 5.3.0.

 gnu/packages/dns.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

-- 
2.30.1

Message #8 received at 46873 <at> debbugs.gnu.org (full text, mbox):

From: Simon South <simon <at> simonsouth.net>
To: 46873 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: knot-resolver: Ensure all custom phases return #t on
 success.
Date: Tue,  2 Mar 2021 08:53:26 -0500

* gnu/packages/dns.scm (knot-resolver)[arguments]<#:phases>: Return #t from
"move-doc" phase on success.
---
 gnu/packages/dns.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm
index 2c4008559f..5b0e310a0c 100644
--- a/gnu/packages/dns.scm
+++ b/gnu/packages/dns.scm
@@ -979,7 +979,8 @@ synthesis, and on-the-fly re-configuration.")
                                (string-append doc "/share/" dir)))
                 '("doc/knot-resolver/examples"
                   "doc/knot-resolver/html"
-                  "info")))))
+                  "info"))
+               #t)))
          (add-after 'install 'wrap-binary
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))
-- 
2.30.1

Message #11 received at 46873 <at> debbugs.gnu.org (full text, mbox):

From: Simon South <simon <at> simonsouth.net>
To: 46873 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: knot-resolver: Update to 5.3.0.
Date: Tue,  2 Mar 2021 08:53:27 -0500

* gnu/packages/dns.scm (knot-resolver): Update to 5.3.0.
---
 gnu/packages/dns.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm
index 5b0e310a0c..bc876ff5c1 100644
--- a/gnu/packages/dns.scm
+++ b/gnu/packages/dns.scm
@@ -942,14 +942,14 @@ synthesis, and on-the-fly re-configuration.")
 (define-public knot-resolver
   (package
     (name "knot-resolver")
-    (version "5.2.1")
+    (version "5.3.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://secure.nic.cz/files/knot-resolver/"
                                   "knot-resolver-" version ".tar.xz"))
               (sha256
                (base32
-                "09jqy23q1pgj76y2qd1xfk72wwmypnyawm3span3gx00qi2bfdxa"))))
+                "0gp3ivv3zccz4b6s1wxbsvvlrc837lw2g089l3cbvzsg7z0b4v7v"))))
     (build-system meson-build-system)
     (outputs '("out" "doc"))
     (arguments
-- 
2.30.1

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Simon South <simon <at> simonsouth.net>
Cc: 46873 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#46873] [PATCH 1/2] gnu: knot-resolver: Ensure all custom
 phases return #t on success.
Date: Tue, 02 Mar 2021 15:22:16 +0100

Simon South 写道：
> * gnu/packages/dns.scm (knot-resolver)[arguments]<#:phases>: 
> Return #t from
> "move-doc" phase on success.

Thanks, but I don't think this is worth the noise at this point: 
that requirement will be gone on the next core-updates merge, and 
there will be much rejoicing.

The update itself LGTM; I'll test it now.

Kind regards,

T G-R

Message #22 received at 46873-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Simon South <simon <at> simonsouth.net>
Cc: 46873-done <at> debbugs.gnu.org
Subject: Re: [bug#46873] [PATCH 2/2] gnu: knot-resolver: Update to 5.3.0.
Date: Tue, 02 Mar 2021 16:12:19 +0100

[Message part 1 (text/plain, inline)]

Simon South 写道：
> * gnu/packages/dns.scm (knot-resolver): Update to 5.3.0.

It resolves things all right.  Update pushed as 
673ab1cdb4702ae2b79434ee1f5b3095eebf8eb3, without the #t.

Thanks again,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.