GNU bug report logs - #46834
28.0.50; byte-compiling the standard counter closure fails

Previous Next

Full log

Message #61 received at 46834 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 46834 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca, pipcet <at> gmail.com
Subject: Re: bug#46834: 28.0.50;
 byte-compiling the standard counter closure fails
Date: Tue, 02 Mar 2021 15:16:52 +0200

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Tue, 02 Mar 2021 08:34:30 +0100
> Cc: 46834 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
> 
> Pip Cet <pipcet <at> gmail.com> writes:
> 
> > On Tue, Mar 2, 2021 at 7:00 AM Lars Ingebrigtsen <larsi <at> gnus.org> wrote:
> >> Pip, are you pushing this fix yourself, or do you want me to do it?
> >
> > It's been a while since I pushed, did I get that right?
> 
> Yup; looks perfect.

Almost perfect:

    * lisp/emacs-lisp/bytecomp.el (byte-compile--reify-function): Don't
    move let bindings into the lambda. Don't reverse list of
    bindings. (byte-compile): Evaluate the return value if it was
    previously reified.

The "(byte-compile):" part should have begun on a new line.

(It is always better to use "C-x 4 a" or similar commands to write log
entries, as then Emacs will format the messages for you.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.