Subject: bug#46832: closed (Re: bug#46833: [PATCH v2] import: hackage: Accept optional version parameter.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 01 Mar 2021 16:03:02 +0000

Your bug report

#46833: [PATCH] import: hackage: Accept optional version paramter.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
46833: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46833
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#46833: [PATCH v2] import: hackage: Accept optional version parameter.
From: Ludovic Courtès <[email-masked]>
To: Xinglu Chen <[email-masked]>
Cc: [email-masked]
Date: Mon, 01 Mar 2021 17:02:13 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Xinglu Chen <[email-masked]> skribis:

> * guix/import/hackage.scm (hackage-recursive-import): Add the VERSION key.
>   Make REPO a key.

Applied, thanks!

Ludo’.

Subject: [PATCH] import: hackage: Accept optional version paramter.
From: Xinglu Chen <[email-masked]>
To: [email-masked]
Date: Sun, 28 Feb 2021 17:16:10 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

* guix/import/hackage.scm (hackage-recursive-import): Add the VERSION key.
  Make REPO a key.
---
Looks like Martin forgot to update the Hackage importer in commit
bea3b17739fc591b8cf6db1f8d28a6f6c9585577.

 guix/import/hackage.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/import/hackage.scm b/guix/import/hackage.scm
index 6ca4f65cb0..9f992ffe8e 100644
--- a/guix/import/hackage.scm
+++ b/guix/import/hackage.scm
@@ -344,8 +344,8 @@ respectively."
   (memoize hackage->guix-package))
 
 (define* (hackage-recursive-import package-name . args)
-  (recursive-import package-name #f
-                    #:repo->guix-package (lambda (name repo)
+  (recursive-import package-name
+                    #:repo->guix-package (lambda* (name #:key repo version)
                                            (apply hackage->guix-package/m
                                                   (cons name args)))
                     #:guix-name hackage-name->package-name))
-- 
2.30.0