GNU bug report logs -
#46830
[PATCH Added hdf5-1.12-parallel-openmpi] * gnu/packages/maths.scm (hdf5-1.12-parallel-openmpi): New package based on HDF5 1.12.0
Previous Next
Reported by: Gerd Heber <gerd.heber <at> gmail.com>
Date: Sun, 28 Feb 2021 17:13:02 UTC
Severity: normal
Tags: patch
Done: Andreas Enge <andreas <at> enge.fr>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
Hi,
On Sun, 28 Feb 2021 at 07:33, Gerd Heber <gerd.heber <at> gmail.com> wrote:
> +(define-public hdf5-1.12-parallel-openmpi
> + (package/inherit hdf5-1.12
> + (name "hdf5-1.12-parallel-openmpi")
> + (inputs
> + `(("mpi" ,openmpi)
> + ,@(package-inputs hdf5)))
> + (arguments
> + (substitute-keyword-arguments (package-arguments hdf5)
> + ((#:configure-flags flags)
> + ``("--enable-parallel"
> + ,@(delete "--enable-cxx"
> + (delete "--enable-threadsafe" ,flags))))
> + ((#:phases phases)
> + `(modify-phases ,phases
> + (add-after 'build 'mpi-setup
> + ,%openmpi-setup)
> + (add-before 'check 'patch-tests
> + (lambda _
> + ;; OpenMPI's mpirun will exit with non-zero status if it
> + ;; detects an "abnormal termination", i.e. any process not
> + ;; calling MPI_Finalize(). Since the test is explicitly
> + ;; avoiding MPI_Finalize so as not to have at_exit and thus
> + ;; H5C_flush_cache from being called, mpirun will always
> + ;; complain, so turn this test off.
> + (substitute* "testpar/Makefile"
> + (("(^TEST_PROG_PARA.*)t_pflush1(.*)" front back)
> + (string-append front back "\n")))
> + (substitute* "tools/test/h5diff/testph5diff.sh"
> + (("/bin/sh") (which "sh")))
> + #t))))))
> + (synopsis "Management suite for data with parallel IO support")))
> +
Why duplicates? Something like:
--8<---------------cut here---------------start------------->8---
(define-public hdf5-1.12-parallel-openmpi
(package/inherit hdf5-parallel-openmpi
(version (package-version hdf5-1.12))
(source (package-source hdf5-1.12)))
--8<---------------cut here---------------end--------------->8---
seems simpler.
All the best,
simon
This bug report was last modified 1 year and 289 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.