GNU bug report logs - #46819
28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation

Previous Next

Package: emacs;

Reported by: Matt Armstrong <matt <at> rfc20.org>

Date: Sat, 27 Feb 2021 20:20:02 UTC

Severity: normal

Tags: fixed

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Matt Armstrong <matt <at> rfc20.org>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 46819 <at> debbugs.gnu.org
Subject: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation
Date: Mon, 01 Mar 2021 01:09:03 +0100
Matt Armstrong <matt <at> rfc20.org> writes:

> It might be hard to fix in the general case.  Think about this example:
>
> (let (...)
>   (some-macro blah))
>
> What if that macro expands to nothing, based on some criteria not
> entirely under programmer control?  Is the code "wrong"?

No.  But if the code is

(let (...)
  )

then it probably is.  So the warning (if retained) has to be done on the
form read before doing any macro expansions.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 4 years and 133 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.