From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 27 15:19:10 2021 Received: (at submit) by debbugs.gnu.org; 27 Feb 2021 20:19:10 +0000 Received: from localhost ([127.0.0.1]:45438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG63S-0006Rk-2g for submit@debbugs.gnu.org; Sat, 27 Feb 2021 15:19:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:55146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG63Q-0006Rc-Mi for submit@debbugs.gnu.org; Sat, 27 Feb 2021 15:19:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lG63Q-0007iV-HB for bug-gnu-emacs@gnu.org; Sat, 27 Feb 2021 15:19:08 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:53663) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lG63N-0004Y6-La for bug-gnu-emacs@gnu.org; Sat, 27 Feb 2021 15:19:08 -0500 Received: from matts-mbp-2016.lan (24-113-169-116.wavecable.com [24.113.169.116]) (Authenticated sender: matt@rfc20.org) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 8B1D8100002; Sat, 27 Feb 2021 20:18:59 +0000 (UTC) From: Matt Armstrong To: bug-gnu-emacs@gnu.org, Stefan Monnier Subject: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation Date: Sat, 27 Feb 2021 12:18:56 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.231; envelope-from=matt@rfc20.org; helo=relay11.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This behavior began with Stefan's recent commit d41a4ad4ae (* lisp/emacs-lisp/macroexp.el ;; (macroexp--expand-all): Warn on empty let bodies, 2021-02-15) `benchmark-run' has a timing `doloop' with an empty body, which `doloop` expands to a `let` with an empty body (in the lexical-binding case). Save the following into my-benchmark-warning.el ---------------------------------------------------------------------- ;;; Code: (require 'benchmark) (defun my-list-benchmark () "Lorem ipsum dolor." (benchmark-run 100 (list 1 2 3))) (provide 'my-benchmark-warning) ;;; my-benchmark-warning.el ends here ---------------------------------------------------------------------- Then run this and you'll see the interaction below: ---------------------------------------------------------------------- % ./src/emacs -Q --batch -f batch-byte-compile ./my-benchmark-warning.el In my-list-benchmark: ./my-benchmark-warning.el:32:8: Warning: Empty let body ---------------------------------------------------------------------- In GNU Emacs 28.0.50 (build 1, x86_64-apple-darwin20.3.0, NS appkit-2022.30 Version 11.2.1 (Build 20D74)) of 2021-02-27 built on matts-mbp-2016.lan Repository revision: de33de1a660283f45a10acfaedef20c460553dbd Repository branch: master Windowing system distributor 'Apple', version 10.3.2022 System Description: macOS 11.2.1 Configured using: 'configure --without-info' Configured features: ACL GLIB GMP GNUTLS JPEG JSON LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER PNG RSVG THREADS TIFF TOOLKIT_SCROLL_BARS ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Special Minor modes in effect: winner-mode: t electric-pair-mode: t auto-insert-mode: t display-time-mode: t show-paren-mode: t keyfreq-autosave-mode: t keyfreq-mode: t icomplete-mode: t magit-auto-revert-mode: t global-auto-revert-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t shell-dirtrack-mode: t global-flycheck-mode: t which-key-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t temp-buffer-resize-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /Users/matt/git/notmuch/emacs/notmuch-mua hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-mua /Users/matt/git/notmuch/emacs/notmuch-tree hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-tree /Users/matt/git/notmuch/emacs/notmuch-show hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-show /Users/matt/git/notmuch/emacs/notmuch-tag hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-tag /Users/matt/git/notmuch/emacs/coolj hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/coolj /Users/matt/git/notmuch/emacs/notmuch-wash hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-wash /Users/matt/git/notmuch/emacs/notmuch-maildir-fcc hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-maildir-fcc /Users/matt/git/notmuch/emacs/notmuch-compat hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-compat /Users/matt/git/notmuch/emacs/notmuch hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch /Users/matt/git/notmuch/emacs/notmuch-address hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-address /Users/matt/git/notmuch/emacs/rstdoc hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/rstdoc /Users/matt/git/notmuch/emacs/notmuch-lib hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-lib /Users/matt/git/notmuch/emacs/notmuch-print hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-print /Users/matt/git/notmuch/emacs/notmuch-draft hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-draft /Users/matt/git/notmuch/emacs/notmuch-jump hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-jump /Users/matt/git/notmuch/emacs/notmuch-parser hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-parser /Users/matt/git/notmuch/emacs/notmuch-query hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-query /Users/matt/git/notmuch/emacs/notmuch-message hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-message /Users/matt/git/notmuch/emacs/notmuch-hello hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-hello /Users/matt/git/notmuch/emacs/notmuch-crypto hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-crypto /Users/matt/git/notmuch/emacs/make-deps hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/make-deps /Users/matt/git/notmuch/emacs/notmuch-company hides /Users/matt/.emacs.d/elpa/notmuch-0.31.3/notmuch-company Features: (shadow sort company-oddmuse company-keywords company-etags company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb mail-extr emacsbug sendmail org-element avl-tree ol-w3m ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-search eieio-opt speedbar ezimage dframe gnus-art mm-uu mml2015 gnus-sum gnus-group gnus-undo gnus-start gnus-dbus dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win ol-eww eww xdg url-queue mm-url gnus nnheader ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex ol-bbdb winner cus-start cus-load elec-pair slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree slime-scratch slime-presentations bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl elp slime-parse slime gud apropos arc-mode archive-mode hyperspec slime-autoloads warnings org-protocol notmuch notmuch-tree notmuch-jump notmuch-hello notmuch-show notmuch-print notmuch-crypto notmuch-mua notmuch-message notmuch-draft notmuch-maildir-fcc notmuch-address notmuch-company notmuch-parser notmuch-wash coolj notmuch-query goto-addr icalendar diary-lib diary-loaddefs notmuch-tag notmuch-lib notmuch-compat hl-line mm-view mml-smime smime dig elisp-format protbuf org-drill persist org-id org-agenda org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs org-loaddefs cal-menu calendar cal-loaddefs diminish ctypes skeleton autoinsert time paren ert debug backtrace keyfreq generic icomplete highlight-symbol cl hi-lock racket-mode racket-bug-report racket-collection tq racket-repl-buffer-name racket-stepper racket-logger racket-profile racket-smart-open racket-xp racket-xp-complete racket-show pos-tip racket-imenu racket-edit hideshow racket-repl semantic/symref/grep semantic/symref semantic/util-modes semantic/util semantic pp semantic/tag semantic/lex semantic/fw mode-local cedet racket-eldoc racket-describe shr kinsoku svg xml dom racket-visit racket-complete racket-common racket-parens racket-indent racket-font-lock racket-ppss racket-keywords-and-builtins racket-doc racket-cmd racket-util racket-browse-url racket-custom sh-script smie executable company-lsp company lsp-mode lsp-protocol tree-widget wid-edit pcase network-stream nsm markdown-mode noutline outline lv inline ht f s ewoc dash-functional bindat projectile grep ibuf-ext ibuffer ibuffer-loaddefs cider tramp-sh cider-debug cider-browse-ns cider-mode cider-inspector cider-completion cider-profile cider-eval cider-repl-history pulse cider-repl cider-resolve cider-test cider-overlays cider-stacktrace cider-doc cider-browse-spec cider-clojuredocs cider-eldoc cider-client cider-common cider-connection cider-util color cider-popup sesman-browser nrepl-client tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat parse-time iso8601 ls-lisp queue nrepl-dict cider-compat spinner parseedn parseclj-parser parseclj-lex a sesman vc vc-dispatcher edmacro kmacro clojure-mode lisp-mnt align magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff diff-mode magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process magit-mode git-commit transient format-spec magit-git magit-section magit-utils crm log-edit message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log with-editor async-bytecomp async shell pcomplete server ido flycheck find-func rx dash go-mode find-file ffap thingatpt etags fileloop generator xref project compile text-property-search comint ansi-color ring which-key advice exec-path-from-shell cl-extra help-mode use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core finder-inf info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar easymenu rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 766437 32631) (symbols 48 56488 4) (strings 32 248491 4562) (string-bytes 1 7334590) (vectors 16 89116) (vector-slots 8 956750 71031) (floats 8 732 300) (intervals 56 545 265) (buffers 992 12)) From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 27 16:00:35 2021 Received: (at submit) by debbugs.gnu.org; 27 Feb 2021 21:00:35 +0000 Received: from localhost ([127.0.0.1]:45459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG6hX-0007SL-L8 for submit@debbugs.gnu.org; Sat, 27 Feb 2021 16:00:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:44950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG6hR-0007S8-PD for submit@debbugs.gnu.org; Sat, 27 Feb 2021 16:00:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lG6hR-0001nd-Cc for bug-gnu-emacs@gnu.org; Sat, 27 Feb 2021 16:00:29 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54362) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lG6hM-00063V-MS for bug-gnu-emacs@gnu.org; Sat, 27 Feb 2021 16:00:28 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 67255441B5F; Sat, 27 Feb 2021 16:00:23 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 21F6D441AF6; Sat, 27 Feb 2021 16:00:22 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1614459622; bh=eQda/HQymrrqehezT9YgM4NRgaB5Cow/XY+r/AZjIR8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DjAtil6s/y3aE/1I96DKJ0OQbIogJ6ySyn/7wGCFxB0FLXH6NCsgl5ufrkGgEtK5S ThS3AD/Vjhh+IKNIT+Zrpbgpa3gZaVZnaSUj1CX56UbWQuKPFYaOaXGULtHowZLqYd CbfvzQfX/s2x7Bp5rOr3A9tg+wtpdw7DXanKBEM68vc3sssUSYQWP3Jc4RYgdNiWMA N7/xs6FAlCBX1VOsIN1CIiqYfJfYvVVBIzcBRoUPd3ZwsAFJxoS6hRPQUVELFFG3lE m6tfcx7p8S0+BhfztHDfXahnpik1YNb8vh9Q1KLh/H2Pm7zIBuhyri9fKf9648VtJZ D/A0VbyLSA9gQ== Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 33D451203C4; Sat, 27 Feb 2021 16:00:22 -0500 (EST) From: Stefan Monnier To: Matt Armstrong Subject: Re: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation Message-ID: References: Date: Sat, 27 Feb 2021 16:00:21 -0500 In-Reply-To: (Matt Armstrong's message of "Sat, 27 Feb 2021 12:18:56 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.100 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > This behavior began with Stefan's recent commit d41a4ad4ae (* > lisp/emacs-lisp/macroexp.el ;; (macroexp--expand-all): Warn on empty let > bodies, 2021-02-15) > > `benchmark-run' has a timing `doloop' with an empty body, which `doloop` > expands to a `let` with an empty body (in the lexical-binding case). It'd be easy to put an explicit nil in the loop's body, but.... The idea was that in actual (non-macroexpanded) source code, empty let bodies are usually the result of a misplaced paren. But it's probably more often annoying than useful since we can't easily distinguish a "let from source code" from a "let from a macro expansion". So I'm also voting to revert that change. Any objection? Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 28 19:04:57 2021 Received: (at 46819) by debbugs.gnu.org; 1 Mar 2021 00:04:57 +0000 Received: from localhost ([127.0.0.1]:47549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGW3U-0006vf-UW for submit@debbugs.gnu.org; Sun, 28 Feb 2021 19:04:57 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:42921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGW3S-0006vO-7j for 46819@debbugs.gnu.org; Sun, 28 Feb 2021 19:04:55 -0500 X-Originating-IP: 24.113.169.116 Received: from matts-mbp-2016.lan (24-113-169-116.wavecable.com [24.113.169.116]) (Authenticated sender: matt@rfc20.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 1DB76FF809; Mon, 1 Mar 2021 00:04:45 +0000 (UTC) From: Matt Armstrong To: Lars Ingebrigtsen , Stefan Monnier Subject: Re: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation In-Reply-To: <87h7lwmgaj.fsf@gnus.org> References: <87h7lwmgaj.fsf@gnus.org> Date: Sun, 28 Feb 2021 16:04:42 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46819 Cc: 46819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: > Stefan Monnier writes: > >> It'd be easy to put an explicit nil in the loop's body, but.... >> >> The idea was that in actual (non-macroexpanded) source code, empty >> let bodies are usually the result of a misplaced paren. But it's >> probably more often annoying than useful since we can't easily >> distinguish a "let from source code" from a "let from a macro >> expansion". >> >> So I'm also voting to revert that change. Any objection? > > It is a nice and helpful warning, though, so if it could be fixed in > another way, that'd be great. (But I have no idea how, of course.) It might be hard to fix in the general case. Think about this example: (let (...) (some-macro blah)) What if that macro expands to nothing, based on some criteria not entirely under programmer control? Is the code "wrong"? From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 28 19:09:19 2021 Received: (at 46819) by debbugs.gnu.org; 1 Mar 2021 00:09:20 +0000 Received: from localhost ([127.0.0.1]:47553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGW7j-00072v-M8 for submit@debbugs.gnu.org; Sun, 28 Feb 2021 19:09:19 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGW7i-00072j-FM for 46819@debbugs.gnu.org; Sun, 28 Feb 2021 19:09:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UlDiL/3z0S7MbnZQVyUZJnAAIzWaQNZS90bp43KIH/I=; b=PweH6S2c6mFRxE+qWTtUuiS8yE qSh9oQJxnDfv+cqi/+b00G9yIe1yQQRkvbxO0JomxLTTV69LMRpnGd/sCND6HdqUfCkq50zlHFleg +x7E25hftF+NN+wZA7jyzrV3Qu87qiqz4X0kkuskFru/rtCPLipjZ2FJZjpVZtSwbIEU=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGW7U-0004TI-Io; Mon, 01 Mar 2021 01:09:11 +0100 From: Lars Ingebrigtsen To: Matt Armstrong Subject: Re: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation References: <87h7lwmgaj.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXBv8AxMTZ/fYH/ //9f11wxAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UDAQAHCtrVQv0AAAFrSURBVCjPdZFBS8NAEIUf C0LM2RTaUyhG2vwKr95KYRayJy2kmPyKJSBITiJs0J62YqXZX+mMaW09OOSwX97Om+UNEiJDVLZZ SQQGIk23J+hpmZGALlnouguBzPS6de7uU4tiQtj1tLo2HWHE4GoywYwcJssQYlevp4ukx2QVwmYe xfYlKTC9VxZxFCFlSD0AhdimiUNq+dww5PPqR+GLgJ8sgRlgLZTy+StSDGV93osQuAM+jbaIwZ/y 8nOKqUUkCsMlbrxYRdKrMJrZGD9zI4Vs31w0TSSzFCZvPls2XjwU5k1DxZ6f8Zgq5KGuaM9NV3mD 9GG1Ja2ukHcBs2z1TouPvWo5kPmOM6oXPnaSTiUpbrKd3g2JGmqfSLsBHqnd/sKz6TYSOCT9oqo7 ZwIDKwX16yp8DSBVG5lzAN0zjA/QOdLD5rhKWeOxp6DjTg+F/F8YUyXPGiCh+jjpj4E7h/IcCoby 5ObOrL8B712sv+MEtpIAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDMtMDFUMDA6MDc6MTArMDA6 MDA4/A7tAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTAzLTAxVDAwOjA3OjEwKzAwOjAwSaG2UQAA AABJRU5ErkJggg== X-Now-Playing: Shackleton's _20 Years of Fabric (2)_: "Drawn and Quartered" Date: Mon, 01 Mar 2021 01:09:03 +0100 In-Reply-To: (Matt Armstrong's message of "Sun, 28 Feb 2021 16:04:42 -0800") Message-ID: <874khvd9b4.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Matt Armstrong writes: > It might be hard to fix in the general case. Think about this example: > > (let (...) > (some-macro blah)) > > What if that macro expands to nothing, based on some criteria not > entirely under prog [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46819 Cc: Stefan Monnier , 46819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Matt Armstrong writes: > It might be hard to fix in the general case. Think about this example: > > (let (...) > (some-macro blah)) > > What if that macro expands to nothing, based on some criteria not > entirely under programmer control? Is the code "wrong"? No. But if the code is (let (...) ) then it probably is. So the warning (if retained) has to be done on the form read before doing any macro expansions. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 28 19:19:51 2021 Received: (at 46819) by debbugs.gnu.org; 1 Mar 2021 00:19:51 +0000 Received: from localhost ([127.0.0.1]:47570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGWHv-0007Il-2E for submit@debbugs.gnu.org; Sun, 28 Feb 2021 19:19:51 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGWHt-0007IZ-Nw for 46819@debbugs.gnu.org; Sun, 28 Feb 2021 19:19:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JlSTwX8W1EGKQ7l+iKBgblKz/855jqAkRIAkhiXaCFg=; b=TD6jwA5oFMFoFEdxDwsIkIW7M4 Kz5p0lPPi/kZk3+hvX0V/5iRjaOCZhm/XQzhid2C+V/sQxEAQT5Sl8AhpPouxIMabe7Ebfjcczdmr Nju2ekKLx+kiYvwXoxU/oOU4NZuQ6Ow26/LFcGuISCxsCkfnLa4XR/B2LHFuUYiIM2Ww=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGWHk-0004Y7-5y; Mon, 01 Mar 2021 01:19:42 +0100 From: Lars Ingebrigtsen To: Matt Armstrong Subject: Re: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation References: <87h7lwmgaj.fsf@gnus.org> <874khvd9b4.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXBv8AxMTZ/fYH/ //9f11wxAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UDAQAHCtrVQv0AAAFrSURBVCjPdZFBS8NAEIUf C0LM2RTaUyhG2vwKr95KYRayJy2kmPyKJSBITiJs0J62YqXZX+mMaW09OOSwX97Om+UNEiJDVLZZ SQQGIk23J+hpmZGALlnouguBzPS6de7uU4tiQtj1tLo2HWHE4GoywYwcJssQYlevp4ukx2QVwmYe xfYlKTC9VxZxFCFlSD0AhdimiUNq+dww5PPqR+GLgJ8sgRlgLZTy+StSDGV93osQuAM+jbaIwZ/y 8nOKqUUkCsMlbrxYRdKrMJrZGD9zI4Vs31w0TSSzFCZvPls2XjwU5k1DxZ6f8Zgq5KGuaM9NV3mD 9GG1Ja2ukHcBs2z1TouPvWo5kPmOM6oXPnaSTiUpbrKd3g2JGmqfSLsBHqnd/sKz6TYSOCT9oqo7 ZwIDKwX16yp8DSBVG5lzAN0zjA/QOdLD5rhKWeOxp6DjTg+F/F8YUyXPGiCh+jjpj4E7h/IcCoby 5ObOrL8B712sv+MEtpIAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDMtMDFUMDA6MDc6MTArMDA6 MDA4/A7tAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTAzLTAxVDAwOjA3OjEwKzAwOjAwSaG2UQAA AABJRU5ErkJggg== X-Now-Playing: Daniel Avery's _20 Years of Fabric (2)_: "Whilst We've Got Metal In Our Blood" Date: Mon, 01 Mar 2021 01:19:33 +0100 In-Reply-To: <874khvd9b4.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 01 Mar 2021 01:09:03 +0100") Message-ID: <87zgznbu96.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: >> It might be hard to fix in the general case. Think about this example: >> >> (let (...) >> (some-macro blah)) >> >> What if that macro expands to nothing, based on some criteria not >> entirely und [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46819 Cc: Stefan Monnier , 46819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: >> It might be hard to fix in the general case. Think about this example: >> >> (let (...) >> (some-macro blah)) >> >> What if that macro expands to nothing, based on some criteria not >> entirely under programmer control? Is the code "wrong"? (And besides -- the macro can't really expand to nothing here, can it? (nil is something.) Or am I misunderstanding what it's warning about?) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 01 00:04:51 2021 Received: (at 46819) by debbugs.gnu.org; 1 Mar 2021 05:04:51 +0000 Received: from localhost ([127.0.0.1]:47783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGaji-0005Zj-Tm for submit@debbugs.gnu.org; Mon, 01 Mar 2021 00:04:51 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGajh-0005ZX-O0 for 46819@debbugs.gnu.org; Mon, 01 Mar 2021 00:04:50 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E54CD440340; Mon, 1 Mar 2021 00:04:43 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BAF7744071B; Mon, 1 Mar 2021 00:04:42 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1614575082; bh=1wrrcHIks22KBXuaPjKpayK9rsCWy0JWNsE7IRwTRBU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=FEFP4PqAIKKA/ahG2Oddw8/o9aP906BoA+iQDetn4wECP8SXZFM+jPUf0rapCbwM9 LLoDEOj8GwOseRUOYXHWNq19JoQ/XreiMsPIhtYXOz7smRjLyRhwauC5L5LowrqiQ9 pfYp05/oAAtDT/Hd+PH9BVp0pAn+gs79jCSMLZUDnrHV+iutn2o/CE2c0YsOy9csd7 EfLTy9eiuy+4/T/MJk6U1KWcjygyjQBlrzH3W6pqhDjspIX+wf2i9qfEQTVBWP0SuZ Afo+hpedu1K6q9drND7WI0gLHnSmohgO8DQ7JmWgWf873lpZ89p6VcV6zyKXsPi2F9 qi+/cegsBSrxg== Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8D7771201E1; Mon, 1 Mar 2021 00:04:42 -0500 (EST) From: Stefan Monnier To: Matt Armstrong Subject: Re: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation Message-ID: References: <87h7lwmgaj.fsf@gnus.org> Date: Mon, 01 Mar 2021 00:04:34 -0500 In-Reply-To: (Matt Armstrong's message of "Sun, 28 Feb 2021 16:04:42 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.100 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46819 Cc: Lars Ingebrigtsen , 46819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > It might be hard to fix in the general case. Think about this example: > > (let (...) > (some-macro blah)) > > What if that macro expands to nothing, No can do. A macro call has to expand to exactly one expression (that expression can be nil, but it's still one expression). Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 01 07:20:27 2021 Received: (at 46819) by debbugs.gnu.org; 1 Mar 2021 12:20:27 +0000 Received: from localhost ([127.0.0.1]:48348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGhXH-0001uj-4f for submit@debbugs.gnu.org; Mon, 01 Mar 2021 07:20:27 -0500 Received: from quimby.gnus.org ([95.216.78.240]:41590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGhXF-0001uW-89 for 46819@debbugs.gnu.org; Mon, 01 Mar 2021 07:20:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Resent-Message-ID:Resent-Date:Resent-From: Resent-To:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Sender:Resent-Cc:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0+iNIVuKLxpTesliPFzdassHef2LHub7S8sdLuDSeQE=; b=FvoRzgN101LajGGpzKpeIwsPc6 WtDs+tMpb9NHvata3Ul1slq0QM1L63iDkgHLhfED5EFx5r7xezoSsTFEAjcXGRnkUL6RoLyLObvXb gzZzqzbXwATnYMTe2aVT6GxBiu/IRWlV1GwI8LQWb0J+0m9F1iqzks7Z5cwmaRsM45DA=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGhX7-0001i5-A9 for 46819@debbugs.gnu.org; Mon, 01 Mar 2021 13:20:19 +0100 Resent-X-Now-Playing: Siouxsie and the Banshees's _Join Hands_: "The Lords Prayer" Resent-To: 46819@debbugs.gnu.org Resent-From: Lars Ingebrigtsen Resent-Date: Mon, 01 Mar 2021 13:20:16 +0100 Resent-Message-ID: <87sg5f9ibj.fsf@gnus.org> X-From-Line: nobody Sun Feb 28 15:13:28 2021 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation References: X-Now-Playing: Boris's _Love_: "Coma" Date: Sun, 28 Feb 2021 15:13:24 +0100 In-Reply-To: (Stefan Monnier's message of "Sat, 27 Feb 2021 16:00:21 -0500") Message-ID: <87h7lwmgaj.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Lines: 18 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > It'd be easy to put an explicit nil in the loop's body, but.... > > The idea was that in actual (non-macroexpanded) source code, empty let > bodies are usually the result of a misplaced paren. But i [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46819 Cc: Matt Armstrong , 46819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > It'd be easy to put an explicit nil in the loop's body, but.... > > The idea was that in actual (non-macroexpanded) source code, empty let > bodies are usually the result of a misplaced paren. But it's probably > more often annoying than useful since we can't easily distinguish a "let > from source code" from a "let from a macro expansion". > > So I'm also voting to revert that change. > Any objection? It is a nice and helpful warning, though, so if it could be fixed in another way, that'd be great. (But I have no idea how, of course.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 02 00:07:34 2021 Received: (at 46819) by debbugs.gnu.org; 2 Mar 2021 05:07:34 +0000 Received: from localhost ([127.0.0.1]:51379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGxFu-00041a-85 for submit@debbugs.gnu.org; Tue, 02 Mar 2021 00:07:34 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:41587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGxFs-00041N-M2 for 46819@debbugs.gnu.org; Tue, 02 Mar 2021 00:07:33 -0500 X-Originating-IP: 24.113.169.116 Received: from matts-mbp-2016.lan (24-113-169-116.wavecable.com [24.113.169.116]) (Authenticated sender: matt@rfc20.org) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id B5AF4240004; Tue, 2 Mar 2021 05:07:24 +0000 (UTC) From: Matt Armstrong To: Stefan Monnier Subject: Re: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation In-Reply-To: References: <87h7lwmgaj.fsf@gnus.org> Date: Mon, 01 Mar 2021 21:07:21 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46819 Cc: Lars Ingebrigtsen , 46819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: >> It might be hard to fix in the general case. Think about this example: >> >> (let (...) >> (some-macro blah)) >> >> What if that macro expands to nothing, > > No can do. A macro call has to expand to exactly one expression (that > expression can be nil, but it's still one expression). > > Stefan Doh, of course. That'd be a C macro I was thinking of... From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 09 23:53:36 2021 Received: (at 46819) by debbugs.gnu.org; 10 Mar 2021 04:53:36 +0000 Received: from localhost ([127.0.0.1]:48445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJqql-0004IC-Sy for submit@debbugs.gnu.org; Tue, 09 Mar 2021 23:53:36 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:59143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJqqg-0004Hu-Uv for 46819@debbugs.gnu.org; Tue, 09 Mar 2021 23:53:34 -0500 Received: from mdeb (24-113-169-116.wavecable.com [24.113.169.116]) (Authenticated sender: matt@rfc20.org) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 3BF9D240008; Wed, 10 Mar 2021 04:53:22 +0000 (UTC) Received: from matt by mdeb with local (Exim 4.94) (envelope-from ) id 1lJqqV-000lXL-Rv; Tue, 09 Mar 2021 20:53:19 -0800 From: Matt Armstrong To: Lars Ingebrigtsen Subject: Re: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation References: <87h7lwmgaj.fsf@gnus.org> Date: Tue, 09 Mar 2021 20:53:19 -0800 In-Reply-To: <87h7lwmgaj.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 28 Feb 2021 15:13:24 +0100") Message-ID: <874khj8v9c.fsf@rfc20.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46819 Cc: Stefan Monnier , 46819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: > Stefan Monnier writes: > >> It'd be easy to put an explicit nil in the loop's body, but.... >> >> The idea was that in actual (non-macroexpanded) source code, empty let >> bodies are usually the result of a misplaced paren. But it's probably >> more often annoying than useful since we can't easily distinguish a "let >> from source code" from a "let from a macro expansion". >> >> So I'm also voting to revert that change. >> Any objection? > > It is a nice and helpful warning, though, so if it could be fixed in > another way, that'd be great. (But I have no idea how, of course.) So, after a little flurry of a conversation, this went quiet. How about we fix benchmark's use of `let', and leave the warning in place. It does not seem to be generating many other complaints, so it may not be particularly annoying after all. I'm currently working with `benchmark-run' a bunch and would like the warning gone from that one use. I can make a patch, but a one liner might be quicker for one of you to just commit directly. ;-) From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 10 09:54:44 2021 Received: (at 46819) by debbugs.gnu.org; 10 Mar 2021 14:54:44 +0000 Received: from localhost ([127.0.0.1]:49489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK0EW-0000r3-Kt for submit@debbugs.gnu.org; Wed, 10 Mar 2021 09:54:44 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK0EU-0000qo-J8 for 46819@debbugs.gnu.org; Wed, 10 Mar 2021 09:54:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IlDqGcA0ehhHuRftktBPUrYITm8FzpW2rjzAlwR7UK4=; b=MC3eVhHiU+7oP+h3Cd1g3xi/sB ONuVXXnQOuryhmSAJp9deyXCzx9btw9e7cs5nymHFNVrtinxPn+RIA+wgFXcwtmNK1HbozQJLnJDz NILskNll1O4gE95AYkGojNkgIPjAFlsf2j/d4NQxyxBVYXuckshUXmN1GoYEmSN7PMRM=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lK0EJ-0004S4-S1; Wed, 10 Mar 2021 15:54:35 +0100 From: Lars Ingebrigtsen To: Matt Armstrong Subject: Re: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation References: <87h7lwmgaj.fsf@gnus.org> <874khj8v9c.fsf@rfc20.org> X-Now-Playing: Siouxsie and the Banshees's _Join Hands_: "Regal Zone" Date: Wed, 10 Mar 2021 15:54:30 +0100 In-Reply-To: <874khj8v9c.fsf@rfc20.org> (Matt Armstrong's message of "Tue, 09 Mar 2021 20:53:19 -0800") Message-ID: <87o8frjbyx.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Matt Armstrong writes: > How about we fix benchmark's use of `let', and leave the warning in > place. It does not seem to be generating many other complaints, so it > may not be particularly annoying after all. I'm currentl [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46819 Cc: Stefan Monnier , 46819@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Matt Armstrong writes: > How about we fix benchmark's use of `let', and leave the warning in > place. It does not seem to be generating many other complaints, so it > may not be particularly annoying after all. I'm currently working with > `benchmark-run' a bunch and would like the warning gone from that one > use. > > I can make a patch, but a one liner might be quicker for one of you to > just commit directly. ;-) Yup; now done. I think we should keep the byte-compilation warning -- at least for now. If it leads to false positives all over the place, then perhaps not, but it's a useful warning, in my opinion. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 10 09:54:49 2021 Received: (at control) by debbugs.gnu.org; 10 Mar 2021 14:54:49 +0000 Received: from localhost ([127.0.0.1]:49492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK0Ea-0000rL-S8 for submit@debbugs.gnu.org; Wed, 10 Mar 2021 09:54:49 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lK0EZ-0000qv-OJ for control@debbugs.gnu.org; Wed, 10 Mar 2021 09:54:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VtPUXyYtEehD2HAGS9O/UqBM/GaFNgEkNgk4jDl9YXY=; b=c/9cnBJOzRgb65FLAv1Le5jOsw 4gYuBRcuydlhU3haD844jZ6XJElhOOt9LnPz2i9MrgaCUxHmHMGWHgSeoNMNSYcxVVCxyjUza5/Yy t66CfzHAiJ73p8Yw/N5/zpU9StUvrw2oBlbuRx1MPtiAEmLviaK4XBA06La9xZU/OAxs=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lK0ES-0004SC-2k for control@debbugs.gnu.org; Wed, 10 Mar 2021 15:54:42 +0100 Date: Wed, 10 Mar 2021 15:54:38 +0100 Message-Id: <87mtvbjbyp.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #46819 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 46819 fixed close 46819 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 46819 fixed close 46819 28.1 quit From unknown Mon Aug 18 15:39:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 08 Apr 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator