From unknown Sat Jun 21 05:04:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46815: cp integer overflow in progress (time remaining) Resent-From: Ronald Knol Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 27 Feb 2021 16:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46815 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 46815@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16144450915717 (code B ref -1); Sat, 27 Feb 2021 16:59:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Feb 2021 16:58:11 +0000 Received: from localhost ([127.0.0.1]:45239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG2uw-0001U7-B9 for submit@debbugs.gnu.org; Sat, 27 Feb 2021 11:58:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:59956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG1dK-0007ze-28 for submit@debbugs.gnu.org; Sat, 27 Feb 2021 10:35:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lG1dJ-0001i2-Rd for bug-coreutils@gnu.org; Sat, 27 Feb 2021 10:35:53 -0500 Received: from mail-il1-x132.google.com ([2607:f8b0:4864:20::132]:46162) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lG1dI-00040V-9I for bug-coreutils@gnu.org; Sat, 27 Feb 2021 10:35:53 -0500 Received: by mail-il1-x132.google.com with SMTP id i18so10724482ilq.13 for ; Sat, 27 Feb 2021 07:35:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=dAnvyZo+vPxmg4P8cJoqChTzxRIYawLDUqCfFzDjn+A=; b=bz0yDt0Dz2f+AwAxizUEu4O+92fGTbd758Gm7cckwfP82RmTe8sMvlkOki+SAAdIAx fmei5k62BA7bHhpkxtKBu5viVJqn7hZBX4LJy8Kmm0w5sTM2F70uPltOubu5bH6jFYCK A2am5bHt3yc14T4JxLuT1CsTsnydDnoba3EMOtTZpYpQWbMDi4UgLRHOI/bAPM3vxbuK dvrfU/gKt3ctbBXmi1X3KpXRnz29xAKeXmCKFi5gt3yHVkm+x5kP436d9/obFVLJysIu NgtLvlO1mBu595G8rbxxlzA3W5diB8l0dDBENZEOl0mWYOe5OFtaqlWf0iuhHUGDClgm PnTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=dAnvyZo+vPxmg4P8cJoqChTzxRIYawLDUqCfFzDjn+A=; b=bPATTc1C1rqSfU1Bc5ZUu9ceE59y/x0VpIaLIVEg9Eq3aWBwMeWBHuw2y4rdbuefsN 6wVAyTu3zZdWl/Y1vqQJOgwNAu2JjvT4Qtd7TBOnWvq1nGCBrW40lnREOtV0/1tHR40z hzbmLPW1r/OxVEZ/3qTnPlf5IG2wo5BigXzt2+fIGgV8jQkDHCCn8uY01askSajtz7T3 G+ojulE4VaUcOycCA9g02thqRqjlyO2GCjPbwS2qHgZw+ywHsWlslpAzr04olUQirF7e wFiqSyVSuD4iJ2hYt5uc1jlwSkyWSBFBeAIGxBNM5w1tXHpfZcrlA6WQ5kns0IbOA96/ uFLQ== X-Gm-Message-State: AOAM531LoGwJ5M/tmNVqUujDBimAT4tRHG4+3kAym9oeiu2qJu7aQYBg 40dbkA35SnpkEj+swhlZA5L5LVSQ5wwpNWUIdXRXEc5hbgdlBA== X-Google-Smtp-Source: ABdhPJzFoKFBLtuHSYgWp+ma1u81uTUbktTj2JaqVE+8WGyUHjG/nWfLXd04Q+ffuhrO/QAiR6hzg0fIiS+G8rI9VAA= X-Received: by 2002:a92:c105:: with SMTP id p5mr7157737ile.266.1614440150478; Sat, 27 Feb 2021 07:35:50 -0800 (PST) MIME-Version: 1.0 From: Ronald Knol Date: Sat, 27 Feb 2021 07:35:38 -0800 Message-ID: Content-Type: multipart/alternative; boundary="000000000000ae354405bc532362" Received-SPF: pass client-ip=2607:f8b0:4864:20::132; envelope-from=rwjknol@gmail.com; helo=mail-il1-x132.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.3 (/) X-Mailman-Approved-At: Sat, 27 Feb 2021 11:58:08 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000ae354405bc532362 Content-Type: text/plain; charset="UTF-8" cp (GNU coreutils) 8.32 CentOS Linux release 7.4.1708 (Core) kernel 3.10.0-693.17.1.el7.x86_64 I have identified an issue with "cp" where, if more than 2 TiB of data is being copied, and progress reporting is on, after 2 TiB has been copied the time remaining overflows. The output goes like this: 728 files copied so far... 2.0 TiB / 4.9 TiB [============================> ] 41.0 % Copying at 206.2 MiB/s (about 4h 25m 44s remaining) ...127TE.RDM/A018_A007_0127H2.RDC/A018_A007_0127H2_004.R3D 1.6 GiB / 3.8 GiB [=============================> ] 42.1 % 728 files copied so far... 2.0 TiB / 4.9 TiB [============================> ] 41.0 % Copying at 203.1 MiB/s (about 4294967286h 4294967261m 4294967249s remaining) ...127TE.RDM/A018_A007_0127H2.RDC/A018_A007_0127H2_004.R3D 1.7 GiB / 3.8 GiB [===============================> ] 44.7 % This is "cp -argu ". The source tree contains more than 2TiB worth of data. I believe the issue is in src/copy.c where (on line 355) an INT is used to store "cur_size". int cur_size = g_iTotalWritten + *total_n_read / 1024; When dealing with filesizes and capacities, the largest possible type should be used, which I believe is a unsigned long long (or __uint64_t). Note that I also think that usec_elapsed and sec_elapsed should be larger types than int and double to prevent overflows. --000000000000ae354405bc532362 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: base64 PGRpdiBkaXI9Imx0ciI+Y3AgKEdOVSBjb3JldXRpbHMpIDguMzI8YnI+Q2VudE9TIExpbnV4IHJl bGVhc2UgNy40LjE3MDggKENvcmUpPGJyPmtlcm5lbCAzLjEwLjAtNjkzLjE3LjEuZWw3Lng4Nl82 NDxicj48YnI+SSBoYXZlIGlkZW50aWZpZWQgYW4gaXNzdWUgd2l0aCAmcXVvdDtjcCZxdW90OyB3 aGVyZSwgaWYgbW9yZSB0aGFuIDIgVGlCIG9mIGRhdGEgaXMgYmVpbmcgY29waWVkLCBhbmQgcHJv Z3Jlc3MgcmVwb3J0aW5nIGlzIG9uLCBhZnRlciAyIFRpQiBoYXMgYmVlbiBjb3BpZWQgdGhlIHRp bWUgcmVtYWluaW5nIG92ZXJmbG93cy48YnI+PGJyPlRoZSBvdXRwdXQgZ29lcyBsaWtlIHRoaXM6 PGJyPjxicj43MjggZmlsZXMgY29waWVkIHNvIGZhci4uLiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCAyLjAgVGlCIC8gwqAgNC45IFRpQjxicj5bPT09 PT09PT09PT09PT09PT09PT09PT09PT09PSZndDsgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBdIDQxLjAgJTxicj5Db3B5aW5nIGF0 IDIwNi4yIE1pQi9zIChhYm91dCA0aCAyNW0gNDRzIHJlbWFpbmluZyk8YnI+Li4uMTI3VEUuUkRN L0EwMThfQTAwN18wMTI3SDIuUkRDL0EwMThfQTAwN18wMTI3SDJfMDA0LlIzRCDCoCAxLjYgR2lC IC8gwqAgMy44IEdpQjxicj5bPT09PT09PT09PT09PT09PT09PT09PT09PT09PT0mZ3Q7IMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIF0g NDIuMSAlPGJyPjcyOCBmaWxlcyBjb3BpZWQgc28gZmFyLi4uIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIDIuMCBUaUIgLyDCoCA0LjkgVGlCPGJyPls9 PT09PT09PT09PT09PT09PT09PT09PT09PT09Jmd0OyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoF0gNDEuMCAlPGJyPkNvcHlpbmcg YXQgMjAzLjEgTWlCL3MgKGFib3V0IDQyOTQ5NjcyODZoIDQyOTQ5NjcyNjFtIDQyOTQ5NjcyNDlz IHJlbWFpbmluZyk8YnI+Li4uMTI3VEUuUkRNL0EwMThfQTAwN18wMTI3SDIuUkRDL0EwMThfQTAw N18wMTI3SDJfMDA0LlIzRCDCoCAxLjcgR2lCIC8gwqAgMy44IEdpQjxicj5bPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PSZndDsgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgXSA0NC43ICU8YnI+PGJyPlRoaXMgaXMgJnF1b3Q7Y3Ag LWFyZ3UgJmx0O3NvdXJjZWRpciZndDsgJmx0O2Rlc3RkaXImZ3Q7JnF1b3Q7LiBUaGUgc291cmNl IHRyZWUgY29udGFpbnMgbW9yZSB0aGFuIDJUaUIgd29ydGggb2YgZGF0YS48YnI+PGJyPkkgYmVs aWV2ZSB0aGUgaXNzdWUgaXMgaW4gc3JjL2NvcHkuYyB3aGVyZSAob24gbGluZSAzNTUpIGFuIElO VCBpcyB1c2VkIHRvIHN0b3JlICZxdW90O2N1cl9zaXplJnF1b3Q7Ljxicj48YnI+wqAgwqAgaW50 IGN1cl9zaXplID0gZ19pVG90YWxXcml0dGVuICsgKnRvdGFsX25fcmVhZCAvIDEwMjQ7PGJyPjxi cj5XaGVuIGRlYWxpbmcgd2l0aCBmaWxlc2l6ZXMgYW5kIGNhcGFjaXRpZXMsIHRoZSBsYXJnZXN0 IHBvc3NpYmxlIHR5cGUgc2hvdWxkIGJlIHVzZWQsIHdoaWNoIEkgYmVsaWV2ZSBpcyBhIHVuc2ln bmVkIGxvbmcgbG9uZyAob3IgX191aW50NjRfdCkuPGJyPjxicj48ZGl2Pk5vdGUgdGhhdCBJIGFs c28gdGhpbmsgdGhhdCB1c2VjX2VsYXBzZWQgYW5kIHNlY19lbGFwc2VkIHNob3VsZCBiZSBsYXJn ZXIgdHlwZXMgdGhhbiBpbnQgYW5kIGRvdWJsZSB0byBwcmV2ZW50IG92ZXJmbG93cy48L2Rpdj48 ZGl2Pjxicj48L2Rpdj48ZGl2Pjxicj48L2Rpdj48YnI+PC9kaXY+DQo= --000000000000ae354405bc532362-- From unknown Sat Jun 21 05:04:07 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ronald Knol Subject: bug#46815: closed (Re: bug#46815: cp integer overflow in progress (time remaining)) Message-ID: References: X-Gnu-PR-Message: they-closed 46815 X-Gnu-PR-Package: coreutils Reply-To: 46815@debbugs.gnu.org Date: Sat, 27 Feb 2021 17:55:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1614448502-10881-1" This is a multi-part message in MIME format... ------------=_1614448502-10881-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #46815: cp integer overflow in progress (time remaining) which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 46815@debbugs.gnu.org. --=20 46815: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D46815 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1614448502-10881-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 46815-done) by debbugs.gnu.org; 27 Feb 2021 17:54:36 +0000 Received: from localhost ([127.0.0.1]:45303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG3nY-0002oo-9I for submit@debbugs.gnu.org; Sat, 27 Feb 2021 12:54:36 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG3nW-0002ob-Na for 46815-done@debbugs.gnu.org; Sat, 27 Feb 2021 12:54:35 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 494B1160124; Sat, 27 Feb 2021 09:54:28 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Y4T3QlxIdC6O; Sat, 27 Feb 2021 09:54:27 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 726DB160125; Sat, 27 Feb 2021 09:54:27 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 2fWqQaLRxzg3; Sat, 27 Feb 2021 09:54:27 -0800 (PST) Received: from [192.168.1.9] (cpe-23-243-218-95.socal.res.rr.com [23.243.218.95]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 4E47D160124; Sat, 27 Feb 2021 09:54:27 -0800 (PST) To: Ronald Knol References: From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: bug#46815: cp integer overflow in progress (time remaining) Message-ID: Date: Sat, 27 Feb 2021 09:54:26 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 46815-done Cc: 46815-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) On 2/27/21 7:35 AM, Ronald Knol wrote: > This is "cp -argu ". The source tree contains more > than 2TiB worth of data. >=20 > I believe the issue is in src/copy.c where (on line 355) an INT is used= to > store "cur_size". >=20 > int cur_size =3D g_iTotalWritten + *total_n_read / 1024; GNU coreutils 'cp' lacks a 'g' option, and doesn't have the line number=20 you mentioned. It sounds like you're dealing with a bug in a modified=20 version of 'cp', which means you should direct your bug report to=20 whoever made that modification. ------------=_1614448502-10881-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Feb 2021 16:58:11 +0000 Received: from localhost ([127.0.0.1]:45239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG2uw-0001U7-B9 for submit@debbugs.gnu.org; Sat, 27 Feb 2021 11:58:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:59956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lG1dK-0007ze-28 for submit@debbugs.gnu.org; Sat, 27 Feb 2021 10:35:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lG1dJ-0001i2-Rd for bug-coreutils@gnu.org; Sat, 27 Feb 2021 10:35:53 -0500 Received: from mail-il1-x132.google.com ([2607:f8b0:4864:20::132]:46162) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lG1dI-00040V-9I for bug-coreutils@gnu.org; Sat, 27 Feb 2021 10:35:53 -0500 Received: by mail-il1-x132.google.com with SMTP id i18so10724482ilq.13 for ; Sat, 27 Feb 2021 07:35:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=dAnvyZo+vPxmg4P8cJoqChTzxRIYawLDUqCfFzDjn+A=; b=bz0yDt0Dz2f+AwAxizUEu4O+92fGTbd758Gm7cckwfP82RmTe8sMvlkOki+SAAdIAx fmei5k62BA7bHhpkxtKBu5viVJqn7hZBX4LJy8Kmm0w5sTM2F70uPltOubu5bH6jFYCK A2am5bHt3yc14T4JxLuT1CsTsnydDnoba3EMOtTZpYpQWbMDi4UgLRHOI/bAPM3vxbuK dvrfU/gKt3ctbBXmi1X3KpXRnz29xAKeXmCKFi5gt3yHVkm+x5kP436d9/obFVLJysIu NgtLvlO1mBu595G8rbxxlzA3W5diB8l0dDBENZEOl0mWYOe5OFtaqlWf0iuhHUGDClgm PnTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=dAnvyZo+vPxmg4P8cJoqChTzxRIYawLDUqCfFzDjn+A=; b=bPATTc1C1rqSfU1Bc5ZUu9ceE59y/x0VpIaLIVEg9Eq3aWBwMeWBHuw2y4rdbuefsN 6wVAyTu3zZdWl/Y1vqQJOgwNAu2JjvT4Qtd7TBOnWvq1nGCBrW40lnREOtV0/1tHR40z hzbmLPW1r/OxVEZ/3qTnPlf5IG2wo5BigXzt2+fIGgV8jQkDHCCn8uY01askSajtz7T3 G+ojulE4VaUcOycCA9g02thqRqjlyO2GCjPbwS2qHgZw+ywHsWlslpAzr04olUQirF7e wFiqSyVSuD4iJ2hYt5uc1jlwSkyWSBFBeAIGxBNM5w1tXHpfZcrlA6WQ5kns0IbOA96/ uFLQ== X-Gm-Message-State: AOAM531LoGwJ5M/tmNVqUujDBimAT4tRHG4+3kAym9oeiu2qJu7aQYBg 40dbkA35SnpkEj+swhlZA5L5LVSQ5wwpNWUIdXRXEc5hbgdlBA== X-Google-Smtp-Source: ABdhPJzFoKFBLtuHSYgWp+ma1u81uTUbktTj2JaqVE+8WGyUHjG/nWfLXd04Q+ffuhrO/QAiR6hzg0fIiS+G8rI9VAA= X-Received: by 2002:a92:c105:: with SMTP id p5mr7157737ile.266.1614440150478; Sat, 27 Feb 2021 07:35:50 -0800 (PST) MIME-Version: 1.0 From: Ronald Knol Date: Sat, 27 Feb 2021 07:35:38 -0800 Message-ID: Subject: cp integer overflow in progress (time remaining) To: bug-coreutils@gnu.org Content-Type: multipart/alternative; boundary="000000000000ae354405bc532362" Received-SPF: pass client-ip=2607:f8b0:4864:20::132; envelope-from=rwjknol@gmail.com; helo=mail-il1-x132.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 27 Feb 2021 11:58:08 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000ae354405bc532362 Content-Type: text/plain; charset="UTF-8" cp (GNU coreutils) 8.32 CentOS Linux release 7.4.1708 (Core) kernel 3.10.0-693.17.1.el7.x86_64 I have identified an issue with "cp" where, if more than 2 TiB of data is being copied, and progress reporting is on, after 2 TiB has been copied the time remaining overflows. The output goes like this: 728 files copied so far... 2.0 TiB / 4.9 TiB [============================> ] 41.0 % Copying at 206.2 MiB/s (about 4h 25m 44s remaining) ...127TE.RDM/A018_A007_0127H2.RDC/A018_A007_0127H2_004.R3D 1.6 GiB / 3.8 GiB [=============================> ] 42.1 % 728 files copied so far... 2.0 TiB / 4.9 TiB [============================> ] 41.0 % Copying at 203.1 MiB/s (about 4294967286h 4294967261m 4294967249s remaining) ...127TE.RDM/A018_A007_0127H2.RDC/A018_A007_0127H2_004.R3D 1.7 GiB / 3.8 GiB [===============================> ] 44.7 % This is "cp -argu ". The source tree contains more than 2TiB worth of data. I believe the issue is in src/copy.c where (on line 355) an INT is used to store "cur_size". int cur_size = g_iTotalWritten + *total_n_read / 1024; When dealing with filesizes and capacities, the largest possible type should be used, which I believe is a unsigned long long (or __uint64_t). Note that I also think that usec_elapsed and sec_elapsed should be larger types than int and double to prevent overflows. --000000000000ae354405bc532362 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: base64 PGRpdiBkaXI9Imx0ciI+Y3AgKEdOVSBjb3JldXRpbHMpIDguMzI8YnI+Q2VudE9TIExpbnV4IHJl bGVhc2UgNy40LjE3MDggKENvcmUpPGJyPmtlcm5lbCAzLjEwLjAtNjkzLjE3LjEuZWw3Lng4Nl82 NDxicj48YnI+SSBoYXZlIGlkZW50aWZpZWQgYW4gaXNzdWUgd2l0aCAmcXVvdDtjcCZxdW90OyB3 aGVyZSwgaWYgbW9yZSB0aGFuIDIgVGlCIG9mIGRhdGEgaXMgYmVpbmcgY29waWVkLCBhbmQgcHJv Z3Jlc3MgcmVwb3J0aW5nIGlzIG9uLCBhZnRlciAyIFRpQiBoYXMgYmVlbiBjb3BpZWQgdGhlIHRp bWUgcmVtYWluaW5nIG92ZXJmbG93cy48YnI+PGJyPlRoZSBvdXRwdXQgZ29lcyBsaWtlIHRoaXM6 PGJyPjxicj43MjggZmlsZXMgY29waWVkIHNvIGZhci4uLiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCAyLjAgVGlCIC8gwqAgNC45IFRpQjxicj5bPT09 PT09PT09PT09PT09PT09PT09PT09PT09PSZndDsgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBdIDQxLjAgJTxicj5Db3B5aW5nIGF0 IDIwNi4yIE1pQi9zIChhYm91dCA0aCAyNW0gNDRzIHJlbWFpbmluZyk8YnI+Li4uMTI3VEUuUkRN L0EwMThfQTAwN18wMTI3SDIuUkRDL0EwMThfQTAwN18wMTI3SDJfMDA0LlIzRCDCoCAxLjYgR2lC IC8gwqAgMy44IEdpQjxicj5bPT09PT09PT09PT09PT09PT09PT09PT09PT09PT0mZ3Q7IMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIF0g NDIuMSAlPGJyPjcyOCBmaWxlcyBjb3BpZWQgc28gZmFyLi4uIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIDIuMCBUaUIgLyDCoCA0LjkgVGlCPGJyPls9 PT09PT09PT09PT09PT09PT09PT09PT09PT09Jmd0OyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoF0gNDEuMCAlPGJyPkNvcHlpbmcg YXQgMjAzLjEgTWlCL3MgKGFib3V0IDQyOTQ5NjcyODZoIDQyOTQ5NjcyNjFtIDQyOTQ5NjcyNDlz IHJlbWFpbmluZyk8YnI+Li4uMTI3VEUuUkRNL0EwMThfQTAwN18wMTI3SDIuUkRDL0EwMThfQTAw N18wMTI3SDJfMDA0LlIzRCDCoCAxLjcgR2lCIC8gwqAgMy44IEdpQjxicj5bPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PSZndDsgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgXSA0NC43ICU8YnI+PGJyPlRoaXMgaXMgJnF1b3Q7Y3Ag LWFyZ3UgJmx0O3NvdXJjZWRpciZndDsgJmx0O2Rlc3RkaXImZ3Q7JnF1b3Q7LiBUaGUgc291cmNl IHRyZWUgY29udGFpbnMgbW9yZSB0aGFuIDJUaUIgd29ydGggb2YgZGF0YS48YnI+PGJyPkkgYmVs aWV2ZSB0aGUgaXNzdWUgaXMgaW4gc3JjL2NvcHkuYyB3aGVyZSAob24gbGluZSAzNTUpIGFuIElO VCBpcyB1c2VkIHRvIHN0b3JlICZxdW90O2N1cl9zaXplJnF1b3Q7Ljxicj48YnI+wqAgwqAgaW50 IGN1cl9zaXplID0gZ19pVG90YWxXcml0dGVuICsgKnRvdGFsX25fcmVhZCAvIDEwMjQ7PGJyPjxi cj5XaGVuIGRlYWxpbmcgd2l0aCBmaWxlc2l6ZXMgYW5kIGNhcGFjaXRpZXMsIHRoZSBsYXJnZXN0 IHBvc3NpYmxlIHR5cGUgc2hvdWxkIGJlIHVzZWQsIHdoaWNoIEkgYmVsaWV2ZSBpcyBhIHVuc2ln bmVkIGxvbmcgbG9uZyAob3IgX191aW50NjRfdCkuPGJyPjxicj48ZGl2Pk5vdGUgdGhhdCBJIGFs c28gdGhpbmsgdGhhdCB1c2VjX2VsYXBzZWQgYW5kIHNlY19lbGFwc2VkIHNob3VsZCBiZSBsYXJn ZXIgdHlwZXMgdGhhbiBpbnQgYW5kIGRvdWJsZSB0byBwcmV2ZW50IG92ZXJmbG93cy48L2Rpdj48 ZGl2Pjxicj48L2Rpdj48ZGl2Pjxicj48L2Rpdj48YnI+PC9kaXY+DQo= --000000000000ae354405bc532362-- ------------=_1614448502-10881-1-- From unknown Sat Jun 21 05:04:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46815: cp integer overflow in progress (time remaining) Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 28 Feb 2021 05:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46815 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Ronald Knol Cc: 46815@debbugs.gnu.org Received: via spool by 46815-submit@debbugs.gnu.org id=B46815.161449039118227 (code B ref 46815); Sun, 28 Feb 2021 05:34:02 +0000 Received: (at 46815) by debbugs.gnu.org; 28 Feb 2021 05:33:11 +0000 Received: from localhost ([127.0.0.1]:45720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGEhb-0004jv-FS for submit@debbugs.gnu.org; Sun, 28 Feb 2021 00:33:11 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:44768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGEhY-0004jg-U5 for 46815@debbugs.gnu.org; Sun, 28 Feb 2021 00:33:09 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B8BD8160133; Sat, 27 Feb 2021 21:33:02 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ewdBTK2zbS8j; Sat, 27 Feb 2021 21:33:01 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A57C016013B; Sat, 27 Feb 2021 21:33:01 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id p_F6YNDuyg1C; Sat, 27 Feb 2021 21:33:01 -0800 (PST) Received: from [192.168.1.9] (cpe-23-243-218-95.socal.res.rr.com [23.243.218.95]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 56296160133; Sat, 27 Feb 2021 21:33:01 -0800 (PST) References: From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <3fa03710-35e1-f73b-bddc-8174789b6c7c@cs.ucla.edu> Date: Sat, 27 Feb 2021 21:33:00 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) On 2/27/21 1:31 PM, Ronald Knol wrote: > I am looking at "src/cp.c" from coreutils-8.32 and it has command line > options --progress-bar (aka -g). coreutils-8.32 doesn't have those options. Apparently you have a modified copy. You can verify this by getting the original from: https://ftp.gnu.org/gnu/coreutils/coreutils-8.32.tar.gz It would have saved time for both of us if the people who modified your copy had changed the package name and bug-reporting address. Once you find out who modified your copy, please suggest that to them.