GNU bug report logs - #46775
27.1; ERC: Track: Modified channels doc and `erc-track-find-face' fixes

Previous Next

Package: emacs;

Reported by: Olivier Certner <ocert.dev <at> free.fr>

Date: Thu, 25 Feb 2021 17:15:01 UTC

Severity: normal

Tags: patch

Found in version 27.1

Done: Amin Bandali <bandali <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Amin Bandali <bandali <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#46775: closed (27.1; ERC: Track: Modified channels doc and
 `erc-track-find-face' fixes)
Date: Sun, 12 Sep 2021 05:26:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sun, 12 Sep 2021 01:25:19 -0400
with message-id <87tuiqwekg.fsf_-_ <at> gnu.org>
and subject line Re: bug#46775: 27.1; ERC: Track: Modified channels doc and `erc-track-find-face' fixes
has caused the debbugs.gnu.org bug report #46775,
regarding 27.1; ERC: Track: Modified channels doc and `erc-track-find-face' fixes
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
46775: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46775
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Olivier Certner <ocert.dev <at> free.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.1;
 ERC: Track: Modified channels doc and `erc-track-find-face' fixes
Date: Thu, 25 Feb 2021 18:14:25 +0100
Several small documentation changes and one minor fix.  List of (separate) 
changes:
1. Fix documentation of `erc-modified-channels-alist' about its structure.
2. Fix documentation of `erc-modified-channels-alist' about which channels it 
contains and when.  Add references to docstring of `erc-make-mode-line-buffer-
name'.
3. Rewrite `erc-track-find-face' to clarify what it does (& minor performance 
improvement; no functional changes).
4. `erc-track-modified-channels': Fix a perceived bug in the use of `erc-
track-find-face' (changes mode line faces selection in some cases).

URL and branch of the repository having the corresponding patches to be posted 
after the bug is open. Changes rebased on master.

-- 
Olivier Certner




[Message part 3 (message/rfc822, inline)]
From: Amin Bandali <bandali <at> gnu.org>
To: Olivier Certner <olce.emacs <at> certner.fr>
Cc: 46775-done <at> debbugs.gnu.org
Subject: Re: bug#46775: 27.1; ERC: Track: Modified channels doc and
 `erc-track-find-face' fixes
Date: Sun, 12 Sep 2021 01:25:19 -0400
Hi Olivier,

Many thanks for your patches, and my apologies it's taken so long to get
them merged.

Olivier Certner writes:

> Patches slightly edited (commit message, doc text) and rebased on top of a 
> recent 'master'. Ready to apply. Easy to backport to 27 as well.

I applied (1) and (2) to 'emacs-27' and then merged that into 'master',
then applied (3) and (4) on 'master'; each with a few small tweaks.

Thanks again,
amin


This bug report was last modified 3 years and 308 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.