GNU bug report logs - #4677
allow VC operations from dired

Previous Next

Full log

Message #19 received at 4677 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Juri Linkov <juri <at> jurta.org>
Cc: 4677 <at> debbugs.gnu.org
Subject: Re: bug#4677: allow VC operations from dired
Date: Mon, 12 Oct 2009 13:51:33 -0700 (PDT)

Juri Linkov <juri <at> jurta.org> writes:

  > >   > > This patch allows VC operations to be run from dired.
  > >   > > State changing VC operations are not supported.
  > >   > > (only the various variations of log and diff)
  > >   >
  > >   > Thanks, it works right except in one case: when called outside of
  > >   > a repository controlled directory, it traverses all subdirectories
  > >   > trying to find a repository (I think traversing subdirectories
  > >   > makes no sense in this case) and later fails with:
  > >   >
  > >   >   Wrong type argument: stringp, nil
  > >
  > > Thanks.  Here's an updated patch.
  > 
  > Hmm, now it fails with "Directory not under VC" in all directories
  > even under version control since (vc-backend default-directory)
  > always returns nil.

Hmm, I should  have said "not really tested".
I guess the first version will have to do then. 

If people want to apply VC operations on non VC controlled directories
it's too bad, they get an error.
Unless someone else wants to work on giving a nicer error in that
case...  I don't really plan to do any further work on this, so if you
want to adopt it and get it checked in, go right ahead.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.